Re: [Freeipa-devel] [PATCH] 170 Remove redundant information from API.txt
On Tue, 2011-11-15 at 17:42 +0200, Alexander Bokovoy wrote: > On Tue, 15 Nov 2011, Martin Kosek wrote: > > > Some Param or Output attributes do not cause API incompatibility > > (e.g. doc, label or callables) and does not need to be included > > in API.txt. When these attributes are modified, a lot of bogus > > changes may get in API.txt - making the real API changes less > > detectable. > > > > https://fedorahosted.org/freeipa/ticket/2107 > > > > --- > > > > The list of ignored attributes can be further discussed. I left just the > > attributes that IMO really influences the Param/Output behavior and that > > we should be cautious when they are changed. > > > > I had to gzip the patch as the API.txt change is "quite" large. > ACK, the makeapi patch looks good to me. You didn't need to use tar, > though, gzip would have been enough. Right, my fingers just used the command they are used to. I will make sure they don't do it next time :-) Pushed to master. > > Now real question is how to achieve fine-grained compatibility with > older releases which I'll look at in ticket #2026. Yup. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 170 Remove redundant information from API.txt
On Tue, 15 Nov 2011, Martin Kosek wrote: > Some Param or Output attributes do not cause API incompatibility > (e.g. doc, label or callables) and does not need to be included > in API.txt. When these attributes are modified, a lot of bogus > changes may get in API.txt - making the real API changes less > detectable. > > https://fedorahosted.org/freeipa/ticket/2107 > > --- > > The list of ignored attributes can be further discussed. I left just the > attributes that IMO really influences the Param/Output behavior and that > we should be cautious when they are changed. > > I had to gzip the patch as the API.txt change is "quite" large. ACK, the makeapi patch looks good to me. You didn't need to use tar, though, gzip would have been enough. Now real question is how to achieve fine-grained compatibility with older releases which I'll look at in ticket #2026. -- / Alexander Bokovoy ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 170 Remove redundant information from API.txt
Some Param or Output attributes do not cause API incompatibility (e.g. doc, label or callables) and does not need to be included in API.txt. When these attributes are modified, a lot of bogus changes may get in API.txt - making the real API changes less detectable. https://fedorahosted.org/freeipa/ticket/2107 --- The list of ignored attributes can be further discussed. I left just the attributes that IMO really influences the Param/Output behavior and that we should be cautious when they are changed. I had to gzip the patch as the API.txt change is "quite" large. Martin binuz45IvImHR.bin Description: application/compressed-tar ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
