Re: [Freeipa-devel] [PATCH] Fixed type of argument in class help

2011-02-14 Thread Rob Crittenden 

Jakub Hrozek wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 02/07/2011 10:54 AM, Jan Zelený wrote:

Jakub Hrozek  wrote:

On Wed, Feb 02, 2011 at 08:54:47AM +0100, Jan Zelený wrote:

At Rob's suggestion I changed the argument type in class help, this is
only oneliner, I think it can be pushed directly.

Jan

-takes_args = (Bytes('command?'),)
+takes_args = (Str('command?'),)


Nack, you also need to import Str from parameters.


Sorry, could have give you headsup: this patch should be pushed along with my
30-3 patch from last wednesday which still waits to be re-reviewed. The import
is in that patch.

Jan


OK, in that case ack on top of patch #30 (or simply squash the change
into 30-4, there's no separate ticket anyway)


Pushed to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Fixed type of argument in class help

2011-02-07 Thread Jakub Hrozek 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 02/07/2011 10:54 AM, Jan Zelený wrote:
> Jakub Hrozek  wrote:
>> On Wed, Feb 02, 2011 at 08:54:47AM +0100, Jan Zelený wrote:
>>> At Rob's suggestion I changed the argument type in class help, this is
>>> only oneliner, I think it can be pushed directly.
>>>
>>> Jan
>>>
>>> -takes_args = (Bytes('command?'),)
>>> +takes_args = (Str('command?'),)
>>
>> Nack, you also need to import Str from parameters.
> 
> Sorry, could have give you headsup: this patch should be pushed along with my 
> 30-3 patch from last wednesday which still waits to be re-reviewed. The 
> import 
> is in that patch.
> 
> Jan

OK, in that case ack on top of patch #30 (or simply squash the change
into 30-4, there's no separate ticket anyway)

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk1P5UsACgkQHsardTLnvCUjOACeI2Bdkhtarcms+ePkcNhLyika
dysAn2oVbPs1Jv5Bu2FpFCQJ7nopT68b
=+5+r
-END PGP SIGNATURE-

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Fixed type of argument in class help

2011-02-07 Thread Jan Zelený 
Jakub Hrozek  wrote:
> On Wed, Feb 02, 2011 at 08:54:47AM +0100, Jan Zelený wrote:
> > At Rob's suggestion I changed the argument type in class help, this is
> > only oneliner, I think it can be pushed directly.
> > 
> > Jan
> > 
> > -takes_args = (Bytes('command?'),)
> > +takes_args = (Str('command?'),)
> 
> Nack, you also need to import Str from parameters.

Sorry, could have give you headsup: this patch should be pushed along with my 
30-3 patch from last wednesday which still waits to be re-reviewed. The import 
is in that patch.

Jan

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Fixed type of argument in class help

2011-02-07 Thread Jakub Hrozek 
On Wed, Feb 02, 2011 at 08:54:47AM +0100, Jan Zelený wrote:
> At Rob's suggestion I changed the argument type in class help, this is only 
> oneliner, I think it can be pushed directly.
> 
> Jan

> -takes_args = (Bytes('command?'),)
> +takes_args = (Str('command?'),)

Nack, you also need to import Str from parameters.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Fixed type of argument in class help

2011-02-01 Thread Jan Zelený 
At Rob's suggestion I changed the argument type in class help, this is only 
oneliner, I think it can be pushed directly.

Jan
From f7ca20a79bf06832c20262582f5ca83ec48ff056 Mon Sep 17 00:00:00 2001
From: Jan Zeleny 
Date: Wed, 2 Feb 2011 02:49:57 -0500
Subject: [PATCH] Fixed type of argument in class help

---
 ipalib/cli.py |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ipalib/cli.py b/ipalib/cli.py
index fa8d36d356076103c3310b7a30f5834ec23350bd..1e61f667913472e26dd138d885cea113919cd04e 100644
--- a/ipalib/cli.py
+++ b/ipalib/cli.py
@@ -609,7 +609,7 @@ class help(frontend.Local):
 Display help for a command or topic.
 """
 
-takes_args = (Bytes('command?'),)
+takes_args = (Str('command?'),)
 
 has_output = tuple()
 
-- 
1.7.3.4

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel