Re: [Freeipa-devel] [PATCH 0136] Remove enumeration index from dynamic role hosts when

2013-12-20 Thread Petr Viktorin 

On 12/12/2013 04:55 PM, Tomas Babej wrote:

Hi,

When exporting test configuration, do not append indexes to dynamic
role definitions as this is not expected form of input.

https://fedorahosted.org/freeipa/ticket/4081


The problem is that this approach would limit us to only one host per 
dynamic role.
Conceptually a host's "role" refers mainly to the set of packages 
installed on the host. [0] Also, the distinction between dynamic and 
static is just a detail of the envvar configuration.
In the future we might want to test with e.g. several legacy clients, or 
several replicas without a "ipa-server-ca" package, so we'll want the 
config system to allow more hosts per role.


Since the ticket is not time-critical, and to prevent conflicts, I'll 
add a patch for it to the next revision of my YAML patchset.




[0] "Master" is an unfortunate exception.

--
Petr³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH 0136] Remove enumeration index from dynamic role hosts when

2013-12-12 Thread Tomas Babej 

Hi,

When exporting test configuration, do not append indexes to dynamic
role definitions as this is not expected form of input.

https://fedorahosted.org/freeipa/ticket/4081

--
Tomas Babej
Associate Software Engeneer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org


From 163df2f7b6cfc03b4f10f9ff14485163362edfa3 Mon Sep 17 00:00:00 2001
From: Tomas Babej 
Date: Thu, 12 Dec 2013 16:54:13 +0100
Subject: [PATCH] Remove enumeration index from dynamic role hosts when
 exporting

When exporting test configuration, do not append indexes to dynamic
role definitions as this is not expected form of input.

https://fedorahosted.org/freeipa/ticket/4081
---
 ipatests/test_integration/config.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ipatests/test_integration/config.py b/ipatests/test_integration/config.py
index b8c5fdc7f9ce1877e34491964418a8d806168e73..d2e7167666b71c16dc3a4e12f5a00e291e960ee9 100644
--- a/ipatests/test_integration/config.py
+++ b/ipatests/test_integration/config.py
@@ -191,7 +191,8 @@ class Config(object):
 env['BEAKER%s_IP%s' % (role.upper(), domain._env)] = ips
 
 for i, host in enumerate(hosts, start=1):
-suffix = '%s%s' % (role.upper(), i)
+suffix = '%s%s' % (role.upper(),
+  '' if role in domain.extra_roles else i)
 prefix = 'TESTHOST_' if role in domain.extra_roles else ''
 
 ext_hostname = host.external_hostname
-- 
1.8.3.1

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel