Re: [Freeipa-devel] [PATCH 0182] Fix pkcs11 python extension reference counting

2015-02-10 Thread Jan Cholasta
Hi, Dne 12.1.2015 v 13:11 Martin Basti napsal(a): Part of DNSSEC (https://fedorahosted.org/freeipa/ticket/4657) Patch attached. 1) In P11_Helper_set_attribute, the return value can be only Py_None or NULL, so why don't you use Py_XINCREF instead of the if/Py_INCREF? 2) In

Re: [Freeipa-devel] [PATCH 0182] Fix pkcs11 python extension reference counting

2015-02-10 Thread Martin Basti
On 10/02/15 10:11, Jan Cholasta wrote: Hi, Dne 12.1.2015 v 13:11 Martin Basti napsal(a): Part of DNSSEC (https://fedorahosted.org/freeipa/ticket/4657) Patch attached. 1) In P11_Helper_set_attribute, the return value can be only Py_None or NULL, so why don't you use Py_XINCREF instead of

Re: [Freeipa-devel] [PATCH 0182] Fix pkcs11 python extension reference counting

2015-02-10 Thread Jan Cholasta
Dne 10.2.2015 v 14:56 Martin Basti napsal(a): On 10/02/15 10:11, Jan Cholasta wrote: Hi, Dne 12.1.2015 v 13:11 Martin Basti napsal(a): Part of DNSSEC (https://fedorahosted.org/freeipa/ticket/4657) Patch attached. 1) In P11_Helper_set_attribute, the return value can be only Py_None or NULL,

[Freeipa-devel] [PATCH 0182] Fix pkcs11 python extension reference counting

2015-01-12 Thread Martin Basti
Part of DNSSEC (https://fedorahosted.org/freeipa/ticket/4657) Patch attached. -- Martin Basti From 28b3ca9f12e75afc581d0ac6c462c8647e054a07 Mon Sep 17 00:00:00 2001 From: Martin Basti mba...@redhat.com Date: Mon, 12 Jan 2015 13:05:53 +0100 Subject: [PATCH] Fix reference counting in pkcs11