Re: [Freeipa-devel] [PATCH 0461] Limit max username lenght to 255 in config-mod

2016-04-20 Thread Martin Basti 



On 20.04.2016 13:27, David Kupka wrote:

On 15/04/16 15:42, Martin Basti wrote:



On 15.04.2016 15:03, Petr Vobornik wrote:

On 04/15/2016 01:25 PM, Martin Basti wrote:


On 15.04.2016 13:18, David Kupka wrote:

On 14/04/16 17:47, Martin Basti wrote:

https://fedorahosted.org/freeipa/ticket/5774

Patch attached.



Hi,
works for me, ACK.

FYI: While trying this I've hit related issue
(https://fedorahosted.org/freeipa/ticket/5822) but I believe the
impact is minimal.

Pushed to master: 93871bf017e1bc5f2c176aa3419278d49fcc003b


API.txt and version was not updated:

-option: Int('ipamaxusernamelength', attribute=True, autofill=False,
cli_name='maxusername', minvalue=1, multivalue=False, required=False)
+option: Int('ipamaxusernamelength', attribute=True, autofill=False,
cli_name='maxusername', maxvalue=255, minvalue=1, multivalue=False,
required=False)


Sorry.

Patch attached.


Sorry, I haven't noticed this. I remember that previously this type of 
errors aborted build. Why was this changed?


Anyway, the patch fixes it, ACK.



Pushed to master: 3dc3d7a61068098e556e6b65b4a56b364a5323dd

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0461] Limit max username lenght to 255 in config-mod

2016-04-20 Thread David Kupka 

On 15/04/16 15:42, Martin Basti wrote:



On 15.04.2016 15:03, Petr Vobornik wrote:

On 04/15/2016 01:25 PM, Martin Basti wrote:


On 15.04.2016 13:18, David Kupka wrote:

On 14/04/16 17:47, Martin Basti wrote:

https://fedorahosted.org/freeipa/ticket/5774

Patch attached.



Hi,
works for me, ACK.

FYI: While trying this I've hit related issue
(https://fedorahosted.org/freeipa/ticket/5822) but I believe the
impact is minimal.

Pushed to master: 93871bf017e1bc5f2c176aa3419278d49fcc003b


API.txt and version was not updated:

-option: Int('ipamaxusernamelength', attribute=True, autofill=False,
cli_name='maxusername', minvalue=1, multivalue=False, required=False)
+option: Int('ipamaxusernamelength', attribute=True, autofill=False,
cli_name='maxusername', maxvalue=255, minvalue=1, multivalue=False,
required=False)


Sorry.

Patch attached.


Sorry, I haven't noticed this. I remember that previously this type of 
errors aborted build. Why was this changed?


Anyway, the patch fixes it, ACK.


--
David Kupka

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0461] Limit max username lenght to 255 in config-mod

2016-04-15 Thread Martin Basti 



On 15.04.2016 15:03, Petr Vobornik wrote:

On 04/15/2016 01:25 PM, Martin Basti wrote:


On 15.04.2016 13:18, David Kupka wrote:

On 14/04/16 17:47, Martin Basti wrote:

https://fedorahosted.org/freeipa/ticket/5774

Patch attached.



Hi,
works for me, ACK.

FYI: While trying this I've hit related issue
(https://fedorahosted.org/freeipa/ticket/5822) but I believe the
impact is minimal.

Pushed to master: 93871bf017e1bc5f2c176aa3419278d49fcc003b


API.txt and version was not updated:

-option: Int('ipamaxusernamelength', attribute=True, autofill=False,
cli_name='maxusername', minvalue=1, multivalue=False, required=False)
+option: Int('ipamaxusernamelength', attribute=True, autofill=False,
cli_name='maxusername', maxvalue=255, minvalue=1, multivalue=False,
required=False)


Sorry.

Patch attached.
From d43973ac14ad635d5dada746162e152db7f6caa2 Mon Sep 17 00:00:00 2001
From: Martin Basti 
Date: Fri, 15 Apr 2016 15:38:53 +0200
Subject: [PATCH] Increase API version for 'ipamaxusernamelength' attribute
 change

https://fedorahosted.org/freeipa/ticket/5774
---
 API.txt | 2 +-
 VERSION | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/API.txt b/API.txt
index 5b75413f930d0e9caaffc68023bed8106d786653..3598b08198cae536754259f7463669052efa3f86 100644
--- a/API.txt
+++ b/API.txt
@@ -774,7 +774,7 @@ option: Str('ipagroupobjectclasses', attribute=True, autofill=False, cli_name='g
 option: IA5Str('ipagroupsearchfields', attribute=True, autofill=False, cli_name='groupsearch', multivalue=False, required=False)
 option: IA5Str('ipahomesrootdir', attribute=True, autofill=False, cli_name='homedirectory', multivalue=False, required=False)
 option: StrEnum('ipakrbauthzdata', attribute=True, autofill=False, cli_name='pac_type', csv=True, multivalue=True, required=False, values=(u'MS-PAC', u'PAD', u'nfs:NONE'))
-option: Int('ipamaxusernamelength', attribute=True, autofill=False, cli_name='maxusername', minvalue=1, multivalue=False, required=False)
+option: Int('ipamaxusernamelength', attribute=True, autofill=False, cli_name='maxusername', maxvalue=255, minvalue=1, multivalue=False, required=False)
 option: Bool('ipamigrationenabled', attribute=True, autofill=False, cli_name='enable_migration', multivalue=False, required=False)
 option: Int('ipapwdexpadvnotify', attribute=True, autofill=False, cli_name='pwdexpnotify', minvalue=0, multivalue=False, required=False)
 option: Int('ipasearchrecordslimit', attribute=True, autofill=False, cli_name='searchrecordslimit', minvalue=-1, multivalue=False, required=False)
diff --git a/VERSION b/VERSION
index 825aace1b8c78486b37ac1809b664ca18f97523b..aedebd185821d42fa48608f4c5fdf9ff510ace3f 100644
--- a/VERSION
+++ b/VERSION
@@ -90,5 +90,5 @@ IPA_DATA_VERSION=2010061412
 #  #
 
 IPA_API_VERSION_MAJOR=2
-IPA_API_VERSION_MINOR=164
-# Last change: simo - add optional string to disable preauth for SPNs
+IPA_API_VERSION_MINOR=165
+# Last change: mbasti - limit ipamaxusernamelength value to 255
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0461] Limit max username lenght to 255 in config-mod

2016-04-15 Thread Petr Vobornik 
On 04/15/2016 01:25 PM, Martin Basti wrote:
> 
> 
> On 15.04.2016 13:18, David Kupka wrote:
>> On 14/04/16 17:47, Martin Basti wrote:
>>> https://fedorahosted.org/freeipa/ticket/5774
>>>
>>> Patch attached.
>>>
>>>
>>
>> Hi,
>> works for me, ACK.
>>
>> FYI: While trying this I've hit related issue
>> (https://fedorahosted.org/freeipa/ticket/5822) but I believe the
>> impact is minimal.
> 
> Pushed to master: 93871bf017e1bc5f2c176aa3419278d49fcc003b
> 

API.txt and version was not updated:

-option: Int('ipamaxusernamelength', attribute=True, autofill=False,
cli_name='maxusername', minvalue=1, multivalue=False, required=False)
+option: Int('ipamaxusernamelength', attribute=True, autofill=False,
cli_name='maxusername', maxvalue=255, minvalue=1, multivalue=False,
required=False)

-- 
Petr Vobornik

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0461] Limit max username lenght to 255 in config-mod

2016-04-15 Thread Martin Basti 



On 15.04.2016 13:18, David Kupka wrote:

On 14/04/16 17:47, Martin Basti wrote:

https://fedorahosted.org/freeipa/ticket/5774

Patch attached.




Hi,
works for me, ACK.

FYI: While trying this I've hit related issue 
(https://fedorahosted.org/freeipa/ticket/5822) but I believe the 
impact is minimal.


Pushed to master: 93871bf017e1bc5f2c176aa3419278d49fcc003b

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0461] Limit max username lenght to 255 in config-mod

2016-04-15 Thread David Kupka 

On 14/04/16 17:47, Martin Basti wrote:

https://fedorahosted.org/freeipa/ticket/5774

Patch attached.




Hi,
works for me, ACK.

FYI: While trying this I've hit related issue 
(https://fedorahosted.org/freeipa/ticket/5822) but I believe the impact 
is minimal.


--
David Kupka

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0461] Limit max username lenght to 255 in config-mod

2016-04-14 Thread Martin Basti 

https://fedorahosted.org/freeipa/ticket/5774

Patch attached.
From c032c8e581a26a4d36b40cf2b60756c3394d2024 Mon Sep 17 00:00:00 2001
From: Martin Basti 
Date: Thu, 14 Apr 2016 17:03:51 +0200
Subject: [PATCH] Limit max username length to 255 in config-mod

This value is same as is used in user and stageuser commands.

https://fedorahosted.org/freeipa/ticket/5774
---
 ipalib/plugins/config.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ipalib/plugins/config.py b/ipalib/plugins/config.py
index 848b41e7b23658010195b782144064a21d695894..e7b6e791ca994c1fe9ceb0b21339fa9fced1b0e2 100644
--- a/ipalib/plugins/config.py
+++ b/ipalib/plugins/config.py
@@ -128,6 +128,7 @@ class config(LDAPObject):
 cli_name='maxusername',
 label=_('Maximum username length'),
 minvalue=1,
+maxvalue=255,
 ),
 IA5Str('ipahomesrootdir',
 cli_name='homedirectory',
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code