Re: [Freeipa-devel] [PATCH 503] upgrade: make sure ldap2 is connected in export_kra_agent_pem
rver/install/server/upgrade.py:1440:80: E501 line too long (80 > 79 characters) ipaserver/install/server/upgrade.py:1465:14: E111 indentation is not a multiple of four ipaserver/install/server/upgrade.py:1519:27: E126 continuation line over-indented for hanging indent ipaserver/install/server/upgrade.py:1531:26: E126 continuation line over-indented for hanging indent ipaserver/install/server/upgrade.py:1583:80: E501 line too long (96 > 79 characters) ipaserver/install/server/upgrade.py:1601:26: E128 continuation line under-indented for visual indent - Original Message - > From: "Jan Cholasta" <jchol...@redhat.com> > To: "freeipa-devel" <freeipa-devel@redhat.com> > Sent: Monday, October 12, 2015 3:11:09 PM > Subject: [Freeipa-devel] [PATCH 503] upgrade: make sure ldap2 is connected in > export_kra_agent_pem > > Hi, > > the attached patch fixes <https://fedorahosted.org/freeipa/ticket/5360>. > > Honza > > -- > Jan Cholasta > > -- > Manage your subscription for the Freeipa-devel mailing list: > https://www.redhat.com/mailman/listinfo/freeipa-devel > Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 503] upgrade: make sure ldap2 is connected in export_kra_agent_pem
ok, it's not fault of patch itself, ACK - Original Message - > From: "Aleš Mareček" <amare...@redhat.com> > To: "Jan Cholasta" <jchol...@redhat.com> > Cc: "freeipa-devel" <freeipa-devel@redhat.com> > Sent: Monday, October 12, 2015 3:45:51 PM > Subject: Re: [Freeipa-devel] [PATCH 503] upgrade: make sure ldap2 is > connected in export_kra_agent_pem > > Hello, > the patch looks good but pep8 cries: > > # pep8 ipaserver/install/server/upgrade.py > ipaserver/install/server/upgrade.py:53:1: E302 expected 2 blank lines, found > 1 > ipaserver/install/server/upgrade.py:68:1: E302 expected 2 blank lines, found > 1 > ipaserver/install/server/upgrade.py:83:25: E261 at least two spaces before > inline comment > ipaserver/install/server/upgrade.py:88:1: E302 expected 2 blank lines, found > 1 > ipaserver/install/server/upgrade.py:94:1: E302 expected 2 blank lines, found > 1 > ipaserver/install/server/upgrade.py:96:13: E225 missing whitespace around > operator > ipaserver/install/server/upgrade.py:109:80: E501 line too long (93 > 79 > characters) > ipaserver/install/server/upgrade.py:111:1: E302 expected 2 blank lines, found > 1 > ipaserver/install/server/upgrade.py:131:1: E302 expected 2 blank lines, found > 1 > ipaserver/install/server/upgrade.py:151:1: E302 expected 2 blank lines, found > 1 > ipaserver/install/server/upgrade.py:172:13: E128 continuation line > under-indented for visual indent > ipaserver/install/server/upgrade.py:179:1: E302 expected 2 blank lines, found > 1 > ipaserver/install/server/upgrade.py:192:80: E501 line too long (108 > 79 > characters) > ipaserver/install/server/upgrade.py:196:1: E302 expected 2 blank lines, found > 1 > ipaserver/install/server/upgrade.py:217:49: E231 missing whitespace after ',' > ipaserver/install/server/upgrade.py:222:1: E302 expected 2 blank lines, found > 1 > ipaserver/install/server/upgrade.py:228:80: E501 line too long (83 > 79 > characters) > ipaserver/install/server/upgrade.py:264:1: E302 expected 2 blank lines, found > 1 > ipaserver/install/server/upgrade.py:277:1: E302 expected 2 blank lines, found > 1 > ipaserver/install/server/upgrade.py:333:17: E128 continuation line > under-indented for visual indent > ipaserver/install/server/upgrade.py:366:80: E501 line too long (82 > 79 > characters) > ipaserver/install/server/upgrade.py:414:49: E251 unexpected spaces around > keyword / parameter equals > ipaserver/install/server/upgrade.py:414:51: E251 unexpected spaces around > keyword / parameter equals > ipaserver/install/server/upgrade.py:441:17: E128 continuation line > under-indented for visual indent > ipaserver/install/server/upgrade.py:455:56: E127 continuation line > over-indented for visual indent > ipaserver/install/server/upgrade.py:459:25: E128 continuation line > under-indented for visual indent > ipaserver/install/server/upgrade.py:487:37: E126 continuation line > over-indented for hanging indent > ipaserver/install/server/upgrade.py:494:17: E126 continuation line > over-indented for hanging indent > ipaserver/install/server/upgrade.py:503:80: E501 line too long (81 > 79 > characters) > ipaserver/install/server/upgrade.py:504:25: E128 continuation line > under-indented for visual indent > ipaserver/install/server/upgrade.py:511:80: E501 line too long (81 > 79 > characters) > ipaserver/install/server/upgrade.py:517:1: E302 expected 2 blank lines, found > 1 > ipaserver/install/server/upgrade.py:538:80: E501 line too long (83 > 79 > characters) > ipaserver/install/server/upgrade.py:539:17: E128 continuation line > under-indented for visual indent > ipaserver/install/server/upgrade.py:541:80: E501 line too long (82 > 79 > characters) > ipaserver/install/server/upgrade.py:542:17: E128 continuation line > under-indented for visual indent > ipaserver/install/server/upgrade.py:551:80: E501 line too long (89 > 79 > characters) > ipaserver/install/server/upgrade.py:552:17: E128 continuation line > under-indented for visual indent > ipaserver/install/server/upgrade.py:554:17: E128 continuation line > under-indented for visual indent > ipaserver/install/server/upgrade.py:556:80: E501 line too long (86 > 79 > characters) > ipaserver/install/server/upgrade.py:557:17: E128 continuation line > under-indented for visual indent > ipaserver/install/server/upgrade.py:561:80: E501 line too long (91 > 79 > characters) > ipaserver/install/server/upgrade.py:562:13: E128 continuation line > under-indented for visual indent > ipaserver/install/server/upgrade.py:577:17: E128 continuation line > under-indented for visual indent > ipaserver/install/server/upgrade.py:603:17: E128 continuation line >
Re: [Freeipa-devel] [PATCH 503] upgrade: make sure ldap2 is connected in export_kra_agent_pem
Thanks. Pushed to: master: 61bdbd6e47b2cd2a62f7e50a6a6cbd2e272470d9 ipa-4-2: 9182f40ac549fc0104878a5599c9effe4f80c3ec On 12.10.2015 15:47, Aleš Mareček wrote: ok, it's not fault of patch itself, ACK - Original Message - From: "Aleš Mareček" <amare...@redhat.com> To: "Jan Cholasta" <jchol...@redhat.com> Cc: "freeipa-devel" <freeipa-devel@redhat.com> Sent: Monday, October 12, 2015 3:45:51 PM Subject: Re: [Freeipa-devel] [PATCH 503] upgrade: make sure ldap2 is connected in export_kra_agent_pem Hello, the patch looks good but pep8 cries: # pep8 ipaserver/install/server/upgrade.py ipaserver/install/server/upgrade.py:53:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:68:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:83:25: E261 at least two spaces before inline comment ipaserver/install/server/upgrade.py:88:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:94:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:96:13: E225 missing whitespace around operator ipaserver/install/server/upgrade.py:109:80: E501 line too long (93 > 79 characters) ipaserver/install/server/upgrade.py:111:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:131:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:151:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:172:13: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:179:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:192:80: E501 line too long (108 > 79 characters) ipaserver/install/server/upgrade.py:196:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:217:49: E231 missing whitespace after ',' ipaserver/install/server/upgrade.py:222:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:228:80: E501 line too long (83 > 79 characters) ipaserver/install/server/upgrade.py:264:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:277:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:333:17: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:366:80: E501 line too long (82 > 79 characters) ipaserver/install/server/upgrade.py:414:49: E251 unexpected spaces around keyword / parameter equals ipaserver/install/server/upgrade.py:414:51: E251 unexpected spaces around keyword / parameter equals ipaserver/install/server/upgrade.py:441:17: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:455:56: E127 continuation line over-indented for visual indent ipaserver/install/server/upgrade.py:459:25: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:487:37: E126 continuation line over-indented for hanging indent ipaserver/install/server/upgrade.py:494:17: E126 continuation line over-indented for hanging indent ipaserver/install/server/upgrade.py:503:80: E501 line too long (81 > 79 characters) ipaserver/install/server/upgrade.py:504:25: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:511:80: E501 line too long (81 > 79 characters) ipaserver/install/server/upgrade.py:517:1: E302 expected 2 blank lines, found 1 ipaserver/install/server/upgrade.py:538:80: E501 line too long (83 > 79 characters) ipaserver/install/server/upgrade.py:539:17: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:541:80: E501 line too long (82 > 79 characters) ipaserver/install/server/upgrade.py:542:17: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:551:80: E501 line too long (89 > 79 characters) ipaserver/install/server/upgrade.py:552:17: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:554:17: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:556:80: E501 line too long (86 > 79 characters) ipaserver/install/server/upgrade.py:557:17: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:561:80: E501 line too long (91 > 79 characters) ipaserver/install/server/upgrade.py:562:13: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:577:17: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:603:17: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:606:17: E128 continuation line under-indented for visual indent ipaserver/install/server/upgrade.py:611:80: E501 line too long (80 > 79 characters) ipaserver/install/server/upgrade.py:616:80: E501 line too long (81 > 79 characters) ipaserver/install/server/upgra
