Re: [Freeipa-devel] [PATCHES] 213-224 Use old entry state in LDAP mods

2014-01-10 Thread Petr Viktorin
On 01/10/2014 12:43 PM, Jan Cholasta wrote: On 20.12.2013 13:06, Petr Viktorin wrote: I now have a failing test in test_permission_rollback. Let's think about this case for a moment: The permission system has "rollback": if an ACI update fails, the entry is rolled back. Currently it works (for

Re: [Freeipa-devel] [PATCHES] 213-224 Use old entry state in LDAP mods

2014-01-10 Thread Jan Cholasta
On 20.12.2013 13:06, Petr Viktorin wrote: I now have a failing test in test_permission_rollback. Let's think about this case for a moment: The permission system has "rollback": if an ACI update fails, the entry is rolled back. Currently it works (for ipapermlocation changes) like this: - The ol

Re: [Freeipa-devel] [PATCHES] 213-224 Use old entry state in LDAP mods

2013-12-20 Thread Petr Viktorin
On 12/18/2013 12:50 PM, Jan Cholasta wrote: On 11.12.2013 18:28, Petr Viktorin wrote: On 12/11/2013 05:05 PM, Petr Viktorin wrote: On 12/10/2013 02:10 PM, Jan Cholasta wrote: Hi, the attached patches fix . Honza These look great, thanks! Just a

Re: [Freeipa-devel] [PATCHES] 213-224 Use old entry state in LDAP mods

2013-12-18 Thread Jan Cholasta
On 11.12.2013 18:28, Petr Viktorin wrote: On 12/11/2013 05:05 PM, Petr Viktorin wrote: On 12/10/2013 02:10 PM, Jan Cholasta wrote: Hi, the attached patches fix . Honza These look great, thanks! Just a couple of questions/nicpicks. 213: ACK 214:

Re: [Freeipa-devel] [PATCHES] 213-224 Use old entry state in LDAP mods

2013-12-11 Thread Petr Viktorin
On 12/11/2013 05:05 PM, Petr Viktorin wrote: On 12/10/2013 02:10 PM, Jan Cholasta wrote: Hi, the attached patches fix . Honza These look great, thanks! Just a couple of questions/nicpicks. 213: ACK 214: ACK 215: ACK 216: ACK 217: ACK 218: ACK 2

Re: [Freeipa-devel] [PATCHES] 213-224 Use old entry state in LDAP mods

2013-12-11 Thread Petr Viktorin
On 12/10/2013 02:10 PM, Jan Cholasta wrote: Hi, the attached patches fix . Honza These look great, thanks! Just a couple of questions/nicpicks. 213: ACK 214: ACK 215: ACK 216: ACK 217: ACK 218: ACK 219: Does the new method guarantee 'attributety

[Freeipa-devel] [PATCHES] 213-224 Use old entry state in LDAP mods

2013-12-10 Thread Jan Cholasta
Hi, the attached patches fix . Honza -- Jan Cholasta >From 7fa3ca5c581b54bfb3d8b6c904d33bde0c3845da Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Tue, 10 Dec 2013 11:09:56 +0100 Subject: [PATCH 01/12] Rename LDAPEntry method commit to reset_mod