URL: https://github.com/freeipa/freeipa/pull/140
Title: #140: Tests: Remove invalid certplugin tests
pvomacka commented:
"""
Hi alichbox,
I agree with steps you are proposing, it does make sense.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/140#issuecomment-251962169
-
URL: https://github.com/freeipa/freeipa/pull/140
Title: #140: Tests: Remove invalid certplugin tests
mirielka commented:
"""
Ok, I will do it like Ales proposed and will sync this PR when new tests are
ready.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/140#issuecomment
URL: https://github.com/freeipa/freeipa/pull/140
Title: #140: Tests: Remove invalid certplugin tests
alichbox commented:
"""
Ok, I would vote for the new tests and when we have them merged we can safely
delete this part of code that is not relevant anymore. The reason we would
leave the curren
URL: https://github.com/freeipa/freeipa/pull/140
Title: #140: Tests: Remove invalid certplugin tests
pvomacka commented:
"""
Yes, that's true and I understand that these tests depend on previous actions.
What I actually wanted to say is that I think that we should rather rewrite
these tests r
URL: https://github.com/freeipa/freeipa/pull/140
Title: #140: Tests: Remove invalid certplugin tests
mirielka commented:
"""
Hi, I discussed this with Rob who authored the tests and he said that these
tests were there just as a kind of checking that no extra revoked certificates
get in. Tests
URL: https://github.com/freeipa/freeipa/pull/140
Title: #140: Tests: Remove invalid certplugin tests
pvomacka commented:
"""
I think that it is not good idea to remove tests, because we are lowering
coverage. Therefore NACK.
Could we rather rewrite these tests? For example issue certain certi
