URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
tiran commented:
"""
memo for me:
- [ ] /freeipa*.tar.gz is not removed
- [ ] ```MOSTLYCLEANFILES``` only cleans ipasetup.py[co] but keeps __pycache__
and other pyc/pyo. add ```clean-local: rm -rf *.
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
tiran commented:
"""
memo for me:
- [ ] /freeipa*.tar.gz is not removed
- [ ] ```MOSTLYCLEANFILES``` only cleans ipasetup.py[co] but keeps __pycache__
and other pyc/pyo. add ```clean-local: rm -rf *.
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
pspacek commented:
"""
@tiran
> autoconf and automake files are not removed (Makefile.in, /config.sub ...)
According to [Automake manual section 13 What Gets
Cleaned](https://www.gnu.org/software/aut
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
pspacek commented:
"""
@tiran
> autoconf and automake files are not removed (Makefile.in, /config.sub ...)
According to [Automake manual section 13 What Gets
Cleaned](https://www.gnu.org/software/aut
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
martbab commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/c48e5fd811326dc64e19490f88003e442815a052
https://fedorahosted.org/freeipa/changeset/0a17155e5b0434d4cab4d1696fac
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
mbasti-rh commented:
"""
ACK
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/213#issuecomment-259399255
--
Manage your subscription for the Freeipa-devel mailing list:
https://ww
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
tiran commented:
"""
memo for me:
- [ ] /freeipa*.tar.gz is not removed
- [ ] ```MOSTLYCLEANFILES``` only cleans ipasetup.py[co] but keeps __pycache__
and other pyc/pyo. add ```clean-local: rm -rf *.
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
pspacek commented:
"""
@tiran
I've tested the find command and it works. The trick is `-o` which acts like OR
and allows you to specify different conditions and associate different actions
to them.
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
pspacek commented:
"""
@tiran
> add ipasetup.py to dist_noinst_SCRIPTS ?
`ipasetup.py` file is auto-generated from `ipasetup.py.in` so it should not be
part of distibution tarball. I've marked this i
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
tiran commented:
"""
memo for me:
- [ ] /freeipa*.tar.gz is not removed
- [ ] ```MOSTLYCLEANFILES``` only cleans ipasetup.py[co] but keeps __pycache__
and other pyc/pyo. add ```clean-local: rm -rf *.
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
tiran commented:
"""
memo for me:
- [ ] /freeipa*.tar.gz is not removed
- [ ] ```MOSTLYCLEANFILES``` only cleans ipasetup.py[co] but keeps __pycache__
and other pyc/pyo. add ```clean-local: rm -rf *.
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
tiran commented:
"""
memo for me:
- [ ] /freeipa*.tar.gz is not removed
- [ ] ```MOSTLYCLEANFILES``` only cleans ipasetup.py[co] but keeps __pycache__
and other pyc/pyo. add ```clean-local: rm -rf *.
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
tiran commented:
"""
memo for me:
- [ ] /freeipa*.tar.gz is not removed
- [ ] ```MOSTLYCLEANFILES``` only cleans ipasetup.py[co] but keeps __pycache__
and other pyc/pyo. add ```clean-local: rm -rf *.
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
tiran commented:
"""
The patch has some minor creases but works. Let's merge it to master and iron
out the remaining small issues with PRs.
"""
See the full comment at
https://github.com/freeipa/fre
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
mbasti-rh commented:
"""
commit `Build: add rpms target and makerpms.sh script` misses makerpms.sh and
ticket, and it looks like you forgot to squash this commit
"""
See the full comment at
https://
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
pspacek commented:
"""
- This version supports lint target and all configuration options for linters
listed in the design document.
- Fixes in systemd-tmpfiles call from make install.
- Updates .travi
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
mbasti-rh commented:
"""
Works for me
I read commits, it makes sense, works for me, but I'm not an autotools expert
so I might miss something.
I'm curious about one commit: Build: cleanup unused L
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
mbasti-rh commented:
"""
Build works for me, error was on my side
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/213#issuecomment-259128604
--
Manage your subscription for the F
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
mbasti-rh commented:
"""
I cannot build rpms
```
./makerpms.sh
...
config.status: executing libtool commands
IPA Server 4.4.90.201611071629GITbcd4f03
==
URL: https://github.com/freeipa/freeipa/pull/213
Title: #213: Build system refactoring phase 3
mbasti-rh commented:
"""
Why are there these whitespace errors?
```
git am ...
...
Applying: Build: stop build when a step in web UI build fails
Applying: Build: fix distribution of static files for we
20 matches
Mail list logo