[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/27e7a89a6289d0d3009f5f7feb9802b7db171a15 https://fedorahosted.org/freeipa/changeset/46b6b9e3091d08412912c37f46af497ddd0b8afb https://fedorahosted.org/freeipa/changeset/1cbd823990da0e931b666c4bc5c72f10d9de8115 https://fedorahosted.org/freeipa/changeset/d5683726d290b71eb44ab3b3150381f062e74df1 https://fedorahosted.org/freeipa/changeset/e2060e8e5562ed6a4fe760eba1babb5c1761576a https://fedorahosted.org/freeipa/changeset/6b9977f04199bf161d7171aedae9f97648c415c8 """ See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-260881124 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ ACKing on behalf of Lukas. """ See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-260776818 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ @lslebodn There is currently no plan to support distcheck: Python setuptools do not support VPATH builds as AFAIK it is impossible to do that without patching setuptools heavily. """ See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-260769449 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ Rebased. """ See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-260769221 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup lslebodn commented: """ Thank you very much for removing problematic patch. Do not forget to remove it from "Build phase 8" :-) as well A) there are few conflicts => patch need to be rebased B) I do not think that @tiran objection about rpm in makerpms.sh is valid but he should reply. Otherwise ACK after rebase Nice work and thank you very much for it. BTW is there a plan to have "make dictcheck" functional? """ See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-260704741 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ @lslebodn I've dropped the controversial patch which removes NULLs to allow you to send PR which adds it everywhere as you proposed. I'm going to wait till deadline at end of this working week. If your PR is not revied by then I'm going to push the removal so things are at least consistent. """ See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-260640084 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup lslebodn commented: """ >Hi Lukas. Given there is no technical justification to have it I'm going to >remove these. Simple is better than complex. I am sorry I do not agree. The technical justification was explained in previous comments few time. The $(NULL) at the end of list makes patches much simpler and easier to read. The purpose of refactoring is make code simpler but also easier to **maintain/review** """ See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-260289586 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ Hi Lukas. Given there is no technical justification to have it I'm going to remove these. Simple is better than complex. """ See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-260280943 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup lslebodn commented: """ You should the opposite of the last patch "Build: clean-up spurious NULL variables from Makefile.am files". The NULL should be added to each list. NACK to the last patch. It does not simplify anything and it makes diff more complicated for adding new entries """ See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-259989321 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
