[Freeipa-devel] [freeipa PR#718][comment] configure: fix AC_CHECK_LIB usage
URL: https://github.com/freeipa/freeipa/pull/718 Title: #718: configure: fix AC_CHECK_LIB usage HonzaCholasta commented: """ master: * 4322b57e313105611df39e99097993ba4161ab42 configure: fix AC_CHECK_LIB usage ipa-4-5: * 207864a61a748a9032e67bf0f1782379e44fb5aa configure: fix AC_CHECK_LIB usage """ See the full comment at https://github.com/freeipa/freeipa/pull/718#issuecomment-295279306 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#718][comment] configure: fix AC_CHECK_LIB usage
URL: https://github.com/freeipa/freeipa/pull/718 Title: #718: configure: fix AC_CHECK_LIB usage stlaz commented: """ This patch seems to have fixed the problem, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/718#issuecomment-295276975 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#718][comment] configure: fix AC_CHECK_LIB usage
URL: https://github.com/freeipa/freeipa/pull/718 Title: #718: configure: fix AC_CHECK_LIB usage lslebodn commented: """ A little bit offtopic. It is interesting that you look for the function `main` in libkrad. Because it does not exist there. I've just noticed it. ``` sh# nm --defined-only --dynamic /usr/lib64/libkrad.so A HIDDEN A krad_0_MIT 2540 T krad_attr_name2num 25d0 T krad_attr_num2name 2780 T krad_attrset_add 2850 T krad_attrset_add_number 2a00 T krad_attrset_copy 28b0 T krad_attrset_del 26a0 T krad_attrset_free 2990 T krad_attrset_get 2630 T krad_attrset_new 3310 T krad_client_free 32a0 T krad_client_new 3380 T krad_client_send 36c0 T krad_code_name2num 3750 T krad_code_num2name 3940 T krad_packet_bytes_needed 3f70 T krad_packet_decode_request 4040 T krad_packet_decode_response 41a0 T krad_packet_encode 39c0 T krad_packet_free 4220 T krad_packet_get_attr 41e0 T krad_packet_get_code 3b20 T krad_packet_new_request 3e10 T krad_packet_new_response ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/718#issuecomment-294845871 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#718][comment] configure: fix AC_CHECK_LIB usage
URL: https://github.com/freeipa/freeipa/pull/718 Title: #718: configure: fix AC_CHECK_LIB usage lslebodn commented: """ >It does not explicitly say what constitutes an unspecified value though. ```, , ``` or ``` , [] ,``` are considered as unspecified values and therefore default action was used. BTW it is not peculiar behaviour because most project define custom LIBS using the 3rd argument and not after invocation of macro. e.g. ``` AC_CHECK_HEADER(krad.h, [], [AC_MSG_ERROR([krad.h not found])]) -AC_CHECK_LIB(krad, main, [], [AC_MSG_ERROR([libkrad not found])]) +AC_CHECK_LIB(krad, main, [KRAD_LIBS="-lkrad"], [AC_MSG_ERROR([libkrad not found])]) -KRAD_LIBS="-lkrad" ``` And link to online documentation https://www.gnu.org/software/autoconf/manual/autoconf.html#Libraries """ See the full comment at https://github.com/freeipa/freeipa/pull/718#issuecomment-294844095 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#718][comment] configure: fix AC_CHECK_LIB usage
URL: https://github.com/freeipa/freeipa/pull/718 Title: #718: configure: fix AC_CHECK_LIB usage lslebodn commented: """ >It does not explicitly say what constitutes an unspecified value though. ```[]``` means default action. BTW it is not peculiar behaviour because most project define custom LIBS using the 3rd argument and not after invocation of macro. e.g. ``` AC_CHECK_HEADER(krad.h, [], [AC_MSG_ERROR([krad.h not found])]) -AC_CHECK_LIB(krad, main, [], [AC_MSG_ERROR([libkrad not found])]) +AC_CHECK_LIB(krad, main, [KRAD_LIBS="-lkrad"], [AC_MSG_ERROR([libkrad not found])]) -KRAD_LIBS="-lkrad" ``` And link to online documentation https://www.gnu.org/software/autoconf/manual/autoconf.html#Libraries """ See the full comment at https://github.com/freeipa/freeipa/pull/718#issuecomment-294844095 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#718][comment] configure: fix AC_CHECK_LIB usage
URL: https://github.com/freeipa/freeipa/pull/718 Title: #718: configure: fix AC_CHECK_LIB usage HonzaCholasta commented: """ `info autoconf Libraries` says: > If ACTION-IF-FOUND is not > specified, the default action prepends `-lLIBRARY' to `LIBS' and > defines `HAVE_LIBLIBRARY' (in all capitals). It does not explicitly say what constitutes an unspecified value though. """ See the full comment at https://github.com/freeipa/freeipa/pull/718#issuecomment-294825956 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#718][comment] configure: fix AC_CHECK_LIB usage
URL: https://github.com/freeipa/freeipa/pull/718 Title: #718: configure: fix AC_CHECK_LIB usage tiran commented: """ Is this peculiar behavior of ```AC_CHECK_LIB``` documented somewhere? """ See the full comment at https://github.com/freeipa/freeipa/pull/718#issuecomment-294823623 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
