Re: [Freeipa-devel] [ PATCH ] lite-server.py failing due to cli.py dependency: import default_encoding_utf8

2010-11-03 Thread John Dennis

On 11/03/2010 11:37 AM, Rob Crittenden wrote:

Patch is a 1 liner that changes:

import default_encoding_utf8

To

from policycoreutils import default_encoding_utf8




But this one was not reviewed yet, right?


It was, I'm trying to decide what to do with it.

It would seem that the SELinux policycoreutils python package has an
identically named shared library that seems to do the same thing. I'm
checking with them to see if that is true, then we can decide if we want
to use theirs or ours.


It is most likely identical as I provided the source code to both Dan 
(SELinux) and Rob (IPA).


But I'm not sure I see the problem, we should be importing from our own 
package area, it's fine if there are two (identical for the moment) 
modules because they are in their own name space.


Bottom line, we should be importing default_encoding_utf8 from *our* ipa 
package space, not from some other random area where there just happens 
to be an identically named module by coincidence.


--
John Dennis 

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [ PATCH ] lite-server.py failing due to cli.py dependency: import default_encoding_utf8

2010-11-03 Thread Rob Crittenden

Dmitri Pal wrote:

JR Aquino wrote:

./lite-server.py -d
ipa: DEBUG: importing all plugin modules in '/usr/src/freeipa/ipalib/plugins'...
ipa: DEBUG: importing plugin module '/usr/src/freeipa/ipalib/plugins/aci.py'
ipa: DEBUG: importing plugin module 
'/usr/src/freeipa/ipalib/plugins/automount.py'
ipa: ERROR: could not load plugin module 
'/usr/src/freeipa/ipalib/plugins/automount.py'
Traceback (most recent call last):
   File "/usr/src/freeipa/ipalib/plugable.py", line 538, in import_plugins
 __import__(fullname)
   File "/usr/src/freeipa/ipalib/plugins/automount.py", line 172, in
 from ipalib.plugins.baseldap import *
   File "/usr/src/freeipa/ipalib/plugins/baseldap.py", line 30, in
 from ipalib.cli import to_cli, from_cli
   File "/usr/src/freeipa/ipalib/cli.py", line 35, in
 import default_encoding_utf8
ImportError: No module named default_encoding_utf8

Patch is a 1 liner that changes:

import default_encoding_utf8

To

from policycoreutils import default_encoding_utf8




But this one was not reviewed yet, right?


It was, I'm trying to decide what to do with it.

It would seem that the SELinux policycoreutils python package has an 
identically named shared library that seems to do the same thing. I'm 
checking with them to see if that is true, then we can decide if we want 
to use theirs or ours.


rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [ PATCH ] lite-server.py failing due to cli.py dependency: import default_encoding_utf8

2010-11-03 Thread JR Aquino
This issue is resolved.

A full uninstall and reinstall properly fixed the dependency issue.

On 11/3/10 8:33 AM, "Dmitri Pal"  wrote:

>JR Aquino wrote:
>> ./lite-server.py -d
>> ipa: DEBUG: importing all plugin modules in
>>'/usr/src/freeipa/ipalib/plugins'...
>> ipa: DEBUG: importing plugin module
>>'/usr/src/freeipa/ipalib/plugins/aci.py'
>> ipa: DEBUG: importing plugin module
>>'/usr/src/freeipa/ipalib/plugins/automount.py'
>> ipa: ERROR: could not load plugin module
>>'/usr/src/freeipa/ipalib/plugins/automount.py'
>> Traceback (most recent call last):
>>   File "/usr/src/freeipa/ipalib/plugable.py", line 538, in
>>import_plugins
>> __import__(fullname)
>>   File "/usr/src/freeipa/ipalib/plugins/automount.py", line 172, in
>>
>> from ipalib.plugins.baseldap import *
>>   File "/usr/src/freeipa/ipalib/plugins/baseldap.py", line 30, in
>>
>> from ipalib.cli import to_cli, from_cli
>>   File "/usr/src/freeipa/ipalib/cli.py", line 35, in 
>> import default_encoding_utf8
>> ImportError: No module named default_encoding_utf8
>>
>> Patch is a 1 liner that changes:
>>
>> import default_encoding_utf8
>>
>> To
>>
>> from policycoreutils import default_encoding_utf8
>>   
>>   
>
>But this one was not reviewed yet, right?
>
>> 
>>
>> ___
>> Freeipa-devel mailing list
>> Freeipa-devel@redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>
>
>-- 
>Thank you,
>Dmitri Pal
>
>Sr. Engineering Manager IPA project,
>Red Hat Inc.
>
>
>---
>Looking to carve out IT costs?
>www.redhat.com/carveoutcosts/
>


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [ PATCH ] lite-server.py failing due to cli.py dependency: import default_encoding_utf8

2010-11-03 Thread Dmitri Pal
JR Aquino wrote:
> ./lite-server.py -d
> ipa: DEBUG: importing all plugin modules in 
> '/usr/src/freeipa/ipalib/plugins'...
> ipa: DEBUG: importing plugin module '/usr/src/freeipa/ipalib/plugins/aci.py'
> ipa: DEBUG: importing plugin module 
> '/usr/src/freeipa/ipalib/plugins/automount.py'
> ipa: ERROR: could not load plugin module 
> '/usr/src/freeipa/ipalib/plugins/automount.py'
> Traceback (most recent call last):
>   File "/usr/src/freeipa/ipalib/plugable.py", line 538, in import_plugins
> __import__(fullname)
>   File "/usr/src/freeipa/ipalib/plugins/automount.py", line 172, in 
> from ipalib.plugins.baseldap import *
>   File "/usr/src/freeipa/ipalib/plugins/baseldap.py", line 30, in 
> from ipalib.cli import to_cli, from_cli
>   File "/usr/src/freeipa/ipalib/cli.py", line 35, in 
> import default_encoding_utf8
> ImportError: No module named default_encoding_utf8
>
> Patch is a 1 liner that changes:
>
> import default_encoding_utf8
>
> To
>
> from policycoreutils import default_encoding_utf8
>   
>   

But this one was not reviewed yet, right?

> 
>
> ___
> Freeipa-devel mailing list
> Freeipa-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel


-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager IPA project,
Red Hat Inc.


---
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [ PATCH ] lite-server.py failing due to cli.py dependency: import default_encoding_utf8

2010-11-01 Thread Rob Crittenden

JR Aquino wrote:

./lite-server.py -d
ipa: DEBUG: importing all plugin modules in '/usr/src/freeipa/ipalib/plugins'...
ipa: DEBUG: importing plugin module '/usr/src/freeipa/ipalib/plugins/aci.py'
ipa: DEBUG: importing plugin module 
'/usr/src/freeipa/ipalib/plugins/automount.py'
ipa: ERROR: could not load plugin module 
'/usr/src/freeipa/ipalib/plugins/automount.py'
Traceback (most recent call last):
   File "/usr/src/freeipa/ipalib/plugable.py", line 538, in import_plugins
 __import__(fullname)
   File "/usr/src/freeipa/ipalib/plugins/automount.py", line 172, in
 from ipalib.plugins.baseldap import *
   File "/usr/src/freeipa/ipalib/plugins/baseldap.py", line 30, in
 from ipalib.cli import to_cli, from_cli
   File "/usr/src/freeipa/ipalib/cli.py", line 35, in
 import default_encoding_utf8
ImportError: No module named default_encoding_utf8

Patch is a 1 liner that changes:

import default_encoding_utf8

To

from policycoreutils import default_encoding_utf8


We provide a module of the same name. You probably just need to update 
your base install on your IPA server.


This is very interesting though. I'll check with those guys, maybe we 
can drop our local copy if they're doing the same thing.


So NACK for now until we can figure this out.

rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel