Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-28 Thread Martin Kosek
On Tue, 2012-03-27 at 19:02 +0200, Petr Viktorin wrote: Updated with a regression test for https://fedorahosted.org/freeipa/ticket/2581 (Unable to delete all sshfp records interactively) which Martin fixed recently. Thank's for adding a specific test for this I see 2 issues with this

Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-28 Thread Petr Viktorin
On 03/28/2012 09:11 AM, Martin Kosek wrote: On Tue, 2012-03-27 at 19:02 +0200, Petr Viktorin wrote: Updated with a regression test for https://fedorahosted.org/freeipa/ticket/2581 (Unable to delete all sshfp records interactively) which Martin fixed recently. Thank's for adding a specific

Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-27 Thread Petr Viktorin
Updated with a regression test for https://fedorahosted.org/freeipa/ticket/2581 (Unable to delete all sshfp records interactively) which Martin fixed recently. -- PetrĀ³ From 585423feb041cd434977130bd6f00975808ccf30 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Tue,

Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-16 Thread Petr Viktorin
On 03/13/2012 12:23 PM, Petr Viktorin wrote: On 03/12/2012 09:18 PM, Rob Crittenden wrote: Petr Viktorin wrote: Most of the tests we have check if the server does the right thing with XML-RPC calls. How the commandline is converted to command arguments, including interactive prompting, is

Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-13 Thread Petr Viktorin
On 03/12/2012 09:18 PM, Rob Crittenden wrote: Petr Viktorin wrote: Most of the tests we have check if the server does the right thing with XML-RPC calls. How the commandline is converted to command arguments, including interactive prompting, is untested. This patch adds some tests in this area.

Re: [Freeipa-devel] [PATCH] 0021 Add CLI tests

2012-03-12 Thread Rob Crittenden
Petr Viktorin wrote: Most of the tests we have check if the server does the right thing with XML-RPC calls. How the commandline is converted to command arguments, including interactive prompting, is untested. This patch adds some tests in this area. To do that I had to break up cli.run into more