Re: [Freeipa-devel] [PATCH] 0041: webui: add create/retrieve keytab tables for hosts
On 06/09/2016 02:18 PM, Pavel Vomacka wrote: > > > On 06/09/2016 02:03 PM, Petr Vobornik wrote: >> On 06/08/2016 03:32 PM, Pavel Vomacka wrote: >>> >>> On 06/08/2016 02:20 PM, Petr Vobornik wrote: On 06/06/2016 04:17 PM, Pavel Vomacka wrote: > Hello, > > please review attached patch. > > Ticket: https://fedorahosted.org/freeipa/ticket/5931 > Also tables for host groups are needed. + the same UI should be also on host page. >>> Added, please see attached patch. >> 1.hostgroups cannot be removed from "allow to read" tables. >> >> This should fix it. >> >> - name: 'ipaallowedtoperform_read_keys_hosts_group', >> + name: 'ipaallowedtoperform_read_keys_hostgroup', >> >> - name: 'ipaallowedtoperform_read_keys_hosts_group', >> + name: 'ipaallowedtoperform_read_keys_hostgroup', >> >> Patch with the change attached. ACK if you ACK it :) > ACK, thank you for fixing it. :) pushed to master: * b1df1cfe71129075a010a0a3a38f1595d79cf412 Add lists of hosts allowed to create or retrieve keytabs -- Petr Vobornik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] 0041: webui: add create/retrieve keytab tables for hosts
On 06/09/2016 02:03 PM, Petr Vobornik wrote: On 06/08/2016 03:32 PM, Pavel Vomacka wrote: On 06/08/2016 02:20 PM, Petr Vobornik wrote: On 06/06/2016 04:17 PM, Pavel Vomacka wrote: Hello, please review attached patch. Ticket: https://fedorahosted.org/freeipa/ticket/5931 Also tables for host groups are needed. + the same UI should be also on host page. Added, please see attached patch. 1.hostgroups cannot be removed from "allow to read" tables. This should fix it. - name: 'ipaallowedtoperform_read_keys_hosts_group', + name: 'ipaallowedtoperform_read_keys_hostgroup', - name: 'ipaallowedtoperform_read_keys_hosts_group', + name: 'ipaallowedtoperform_read_keys_hostgroup', Patch with the change attached. ACK if you ACK it :) ACK, thank you for fixing it. :) -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] 0041: webui: add create/retrieve keytab tables for hosts
On 06/08/2016 03:32 PM, Pavel Vomacka wrote:
>
>
> On 06/08/2016 02:20 PM, Petr Vobornik wrote:
>> On 06/06/2016 04:17 PM, Pavel Vomacka wrote:
>>> Hello,
>>>
>>> please review attached patch.
>>>
>>> Ticket: https://fedorahosted.org/freeipa/ticket/5931
>>>
>> Also tables for host groups are needed.
>>
>> + the same UI should be also on host page.
> Added, please see attached patch.
1.hostgroups cannot be removed from "allow to read" tables.
This should fix it.
- name: 'ipaallowedtoperform_read_keys_hosts_group',
+ name: 'ipaallowedtoperform_read_keys_hostgroup',
- name: 'ipaallowedtoperform_read_keys_hosts_group',
+ name: 'ipaallowedtoperform_read_keys_hostgroup',
Patch with the change attached. ACK if you ACK it :)
--
Petr Vobornik
From 8ed91c9aeab243c4e42dce566ff5bdd1dd63e849 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka
Date: Mon, 6 Jun 2016 12:59:24 +0200
Subject: [PATCH] Add lists of hosts allowed to create or retrieve keytabs
Attributes tables are added on host and service pages.
https://fedorahosted.org/freeipa/ticket/5931
---
install/ui/src/freeipa/host.js| 64 +++
install/ui/src/freeipa/service.js | 64 +++
2 files changed, 128 insertions(+)
diff --git a/install/ui/src/freeipa/host.js b/install/ui/src/freeipa/host.js
index 817e62efca7dca9745c71ee4d4d4823f885a8fab..80e3db65844759cb195c56fe0b48a95bba78bd00 100644
--- a/install/ui/src/freeipa/host.js
+++ b/install/ui/src/freeipa/host.js
@@ -187,6 +187,38 @@ return {
link: true
}
]
+},
+{
+$type: 'association_table',
+id: 'service_ipaallowedtoperform_read_keys_host',
+name: 'ipaallowedtoperform_read_keys_host',
+add_method: 'allow_retrieve_keytab',
+remove_method: 'disallow_retrieve_keytab',
+add_title: '@i18n:keytab.add_retrive',
+remove_title: '@i18n:keytab.remove_retrieve',
+columns: [
+{
+name: 'ipaallowedtoperform_read_keys_host',
+label: '@mo:host.label_singular',
+link: true
+}
+]
+},
+{
+$type: 'association_table',
+id: 'service_ipaallowedtoperform_read_keys_hostgroup',
+name: 'ipaallowedtoperform_read_keys_hostgroup',
+add_method: 'allow_retrieve_keytab',
+remove_method: 'disallow_retrieve_keytab',
+add_title: '@i18n:keytab.add_retrive',
+remove_title: '@i18n:keytab.remove_retrieve',
+columns: [
+{
+name: 'ipaallowedtoperform_read_keys_hostgroup',
+label: '@mo:hostgroup.label_singular',
+link: true
+}
+]
}
]
},
@@ -226,6 +258,38 @@ return {
link: true
}
]
+},
+{
+$type: 'association_table',
+id: 'service_ipaallowedtoperform_write_keys_host',
+name: 'ipaallowedtoperform_write_keys_host',
+add_method: 'allow_create_keytab',
+remove_method: 'disallow_create_keytab',
+add_title: '@i18n:keytab.add_create',
+remove_title: '@i18n:keytab.remove_create',
+columns: [
+{
+name: 'ipaallowedtoperform_write_keys_host',
+label: '@mo:host.label_singular',
+link: true
+}
+]
+},
+{
+$type: 'association_table',
+id: 'service_ipaallowedtoperform_write_keys_hostgroup',
+name: 'ipaallowedtoperform_write_keys_hostgroup',
+add_method: 'allow_create_keytab',
+remove_method: 'disallow_create_keytab',
+add_title: '@i18n:k
Re: [Freeipa-devel] [PATCH] 0041: webui: add create/retrieve keytab tables for hosts
On 06/08/2016 02:20 PM, Petr Vobornik wrote:
On 06/06/2016 04:17 PM, Pavel Vomacka wrote:
Hello,
please review attached patch.
Ticket: https://fedorahosted.org/freeipa/ticket/5931
Also tables for host groups are needed.
+ the same UI should be also on host page.
Added, please see attached patch.
From 3b32ca1641fa388cd23bc7437f28e99ecbcba9b2 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka
Date: Mon, 6 Jun 2016 12:59:24 +0200
Subject: [PATCH] Add lists of hosts allowed to create or retrieve keytabs
Attributes tables are added on host and service pages.
https://fedorahosted.org/freeipa/ticket/5931
---
install/ui/src/freeipa/host.js| 64 +++
install/ui/src/freeipa/service.js | 64 +++
2 files changed, 128 insertions(+)
diff --git a/install/ui/src/freeipa/host.js b/install/ui/src/freeipa/host.js
index 817e62efca7dca9745c71ee4d4d4823f885a8fab..d1795d5bf1fe4b593fd7db87fb1385f8a31ed07a 100644
--- a/install/ui/src/freeipa/host.js
+++ b/install/ui/src/freeipa/host.js
@@ -187,6 +187,38 @@ return {
link: true
}
]
+},
+{
+$type: 'association_table',
+id: 'service_ipaallowedtoperform_read_keys_host',
+name: 'ipaallowedtoperform_read_keys_host',
+add_method: 'allow_retrieve_keytab',
+remove_method: 'disallow_retrieve_keytab',
+add_title: '@i18n:keytab.add_retrive',
+remove_title: '@i18n:keytab.remove_retrieve',
+columns: [
+{
+name: 'ipaallowedtoperform_read_keys_host',
+label: '@mo:host.label_singular',
+link: true
+}
+]
+},
+{
+$type: 'association_table',
+id: 'service_ipaallowedtoperform_read_keys_hostgroup',
+name: 'ipaallowedtoperform_read_keys_hostgroup',
+add_method: 'allow_retrieve_keytab',
+remove_method: 'disallow_retrieve_keytab',
+add_title: '@i18n:keytab.add_retrive',
+remove_title: '@i18n:keytab.remove_retrieve',
+columns: [
+{
+name: 'ipaallowedtoperform_read_keys_hosts_group',
+label: '@mo:hostgroup.label_singular',
+link: true
+}
+]
}
]
},
@@ -226,6 +258,38 @@ return {
link: true
}
]
+},
+{
+$type: 'association_table',
+id: 'service_ipaallowedtoperform_write_keys_host',
+name: 'ipaallowedtoperform_write_keys_host',
+add_method: 'allow_create_keytab',
+remove_method: 'disallow_create_keytab',
+add_title: '@i18n:keytab.add_create',
+remove_title: '@i18n:keytab.remove_create',
+columns: [
+{
+name: 'ipaallowedtoperform_write_keys_host',
+label: '@mo:host.label_singular',
+link: true
+}
+]
+},
+{
+$type: 'association_table',
+id: 'service_ipaallowedtoperform_write_keys_hostgroup',
+name: 'ipaallowedtoperform_write_keys_hostgroup',
+add_method: 'allow_create_keytab',
+remove_method: 'disallow_create_keytab',
+add_title: '@i18n:keytab.add_create',
+remove_title: '@i18n:keytab.remove_create',
+columns: [
+{
+name: 'ipaallowedtoperform_write_keys_hostgroup',
+label: '@mo:hostgroup.label_singular',
+link: true
+}
+]
Re: [Freeipa-devel] [PATCH] 0041: webui: add create/retrieve keytab tables for hosts
On 06/06/2016 04:17 PM, Pavel Vomacka wrote: > Hello, > > please review attached patch. > > Ticket: https://fedorahosted.org/freeipa/ticket/5931 > Also tables for host groups are needed. + the same UI should be also on host page. -- Petr Vobornik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
