Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Martin Kosek]

On 01/16/2014 03:23 PM, Martin Kosek wrote:
> On 01/16/2014 12:06 PM, Petr Vobornik wrote:
>> On 3.1.2014 12:38, Petr Vobornik wrote:
>>> On 29.11.2013 17:02, Ana Krivokapic wrote:
 On 11/29/2013 02:45 PM, Ana Krivokapic wrote:
>> On 11/25/2013 04:48 PM, Ana Krivokapic wrote:
 On 11/15/2013 02:26 PM, Petr Vobornik wrote:
>> Hello list,
>>
>> this is a first part of RCUE adoption effort. Main themes of
>>> this patch set are:
>>
>> - use RCUE navigation
>> - new styles for textboxes, textareas, radio/checkbox buttons
>>> and buttons-
>> part of
>> - new internal form layout (tables replaced by divs)
>> - layout does not have fixed
>>> size
>> - new dialog styles + removed dependency on jQuery UI dialog
>> - icons replaced by Font Awesome glyphs
>>
>> Example is at:
>>
>> Some reasonings and additional info:
>>
>> 1. RCUE includes Bootstrap which defines o lot of styles for a
>>> lot of things.
>> That messed up the UI and therefore I did the form changes now.
>>
>> 2. jQuery UI is pretty big lib and we used it only for dialog
>>> and buttons.
>> Buttons were replaced by RCUE buttons so removal of dialog
>>> dependency was a
>> obvious step to get rid of the whole lib. The lib is removed
>>> from main UI but
>> is still present in separate pages - will be removed later.
>>
>> 3. Dojo and jQuery were upgraded to latest
>> versions.
>>
>> This approach was ACKed by Kyle from a design perspective with a
>>> note that we
>> will review and fixed some styling after second phase. We should
>>> not release
>> until then.
>>
>> The second phase, which I'm working on right now, will consist of:
>>  * login screen
>>  * new styles for standalone pages
>>  * necessary responsive enhancement (the ultimate future goal
>>> is responsive
>> layout)
>>
>> It's quite a lot of patches so I did not attach them here. You
>>> can see the
>> code in my private repo:
>>>  branch
>> 'rcue'.
 I tested this phase of RCUE adoption effort, overall it looks and
>> works great. A
 couple of findings:

 1) Two ui integration tests are failing, I guess this is due to
>> the re-arranging
 of elements on the automember page. So the tests should be amended
>> to reflect
 that change.
 Commit ee4f6540490a16f0fbb5cdd02097a9b3ff354252 works around the
 navigation
 issue which caused tests to fail. ACK.

>>>
>>> I've unbundled font files from FreeIPA Web UI
>>> - Open Sans will be in new fedora package - open-sans-fonts
>>> - Font Awesome as well - fontawesome-fonts
>>> - Overpass fonts are no longer used
>>>
>>> Branch rcue-fonts-unbundled
>>> git://fedorapeople.org/home/fedora/pvoborni/public_git/freeipa.git
>>> contains the changes. It's 6 additional commits on top of the reviewed
>>> rcue branch. 5 commits were squashed in order to reduce size of the
>>> final push. Attaching all of the patches for reference.
>>>
>>> open-sans-fonts and fontawesome-fonts Fedora packages are still on review:
>>> - https://bugzilla.redhat.com/show_bug.cgi?id=1035897
>>> - https://bugzilla.redhat.com/show_bug.cgi?id=1026376
>>>
>>> Reviewer for open-sans-fonts needed.
>>>
>>> OTP UI will be rebased on top of this effort.
>>>
>>
>> The review is not blocked anymore - both fonts are available in updates 
>> testing.
> 
> I tested the 'rcue-fonts-unbundled' branch and it works for me. Given Ana's
> previous review, the only unreviewed patch is the top one switching to using
> the external fonts you packaged [1]. I found just one issue in the patch - the
> version of ipa.conf was not bumped, thus the upgrade would fail as ipa.conf
> would not be updated.
> 
> If this is fixed, I would be OK with pushing this work to master so that you
> can base your next work on a stable grounds. Adding Simo and Rob to CC to
> notify them about this bigger push so that they can express any concerns.
> 
> Note that current state is still not ready to be released as is, it still has
> some rough edges, but it will at least give others developers opportunity to
> test it.
> 
> Martin
> 
> [1]
> http://fedorapeople.org/cgit/pvoborni/public_git/freeipa.git/commit/?h=datetime-ui&id=3d976cdb60e122ea722ecb3bd03a78b25ef105ca

I bumped up the version of the ipa.conf package in the last patch as notified.

I pushed all 70 patches to master. Thanks Petr for your RCUE work so fa

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Martin Kosek]

On 01/16/2014 12:06 PM, Petr Vobornik wrote:
> On 3.1.2014 12:38, Petr Vobornik wrote:
>> On 29.11.2013 17:02, Ana Krivokapic wrote:
>>> On 11/29/2013 02:45 PM, Ana Krivokapic wrote:
 >On 11/25/2013 04:48 PM, Ana Krivokapic wrote:
> >>On 11/15/2013 02:26 PM, Petr Vobornik wrote:
>> >>>Hello list,
>> >>>
>> >>>this is a first part of RCUE adoption effort. Main themes of
>> this patch set are:
>> >>>
>> >>>- use RCUE navigation
>> >>>- new styles for textboxes, textareas, radio/checkbox buttons
>> and buttons-
>> >>>part of
>> >>>- new internal form layout (tables replaced by divs)
>> >>>- layout does not have fixed
>> size
>> >>>- new dialog styles + removed dependency on jQuery UI dialog
>> >>>- icons replaced by Font Awesome glyphs
>> >>>
>> >>>Example is at:
>> >>>
>> >>>Some reasonings and additional info:
>> >>>
>> >>>1. RCUE includes Bootstrap which defines o lot of styles for a
>> lot of things.
>> >>>That messed up the UI and therefore I did the form changes now.
>> >>>
>> >>>2. jQuery UI is pretty big lib and we used it only for dialog
>> and buttons.
>> >>>Buttons were replaced by RCUE buttons so removal of dialog
>> dependency was a
>> >>>obvious step to get rid of the whole lib. The lib is removed
>> from main UI but
>> >>>is still present in separate pages - will be removed later.
>> >>>
>> >>>3. Dojo and jQuery were upgraded to latest
>> >>>versions.
>> >>>
>> >>>This approach was ACKed by Kyle from a design perspective with a
>> note that we
>> >>>will review and fixed some styling after second phase. We should
>> not release
>> >>>until then.
>> >>>
>> >>>The second phase, which I'm working on right now, will consist of:
>> >>>  * login screen
>> >>>  * new styles for standalone pages
>> >>>  * necessary responsive enhancement (the ultimate future goal
>> is responsive
>> >>>layout)
>> >>>
>> >>>It's quite a lot of patches so I did not attach them here. You
>> can see the
>> >>>code in my private repo:
>>  branch
>> >>>'rcue'.
> >>I tested this phase of RCUE adoption effort, overall it looks and
> works great. A
> >>couple of findings:
> >>
> >>1) Two ui integration tests are failing, I guess this is due to
> the re-arranging
> >>of elements on the automember page. So the tests should be amended
> to reflect
> >>that change.
>>> Commit ee4f6540490a16f0fbb5cdd02097a9b3ff354252 works around the
>>> navigation
>>> issue which caused tests to fail. ACK.
>>>
>>
>> I've unbundled font files from FreeIPA Web UI
>> - Open Sans will be in new fedora package - open-sans-fonts
>> - Font Awesome as well - fontawesome-fonts
>> - Overpass fonts are no longer used
>>
>> Branch rcue-fonts-unbundled
>> git://fedorapeople.org/home/fedora/pvoborni/public_git/freeipa.git
>> contains the changes. It's 6 additional commits on top of the reviewed
>> rcue branch. 5 commits were squashed in order to reduce size of the
>> final push. Attaching all of the patches for reference.
>>
>> open-sans-fonts and fontawesome-fonts Fedora packages are still on review:
>> - https://bugzilla.redhat.com/show_bug.cgi?id=1035897
>> - https://bugzilla.redhat.com/show_bug.cgi?id=1026376
>>
>> Reviewer for open-sans-fonts needed.
>>
>> OTP UI will be rebased on top of this effort.
>>
> 
> The review is not blocked anymore - both fonts are available in updates 
> testing.

I tested the 'rcue-fonts-unbundled' branch and it works for me. Given Ana's
previous review, the only unreviewed patch is the top one switching to using
the external fonts you packaged [1]. I found just one issue in the patch - the
version of ipa.conf was not bumped, thus the upgrade would fail as ipa.conf
would not be updated.

If this is fixed, I would be OK with pushing this work to master so that you
can base your next work on a stable grounds. Adding Simo and Rob to CC to
notify them about this bigger push so that they can express any concerns.

Note that current state is still not ready to be released as is, it still has
some rough edges, but it will at least give others developers opportunity to
test it.

Martin

[1]
http://fedorapeople.org/cgit/pvoborni/public_git/freeipa.git/commit/?h=datetime-ui&id=3d976cdb60e122ea722ecb3bd03a78b25ef105ca

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Petr Vobornik]

On 3.1.2014 12:38, Petr Vobornik wrote:

On 29.11.2013 17:02, Ana Krivokapic wrote:

On 11/29/2013 02:45 PM, Ana Krivokapic wrote:

>On 11/25/2013 04:48 PM, Ana Krivokapic wrote:

>>On 11/15/2013 02:26 PM, Petr Vobornik wrote:

>>>Hello list,
>>>
>>>this is a first part of RCUE adoption effort. Main themes of
this patch set are:
>>>
>>>- use RCUE navigation
>>>- new styles for textboxes, textareas, radio/checkbox buttons
and buttons-
>>>part of
>>>- new internal form layout (tables replaced by divs)
>>>- layout does not have fixed
size
>>>- new dialog styles + removed dependency on jQuery UI dialog
>>>- icons replaced by Font Awesome glyphs
>>>
>>>Example is at:
>>>
>>>Some reasonings and additional info:
>>>
>>>1. RCUE includes Bootstrap which defines o lot of styles for a
lot of things.
>>>That messed up the UI and therefore I did the form changes now.
>>>
>>>2. jQuery UI is pretty big lib and we used it only for dialog
and buttons.
>>>Buttons were replaced by RCUE buttons so removal of dialog
dependency was a
>>>obvious step to get rid of the whole lib. The lib is removed
from main UI but
>>>is still present in separate pages - will be removed later.
>>>
>>>3. Dojo and jQuery were upgraded to latest
>>>versions.
>>>
>>>This approach was ACKed by Kyle from a design perspective with a
note that we
>>>will review and fixed some styling after second phase. We should
not release
>>>until then.
>>>
>>>The second phase, which I'm working on right now, will consist of:
>>>  * login screen
>>>  * new styles for standalone pages
>>>  * necessary responsive enhancement (the ultimate future goal
is responsive
>>>layout)
>>>
>>>It's quite a lot of patches so I did not attach them here. You
can see the
>>>code in my private repo:
 branch
>>>'rcue'.

>>I tested this phase of RCUE adoption effort, overall it looks and
works great. A
>>couple of findings:
>>
>>1) Two ui integration tests are failing, I guess this is due to
the re-arranging
>>of elements on the automember page. So the tests should be amended
to reflect
>>that change.

Commit ee4f6540490a16f0fbb5cdd02097a9b3ff354252 works around the
navigation
issue which caused tests to fail. ACK.



I've unbundled font files from FreeIPA Web UI
- Open Sans will be in new fedora package - open-sans-fonts
- Font Awesome as well - fontawesome-fonts
- Overpass fonts are no longer used

Branch rcue-fonts-unbundled
git://fedorapeople.org/home/fedora/pvoborni/public_git/freeipa.git
contains the changes. It's 6 additional commits on top of the reviewed
rcue branch. 5 commits were squashed in order to reduce size of the
final push. Attaching all of the patches for reference.

open-sans-fonts and fontawesome-fonts Fedora packages are still on review:
- https://bugzilla.redhat.com/show_bug.cgi?id=1035897
- https://bugzilla.redhat.com/show_bug.cgi?id=1026376

Reviewer for open-sans-fonts needed.

OTP UI will be rebased on top of this effort.



The review is not blocked anymore - both fonts are available in updates 
testing.

--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Ana Krivokapic]

On 11/29/2013 02:45 PM, Ana Krivokapic wrote:
> On 11/25/2013 04:48 PM, Ana Krivokapic wrote:
>> On 11/15/2013 02:26 PM, Petr Vobornik wrote:
>>> Hello list,
>>>
>>> this is a first part of RCUE adoption effort. Main themes of this patch set 
>>> are:
>>>
>>> - use RCUE navigation 
>>> - new styles for textboxes, textareas, radio/checkbox buttons and buttons-
>>> part of 
>>> - new internal form layout (tables replaced by divs)
>>> - layout does not have fixed size 
>>> 
>>> - new dialog styles + removed dependency on jQuery UI dialog
>>> - icons replaced by Font Awesome glyphs
>>>
>>> Example is at: 
>>>
>>> Some reasonings and additional info:
>>>
>>> 1. RCUE includes Bootstrap which defines o lot of styles for a lot of 
>>> things.
>>> That messed up the UI and therefore I did the form changes now.
>>>
>>> 2. jQuery UI is pretty big lib and we used it only for dialog and buttons.
>>> Buttons were replaced by RCUE buttons so removal of dialog dependency was a
>>> obvious step to get rid of the whole lib. The lib is removed from main UI 
>>> but
>>> is still present in separate pages - will be removed later.
>>>
>>> 3. Dojo and jQuery were upgraded to latest
>>> versions.
>>>
>>> This approach was ACKed by Kyle from a design perspective with a note that 
>>> we
>>> will review and fixed some styling after second phase. We should not release
>>> until then.
>>>
>>> The second phase, which I'm working on right now, will consist of:
>>>  * login screen 
>>>  * new styles for standalone pages
>>>  * necessary responsive enhancement (the ultimate future goal is responsive
>>> layout)
>>>
>>> It's quite a lot of patches so I did not attach them here. You can see the
>>> code in my private repo:  
>>> branch
>>> 'rcue'.
>> I tested this phase of RCUE adoption effort, overall it looks and works 
>> great. A
>> couple of findings:
>>
>> 1) Two ui integration tests are failing, I guess this is due to the 
>> re-arranging
>> of elements on the automember page. So the tests should be amended to reflect
>> that change.

Commit ee4f6540490a16f0fbb5cdd02097a9b3ff354252 works around the navigation
issue which caused tests to fail. ACK.

>>
>> 2) In the 'Add Host' dialog, validation error messages do not have the proper
>> styles. E.g. if you don't fill any values, and just click 'Add', 'Required
>> field' messages appear, but they are not red, and the related fields do not 
>> get
>> a red frame.
>>
>>
> I have reviewed Petr's fix for the issue with the host adder dialog (issue 2)
> above). The fix is contained in commit 
> 829eb4f69e004c20f2d06b16ebd8d9bd176a81dd
> in his private repo. I can confirm that the adder dialog now behaves 
> correctly,
> so ACK for that fix.
>


-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Ana Krivokapic]

On 11/25/2013 04:48 PM, Ana Krivokapic wrote:
> On 11/15/2013 02:26 PM, Petr Vobornik wrote:
>> Hello list,
>>
>> this is a first part of RCUE adoption effort. Main themes of this patch set 
>> are:
>>
>> - use RCUE navigation 
>> - new styles for textboxes, textareas, radio/checkbox buttons and buttons-
>> part of 
>> - new internal form layout (tables replaced by divs)
>> - layout does not have fixed size 
>> 
>> - new dialog styles + removed dependency on jQuery UI dialog
>> - icons replaced by Font Awesome glyphs
>>
>> Example is at: 
>>
>> Some reasonings and additional info:
>>
>> 1. RCUE includes Bootstrap which defines o lot of styles for a lot of things.
>> That messed up the UI and therefore I did the form changes now.
>>
>> 2. jQuery UI is pretty big lib and we used it only for dialog and buttons.
>> Buttons were replaced by RCUE buttons so removal of dialog dependency was a
>> obvious step to get rid of the whole lib. The lib is removed from main UI but
>> is still present in separate pages - will be removed later.
>>
>> 3. Dojo and jQuery were upgraded to latest
>> versions.
>>
>> This approach was ACKed by Kyle from a design perspective with a note that we
>> will review and fixed some styling after second phase. We should not release
>> until then.
>>
>> The second phase, which I'm working on right now, will consist of:
>>  * login screen 
>>  * new styles for standalone pages
>>  * necessary responsive enhancement (the ultimate future goal is responsive
>> layout)
>>
>> It's quite a lot of patches so I did not attach them here. You can see the
>> code in my private repo:  
>> branch
>> 'rcue'.
> I tested this phase of RCUE adoption effort, overall it looks and works 
> great. A
> couple of findings:
>
> 1) Two ui integration tests are failing, I guess this is due to the 
> re-arranging
> of elements on the automember page. So the tests should be amended to reflect
> that change.
>
> 2) In the 'Add Host' dialog, validation error messages do not have the proper
> styles. E.g. if you don't fill any values, and just click 'Add', 'Required
> field' messages appear, but they are not red, and the related fields do not 
> get
> a red frame.
>
>

I have reviewed Petr's fix for the issue with the host adder dialog (issue 2)
above). The fix is contained in commit 829eb4f69e004c20f2d06b16ebd8d9bd176a81dd
in his private repo. I can confirm that the adder dialog now behaves correctly,
so ACK for that fix.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Ana Krivokapic]

On 11/15/2013 02:26 PM, Petr Vobornik wrote:
> Hello list,
>
> this is a first part of RCUE adoption effort. Main themes of this patch set 
> are:
>
> - use RCUE navigation 
> - new styles for textboxes, textareas, radio/checkbox buttons and buttons-
> part of 
> - new internal form layout (tables replaced by divs)
> - layout does not have fixed size 
> 
> - new dialog styles + removed dependency on jQuery UI dialog
> - icons replaced by Font Awesome glyphs
>
> Example is at: 
>
> Some reasonings and additional info:
>
> 1. RCUE includes Bootstrap which defines o lot of styles for a lot of things.
> That messed up the UI and therefore I did the form changes now.
>
> 2. jQuery UI is pretty big lib and we used it only for dialog and buttons.
> Buttons were replaced by RCUE buttons so removal of dialog dependency was a
> obvious step to get rid of the whole lib. The lib is removed from main UI but
> is still present in separate pages - will be removed later.
>
> 3. Dojo and jQuery were upgraded to latest
> versions.
>
> This approach was ACKed by Kyle from a design perspective with a note that we
> will review and fixed some styling after second phase. We should not release
> until then.
>
> The second phase, which I'm working on right now, will consist of:
>  * login screen 
>  * new styles for standalone pages
>  * necessary responsive enhancement (the ultimate future goal is responsive
> layout)
>
> It's quite a lot of patches so I did not attach them here. You can see the
> code in my private repo:  branch
> 'rcue'.

I tested this phase of RCUE adoption effort, overall it looks and works great. A
couple of findings:

1) Two ui integration tests are failing, I guess this is due to the re-arranging
of elements on the automember page. So the tests should be amended to reflect
that change.

2) In the 'Add Host' dialog, validation error messages do not have the proper
styles. E.g. if you don't fill any values, and just click 'Add', 'Required
field' messages appear, but they are not red, and the related fields do not get
a red frame.


-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Petr Viktorin]

On 11/19/2013 01:27 PM, Petr Vobornik wrote:

On 11/18/2013 08:47 PM, Petr Viktorin wrote:

On 11/18/2013 06:17 PM, Petr Vobornik wrote:

On 11/15/2013 05:43 PM, Petr Viktorin wrote:

On 11/15/2013 03:28 PM, Petr Vobornik wrote:

On 11/15/2013 02:40 PM, Petr Viktorin wrote:

On 11/15/2013 02:26 PM, Petr Vobornik wrote:

[...]

It's quite a lot of patches so I did not attach them here. You can
see
the code in my private repo:
 branch 'rcue'.


Wow. Do we really need all these third-party fonts and styles in our
repo?


It's common in Web development to offer all versions and let the
browser
to choose one.

Since FreeIPA Web UI supports IE9+ we can safely reduce the font files
only to .woff fonts . We can also discard all
Italic fonts (not used atm).

Fedora 20 has a new feature called Web Assets
 which should solve
such bundles. I'm not convinced that it's in usable state atm.



That doesn't answer the question of why we need third-party compiled
assets in the repo.

Fedora spec files can also have multiple Sources, if we need to bundle
for distribution.



I worry that it will be just source of build errors and such. For
example I would like to have access to the files during development
without running rpm build or using crystal ball to figure out what is
needed and where to get it.


A curious requirement, bundling everything in the Git repo. I'm afraid I
don't really understand your thinking here.
In the world I live in, a repo should contain upstream source files.
Third-party dependencies must be listed, and need to be installed for
building/using the project, and compiled artifacts should be compiled
from sources.
Having third-party compiled stuff means bundling, forking, and other
similar swear words.

Needing a crystal ball to locate the source is a packager's nightmare.
And this patchset put us in that situation, for any kind of checking if
these are up to date or what the licenses are.


Now I would suggest to use Bower  to solve it, but it
requires Node.js so I won't do that.

Here is some information about possible sources. Does it look usable to
you in any way?

1. Open Sans
- hard to find usable source, they should be in googlefontdirectory
 but that's 2.5GB+
Mercuial repo...
- some unofficial source (can be used by Bower):
 It has a bit different
font-face declaration which would require additional changes

2. Overpass
- official distribution [1] contains only .ttf fonts
- .woff version is in git repo


3. Font Awesome
- provides tarball 
- should not be a problem if I don't count .less files which required
some changes because lesscpy could not process them


So we have a fork there as well?
Did you try to submit the patch upstream?

So, now we need to package these so that we can depend on them, right?
At least that's how it works with any other project we want to depend on
if it's not in Fedora yet.



Fedora is not ready for packaging web libraries. We can continue with
the discussion after release of Fedora 21.

https://fedoraproject.org/wiki/Changes/Web_Assets#Scope


I must be reading the page wrong. For F20 it links to approved 
guidelines[0] that explicitly say to use/link system fonts from 
%{_datadir}/fonts, and packaging fonts elsewhere is prohibited.


Also web-assets is in f19, so only the httpd config is missing. As I 
read it, we're supposed to provide that ourselves for now.




Until then we have to bundle unless we use system like aforementioned
Bower.



[0] https://fedoraproject.org/wiki/Packaging:Web_Assets#Fonts

--
Petr³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Petr Vobornik]

On 11/18/2013 08:47 PM, Petr Viktorin wrote:

On 11/18/2013 06:17 PM, Petr Vobornik wrote:

On 11/15/2013 05:43 PM, Petr Viktorin wrote:

On 11/15/2013 03:28 PM, Petr Vobornik wrote:

On 11/15/2013 02:40 PM, Petr Viktorin wrote:

On 11/15/2013 02:26 PM, Petr Vobornik wrote:

[...]

It's quite a lot of patches so I did not attach them here. You can
see
the code in my private repo:
 branch 'rcue'.


Wow. Do we really need all these third-party fonts and styles in our
repo?


It's common in Web development to offer all versions and let the
browser
to choose one.

Since FreeIPA Web UI supports IE9+ we can safely reduce the font files
only to .woff fonts . We can also discard all
Italic fonts (not used atm).

Fedora 20 has a new feature called Web Assets
 which should solve
such bundles. I'm not convinced that it's in usable state atm.



That doesn't answer the question of why we need third-party compiled
assets in the repo.

Fedora spec files can also have multiple Sources, if we need to bundle
for distribution.



I worry that it will be just source of build errors and such. For
example I would like to have access to the files during development
without running rpm build or using crystal ball to figure out what is
needed and where to get it.


A curious requirement, bundling everything in the Git repo. I'm afraid I
don't really understand your thinking here.
In the world I live in, a repo should contain upstream source files.
Third-party dependencies must be listed, and need to be installed for
building/using the project, and compiled artifacts should be compiled
from sources.
Having third-party compiled stuff means bundling, forking, and other
similar swear words.

Needing a crystal ball to locate the source is a packager's nightmare.
And this patchset put us in that situation, for any kind of checking if
these are up to date or what the licenses are.


Now I would suggest to use Bower  to solve it, but it
requires Node.js so I won't do that.

Here is some information about possible sources. Does it look usable to
you in any way?

1. Open Sans
- hard to find usable source, they should be in googlefontdirectory
 but that's 2.5GB+
Mercuial repo...
- some unofficial source (can be used by Bower):
 It has a bit different
font-face declaration which would require additional changes

2. Overpass
- official distribution [1] contains only .ttf fonts
- .woff version is in git repo


3. Font Awesome
- provides tarball 
- should not be a problem if I don't count .less files which required
some changes because lesscpy could not process them


So we have a fork there as well?
Did you try to submit the patch upstream?

So, now we need to package these so that we can depend on them, right?
At least that's how it works with any other project we want to depend on
if it's not in Fedora yet.



Fedora is not ready for packaging web libraries. We can continue with 
the discussion after release of Fedora 21.


https://fedoraproject.org/wiki/Changes/Web_Assets#Scope

Until then we have to bundle unless we use system like aforementioned Bower.
--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Petr Viktorin]

On 11/18/2013 06:17 PM, Petr Vobornik wrote:

On 11/15/2013 05:43 PM, Petr Viktorin wrote:

On 11/15/2013 03:28 PM, Petr Vobornik wrote:

On 11/15/2013 02:40 PM, Petr Viktorin wrote:

On 11/15/2013 02:26 PM, Petr Vobornik wrote:

[...]

It's quite a lot of patches so I did not attach them here. You can see
the code in my private repo:
 branch 'rcue'.


Wow. Do we really need all these third-party fonts and styles in our
repo?


It's common in Web development to offer all versions and let the browser
to choose one.

Since FreeIPA Web UI supports IE9+ we can safely reduce the font files
only to .woff fonts . We can also discard all
Italic fonts (not used atm).

Fedora 20 has a new feature called Web Assets
 which should solve
such bundles. I'm not convinced that it's in usable state atm.



That doesn't answer the question of why we need third-party compiled
assets in the repo.

Fedora spec files can also have multiple Sources, if we need to bundle
for distribution.



I worry that it will be just source of build errors and such. For
example I would like to have access to the files during development
without running rpm build or using crystal ball to figure out what is
needed and where to get it.


A curious requirement, bundling everything in the Git repo. I'm afraid I 
don't really understand your thinking here.
In the world I live in, a repo should contain upstream source files. 
Third-party dependencies must be listed, and need to be installed for 
building/using the project, and compiled artifacts should be compiled 
from sources.
Having third-party compiled stuff means bundling, forking, and other 
similar swear words.


Needing a crystal ball to locate the source is a packager's nightmare. 
And this patchset put us in that situation, for any kind of checking if 
these are up to date or what the licenses are.



Now I would suggest to use Bower  to solve it, but it
requires Node.js so I won't do that.

Here is some information about possible sources. Does it look usable to
you in any way?

1. Open Sans
- hard to find usable source, they should be in googlefontdirectory
 but that's 2.5GB+
Mercuial repo...
- some unofficial source (can be used by Bower):
 It has a bit different
font-face declaration which would require additional changes

2. Overpass
- official distribution [1] contains only .ttf fonts
- .woff version is in git repo


3. Font Awesome
- provides tarball 
- should not be a problem if I don't count .less files which required
some changes because lesscpy could not process them


So we have a fork there as well?
Did you try to submit the patch upstream?




So, now we need to package these so that we can depend on them, right?
At least that's how it works with any other project we want to depend on 
if it's not in Fedora yet.


--
Petr³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Petr Vobornik]

On 11/15/2013 05:43 PM, Petr Viktorin wrote:

On 11/15/2013 03:28 PM, Petr Vobornik wrote:

On 11/15/2013 02:40 PM, Petr Viktorin wrote:

On 11/15/2013 02:26 PM, Petr Vobornik wrote:

Hello list,

this is a first part of RCUE adoption effort. Main themes of this patch
set are:

- use RCUE navigation 
- new styles for textboxes, textareas, radio/checkbox buttons and
buttons- part of 
- new internal form layout (tables replaced by divs)
- layout does not have fixed size

- new dialog styles + removed dependency on jQuery UI dialog
- icons replaced by Font Awesome glyphs

Example is at: 

Some reasonings and additional info:

1. RCUE includes Bootstrap which defines o lot of styles for a lot of
things. That messed up the UI and therefore I did the form changes now.

2. jQuery UI is pretty big lib and we used it only for dialog and
buttons. Buttons were replaced by RCUE buttons so removal of dialog
dependency was a obvious step to get rid of the whole lib. The lib is
removed from main UI but is still present in separate pages - will be
removed later.

3. Dojo and jQuery were upgraded to latest
versions.

This approach was ACKed by Kyle from a design perspective with a note
that we will review and fixed some styling after second phase. We
should
not release until then.

The second phase, which I'm working on right now, will consist of:
  * login screen 
  * new styles for standalone pages
  * necessary responsive enhancement (the ultimate future goal is
responsive layout)

It's quite a lot of patches so I did not attach them here. You can see
the code in my private repo:
 branch 'rcue'.


Wow. Do we really need all these third-party fonts and styles in our
repo?


It's common in Web development to offer all versions and let the browser
to choose one.

Since FreeIPA Web UI supports IE9+ we can safely reduce the font files
only to .woff fonts . We can also discard all
Italic fonts (not used atm).

Fedora 20 has a new feature called Web Assets
 which should solve
such bundles. I'm not convinced that it's in usable state atm.



That doesn't answer the question of why we need third-party compiled
assets in the repo.

Fedora spec files can also have multiple Sources, if we need to bundle
for distribution.



I worry that it will be just source of build errors and such. For 
example I would like to have access to the files during development 
without running rpm build or using crystal ball to figure out what is 
needed and where to get it.


Now I would suggest to use Bower  to solve it, but it 
requires Node.js so I won't do that.


Here is some information about possible sources. Does it look usable to 
you in any way?


1. Open Sans
- hard to find usable source, they should be in googlefontdirectory 
 but that's 2.5GB+ 
Mercuial repo...
- some unofficial source (can be used by Bower): 
 It has a bit different 
font-face declaration which would require additional changes


2. Overpass
- official distribution [1] contains only .ttf fonts
- .woff version is in git repo 



3. Font Awesome
- provides tarball 
- should not be a problem if I don't count .less files which required 
some changes because lesscpy could not process them


Fedora doesn't have any standalone .woff font packaged.

[1] 



--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Petr Vobornik]

On 11/16/2013 04:17 AM, Simo Sorce wrote:

On Fri, 2013-11-15 at 14:26 +0100, Petr Vobornik wrote:


It's quite a lot of patches so I did not attach them here. You can
see
the code in my private repo:
 branch 'rcue'.


I can't see it listed here:
http://fedorapeople.org/cgit

Can you `touch ~/public_git/freeipa.git/git-daemon-export-ok` so that
cgit will pick it up ?

Simo.


Done
--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Simo Sorce]

On Fri, 2013-11-15 at 14:26 +0100, Petr Vobornik wrote:
> 
> It's quite a lot of patches so I did not attach them here. You can
> see 
> the code in my private repo: 
>  branch 'rcue'. 

I can't see it listed here:
http://fedorapeople.org/cgit

Can you `touch ~/public_git/freeipa.git/git-daemon-export-ok` so that
cgit will pick it up ?

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Jérôme Fenal]

2013/11/15 Dmitri Pal :
> On 11/15/2013 04:44 PM, James wrote:
>> On Fri, Nov 15, 2013 at 8:26 AM, Petr Vobornik  wrote:
>>> Example is at: 
>>
>> And here I thought FreeIPA couldn't get any prettier...
>> Nice work. +1
>>
>> James
>>
>> ___
>> Freeipa-devel mailing list
>> Freeipa-devel@redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>
> Very cool!

+1 very nice.
Side effect: the impact on all UI task descriptions in the
documentation when a sub-menu is involved ;)

-- 
Jérôme Fenal

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Dmitri Pal]

On 11/15/2013 04:44 PM, James wrote:
> On Fri, Nov 15, 2013 at 8:26 AM, Petr Vobornik  wrote:
>> Example is at: 
>
> And here I thought FreeIPA couldn't get any prettier...
> Nice work. +1
>
> James
>
> ___
> Freeipa-devel mailing list
> Freeipa-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

Very cool!

-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager for IdM portfolio
Red Hat Inc.


---
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/



___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[James]

On Fri, Nov 15, 2013 at 8:26 AM, Petr Vobornik  wrote:
> Example is at: 


And here I thought FreeIPA couldn't get any prettier...
Nice work. +1

James

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Petr Viktorin]

On 11/15/2013 03:28 PM, Petr Vobornik wrote:

On 11/15/2013 02:40 PM, Petr Viktorin wrote:

On 11/15/2013 02:26 PM, Petr Vobornik wrote:

Hello list,

this is a first part of RCUE adoption effort. Main themes of this patch
set are:

- use RCUE navigation 
- new styles for textboxes, textareas, radio/checkbox buttons and
buttons- part of 
- new internal form layout (tables replaced by divs)
- layout does not have fixed size

- new dialog styles + removed dependency on jQuery UI dialog
- icons replaced by Font Awesome glyphs

Example is at: 

Some reasonings and additional info:

1. RCUE includes Bootstrap which defines o lot of styles for a lot of
things. That messed up the UI and therefore I did the form changes now.

2. jQuery UI is pretty big lib and we used it only for dialog and
buttons. Buttons were replaced by RCUE buttons so removal of dialog
dependency was a obvious step to get rid of the whole lib. The lib is
removed from main UI but is still present in separate pages - will be
removed later.

3. Dojo and jQuery were upgraded to latest
versions.

This approach was ACKed by Kyle from a design perspective with a note
that we will review and fixed some styling after second phase. We should
not release until then.

The second phase, which I'm working on right now, will consist of:
  * login screen 
  * new styles for standalone pages
  * necessary responsive enhancement (the ultimate future goal is
responsive layout)

It's quite a lot of patches so I did not attach them here. You can see
the code in my private repo:
 branch 'rcue'.


Wow. Do we really need all these third-party fonts and styles in our
repo?


It's common in Web development to offer all versions and let the browser
to choose one.

Since FreeIPA Web UI supports IE9+ we can safely reduce the font files
only to .woff fonts . We can also discard all
Italic fonts (not used atm).

Fedora 20 has a new feature called Web Assets
 which should solve
such bundles. I'm not convinced that it's in usable state atm.



That doesn't answer the question of why we need third-party compiled 
assets in the repo.


Fedora spec files can also have multiple Sources, if we need to bundle 
for distribution.


--
Petr³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Petr Vobornik]

On 11/15/2013 02:40 PM, Petr Viktorin wrote:

On 11/15/2013 02:26 PM, Petr Vobornik wrote:

Hello list,

this is a first part of RCUE adoption effort. Main themes of this patch
set are:

- use RCUE navigation 
- new styles for textboxes, textareas, radio/checkbox buttons and
buttons- part of 
- new internal form layout (tables replaced by divs)
- layout does not have fixed size

- new dialog styles + removed dependency on jQuery UI dialog
- icons replaced by Font Awesome glyphs

Example is at: 

Some reasonings and additional info:

1. RCUE includes Bootstrap which defines o lot of styles for a lot of
things. That messed up the UI and therefore I did the form changes now.

2. jQuery UI is pretty big lib and we used it only for dialog and
buttons. Buttons were replaced by RCUE buttons so removal of dialog
dependency was a obvious step to get rid of the whole lib. The lib is
removed from main UI but is still present in separate pages - will be
removed later.

3. Dojo and jQuery were upgraded to latest
versions.

This approach was ACKed by Kyle from a design perspective with a note
that we will review and fixed some styling after second phase. We should
not release until then.

The second phase, which I'm working on right now, will consist of:
  * login screen 
  * new styles for standalone pages
  * necessary responsive enhancement (the ultimate future goal is
responsive layout)

It's quite a lot of patches so I did not attach them here. You can see
the code in my private repo:
 branch 'rcue'.


Wow. Do we really need all these third-party fonts and styles in our repo?


It's common in Web development to offer all versions and let the browser 
to choose one.


Since FreeIPA Web UI supports IE9+ we can safely reduce the font files 
only to .woff fonts . We can also discard all 
Italic fonts (not used atm).


Fedora 20 has a new feature called Web Assets 
 which should solve 
such bundles. I'm not convinced that it's in usable state atm.





  install/ui/font/FontAwesome.otf   | Bin 0 -> 62856
bytes
  install/ui/font/Makefile.am   |  45 +++
  install/ui/font/OpenSans-Bold-webfont.eot | Bin 0 -> 21190
bytes
  install/ui/font/OpenSans-Bold-webfont.svg | 146
++
  install/ui/font/OpenSans-Bold-webfont.ttf | Bin 0 -> 21012
bytes
  install/ui/font/OpenSans-Bold-webfont.woff| Bin 0 -> 14036
bytes
  install/ui/font/OpenSans-BoldItalic-webfont.eot   | Bin 0 -> 23510
bytes
  install/ui/font/OpenSans-BoldItalic-webfont.svg   | 146
++
  install/ui/font/OpenSans-BoldItalic-webfont.ttf   | Bin 0 -> 23304
bytes
  install/ui/font/OpenSans-BoldItalic-webfont.woff  | Bin 0 -> 15572
bytes
  install/ui/font/OpenSans-ExtraBold-webfont.eot| Bin 0 -> 21186
bytes
  install/ui/font/OpenSans-ExtraBold-webfont.svg| 146
++
  install/ui/font/OpenSans-ExtraBold-webfont.ttf| Bin 0 -> 20988
bytes
  install/ui/font/OpenSans-ExtraBold-webfont.woff   | Bin 0 -> 14200
bytes
  install/ui/font/OpenSans-ExtraBoldItalic-webfont.eot  | Bin 0 -> 23086
bytes
  install/ui/font/OpenSans-ExtraBoldItalic-webfont.svg  | 146
++
  install/ui/font/OpenSans-ExtraBoldItalic-webfont.ttf  | Bin 0 -> 22860
bytes
  install/ui/font/OpenSans-ExtraBoldItalic-webfont.woff | Bin 0 -> 15468
bytes
  install/ui/font/OpenSans-Italic-webfont.eot   | Bin 0 -> 23866
bytes
  install/ui/font/OpenSans-Italic-webfont.svg   | 146
++
  install/ui/font/OpenSans-Italic-webfont.ttf   | Bin 0 -> 23680
bytes
  install/ui/font/OpenSans-Italic-webfont.woff  | Bin 0 -> 15836
bytes
  install/ui/font/OpenSans-Light-webfont.eot| Bin 0 -> 20886
bytes
  install/ui/font/OpenSans-Light-webfont.svg| 146
++
  install/ui/font/OpenSans-Light-webfont.ttf| Bin 0 -> 20704
bytes
  install/ui/font/OpenSans-Light-webfont.woff   | Bin 0 -> 13972
bytes
  install/ui/font/OpenSans-LightItalic-webfont.eot  | Bin 0 -> 24074
bytes
  install/ui/font/OpenSans-LightItalic-webfont.svg  | 146
++
  install/ui/font/OpenSans-LightItalic-webfont.ttf  | Bin 0 -> 23864
bytes
  install/ui/font/OpenSans-LightItalic-webfont.woff | Bin 0 -> 15944
bytes
  install/ui/font/OpenSans-Regular-webfont.eot  | Bin 0 -> 20878
bytes
  install/ui/font/OpenSans-Regular-webfont.svg  | 146
++
  install/ui/

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

[Petr Viktorin]

On 11/15/2013 02:26 PM, Petr Vobornik wrote:

Hello list,

this is a first part of RCUE adoption effort. Main themes of this patch
set are:

- use RCUE navigation 
- new styles for textboxes, textareas, radio/checkbox buttons and
buttons- part of 
- new internal form layout (tables replaced by divs)
- layout does not have fixed size

- new dialog styles + removed dependency on jQuery UI dialog
- icons replaced by Font Awesome glyphs

Example is at: 

Some reasonings and additional info:

1. RCUE includes Bootstrap which defines o lot of styles for a lot of
things. That messed up the UI and therefore I did the form changes now.

2. jQuery UI is pretty big lib and we used it only for dialog and
buttons. Buttons were replaced by RCUE buttons so removal of dialog
dependency was a obvious step to get rid of the whole lib. The lib is
removed from main UI but is still present in separate pages - will be
removed later.

3. Dojo and jQuery were upgraded to latest
versions.

This approach was ACKed by Kyle from a design perspective with a note
that we will review and fixed some styling after second phase. We should
not release until then.

The second phase, which I'm working on right now, will consist of:
  * login screen 
  * new styles for standalone pages
  * necessary responsive enhancement (the ultimate future goal is
responsive layout)

It's quite a lot of patches so I did not attach them here. You can see
the code in my private repo:
 branch 'rcue'.


Wow. Do we really need all these third-party fonts and styles in our repo?


 install/ui/font/FontAwesome.otf   | Bin 0 -> 62856 
bytes

 install/ui/font/Makefile.am   |  45 +++
 install/ui/font/OpenSans-Bold-webfont.eot | Bin 0 -> 21190 
bytes
 install/ui/font/OpenSans-Bold-webfont.svg | 146 
++
 install/ui/font/OpenSans-Bold-webfont.ttf | Bin 0 -> 21012 
bytes
 install/ui/font/OpenSans-Bold-webfont.woff| Bin 0 -> 14036 
bytes
 install/ui/font/OpenSans-BoldItalic-webfont.eot   | Bin 0 -> 23510 
bytes
 install/ui/font/OpenSans-BoldItalic-webfont.svg   | 146 
++
 install/ui/font/OpenSans-BoldItalic-webfont.ttf   | Bin 0 -> 23304 
bytes
 install/ui/font/OpenSans-BoldItalic-webfont.woff  | Bin 0 -> 15572 
bytes
 install/ui/font/OpenSans-ExtraBold-webfont.eot| Bin 0 -> 21186 
bytes
 install/ui/font/OpenSans-ExtraBold-webfont.svg| 146 
++
 install/ui/font/OpenSans-ExtraBold-webfont.ttf| Bin 0 -> 20988 
bytes
 install/ui/font/OpenSans-ExtraBold-webfont.woff   | Bin 0 -> 14200 
bytes
 install/ui/font/OpenSans-ExtraBoldItalic-webfont.eot  | Bin 0 -> 23086 
bytes
 install/ui/font/OpenSans-ExtraBoldItalic-webfont.svg  | 146 
++
 install/ui/font/OpenSans-ExtraBoldItalic-webfont.ttf  | Bin 0 -> 22860 
bytes
 install/ui/font/OpenSans-ExtraBoldItalic-webfont.woff | Bin 0 -> 15468 
bytes
 install/ui/font/OpenSans-Italic-webfont.eot   | Bin 0 -> 23866 
bytes
 install/ui/font/OpenSans-Italic-webfont.svg   | 146 
++
 install/ui/font/OpenSans-Italic-webfont.ttf   | Bin 0 -> 23680 
bytes
 install/ui/font/OpenSans-Italic-webfont.woff  | Bin 0 -> 15836 
bytes
 install/ui/font/OpenSans-Light-webfont.eot| Bin 0 -> 20886 
bytes
 install/ui/font/OpenSans-Light-webfont.svg| 146 
++
 install/ui/font/OpenSans-Light-webfont.ttf| Bin 0 -> 20704 
bytes
 install/ui/font/OpenSans-Light-webfont.woff   | Bin 0 -> 13972 
bytes
 install/ui/font/OpenSans-LightItalic-webfont.eot  | Bin 0 -> 24074 
bytes
 install/ui/font/OpenSans-LightItalic-webfont.svg  | 146 
++
 install/ui/font/OpenSans-LightItalic-webfont.ttf  | Bin 0 -> 23864 
bytes
 install/ui/font/OpenSans-LightItalic-webfont.woff | Bin 0 -> 15944 
bytes
 install/ui/font/OpenSans-Regular-webfont.eot  | Bin 0 -> 20878 
bytes
 install/ui/font/OpenSans-Regular-webfont.svg  | 146 
++
 install/ui/font/OpenSans-Regular-webfont.ttf  | Bin 0 -> 20688 
bytes
 install/ui/font/OpenSans-Regular-webfont.woff | Bin 0 -> 13988 
bytes
 install/ui/font/OpenSans-Semibold-webfont.eot | Bin 0 -> 21046 
bytes
 install/ui/font/OpenSans-Semibold-webfont.svg | 146 
++
 install/ui/font/OpenSans-Semibold-webfont.ttf | Bin 0 -> 20852 
bytes
 install/ui/font/OpenSans-Semibold-webfont.woff| Bin 0 -> 14052 
bytes
 install/ui/font/Op