Re: [Freeipa-devel] [PATCH] Added error handler for ipa_cmd().

2010-09-29 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Should have remembered this approach, standard JS way to deal with > undefined values. admiyo-freeipa-0048-3-Item-Level-Undo.patch A few notes: 1. You're replying to the wrong thread :) 2. The undo button will only appear when the input field loses focus. Ideally

Re: [Freeipa-devel] [PATCH] Added error handler for ipa_cmd().

2010-09-29 Thread Adam Young
On 09/29/2010 05:05 PM, Adam Young wrote: On 09/29/2010 04:53 PM, Adam Young wrote: On 09/29/2010 03:17 PM, Endi Sukma Dewata wrote: - "Adam Young" wrote: Endi, can you add in a Unit test for this? If need be, extend the ipa_cmd so that it looks for an optional command line param that ma

Re: [Freeipa-devel] [PATCH] Added error handler for ipa_cmd().

2010-09-29 Thread Adam Young
On 09/29/2010 04:53 PM, Adam Young wrote: On 09/29/2010 03:17 PM, Endi Sukma Dewata wrote: - "Adam Young" wrote: Endi, can you add in a Unit test for this? If need be, extend the ipa_cmd so that it looks for an optional command line param that makes it try to fetch a .json file that doesn

Re: [Freeipa-devel] [PATCH] Added error handler for ipa_cmd().

2010-09-29 Thread Adam Young
On 09/29/2010 03:17 PM, Endi Sukma Dewata wrote: - "Adam Young" wrote: Endi, can you add in a Unit test for this? If need be, extend the ipa_cmd so that it looks for an optional command line param that makes it try to fetch a .json file that doesn't exist: Something like var suffix =

Re: [Freeipa-devel] [PATCH] Added error handler for ipa_cmd().

2010-09-29 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Endi, can you add in a Unit test for this? If need be, extend the > ipa_cmd so that it looks for an optional command line param that makes > it try to fetch a .json file that doesn't exist: > > > Something like > var suffix = $.bbq.get("cmd_suffix"); > if (suffix){ >

Re: [Freeipa-devel] [PATCH] Added error handler for ipa_cmd().

2010-09-28 Thread Adam Young
On 09/28/2010 07:20 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. It can be tested by moving one of the JSON files in test/data somewhere else. Thanks! The ipa_cmd() has been modified such that when an error occurs a dialog box will appear showing the error message with 2 b