Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0015 hashchange

2010-08-26 Thread Adam Young

On 08/26/2010 01:13 PM, Rob Crittenden wrote:

Adam Young wrote:

On 08/25/2010 11:21 PM, Adam Young wrote:

On 08/25/2010 10:33 PM, Adam Young wrote:

On 08/25/2010 05:52 PM, Rob Crittenden wrote:

Adam Young wrote:

On 08/25/2010 10:41 AM, Adam Young wrote:

On 08/25/2010 07:39 AM, Pavel Zůna wrote:

On 2010-08-24 23:57, Adam Young wrote:
This is a fairly substantial patch that makes use of the 
hashchange

event to drive the site. It affcets just about all places where
click
events are triggered.



Just started reviewing the patch a few moments ago. Just 2 
notes in

advance:

1) It doesn't apply after the 

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0015 hashchange

2010-08-26 Thread Rob Crittenden

Adam Young wrote:

On 08/25/2010 11:21 PM, Adam Young wrote:

On 08/25/2010 10:33 PM, Adam Young wrote:

On 08/25/2010 05:52 PM, Rob Crittenden wrote:

Adam Young wrote:

On 08/25/2010 10:41 AM, Adam Young wrote:

On 08/25/2010 07:39 AM, Pavel Zůna wrote:

On 2010-08-24 23:57, Adam Young wrote:

This is a fairly substantial patch that makes use of the hashchange
event to drive the site. It affcets just about all places where
click
events are triggered.



Just started reviewing the patch a few moments ago. Just 2 notes in
advance:

1) It doesn't apply after the 

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0015 hashchange

2010-08-25 Thread Adam Young

On 08/25/2010 10:33 PM, Adam Young wrote:

On 08/25/2010 05:52 PM, Rob Crittenden wrote:

Adam Young wrote:

On 08/25/2010 10:41 AM, Adam Young wrote:

On 08/25/2010 07:39 AM, Pavel Zůna wrote:

On 2010-08-24 23:57, Adam Young wrote:

This is a fairly substantial patch that makes use of the hashchange
event to drive the site. It affcets just about all places where 
click

events are triggered.



Just started reviewing the patch a few moments ago. Just 2 notes in
advance:

1) It doesn't apply after the 

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0015 hashchange

2010-08-25 Thread Rob Crittenden

Adam Young wrote:

On 08/25/2010 10:41 AM, Adam Young wrote:

On 08/25/2010 07:39 AM, Pavel Zůna wrote:

On 2010-08-24 23:57, Adam Young wrote:

This is a fairly substantial patch that makes use of the hashchange
event to drive the site. It affcets just about all places where click
events are triggered.



Just started reviewing the patch a few moments ago. Just 2 notes in
advance:

1) It doesn't apply after the 

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0015 hashchange

2010-08-25 Thread Adam Young

On 08/25/2010 07:39 AM, Pavel Zůna wrote:

On 2010-08-24 23:57, Adam Young wrote:

This is a fairly substantial patch that makes use of the hashchange
event to drive the site. It affcets just about all places where click
events are triggered.



Just started reviewing the patch a few moments ago. Just 2 notes in 
advance:


1) It doesn't apply after the 

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0015 hashchange

2010-08-25 Thread Pavel Zůna

On 2010-08-24 23:57, Adam Young wrote:

This is a fairly substantial patch that makes use of the hashchange
event to drive the site. It affcets just about all places where click
events are triggered.



Just started reviewing the patch a few moments ago. Just 2 notes in advance:

1) It doesn't apply after the