Re: [Freeipa-devel] [PATCH] split password extop plugin in multiple files
Simo Sorce wrote: On Wed, 29 Sep 2010 18:00:15 -0400 Simo Sorcesso...@redhat.com wrote: I was looking into a few bugs to fix in the plugin and realized it was so big an messy that it would greatly help readbility if we splitted it up. This is a first pass (compiles, but not tested). Only one function needed some minor refactoring (ipapwd_SetPassword). Tomorrow I should be able to test it, meanwhile I'd like a generic ack/nack on the approach. Ok updated patch, this one has been tested and seem to work properly. Simo. ack rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] split password extop plugin in multiple files
On Fri, 1 Oct 2010 10:40:34 -0400 Simo Sorce sso...@redhat.com wrote: On Wed, 29 Sep 2010 18:00:15 -0400 Simo Sorce sso...@redhat.com wrote: I was looking into a few bugs to fix in the plugin and realized it was so big an messy that it would greatly help readbility if we splitted it up. This is a first pass (compiles, but not tested). Only one function needed some minor refactoring (ipapwd_SetPassword). Tomorrow I should be able to test it, meanwhile I'd like a generic ack/nack on the approach. Ok updated patch, this one has been tested and seem to work properly. Simo. Rob Acked on IRC. Pushed to master. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
