Re: [Freeipa-devel] [PATCH 0046] Remove unneeded --ip-address option in ipa-adtrust-install

2015-05-05 Thread Petr Vobornik

On 04/28/2015 06:56 PM, Martin Basti wrote:

On 28/04/15 15:36, Gabe Alford wrote:

On Tue, Apr 28, 2015 at 7:18 AM, Martin Basti mba...@redhat.com
mailto:mba...@redhat.com wrote:

On 27/04/15 15:02, Gabe Alford wrote:

Hello,

Fix for https://fedorahosted.org/freeipa/ticket/4575





Thank you, ACK!


Pushed to master: 26c1851e98f31f11cf52b36bcb7e399ccbb2af17



This check is not needed anymore, it will not work with dualstack, and
adtrustisntance is installed on IPA server which must have resolvable IP
address.


--
Petr Vobornik

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0046] Remove unneeded --ip-address option in ipa-adtrust-install

2015-04-28 Thread Martin Basti

On 28/04/15 15:36, Gabe Alford wrote:
On Tue, Apr 28, 2015 at 7:18 AM, Martin Basti mba...@redhat.com 
mailto:mba...@redhat.com wrote:


On 27/04/15 15:02, Gabe Alford wrote:

Hello,

Fix for https://fedorahosted.org/freeipa/ticket/4575

Thanks,

Gabe



Hello,

thank you for your patch, looks good.

However, IMO you can remove hostaddr variable as well, it was used
for validate IP address.
I could not find it used anywhere, did you?


Removed. It still seemed like it could be a logical check to have to 
me which is why I kept it in the first place.

Updated patch attached.

Martin^2

-- 
Martin Basti





Thank you, ACK!

This check is not needed anymore, it will not work with dualstack, and 
adtrustisntance is installed on IPA server which must have resolvable IP 
address.


--
Martin Basti

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code