Re: [Freeipa-devel] [PATCH 0082] Forward zones: add warning about forwarders semantic change in dnszone-add/mod

2014-07-03 Thread Petr Viktorin
On 07/03/2014 10:29 AM, Petr Spacek wrote: On 1.7.2014 17:23, Martin Basti wrote: On Tue, 2014-07-01 at 12:17 +0200, Petr Viktorin wrote: On 07/01/2014 12:10 PM, Martin Basti wrote: On Mon, 2014-06-30 at 13:57 +0200, Petr Viktorin wrote: On 06/30/2014 12:48 PM, Martin Basti wrote: Ticket: ht

Re: [Freeipa-devel] [PATCH 0082] Forward zones: add warning about forwarders semantic change in dnszone-add/mod

2014-07-03 Thread Petr Spacek
On 1.7.2014 17:23, Martin Basti wrote: On Tue, 2014-07-01 at 12:17 +0200, Petr Viktorin wrote: On 07/01/2014 12:10 PM, Martin Basti wrote: On Mon, 2014-06-30 at 13:57 +0200, Petr Viktorin wrote: On 06/30/2014 12:48 PM, Martin Basti wrote: Ticket: https://fedorahosted.org/freeipa/ticket/3210#c

Re: [Freeipa-devel] [PATCH 0082] Forward zones: add warning about forwarders semantic change in dnszone-add/mod

2014-07-01 Thread Martin Basti
On Tue, 2014-07-01 at 12:17 +0200, Petr Viktorin wrote: > On 07/01/2014 12:10 PM, Martin Basti wrote: > > On Mon, 2014-06-30 at 13:57 +0200, Petr Viktorin wrote: > >> On 06/30/2014 12:48 PM, Martin Basti wrote: > >>> Ticket: https://fedorahosted.org/freeipa/ticket/3210#comment:16 > >>> Patch attach

Re: [Freeipa-devel] [PATCH 0082] Forward zones: add warning about forwarders semantic change in dnszone-add/mod

2014-07-01 Thread Petr Viktorin
On 07/01/2014 12:10 PM, Martin Basti wrote: On Mon, 2014-06-30 at 13:57 +0200, Petr Viktorin wrote: On 06/30/2014 12:48 PM, Martin Basti wrote: Ticket: https://fedorahosted.org/freeipa/ticket/3210#comment:16 Patch attached. When you add a new message, you should also define a new class for i

Re: [Freeipa-devel] [PATCH 0082] Forward zones: add warning about forwarders semantic change in dnszone-add/mod

2014-07-01 Thread Martin Basti
On Mon, 2014-06-30 at 13:57 +0200, Petr Viktorin wrote: > On 06/30/2014 12:48 PM, Martin Basti wrote: > > Ticket: https://fedorahosted.org/freeipa/ticket/3210#comment:16 > > Patch attached. > > > > When you add a new message, you should also define a new class for it in > messages.py with a new e

Re: [Freeipa-devel] [PATCH 0082] Forward zones: add warning about forwarders semantic change in dnszone-add/mod

2014-06-30 Thread Petr Spacek
On 30.6.2014 13:57, Petr Viktorin wrote: On 06/30/2014 12:48 PM, Martin Basti wrote: Ticket: https://fedorahosted.org/freeipa/ticket/3210#comment:16 Patch attached. When you add a new message, you should also define a new class for it in messages.py with a new errno, not just reuse PublicMess

Re: [Freeipa-devel] [PATCH 0082] Forward zones: add warning about forwarders semantic change in dnszone-add/mod

2014-06-30 Thread Petr Viktorin
On 06/30/2014 12:48 PM, Martin Basti wrote: Ticket: https://fedorahosted.org/freeipa/ticket/3210#comment:16 Patch attached. When you add a new message, you should also define a new class for it in messages.py with a new errno, not just reuse PublicMessage with a custom string. -- Petr³ _