Re: [Freeipa-devel] [PATCH 46/46] ticket 1669 - improve i18n docstring extraction

2011-08-25 Thread Rob Crittenden
Alexander Bokovoy wrote: On 25.08.2011 06:46, John Dennis wrote: class foo(Command): ''' The foo command takes out the garbage. ''' Would become: class foo(Command): __doc__ = _('The foo command takes out the garbage.') But which docstrings need to be marked for translatio

Re: [Freeipa-devel] [PATCH 46/46] ticket 1669 - improve i18n docstring extraction

2011-08-25 Thread Alexander Bokovoy
On 25.08.2011 18:02, John Dennis wrote: > On 08/25/2011 10:36 AM, Alexander Bokovoy wrote: >> This would have been enough if only gettext supported fallback between >> language translations on the same domain. I.e. if Russian translation is >> not available, try English one and if not, return trans

Re: [Freeipa-devel] [PATCH 46/46] ticket 1669 - improve i18n docstring extraction

2011-08-25 Thread John Dennis
On 08/25/2011 10:36 AM, Alexander Bokovoy wrote: This would have been enough if only gettext supported fallback between language translations on the same domain. I.e. if Russian translation is not available, try English one and if not, return translation Id. There is discussion about similar case

Re: [Freeipa-devel] [PATCH 46/46] ticket 1669 - improve i18n docstring extraction

2011-08-25 Thread Alexander Bokovoy
On 25.08.2011 16:53, John Dennis wrote: > On 08/25/2011 07:50 AM, Alexander Bokovoy wrote: >> Read through whole patch. This is one of rare cases where gettext's use >> of original text as translation id isn't helpful from both performance >> (longer calculation of Id hash during run-time) and main

Re: [Freeipa-devel] [PATCH 46/46] ticket 1669 - improve i18n docstring extraction

2011-08-25 Thread John Dennis
On 08/25/2011 07:50 AM, Alexander Bokovoy wrote: Read through whole patch. This is one of rare cases where gettext's use of original text as translation id isn't helpful from both performance (longer calculation of Id hash during run-time) and maintenance. Looks like we have to live with that if

Re: [Freeipa-devel] [PATCH 46/46] ticket 1669 - improve i18n docstring extraction

2011-08-25 Thread Alexander Bokovoy
On 25.08.2011 06:46, John Dennis wrote: > class foo(Command): > ''' > The foo command takes out the garbage. > ''' > > Would become: > > class foo(Command): > __doc__ = _('The foo command takes out the garbage.') > > But which docstrings need to be marked for translation? The mak