Re: [Freeipa-devel] [PATCHES] 137-144 LDAP code refactoring (Part 3)

2013-02-25 Thread Jan Cholasta
On 19.2.2013 16:56, Petr Viktorin wrote: On 02/19/2013 02:17 PM, Jan Cholasta wrote: On 29.1.2013 10:21, Jan Cholasta wrote: A patch from this patchset (part 3) causes some of the dns plugin tests to fail (idnsallowdynupdate is missing in dnszone_add output). Honza Patch 143: +

Re: [Freeipa-devel] [PATCHES] 137-144 LDAP code refactoring (Part 3)

2013-02-19 Thread Petr Viktorin
On 02/19/2013 02:17 PM, Jan Cholasta wrote: On 29.1.2013 10:21, Jan Cholasta wrote: A patch from this patchset (part 3) causes some of the dns plugin tests to fail (idnsallowdynupdate is missing in dnszone_add output). Honza Patch 143: +assert isinstance(entry_or_dn, DN) +

Re: [Freeipa-devel] [PATCHES] 137-144 LDAP code refactoring (Part 3)

2013-02-19 Thread Jan Cholasta
On 29.1.2013 10:21, Jan Cholasta wrote: A patch from this patchset (part 3) causes some of the dns plugin tests to fail (idnsallowdynupdate is missing in dnszone_add output). Honza Patch 143: +assert isinstance(entry_or_dn, DN) +if normalize is None or normalize: +

Re: [Freeipa-devel] [PATCHES] 137-144 LDAP code refactoring (Part 3)

2013-01-29 Thread Jan Cholasta
On 28.1.2013 09:34, Jan Cholasta wrote: On 25.1.2013 14:54, Petr Viktorin wrote: On 01/24/2013 03:06 PM, Petr Viktorin wrote: On 01/24/2013 10:43 AM, Petr Viktorin wrote: On 01/22/2013 04:04 PM, Petr Viktorin wrote: On 01/21/2013 06:38 PM, Petr Viktorin wrote: On 01/17/2013 06:27 PM, Petr Vi

Re: [Freeipa-devel] [PATCHES] 137-144 LDAP code refactoring (Part 3)

2013-01-28 Thread Jan Cholasta
On 25.1.2013 14:54, Petr Viktorin wrote: On 01/24/2013 03:06 PM, Petr Viktorin wrote: On 01/24/2013 10:43 AM, Petr Viktorin wrote: On 01/22/2013 04:04 PM, Petr Viktorin wrote: On 01/21/2013 06:38 PM, Petr Viktorin wrote: On 01/17/2013 06:27 PM, Petr Viktorin wrote: Hello, This is the first b

Re: [Freeipa-devel] [PATCHES] 137-144 LDAP code refactoring (Part 3)

2013-01-25 Thread Petr Viktorin
On 01/24/2013 03:06 PM, Petr Viktorin wrote: On 01/24/2013 10:43 AM, Petr Viktorin wrote: On 01/22/2013 04:04 PM, Petr Viktorin wrote: On 01/21/2013 06:38 PM, Petr Viktorin wrote: On 01/17/2013 06:27 PM, Petr Viktorin wrote: Hello, This is the first batch of changes aimed to consolidate our L