Re: [Freeipa-devel] [PATCHES] 206-209 Add default CFLAGS & fix hardened build

2013-12-06 Thread Petr Spacek
On 6.12.2013 11:52, Jan Cholasta wrote: freeipa-jcholast-208.1-Add-stricter-default-CFLAGS-to-Makefile.patch From 85ad15d522274a711c87f92ed91889b781d7455e Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Wed, 4 Dec 2013 18:42:36 +0100 Subject: [PATCH 3/5] Add stricter default CFLAGS to Makef

Re: [Freeipa-devel] [PATCHES] 206-209 Add default CFLAGS & fix hardened build

2013-12-06 Thread Petr Viktorin
On 12/06/2013 02:26 PM, Alexander Bokovoy wrote: On Fri, 06 Dec 2013, Jan Cholasta wrote: However, even if writing to the pipe failed, we still need to wait until thread dies with pthread_join(). I think returning -1 here is premature. Fixed, updated patches attached. Also removed CFLAGS dupl

Re: [Freeipa-devel] [PATCHES] 206-209 Add default CFLAGS & fix hardened build

2013-12-06 Thread Alexander Bokovoy
On Fri, 06 Dec 2013, Jan Cholasta wrote: However, even if writing to the pipe failed, we still need to wait until thread dies with pthread_join(). I think returning -1 here is premature. Fixed, updated patches attached. Also removed CFLAGS duplication, see patch 212. Thanks you! The build wo

Re: [Freeipa-devel] [PATCHES] 206-209 Add default CFLAGS & fix hardened build

2013-12-06 Thread Jan Cholasta
On 6.12.2013 13:31, Jan Cholasta wrote: On 6.12.2013 12:57, Alexander Bokovoy wrote: On Fri, 06 Dec 2013, Petr Viktorin wrote: On 12/06/2013 11:52 AM, Jan Cholasta wrote: On 5.12.2013 13:31, Alexander Bokovoy wrote: On Thu, 05 Dec 2013, Petr Viktorin wrote: On 12/05/2013 11:15 AM, Jan Cholas

Re: [Freeipa-devel] [PATCHES] 206-209 Add default CFLAGS & fix hardened build

2013-12-06 Thread Jan Cholasta
On 6.12.2013 12:57, Alexander Bokovoy wrote: On Fri, 06 Dec 2013, Petr Viktorin wrote: On 12/06/2013 11:52 AM, Jan Cholasta wrote: On 5.12.2013 13:31, Alexander Bokovoy wrote: On Thu, 05 Dec 2013, Petr Viktorin wrote: On 12/05/2013 11:15 AM, Jan Cholasta wrote: Hi, the attached patches fix

Re: [Freeipa-devel] [PATCHES] 206-209 Add default CFLAGS & fix hardened build

2013-12-06 Thread Alexander Bokovoy
On Fri, 06 Dec 2013, Petr Viktorin wrote: On 12/06/2013 11:52 AM, Jan Cholasta wrote: On 5.12.2013 13:31, Alexander Bokovoy wrote: On Thu, 05 Dec 2013, Petr Viktorin wrote: On 12/05/2013 11:15 AM, Jan Cholasta wrote: Hi, the attached patches fix

Re: [Freeipa-devel] [PATCHES] 206-209 Add default CFLAGS & fix hardened build

2013-12-06 Thread Petr Viktorin
On 12/06/2013 11:52 AM, Jan Cholasta wrote: On 5.12.2013 13:31, Alexander Bokovoy wrote: On Thu, 05 Dec 2013, Petr Viktorin wrote: On 12/05/2013 11:15 AM, Jan Cholasta wrote: Hi, the attached patches fix . Patch 207 should fix build failures some

Re: [Freeipa-devel] [PATCHES] 206-209 Add default CFLAGS & fix hardened build

2013-12-06 Thread Jan Cholasta
On 5.12.2013 13:31, Alexander Bokovoy wrote: On Thu, 05 Dec 2013, Petr Viktorin wrote: On 12/05/2013 11:15 AM, Jan Cholasta wrote: Hi, the attached patches fix . Patch 207 should fix build failures some of you were having after hardenening was ena

Re: [Freeipa-devel] [PATCHES] 206-209 Add default CFLAGS & fix hardened build

2013-12-05 Thread Alexander Bokovoy
On Thu, 05 Dec 2013, Petr Viktorin wrote: On 12/05/2013 11:15 AM, Jan Cholasta wrote: Hi, the attached patches fix . Patch 207 should fix build failures some of you were having after hardenening was enabled in the spec file. Thanks! In 209, woul

Re: [Freeipa-devel] [PATCHES] 206-209 Add default CFLAGS & fix hardened build

2013-12-05 Thread Petr Viktorin
On 12/05/2013 11:15 AM, Jan Cholasta wrote: Hi, the attached patches fix . Patch 207 should fix build failures some of you were having after hardenening was enabled in the spec file. Thanks! In 209, would (ret != 1) make more sense than (ret == -