[Freeipmi-devel] docs/ directory

2007-04-27 Thread Albert Chu
Would anyone object if we got rid of a lot of this? 1) freeipmi.texi, version-doc.texi, authors.texi, gpl.texi, fdl.texi Most of this doc is just cut and pasted from the manpages and other .txt files, it's already grown out of date, and nobody bothers to keep up with it. 2) freeipmi-hackers-intr

Re: [Freeipmi-devel] Patch for hex k_g keys in ipmipower, take 2

2007-04-27 Thread Albert Chu
Hey Levi, Oh, and I think I fixed that 20 byte k_g corner case you mentioned earlier. It's in the stable 0.3.X branch. Al > Hey Levi, > > Looks good. I fixed the one or two remaining nit picks I found. It's now > in the 0.3.X stable line and CVS head. > > Were you going to work on the ipmicon

Re: [Freeipmi-devel] Patch for hex k_g keys in ipmipower, take 2

2007-04-27 Thread Albert Chu
Hey Levi, Looks good. I fixed the one or two remaining nit picks I found. It's now in the 0.3.X stable line and CVS head. Were you going to work on the ipmiconsole and bmc-config equivalent support too? Thanks, Al > On Thu, 2007-04-26 at 22:47 -0700, Albert Chu wrote: >> Hey Levi, >> >> Looks

Re: [Freeipmi-devel] Patch for hex k_g keys in ipmipower, take 2

2007-04-27 Thread Levi Pearson
On Thu, 2007-04-26 at 22:47 -0700, Albert Chu wrote: > Hey Levi, > > Looks pretty good. Some minor nit-picks. Fixed those, and I prevented printing out a key starting with a literal '0x' in ascii. --Levi Index: common/src/ipmi-common.c ===

Re: [Freeipmi-devel] Patch for hex k_g keys in ipmipower, take 2

2007-04-27 Thread Albert Chu
> Levi Pearson wrote: > >> This version should address the issues from the review of the previous >> patch. I've tested this one a bit more and it seems pretty solid to me. > > This is probably a very uncommon use case: Since the "0x" prefix is used > for specifying keys in hex format you cannot

Re: [Freeipmi-devel] Patch for hex k_g keys in ipmipower, take 2

2007-04-27 Thread Ingo van Lil
Levi Pearson wrote: This version should address the issues from the review of the previous patch. I've tested this one a bit more and it seems pretty solid to me. This is probably a very uncommon use case: Since the "0x" prefix is used for specifying keys in hex format you cannot encode keys