Re: [Freeipmi-devel] Patch for hex k_g keys in ipmiconsole and bmc-config + bugfix

2007-05-04 Thread Albert Chu
I added a k_g_len component to workaround the issue. The patch is in the head and 0.3.X branch now. I also found a ipmiconsole state machine bug along the way too. Thanks, Al > Hey Levi, > > I've commited the bmc-config strdup fix and bmc-config 0x support into the > CVS head and 0.3.X branch.

Re: [Freeipmi-devel] Patch for hex k_g keys in ipmiconsole and bmc-config + bugfix

2007-05-03 Thread Albert Chu
Hey Levi, I've commited the bmc-config strdup fix and bmc-config 0x support into the CVS head and 0.3.X branch. The ipmiconsole part is fine, except for the part that you assume the k_g input into libipmiconsole is 20 bytes. I can understand that you didn't want to change the API format, but I t

Re: [Freeipmi-devel] Patch for hex k_g keys in ipmiconsole and bmc-config + bugfix

2007-05-03 Thread Al Chu
Hi Levi, Thanks. I hope I can look at the patch later today or possibly tomorrow. > I also noticed that several of the bmc-config sections return non- > fatal error codes; I'm assuming that this means there were > configuration items within that didn't exist on the BMC. Is this > correct? Yu

[Freeipmi-devel] Patch for hex k_g keys in ipmiconsole and bmc-config + bugfix

2007-05-03 Thread Levi Pearson
This patch includes the changes to both ipmiconsole and bmc-config, including a bugfix in bmc-config to fix a memory bug due to a missing strdup. I also noticed that several of the bmc-config sections return non-fatal error codes; I'm assuming that this means there were configuration items within