[Freeipmi-devel] Re: now ipmi-sel is in C
Hi Al, I have already reverted ipmi_lan_sendto(), ipmi_lan_recvfrom() and ipckey changes back. Thanks, Bala --- Free as in freedom http://www.gnu.org/ Hey Bala, The issue is that this was a maintenance branch, so that code should have never been cleaned up, if there were actually no bugs. I still think we should still revert the code, so that the differences between the different releases are still kept to a minimum. Al On Fri, 2006-07-07 at 18:39 -0700, Bala.A wrote: Hi Al, packet retransmission code is only in UDM. I did code cleanup in ipmi_lan_sendto() and forgot to initialize packet_size variable. Because of that, ipmi_lan_sendto() was failing. Thanks, Bala --- Free as in freedom http://www.gnu.org/ On Fri, 2006-07-07 at 15:20 -0700, Anand Babu wrote: This bug was introduced because of re-transmission feature. I thought, that feature was required, so we fix the bug. These functions were nearly entirely re-written. I have no idea why. All retransmission code should only be in the UDM code. None of it should be in ipmi_lan_sendto(). The ipmi_lan_sendto() in 0.3.0 is still the same as the code in 0.2.0. Al -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
[Freeipmi-devel] Re: now ipmi-sel is in C
Could you tell describe about this bug? Bala --- Free as in freedom http://www.gnu.org/ now freeipmi main branch has C version of ipmi-sel. I have removed scheme version of ipmi-sel. Just remembered, how will we be dealing with bug #16278? http://savannah.gnu.org/bugs/?func=detailitemitem_id=16278 Al -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
[Freeipmi-devel] Re: now ipmi-sel is in C
On threshold based events (ipmi 2.0 spec, Table 29-6, row #1 event data), ipmi-sel outputs something generic like: 1:31-Dec-1969 16:00:24:Voltage #88:Lower Critical - going low:Trigger reading = 1Eh:Trigger reading = 49h It should output the actual sensor values: 1:31-Dec-1969 16:00:24:Voltage #88:Lower Critical - going low: Reading = 18.2V:Threshold = 18.0V or whatever. The problem is ipmi-sel does not bother with an SDR, so converting the readings to values can't be done yet. It should probably read/access/create SDRs just like ipmi-sensors does. Al On Tue, 2006-07-11 at 02:58 -0700, Bala.A wrote: Could you tell describe about this bug? Bala --- Free as in freedom http://www.gnu.org/ now freeipmi main branch has C version of ipmi-sel. I have removed scheme version of ipmi-sel. Just remembered, how will we be dealing with bug #16278? http://savannah.gnu.org/bugs/?func=detailitemitem_id=16278 Al -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
[Freeipmi-devel] Re: now ipmi-sel is in C
Hey Bala, The issue is that this was a maintenance branch, so that code should have never been cleaned up, if there were actually no bugs. I still think we should still revert the code, so that the differences between the different releases are still kept to a minimum. Al On Fri, 2006-07-07 at 18:39 -0700, Bala.A wrote: Hi Al, packet retransmission code is only in UDM. I did code cleanup in ipmi_lan_sendto() and forgot to initialize packet_size variable. Because of that, ipmi_lan_sendto() was failing. Thanks, Bala --- Free as in freedom http://www.gnu.org/ On Fri, 2006-07-07 at 15:20 -0700, Anand Babu wrote: This bug was introduced because of re-transmission feature. I thought, that feature was required, so we fix the bug. These functions were nearly entirely re-written. I have no idea why. All retransmission code should only be in the UDM code. None of it should be in ipmi_lan_sendto(). The ipmi_lan_sendto() in 0.3.0 is still the same as the code in 0.2.0. Al -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
[Freeipmi-devel] Re: now ipmi-sel is in C
now freeipmi main branch has C version of ipmi-sel. I have removed scheme version of ipmi-sel. Just remembered, how will we be dealing with bug #16278? http://savannah.gnu.org/bugs/?func=detailitemitem_id=16278 Al -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
[Freeipmi-devel] Re: now ipmi-sel is in C
Also I have fixed a bug in ipmi_lan_sendto() in Release-0_2_0_branch. I believe A.B. said we were just going to revert those changes and go back to the codebase at 0.2.1? Al -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
[Freeipmi-devel] Re: now ipmi-sel is in C
On Fri, 2006-07-07 at 15:20 -0700, Anand Babu wrote: This bug was introduced because of re-transmission feature. I thought, that feature was required, so we fix the bug. These functions were nearly entirely re-written. I have no idea why. All retransmission code should only be in the UDM code. None of it should be in ipmi_lan_sendto(). The ipmi_lan_sendto() in 0.3.0 is still the same as the code in 0.2.0. Al -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
[Freeipmi-devel] Re: now ipmi-sel is in C
Hi Al, packet retransmission code is only in UDM. I did code cleanup in ipmi_lan_sendto() and forgot to initialize packet_size variable. Because of that, ipmi_lan_sendto() was failing. Thanks, Bala --- Free as in freedom http://www.gnu.org/ On Fri, 2006-07-07 at 15:20 -0700, Anand Babu wrote: This bug was introduced because of re-transmission feature. I thought, that feature was required, so we fix the bug. These functions were nearly entirely re-written. I have no idea why. All retransmission code should only be in the UDM code. None of it should be in ipmi_lan_sendto(). The ipmi_lan_sendto() in 0.3.0 is still the same as the code in 0.2.0. Al -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
