Re: Support for RFC4372 (Chargeable User Identity)

2008-01-21 Thread Maja Wolniewicz
Alan DeKok pisze: Maja Wolniewicz wrote: According to RFC4372 CUI attribute in request can include a single NUL character, then your test if (%{Chargeable-User-Identifier}) { update reply { Chargeable-User-Identifier = } } evaluates to false. I've fixed this in CVS

Re: Support for RFC4372 (Chargeable User Identity)

2008-01-21 Thread Alan DeKok
Maja Wolniewicz wrote: I'm now running freeradius from CVS FreeRADIUS Version 2.0.1-pre in post-auth I have: if (%{FreeRADIUS-Proxied-To} == 127.0.0.1) { if (%{Chargeable-User-Identity}) { Please fix this. Putting double quotes around *everything* was never necessary, and is much less

Re: Support for RFC4372 (Chargeable User Identity)

2008-01-21 Thread Maja Wolniewicz
Alan DeKok pisze: Maja Wolniewicz wrote: I'm now running freeradius from CVS FreeRADIUS Version 2.0.1-pre in post-auth I have: if (%{FreeRADIUS-Proxied-To} == 127.0.0.1) { if (%{Chargeable-User-Identity}) { Please fix this. Putting double quotes around *everything* was never necessary,

Re: Support for RFC4372 (Chargeable User Identity)

2008-01-21 Thread Alan DeKok
Maja Wolniewicz wrote: Thanks. Now it works. That's good to hear. Yes, I want to add current realm to reply attribute Chargeable-User-Identity which comes form LDAP. When Chargeable-User-Identity attribute isn't present in request I want to remove Chargeable-User-Identity from reply.

Re: Support for RFC4372 (Chargeable User Identity)

2008-01-21 Thread Maja Wolniewicz
Alan DeKok pisze: Maja Wolniewicz wrote: Thanks. Now it works. That's good to hear. Yes, I want to add current realm to reply attribute Chargeable-User-Identity which comes form LDAP. When Chargeable-User-Identity attribute isn't present in request I want to remove

Re: Support for RFC4372 (Chargeable User Identity)

2008-01-15 Thread Alan DeKok
Maja Wolniewicz wrote: According to RFC4372 CUI attribute in request can include a single NUL character, then your test if (%{Chargeable-User-Identifier}) { update reply { Chargeable-User-Identifier = } } evaluates to false. I've fixed this in CVS head

Re: Support for RFC4372 (Chargeable User Identity)

2008-01-07 Thread Alan DeKok
Stefan Winter wrote: is that implemented in FR, be it 1.1 or 2.0? According to http://wiki.freeradius.org/RFC it shouldn't be. It's in the dictionaries... From my reading of the RFC, defining it by hand in radreply is not considered good enough, because it has a specific logic behind