Re: rlm_sql.c in 2.0.0-pre2

2007-07-07 Thread Phil Mayers
Unfortunately whoever modified rlm_sql in cvs head chose a very inefficient querying system. So change it - stored procedures maybe? First you query to pull out group membership, second you query to get each groups check items, then to get each groups reply items ... It just doesn't

Re: rlm_sql.c in 2.0.0-pre2

2007-07-07 Thread Arran Cudbard-Bell
Phil Mayers wrote: Unfortunately whoever modified rlm_sql in cvs head chose a very inefficient querying system. So change it - stored procedures maybe? Stored procedures ... but then you lose the only advantage of using the SQL modules in authorisation, which is that it can

Re: rlm_sql.c in 2.0.0-pre2

2007-07-07 Thread Phil Mayers
You can pull out all rows relating to the groups a user is a member of, and process them on the RADIUS server using the group name as a key. This could be done in one query if you were feeling adventurous, or probably more easily with two. That's a very reasonable suggestion, and would

Re: rlm_sql.c in 2.0.0-pre2

2007-06-20 Thread Alan DeKok
Alexander Serkin wrote: Hi, Is the read_groups configuration paramter reading strings intentionally removed from rlm_sql.c? Why? I don't think it was ever added. I'm not sure the functionality is even tested. i.e. Does it work? Alan DeKok. - List info/subscribe/unsubscribe? See

Re: rlm_sql.c in 2.0.0-pre2

2007-06-20 Thread Arran Cudbard-Bell
Alan DeKok wrote: Alexander Serkin wrote: Hi, Is the read_groups configuration paramter reading strings intentionally removed from rlm_sql.c? Why? I don't think it was ever added. I'm not sure the functionality is even tested. i.e. Does it work? Alan DeKok. - List

Re: rlm_sql.c in 2.0.0-pre2

2007-06-20 Thread Alexander Serkin
Arran Cudbard-Bell wrote: Alan DeKok wrote: I don't think it was ever added. I'm not sure the functionality is even tested. i.e. Does it work? Alan DeKok. Read Groups in SQL ? Yes, very very well tested. It's horribly broken in 1.*.* though, or at least it was for me.

rlm_sql.c in 2.0.0-pre2

2007-06-18 Thread Alexander Serkin
Hi, Is the read_groups configuration paramter reading strings intentionally removed from rlm_sql.c? Why? Let me suggest a patch: *** rlm_sql.c.orig 2007-05-15 14:10:35.0 +0400 --- rlm_sql.c 2007-06-18 19:46:59.0 +0400 *** *** 57,62 --- 57,64