Re: [Freerdp-devel] Question on BER code

2011-07-26 Thread Marc-André Moreau
On Tue, Jul 26, 2011 at 7:02 AM, Roman Barabanov wrote: > > Good day, Brad. > > I think you should add brackets after *byte !=* > It's helps compiler to understand properly operator priority. > > IMHO, more brackets - less pain with priorities, because brackets helps to > set explicit priority. >

Re: [Freerdp-devel] Question on BER code

2011-07-26 Thread Roman Barabanov
Good day, Martin. Sorry, I did not see your message. Agree with your solution. Best regards, Roman Barabanov On Tue, Jul 26, 2011 at 13:43, Martin Fleisz wrote: > On 26.07.2011 12:35, Brad Hards wrote: > > I'm trying to fix up a stack of warnings given by gcc. Mostly its pretty > > obvious. S

Re: [Freerdp-devel] Question on BER code

2011-07-26 Thread Roman Barabanov
Good day, Brad. I think you should add brackets after *byte !=* It's helps compiler to understand properly operator priority. IMHO, more brackets - less pain with priorities, because brackets helps to set explicit priority. Best regards, Roman Barabanov On Tue, Jul 26, 2011 at 13:35, Brad Har

Re: [Freerdp-devel] Question on BER code

2011-07-26 Thread Martin Fleisz
On 26.07.2011 12:35, Brad Hards wrote: > I'm trying to fix up a stack of warnings given by gcc. Mostly its pretty > obvious. Sometimes, I'm scratching my head. > > What is this supposed to do? Should the second | be a ||? > > boolean ber_read_universal_tag(STREAM* s, uint8 tag, boolean pc) > { >