>> However, I've already invested a lot of time in writing ChangeLog
>> entries...
>
> Would you consider dropping the ChangeLog entries.
Basically, I don't object to that. However, experience has shown that
people tend to write very sloppy git commit messages in general. The
ChangeLog format
Would you consider dropping the ChangeLog entries. It is far simpler
to rely on the git history for this, and just enforcing that commiter
provide meaningful commit message should be enough?
Yes please. Alternatively, there are tools like
https://pypi.org/project/towncrier/.
> Would you
Le lun. 6 juil. 2020 à 11:58, Werner LEMBERG a écrit :
>
> > Werner, please don't commit something if you think there are still
> > problems in it, that's what code reviews are,
>
> Normally, I do that. However, I've already invested a lot of time in
> writing ChangeLog entries...
>
> Would you
>> What do you mean with 'toggle'?
>
> In one of the previous mail, you mentioned that you wanted to print
> FT_COMPONENTS along with actual log message only when there is some
> string present in the FT2_DEBUG env variable. Therefore, I wanted
> to ask about what exactly do you have in your
*> I thought of> [] ...> where is the value given
in the `FT_COMPONENT` macro,> padded with spaces to ensure a uniform
width. Example:> [cffdriver] ...> [psconv ] ...> [sfobjs ] ...>
However, this should be freely adjustable – thus my request to make> `{`
and `}` configurable in the
>> Oh yes, you can! Either you modify the source code of 'dlg' within
>> FreeType, or – which is better IMHO – you submit a feature request
>> or patch to the 'dlg' maintainers that allows control of the '{'
>> and '}' characters for marking tags. I see no reason why this must
>> be hard-coded.
*> Oh yes, you can! Either you modify the source code of 'dlg' within>
FreeType, or – which is better IMHO – you submit a feature request or>
patch to the 'dlg' maintainers that allows control of the '{' and '}'>
characters for marking tags. I see no reason why this must be> hard-coded.*
Ok, I
On Mon, Jul 6, 2020 at 11:58 AM Werner LEMBERG wrote:
>
>
> > Werner, please don't commit something if you think there are still
> > problems in it, that's what code reviews are,
>
> Normally, I do that. However, I've already invested a lot of time in
> writing ChangeLog entries...
>
> > See
>> Of course. Please send a separate patch for these fixed so that I
>> can apply it to master directly.
>
> Ok, I will provide you the patch once done...
Thanks.
>> Very nice! Do you have some data how large the slowdown is due to
>> the additional code?
>
> No, As I haven't done software
> Werner, please don't commit something if you think there are still
> problems in it, that's what code reviews are,
Normally, I do that. However, I've already invested a lot of time in
writing ChangeLog entries...
> See attached patch for a fix.
Applied, thanks. Note, however, that there
On Mon, Jul 6, 2020 at 11:17 AM Nikolaus Waxweiler
wrote:
> Meson has a check-dist thing built in. Just saying
>
and other nice things. I'm eagerly waiting for a meson build
Vincent Torri
Meson has a check-dist thing built in. Just saying
*Ouch* :-)
Werner, please don't commit something if you think there are still problems
in it, that's what code reviews are, and I'm currently on vacation, so
we've been lucky I could glimpse at my email and have time to fix it.
See attached patch for a fix. Sorry about that. We need a better way
*> Of course. Please send a separate patch for these fixed so that I can>
apply it to master directly.*
Ok, I will provide you the patch once done...
*> Very nice! Do you have some data how large the slowdown is due to the>
additional code?*
No,
As I haven't done software profiling before
> I have added some changes to produce the desired output using the
> previous approach specified by you. With this approach, I have to
> make very little changes in some FT_TRACE calls for better
> indentation. Would that be OK with you?
Of course. Please send a separate patch for these
> [...] compilation of the the demo programs fails with
>
> freetype2-demos/src/ftbench.c: In function ‘face_requester’:
> freetype2-demos/src/ftbench.c:165:5: warning:
> implicit declaration of function ‘FT_UNUSED’
> [-Wimplicit-function-declaration]
>FT_UNUSED(
> > Since debugging isn't time critical it might be necessary to add
> > an additional step that scans tracing messages for newline
> > characters, then massaging the output by inserting the time stamp.
> > In other words, all occurrences of `\n` should be replaced with
> > `\n[time stamp] ` or
17 matches
Mail list logo
