- documentation: the API documentation doesn't make the purpose of
these functions very clear. An explanation of what a variant
selector charmap is would be welcomed
Unicode decided that some characters had variant forms. [...]
I've moved the cmap 14 API into a new section (in
On Fri, 2007-10-19 at 04:04, David Turner wrote:
By the way, where can I find the spec for cmap format 14 and the
variant selector things ?, I could not find anything on the
Internet.(yes, I've seen the description in src/sfnt/ttcmap.c)
This was posted on the opentype list:
Another point is that the arrays returned are 0-terminated. this
assumes that 0 is not a valid selector variant, but I don't see code
to check for this in the cmap 14_validate function. will add these
George, what do you think of undefining TT_CONFIG_CMAP_FORMAT_14 until
the specs are
Another point is that the arrays returned are 0-terminated. this assumes
that 0 is not a valid selector variant, but I don't see code to check for
this in the cmap 14_validate function. will add these
2007/10/19, David Turner [EMAIL PROTECTED]:
ok, I have several issues with this patch (and I'm
ok, I have several issues with this patch (and I'm writing a fix right now):
-naming: I prefer all new APIs to use the FT_Object_ActionName template,
this means I'd favor renaming the functions to things like:
FT_Face_GetCharsOfVariant
FT_Face_GetVariantsOfChar
FT_Face_GetVariantSelectors
ok, I have several issues with this patch
I've expected this, but you have been silent :-)
(and I'm writing a fix right now):
Great.
-naming: I prefer all new APIs to use the FT_Object_ActionName
template,
OK.
- documentation: the API documentation doesn't make the purpose of these
ok, this is done. the functions still return arrays, but these are owned by
the FT_Face but may be reused/deallocated on the next FreeType call. I've
also renamed the functions, and updated their documentation.
I'm still interested by the CMAP 14 spec by the way :-)
- David
On Tue, 2007-10-09 at 23:56, Werner LEMBERG wrote:
if called on a format 14 charmap (which
shouldn't be possible in the first place). Instead a new routine
FT_Get_Char_Variant_Index
I believe the following patch will add cmap14 support to freetype.
(based on the cvs tree as it
On Tue, 2007-10-09 at 23:56, Werner LEMBERG wrote:
I have no opinion here. If you think this is the route to go, let's
do this. However, I could imagine to have
FT_Get_Chars_Of_Variant
FT_Get_Variants_Of_Char
FT_Get_Variant_Selectors
I like this much better (I was just trying to be
