Re: [fricas-devel] comparable patches and comments on unparse

2010-01-06 Thread Waldek Hebisch
Bill Page wrote: On Sun, Nov 22, 2009 at 9:06 PM, Waldek Hebisch wrote: ?In unlikely case that your changes have no bugs the next person changing this code is likely to break it: it is really tricky to get operators correct without simple scheme which is correct by design. Clearly I

Re: [fricas-devel] comparable patches and comments on unparse

2009-12-08 Thread Bill Page
On Sat, Dec 5, 2009 at 8:12 AM, Waldek Hebisch wrote: Bill Page wrote: Martin Rubey wrote: I would also like to see the rudimentary test file I sent to go with this patch. ?One remark: as you probably know, I'm strongly in favour of having InputForm keep all type information. ?I tried

Re: [fricas-devel] comparable patches and comments on unparse

2009-12-05 Thread Waldek Hebisch
Bill Page wrote: Martin Rubey wrote: I would also like to see the rudimentary test file I sent to go with this patch. ?One remark: as you probably know, I'm strongly in favour of having InputForm keep all type information. ?I tried to prepare such a patch, but there is a small problem

Re: [fricas-devel] comparable patches and comments on unparse

2009-11-23 Thread Bill Page
Martin Rubey wrote: I would also like to see the rudimentary test file I sent to go with this patch.  One remark: as you probably know, I'm strongly in favour of having InputForm keep all type information.  I tried to prepare such a patch, but there is a small problem in the way the

Re: [fricas-devel] comparable patches and comments on unparse

2009-11-22 Thread Waldek Hebisch
Martin Rubey wrote: I would also like to see the rudimentary test file I sent to go with this patch. One remark: as you probably know, I'm strongly in favour of having InputForm keep all type information. I tried to prepare such a patch, but there is a small problem in the way the

Re: [fricas-devel] comparable patches and comments on unparse

2009-11-12 Thread Martin Rubey
Bill Page bill.p...@newsynthesis.org writes: The next patch shown in 'svn status' above contains the changes to InputForm and unparse I have discussed with Martin Rubey for product and summation. +if F has ConvertibleTo(I) then + indprod l == +

Re: [fricas-devel] comparable patches and comments on unparse

2009-11-12 Thread Bill Page
Waldek, Thank you for your testing and comments about 'algebra-comparable-1.patch' On Wed, Nov 11, 2009 at 10:57 PM, Waldek Hebisch wrote: The algebra-comparable-1.patch mostly looks OK.  However I have doubts about the followig hunk: Index: src/algebra/variable.spad.pamphlet

Re: [fricas-devel] comparable patches and comments on unparse

2009-11-12 Thread Waldek Hebisch
Bill Page wrote: On Wed, Nov 11, 2009 at 10:57 PM, Waldek Hebisch wrote: The algebra-comparable-1.patch mostly looks OK. ?However I have doubts about the followig hunk: Index: src/algebra/variable.spad.pamphlet ===

Re: [fricas-devel] comparable patches and comments on unparse

2009-11-12 Thread Bill Page
Waldek, Thanks for the example of where the ordering of an OrderedVariableList is important in the library. As I said, I will commit the code for comparable without this change. But I will be traveling for the next few days and may not be able to do the commit until some time next week. On Thu,

Re: [fricas-devel] comparable patches and comments on unparse

2009-11-11 Thread Waldek Hebisch
Bill Page wrote: Waldek, Attached and below is the patch rebased to revision 730 that adds Comparable to the XPOLY and Tensor domains (and others that depend on FreeModuleCategory). Among other things this change permits these domains to participate with domains like Expression again,

[fricas-devel] comparable patches and comments on unparse

2009-11-10 Thread Bill Page
Waldek, Attached and below is the patch rebased to revision 730 that adds Comparable to the XPOLY and Tensor domains (and others that depend on FreeModuleCategory). Among other things this change permits these domains to participate with domains like Expression again, although there are some