Re: [fricas-devel] patches for aggcat.spad

2016-06-16 Thread oldk1331
> At first glance I can not see if it is wrong or not: it depends > on intent of original writer. I suspect that the intention was > to use this code only for sparse sets. See the patch that changes Rep of BinaryTree in the other thread, I think the intention here was for this BinaryTree case,

Re: [fricas-devel] patches for aggcat.spad

2016-06-16 Thread Waldek Hebisch
oldk1331 wrote: > https://github.com/oldk1331/fricas/commit/391150ca162af518b8adce509997757fbaacba54.patch > > this patch fixes code related to BasicType: > > = (equality operator) and functions that only relies on = requires > S has BasicType, not SetCategory. Actually, we can compute equality

[fricas-devel] patches for aggcat.spad

2016-06-16 Thread oldk1331
https://github.com/oldk1331/fricas/commit/391150ca162af518b8adce509997757fbaacba54.patch this patch fixes code related to BasicType: = (equality operator) and functions that only relies on = requires S has BasicType, not SetCategory. In BinaryRecursiveAggregate, "has SetAggregate(S)" is totally