Re: czech keyboard and fvwm (incoming/837), patch

2002-04-15 Thread Dominik Vogt
ther strange national > keyboards because I don't use them. > > > --- fvwm-2.4.5.orig/libs/Bindings.c Wed Feb 20 20:19:35 2002 > +++ fvwm-2.4.5/libs/Bindings.cWed Feb 20 20:19:38 2002 > @@ -550,7 +550,7 @@ >Binding *b; >unsigned int used_modifiers = ~

Re: FvwmBanner: PNG or Colorset support and more

2003-06-06 Thread Dominik Vogt
On Thu, Jun 05, 2003 at 03:39:45PM +, Mikhael Goikhman wrote: > We don't seem to have the png or colorset support in FvwmBanner. > > So if a logo with an alpha channel wins, we will not be able to show it > as nicely as we could with such support. > > Is it hard to add the colorset or png sup

Re: FvwmBanner: PNG or Colorset support and more

2003-06-06 Thread Dominik Vogt
On Thu, Jun 05, 2003 at 04:52:00PM +, Mikhael Goikhman wrote: > On 05 Jun 2003 18:16:24 +0200, Dominik Vogt wrote: > > > > On Thu, Jun 05, 2003 at 03:39:45PM +, Mikhael Goikhman wrote: > > > We don't seem to have the png or colorset support in FvwmBanner. >

Re: FvwmBanner: PNG or Colorset support and more

2003-06-06 Thread Dominik Vogt
On Fri, Jun 06, 2003 at 07:38:12AM +, Mikhael Goikhman wrote: > > I'm speaking about tarball size, not executable size. > > So it will be 2283442 instead of 2243442 for each new logo. Why not? Because the gain you get for the additional size is close to zero. It's against the philosophy fvwm

Re: 2.4.16 and 2.5.7 releases?

2003-05-29 Thread dominik . vogt
On Wed, May 28, 2003 at 07:39:07PM +, Mikhael Goikhman wrote: > On 13 May 2003 20:51:22 +, Mikhael Goikhman wrote: > > > > On 13 May 2003 11:45:36 +0200, Dominik Vogt wrote: > > > > > > Anyone wants to build the next releases? Because I won't do i

Re: fvwm security issue

2006-11-13 Thread Dominik Vogt
in gentoo's package as well. Is that already fixed in CVS? Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: releasing 2.4.20 and 2.5.19?

2006-12-09 Thread Dominik Vogt
I want to ask > before doing anything. > > So is this weekend a good time to release 2.5.19 and 2.4.20? Go ahead if you want to. I hope the instructions are complete, but if there are any questions, just ask. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: releasing 2.4.20 and 2.5.19?

2006-12-09 Thread Dominik Vogt
On Sat, Dec 09, 2006 at 12:50:35PM +0100, Viktor Griph wrote: > On Sat, 9 Dec 2006, Dominik Vogt wrote: > > >On Sat, Dec 09, 2006 at 12:21:56PM +0100, Viktor Griph wrote: > >>With the security fix in fvwm-menu-directory it would be good to release > >>fixed v

Re: releasing 2.4.20 and 2.5.19?

2006-12-09 Thread Dominik Vogt
On Sat, Dec 09, 2006 at 01:10:24PM +0100, Viktor Griph wrote: > On Sat, 9 Dec 2006, Dominik Vogt wrote: > > >On Sat, Dec 09, 2006 at 12:50:35PM +0100, Viktor Griph wrote: > >>On Sat, 9 Dec 2006, Dominik Vogt wrote: > >> > >>>On Sat, Dec 09, 2006 at 12:21:

Re: CVS griph: * added menu context mouse and key bindings

2006-12-27 Thread Dominik Vogt
me). Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS griph: * added menu context mouse and key bindings

2006-12-27 Thread Dominik Vogt
On Wed, Dec 27, 2006 at 05:50:11PM +0100, Viktor Griph wrote: > On Wed, 27 Dec 2006, Dominik Vogt wrote: > > >On Wed, Dec 27, 2006 at 10:18:36AM -0600, fvwm-workers wrote: > >>Log message: > >>* added menu context mouse and key bindings > > > >Can you p

Re: CVS griph: * added menu context mouse and key bindings

2006-12-27 Thread Dominik Vogt
On Wed, Dec 27, 2006 at 06:34:05PM +0100, Dominik Vogt wrote: > On Wed, Dec 27, 2006 at 05:50:11PM +0100, Viktor Griph wrote: > > It allows for customization of the menu navigation shortcuts. The > > implementatioin was done by first translating the old menuShortcuts > &

Re: CVS griph: * added menu context mouse and key bindings

2006-12-28 Thread Dominik Vogt
On Wed, Dec 27, 2006 at 08:52:49PM +0100, Viktor Griph wrote: > On Wed, 27 Dec 2006, Dominik Vogt wrote: > > >On Wed, Dec 27, 2006 at 06:34:05PM +0100, Dominik Vogt wrote: > >>On Wed, Dec 27, 2006 at 05:50:11PM +0100, Viktor Griph wrote: > >>>It allows for cus

Re: some 64bit cleanup on CVS head (XGetWindowProperty())

2006-12-28 Thread Dominik Vogt
ndowProperty(dpy, w, atom, 0L, 1024L, > False, AnyPropertyType, > &actual_type, > &actual_format, &nitems, Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS griph: * added menu context mouse and key bindings

2006-12-28 Thread Dominik Vogt
On Thu, Dec 28, 2006 at 10:49:34PM +0100, Viktor Griph wrote: > On Thu, 28 Dec 2006, Dominik Vogt wrote: > > >On Wed, Dec 27, 2006 at 08:52:49PM +0100, Viktor Griph wrote: > >>On Wed, 27 Dec 2006, Dominik Vogt wrote: > >> > >>>On Wed, Dec 27, 2006 at 06:3

Re: CVS griph: * added menu context mouse and key bindings

2006-12-28 Thread Dominik Vogt
On Thu, Dec 28, 2006 at 11:25:48PM +0100, Dominik Vogt wrote: > On Thu, Dec 28, 2006 at 10:49:34PM +0100, Viktor Griph wrote: > > On Thu, 28 Dec 2006, Dominik Vogt wrote: > > > > >On Wed, Dec 27, 2006 at 08:52:49PM +0100, Viktor Griph wrote: > > >>On

Re: CVS griph: * added menu context mouse and key bindings

2006-12-28 Thread Dominik Vogt
On Thu, Dec 28, 2006 at 11:57:50PM +0100, Viktor Griph wrote: > On Thu, 28 Dec 2006, Dominik Vogt wrote: [snip] > >Sorry for the confusion. I had my patched ready and tried to > >commit them at the very same moment you did. I had to remove your > >patches to get my (more g

Re: A "newbie" question regarding FD_SET

2006-12-28 Thread Dominik Vogt
all the hard work I spent to remove almost all globals). Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS griph: * added menu context mouse and key bindings

2006-12-29 Thread Dominik Vogt
On Fri, Dec 29, 2006 at 08:42:05AM +0100, Viktor Griph wrote: > On Fri, 29 Dec 2006, Dominik Vogt wrote: > > >On Thu, Dec 28, 2006 at 11:57:50PM +0100, Viktor Griph wrote: > >>On Thu, 28 Dec 2006, Dominik Vogt wrote: > >[snip] > >>>Sorry for the confusio

Re: Changing from module arrays to module structure

2006-12-29 Thread Dominik Vogt
>communication functions > > (something like module_list.h/c and module_interface.h/c) > >* dont use fdsets to store the list of initialization modules. Use > >another module list instead. > >* cleanup the module interface functions (remove dup code, etc) > > > >Th

Re: Changing from module arrays to module structure

2006-12-29 Thread Dominik Vogt
On Fri, Dec 29, 2006 at 09:43:23PM +, seventh guardian wrote: > On 12/29/06, Dominik Vogt <[EMAIL PROTECTED]> wrote: > >On Fri, Dec 29, 2006 at 02:42:16PM +, seventh guardian wrote: > >> > >> OOPS it's not safe yet. There's a segmentation fault r

Re: Changing from module arrays to module structure

2006-12-29 Thread Dominik Vogt
On Fri, Dec 29, 2006 at 09:55:31PM +, seventh guardian wrote: > On 12/29/06, seventh guardian <[EMAIL PROTECTED]> wrote: > >On 12/29/06, Dominik Vogt <[EMAIL PROTECTED]> wrote: > >> On Fri, Dec 29, 2006 at 02:42:16PM +, seventh guardian wrote: > >> &

Re: fvwmSelect first argument (bug?)

2006-12-30 Thread Dominik Vogt
1. And since "channel" is the only fd in the set, "channel + 1" is the correct value. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Changing from module arrays to module structure

2006-12-30 Thread Dominik Vogt
PositiveWrite(module, body, + length*sizeof(unsigned long)); Please reindent like this: + PositiveWrite( +module, body, length*sizeof(unsigned long)); > So the only thing missing now is module_interface.c :) It needs a bit > of cleanup, and as soon as its clean I'll send it. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Changing from module arrays to module structure

2006-12-30 Thread Dominik Vogt
bother to to the changes I posted earlier; I'll do it myself. The branch name will be "fvwm-module-struct-branch". To pull it from cvs into a directory "modstruct-branch", issue $ cvs co -Pd modstruct-branch -r fvwm-module-struct-branch fvwm Ciao Dominik ^_^

Re: Changing from module arrays to module structure

2006-12-30 Thread Dominik Vogt
On Sat, Dec 30, 2006 at 12:57:20PM +0100, Dominik Vogt wrote: > On Sat, Dec 30, 2006 at 02:13:29AM +, seventh guardian wrote: > [snip] > > Ok, here goes the patch module_interface.c. The first goal of having a > > functional system is hopefully done. > > I'm go

Re: Changing from module arrays to module structure

2006-12-30 Thread Dominik Vogt
On Sat, Dec 30, 2006 at 03:01:22PM +0100, Dominik Vogt wrote: > On Sat, Dec 30, 2006 at 12:57:20PM +0100, Dominik Vogt wrote: > > On Sat, Dec 30, 2006 at 02:13:29AM +, seventh guardian wrote: > > [snip] > > > Ok, here goes the patch module_interface.c. Th

Re: Changing from module arrays to module structure

2006-12-30 Thread Dominik Vogt
On Sat, Dec 30, 2006 at 02:37:15PM +, seventh guardian wrote: > On 12/30/06, Dominik Vogt <[EMAIL PROTECTED]> wrote: > >On Sat, Dec 30, 2006 at 03:01:22PM +0100, Dominik Vogt wrote: > >> On Sat, Dec 30, 2006 at 12:57:20PM +0100, Dominik Vogt wrote: > >> >

Re: Changing from module arrays to module structure

2006-12-30 Thread Dominik Vogt
On Sat, Dec 30, 2006 at 04:12:16PM +0100, Dominik Vogt wrote: > On Sat, Dec 30, 2006 at 02:37:15PM +, seventh guardian wrote: > > On 12/30/06, Dominik Vogt <[EMAIL PROTECTED]> wrote: > > >On Sat, Dec 30, 2006 at 03:01:22PM +0100, Dominik Vogt wrote: > > >>

Re: CVS domivogt: * Add new modules to the end of the list, not the beginning.

2006-12-30 Thread Dominik Vogt
s reverted the order of the modules. When we are sure that nothing bad can happen, we can switch back to adding at the beginning. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Changing from module arrays to module structure

2006-12-30 Thread Dominik Vogt
On Sat, Dec 30, 2006 at 05:14:54PM +0100, Dominik Vogt wrote: > > I don't have the time now, but there is one important bug left: > > My InitFunction is not executed because it is not defined yet at > > the moment it is called (StartupStuff() in fvwm.c). I'm

Re: DeadPipe signal handler

2006-12-30 Thread Dominik Vogt
er). Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: module_interface old vs new functions

2006-12-30 Thread Dominik Vogt
_interface.c.. I don't even know which functions you consider to be "new" or "old". Can you list them? Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: todo-2.6: C.23 XForms "sliderall" demo

2006-12-30 Thread Dominik Vogt
rs a managed window (or the pan frames, root window etc.) and the focus does not change anyway, reinstall the focus. (2) might be tricky. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: DeadPipe signal handler

2006-12-30 Thread Dominik Vogt
On Sun, Dec 31, 2006 at 12:48:08AM +, seventh guardian wrote: > On 12/31/06, Dominik Vogt <[EMAIL PROTECTED]> wrote: > >On Sat, Dec 30, 2006 at 11:35:21PM +, seventh guardian wrote: > >> The DeadPipe signal handling is actually done by an empty function. Is > >

Re: module_interface old vs new functions

2006-12-30 Thread Dominik Vogt
On Sun, Dec 31, 2006 at 12:27:09AM +, seventh guardian wrote: > On 12/31/06, Dominik Vogt <[EMAIL PROTECTED]> wrote: > >On Sat, Dec 30, 2006 at 05:47:51PM +, seventh guardian wrote: > >> Hello. > >> > >> Inside module_interface there are lots of

Re: DeadPipe signal handler

2006-12-30 Thread Dominik Vogt
On Sun, Dec 31, 2006 at 01:13:26AM +, seventh guardian wrote: > On 12/31/06, Dominik Vogt <[EMAIL PROTECTED]> wrote: > >On Sun, Dec 31, 2006 at 12:48:08AM +, seventh guardian wrote: > >> On 12/31/06, Dominik Vogt <[EMAIL PROTECTED]> wrote: > >> &g

Re: todo-2.6: C.23 XForms "sliderall" demo

2006-12-31 Thread Dominik Vogt
On Sun, Dec 31, 2006 at 09:08:00AM +0100, Viktor Griph wrote: > On Sun, 31 Dec 2006, Viktor Griph wrote: > > >On Sun, 31 Dec 2006, Dominik Vogt wrote: > > > >>On Sat, Dec 30, 2006 at 06:03:55PM +, seventh guardian wrote: > >>>On 9/1/06, Viktor Griph <

Re: macros and inline functions in module_interface.h

2006-12-31 Thread Dominik Vogt
to move part of a function to another inlined function if the latter is called only in one place. Even this should be done only if there is a very good reaseon, e.g. in a loop with potentially lots of iterations. ** There are some macros in the sources that contain real code. Personally I think it's a bad idea. ** There are lots of macros that allow access sto structure members in the header files. These can not be replaced by "inline" functions. I'm no big fan of that, but it's much better than exposing the details of a structure to the caller. ** C99 is irrelevant to fvwm code. Fvwm has to compile on C89 compilers. This forbids, for example, declarations in the body of a block (my compiler refuses to compile this) or c++-style comments: "// bla bla". Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: macros and inline functions in module_interface.h

2007-01-01 Thread Dominik Vogt
y contain coes). Macros are solely used for information hiding. Before we had the macros, structure members were referenced directly in thousands of places. It was extremely tedious to change member names or structure layout. > I wonder if this scenario could be reached somehow.. > > Even if this conversation eventually leads to nowhere, I'm really > learning a lot about compilers! Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS renato: *Removed the test for MAX_NUM_MODULES - let the O.S. do the checks

2007-01-01 Thread Dominik Vogt
it might even overflow with the limit if fvwm is started from a process with lots of open fds). > *Moved the module allocation call to the end of the sanity checks an pipe > creation Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Changing from module arrays to module structure

2007-01-01 Thread Dominik Vogt
On Sat, Dec 30, 2006 at 02:47:37PM +, seventh guardian wrote: > On 12/30/06, Dominik Vogt <[EMAIL PROTECTED]> wrote: > >On Sat, Dec 30, 2006 at 03:01:22PM +0100, Dominik Vogt wrote: > >> On Sat, Dec 30, 2006 at 12:57:20PM +0100, Dominik Vogt wrote: > >> >

Re: CVS renato: * Created function module_add_to_fdsets from events.c and module_interface.c

2007-01-03 Thread Dominik Vogt
On Wed, Jan 03, 2007 at 12:03:18AM +, seventh guardian wrote: > On 1/2/07, Dominik Vogt <[EMAIL PROTECTED]> wrote: > >> In the tests I'm calling the function GetFdWidth() twice for every > >> module, which may incur in a bit overhead.. > >> > >

latest changes to module_interface.[ch]

2007-01-03 Thread Dominik Vogt
the fds *every time* they are added to a set. The size of the fdset struct does not ever change, so the checks can be done once when the fds are created. And finally, the implementation details of the module structure can be hidden with access macros. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: latest changes to module_interface.[ch]

2007-01-03 Thread Dominik Vogt
On Wed, Jan 03, 2007 at 12:02:34PM +0100, Dominik Vogt wrote: > With the introduction of the of the module_add_to_fdsets() > function the code is now moving into a very unfortunate direction. > When fvwm is busy, that function might be called thousands of > times per second, with three

Re: latest changes to module_interface.[ch]

2007-01-03 Thread Dominik Vogt
On Wed, Jan 03, 2007 at 02:18:31PM +, seventh guardian wrote: > On 1/3/07, Dominik Vogt <[EMAIL PROTECTED]> wrote: > >On Wed, Jan 03, 2007 at 12:02:34PM +0100, Dominik Vogt wrote: > >> With the introduction of the of the module_add_to_fdsets() > >> function t

Re: Hello, where did fw->frame_g go?

2007-01-03 Thread Dominik Vogt
iption of these changes is missing from the > corresponding ChangeLog entry. Can you provide one? Sone. > Also, 'g' is a rather vague name, no? It's rarely used alone, so if you come across g.frame that's no worse or better than frame_g. In the sources, "g" usually stands for "geometry". Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: FvwmIconBox: IconColorset bg color bug

2007-01-03 Thread Dominik Vogt
g red > *FvwmIconBox: IconColorset 42 > Module FvwmIconBox > Colorset 42 bg green > > Oops! The background of inactive icon labels stays red, but must be green. Applied. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: focus when between pages

2007-01-05 Thread Dominik Vogt
t, > >although one could accomplish switching pages fully with something like: > > > >DestroyFunc MyFunc > >AddToFunc MyFunc > >+ I Current (Visible) GotoPage $[page.nx] $[page.ny] > > > >(Crude at best, but you get the idea.) Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: focus when between pages

2007-01-05 Thread Dominik Vogt
On Fri, Jan 05, 2007 at 10:07:39AM +0100, Dominik Vogt wrote: > On Thu, Jan 04, 2007 at 08:34:25PM +0100, Viktor Griph wrote: > > On Thu, 4 Jan 2007, Thomas Adam wrote: > > > > >On Thu, Jan 04, 2007 at 08:02:06PM +0100, Viktor Griph wrote: > > >>Result: The

Re: cleanup patch

2007-01-06 Thread Dominik Vogt
On Fri, Jan 05, 2007 at 11:15:35PM +0300, Serge (gentoosiast) Koksharov wrote: > Please see attached patch's ChangeLog. Very good patches. I'll apply them. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: FvwmConsole under urxvtc

2007-01-06 Thread Dominik Vogt
> clean_up(); > exit(0); > } > > So if we remove SIGCHLD handler completely or only for urxvtc, this `if' > body will still be executed after closing terminal window and stale > socket file will be removed. So I assume we can safely do this. Your > opinion? Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: FvwmConsole under urxvtc

2007-01-07 Thread Dominik Vogt
On Sat, Jan 06, 2007 at 11:52:07PM +0300, Serge (gentoosiast) Koksharov wrote: > On Sat, Jan 06, 2007 at 12:56:41PM +0100, Dominik Vogt wrote: > > > > or removing this SIGCHLD signal handler completely. > > > > Hm, I don't know. Why does FvwmConsole get a SIGC

Re: FvwmConsole under urxvtc

2007-01-07 Thread Dominik Vogt
On Sun, Jan 07, 2007 at 02:36:21PM +0100, Dominik Vogt wrote: > On Sat, Jan 06, 2007 at 11:52:07PM +0300, Serge (gentoosiast) Koksharov wrote: > > On Sat, Jan 06, 2007 at 12:56:41PM +0100, Dominik Vogt wrote: > > > > > > or removing this SIGCHLD signal handler completel

Re: FvwmConsole under urxvtc

2007-01-07 Thread Dominik Vogt
mConsole not > compiles at all if you pass --without-readline-library option to > configure script. Because I did not think before committing. Will be fixed in a minute. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS domivogt: * Reindented and cleaned up FvwmConsole code.

2007-01-07 Thread Dominik Vogt
c and fio.h to provide wrappers for the io > >functions > >that filter EINTR for the caller. > > Can fvwm_send and fvwm_recv used to provide a socket for terminals to > connect, ala todo-3.0 entry 5? It seems interesting. Ah, not really. All I did is put a wrapper that catches

Re: Apparently duplicated function in module_interface.c

2007-01-07 Thread Dominik Vogt
Original-Nachricht Datum: Mon, 8 Jan 2007 02:24:12 + Von: "seventh guardian" <[EMAIL PROTECTED]> An: "FVWM Workers" Betreff: Apparently duplicated function in module_interface.c > I've came across two very similar functions in module_interface.c, one > of which was introduc

Re: separating module handling from packet sending/receiving

2007-01-08 Thread Dominik Vogt
he current module interface code, and help keeping > it that way. Does it seem a worthy thing to do? > > If so, should I send the diffs for review or should there be created a > new branch? As long as the risk is not high, we don't need a branch for that. Go ahead. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Commit in FScreen.c

2007-01-09 Thread Dominik Vogt
write always have this structure: 1. Declarations (no initializatios to allow gcc to warn about uninitialized variables) 2. BLANK LINE 3. Body of the block (usually without *any* blank lines) 4. BLANK LINE 5. Return statement Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROT

Re: CVS griph: * don't warp on popdown if triggered by motion

2007-01-10 Thread Dominik Vogt
> CVSROOT: /home/cvs/fvwm > Module name: fvwm > Changes by: griph 07/01/09 16:18:10 > > Modified files: > fvwm : menus.c > . : ChangeLog > > Log message: > * don't warp on popdown if triggered by motion Can you describe the problem please? (Note:

Re: CVS griph: * don't warp on popdown if triggered by motion

2007-01-10 Thread Dominik Vogt
On Wed, Jan 10, 2007 at 05:04:46PM +0100, Viktor Griph wrote: > On Wed, 10 Jan 2007, Viktor Griph wrote: > > >On Wed, 10 Jan 2007, Dominik Vogt wrote: > > > >>>CVSROOT: /home/cvs/fvwm > >>>Module name: fvwm > >>>Changes by:

Re: moving headers to fvwm_INCLUDE in Makefile.am

2007-01-11 Thread Dominik Vogt
ile now they should go on > fvwm_INCLUDES. > > Is there any issue with older supported versions of automake preventing > this? I don't know, we never tried this. Does automake-1.4 (which is the required version) support this? Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: StackTransientParent race condition

2007-01-11 Thread Dominik Vogt
ttributes(dpy, parent, > CWEventMask, &attr); > } > if (junk_list != NULL) > { > XFree(junk_list); > junk_list = NULL; > } > break; > } > default: > break; > } > fflush(stderr); > } > XDestroyWindow(dpy,w2); > XDestroyWindow(dpy,w1); > XCloseDisplay(dpy); > } Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS domivogt foo: Imported sources

2007-01-11 Thread Dominik Vogt
On Thu, Jan 11, 2007 at 08:44:24AM -0600, fvwm-workers wrote: > CVSROOT: /home/cvs/fvwm > Module name: foo > Changes by: domivogt07/01/11 08:44:24 Ingonre this commit, I had the wrog cvsroot set. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] sign

Re: moving headers to fvwm_INCLUDE in Makefile.am

2007-01-13 Thread Dominik Vogt
On Sat, Jan 13, 2007 at 01:32:58PM +, seventh guardian wrote: > On 1/10/07, Dominik Vogt <[EMAIL PROTECTED]> wrote: > >On Wed, Jan 10, 2007 at 04:28:14PM +, seventh guardian wrote: > >> Hello. > >> > >> In the process of adding the module_list.c

Re: Bug in FvwmIdent's Geometry string.

2007-01-13 Thread Dominik Vogt
of: > > xterm -g some_geometry_string > > for the numbers from xwininfo and FvwmIdent to see what's happening. I > don't have time to look into why at the moment, I wish I did. Fixed. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS domivogt: * Use "int" instead of "unsinged int" in many places.

2007-01-13 Thread Dominik Vogt
nsingned arithmetics in the fvwm code. Well, as I don't have a gcc version that throws errors, I can't fix the warnings. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS domivogt: * Use "int" instead of "unsinged int" in many places.

2007-01-13 Thread Dominik Vogt
On Sat, Jan 13, 2007 at 09:11:51PM +0100, Viktor Griph wrote: > On Sat, 13 Jan 2007, Dominik Vogt wrote: > > >On Sat, Jan 13, 2007 at 05:41:43PM +0100, Viktor Griph wrote: > >>On Sat, 13 Jan 2007, FVWM CVS wrote: > >>>* Use "int" instead of "u

Re: Bug in FvwmIdent's Geometry string.

2007-01-13 Thread Dominik Vogt
On Sat, Jan 13, 2007 at 09:12:00PM +, Thomas Adam wrote: > On Sat, Jan 13, 2007 at 04:34:17PM +0100, Dominik Vogt wrote: > > > There appears to be a discrepency between how FvwmIdent calculates the > > > geometry of the specified window, in relation to, say, how xwininf

Re: CVS domivogt: * Use "int" instead of "unsinged int" in many places.

2007-01-13 Thread Dominik Vogt
ed int with wrappers that take signed and do the casting there. I've not decided yet. Anyway, I didn't do that for the kicks but because I needed to make the "rectangle" structure using signed only in order to code some enhancements to the placement code. Ciao Dominik ^_^

Re: Bug in FvwmIdent's Geometry string.

2007-01-14 Thread Dominik Vogt
On Sun, Jan 14, 2007 at 12:27:35AM +, Thomas Adam wrote: > On Sun, Jan 14, 2007 at 12:50:57AM +0100, Dominik Vogt wrote: > > On Sat, Jan 13, 2007 at 09:12:00PM +, Thomas Adam wrote: > > > On Sat, Jan 13, 2007 at 04:34:17PM +0100, Dominik Vogt wrote: > > >

Re: CVS griph: * silence compiler warnings

2007-01-14 Thread Dominik Vogt
/FvwmIdent: FvwmIdent.c > modules/FvwmRearrange: FvwmRearrange.c > modules/FvwmScript: types.h > modules/FvwmTaskBar: ButtonArray.c ButtonArray.h > modules/FvwmWharf: FvwmWharf.c Wharf.h > > Log message: > * silence compiler warnings Cool, thanks!

Re: Bug in FvwmIdent's Geometry string.

2007-01-14 Thread Dominik Vogt
On Sun, Jan 14, 2007 at 03:10:41PM +, Thomas Adam wrote: > On Sun, Jan 14, 2007 at 04:00:28PM +0100, Dominik Vogt wrote: > > > I don't understand what your problem is. When I start xterm like > > this: > > > > $ xterm -g "80x24+0+0" > >

Re: deiconify may loop forever

2007-01-14 Thread Dominik Vogt
that logic because it climbs only one level up the tree. The right fix is to break the loop if get_transientfor_fvwmwindow returns NULL. The comparison (ofw == fw) is there to catch windows that are their own transients. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS domivogt: * Icon loop fix.

2007-01-14 Thread Dominik Vogt
tand your patch correctly. The effect is the same, but the new version is a bit easier to understand (I hope). Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Bug in FvwmIdent's Geometry string.

2007-01-14 Thread Dominik Vogt
On Sun, Jan 14, 2007 at 03:54:23PM +, Thomas Adam wrote: > On Sun, Jan 14, 2007 at 04:33:56PM +0100, Dominik Vogt wrote: > > > With that, FvwmIdent prints the relevant information to the > > console. Can you post the output and the (relevant) output of > > xwinin

Re: deiconify may loop forever

2007-01-14 Thread Dominik Vogt
On Sun, Jan 14, 2007 at 07:01:06PM +0100, Viktor Griph wrote: > On Sun, 14 Jan 2007, Dominik Vogt wrote: > > >On Sun, Jan 14, 2007 at 04:42:23PM +0100, Viktor Griph wrote: > >>This loop is on line 2288 in icons.c: > >> > >>for (ofw = NULL;

Re: CVS domivogt: * Use resize_inc hint even with ResizeHintOverride style.

2007-01-14 Thread Dominik Vogt
ng strange values. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Bug in FvwmIdent's Geometry string.

2007-01-14 Thread Dominik Vogt
On Sun, Jan 14, 2007 at 06:25:15PM +, Thomas Adam wrote: > On Sun, Jan 14, 2007 at 07:13:04PM +0100, Dominik Vogt wrote: > > The reason is that fvwm thinks the character size is 1x1. This > > happens explicitly with the ResizeHintOverride style (I've > > committed

Re: deiconify may loop forever

2007-01-14 Thread Dominik Vogt
On Sun, Jan 14, 2007 at 07:28:39PM +0100, Viktor Griph wrote: > On Sun, 14 Jan 2007, Dominik Vogt wrote: > > >On Sun, Jan 14, 2007 at 07:01:06PM +0100, Viktor Griph wrote: > >>On Sun, 14 Jan 2007, Dominik Vogt wrote: > >> > >>>On Sun, Jan 14, 20

Re: CVS domivogt: * Use resize_inc hint even with ResizeHintOverride style.

2007-01-14 Thread Dominik Vogt
> > This faq question will have to be updated: > > http://www.fvwm.org/documentation/faq/#5.16 So this bug has been exploited for years? Ouch. I'll change the man page and revive overriding the resize_inc. Thanks for the hint. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Bug in FvwmIdent's Geometry string.

2007-01-14 Thread Dominik Vogt
On Sun, Jan 14, 2007 at 06:43:48PM +, Thomas Adam wrote: > On Sun, Jan 14, 2007 at 07:36:02PM +0100, Dominik Vogt wrote: > > On Sun, Jan 14, 2007 at 06:25:15PM +, Thomas Adam wrote: > > > On Sun, Jan 14, 2007 at 07:13:04PM +0100, Dominik Vogt wrote: > > > >

Re: deiconify may loop forever

2007-01-14 Thread Dominik Vogt
On Sun, Jan 14, 2007 at 08:03:57PM +0100, Viktor Griph wrote: > On Sun, 14 Jan 2007, Dominik Vogt wrote: > > >On Sun, Jan 14, 2007 at 07:28:39PM +0100, Viktor Griph wrote: > >>On Sun, 14 Jan 2007, Dominik Vogt wrote: > >> > >>>On Sun, Jan 14, 2007 at 07:0

Re: Bug in FvwmIdent's Geometry string.

2007-01-14 Thread Dominik Vogt
On Sun, Jan 14, 2007 at 07:55:19PM +0100, Dominik Vogt wrote: > On Sun, Jan 14, 2007 at 06:43:48PM +, Thomas Adam wrote: > > On Sun, Jan 14, 2007 at 07:36:02PM +0100, Dominik Vogt wrote: > > > On Sun, Jan 14, 2007 at 06:25:15PM +, Thomas Adam wrote: > > > >

Re: Question regarding ModuleSynchronous man page entry

2007-01-14 Thread Dominik Vogt
es are started. > > What is this "hypothetical module"? The former FvwmTheme module (that is now part of the core). I still start it as a module with ModuleSynchronous. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: big "do-everything" functions or small "do-one-thing" ones?

2007-01-14 Thread Dominik Vogt
s to optimize are handling input from X and sending output to the modules. > If the possible added overhead isn't that important, I would like to > eventually apply my (unfinished) local changes to cvs. They make the > module code much more "modular" :-) Hm, did someone mention releaseing 2.5.21? This should be done before (I think the code is ready to be released). Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: Releasing 2.5.20

2007-01-15 Thread Dominik Vogt
(sorry, I deleted the mail this one refers to before I could reply). I think it's fine to release 2.5.20 with the current code. There's no need to back out anything. Ciao Dominik ^_^ ^_^ -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://w

Re: Releasing 2.5.20

2007-01-15 Thread Dominik Vogt
> On Mon, 15 Jan 2007, Dominik Vogt wrote: > > > (sorry, I deleted the mail this one refers to before I could reply). > > > > I think it's fine to release 2.5.20 with the current code. There's > > no need to back out anything. > > I get some war

Re: CVS griph fvwm-web: * update for 2.5.20 release

2007-01-15 Thread Dominik Vogt
[snip] > Log message: > * update for 2.5.20 release When you're done, don't forget to send mail to tibbs+++fvwm###org (+++ = @, ### = .) not just fvwm-owner to get the tarballs up fast. Ciao Dominik ^_^ ^_^ -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem

Re: CVS griph: * don't mangle $png_LIBS, use --with-png-library

2007-01-16 Thread Dominik Vogt
soon enough :) Hm?? Anyway, moving tags is not the thing to do. If a release is flawed, a new one can be built immediately, but if the tags are changed we might end up with several tarballs bearing the same release number. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc De

Re: StackTransientParent race condition

2007-01-16 Thread Dominik Vogt
? It's not that I don't trust your code quality, but the stacking code is very difficult to understand and very easy to break. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS griph: * add interactive scrolling

2007-01-19 Thread Dominik Vogt
lways compile with the above CFLAGS to catch these errors (however, if make needs to run the autotools, you have to call them either manually or run make without any options once). Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: CVS griph: * add interactive scrolling

2007-01-19 Thread Dominik Vogt
;blabla." * Use the word "will" sparingly. Hint: It's all described at the top of the man page. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: placement bug after cleanup

2007-01-19 Thread Dominik Vogt
this on to the worker-list since > I get the feeling that the bug tracker isn't widely used. I don't look at it anymore because I have to poll the information. > PS Is there anyone bu me that checks the tracker semi-regulary? Probably not. Ciao Dominik ^_^ ^_^ -- Domin

Re: placement bug after cleanup

2007-01-19 Thread Dominik Vogt
On Sat, Jan 20, 2007 at 01:09:20AM +0100, Dominik Vogt wrote: > On Fri, Jan 19, 2007 at 04:27:29PM +0100, Viktor Griph wrote: > > Bug #4176 in the bug tracker reports that TileManualPlacement and > > TileCascadePlacement don't work with 2.5.20. They always place windows

fvwm-2.5.21 has been released

2007-01-20 Thread Dominik Vogt
Tarballs and ANNOUNCE are in the usual places. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: FvwmGtk2 revived?

2007-01-21 Thread Dominik Vogt
Unfortunately the thread ended > there.. > > I wonder if this patch could be revived. Any one interested in this? Pernonally, no. I never understood what FvwmGtk was good for in the first place. > (hum should I also ask on the fvwm list?) Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMA

Re: Aspect-ratio resizing + Mazimize command.

2007-01-21 Thread Dominik Vogt
ot what we want when the window is maximized (or otherwise resized automatically). Fixed. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: SVG image loader

2007-01-21 Thread Dominik Vogt
to do: $ cd fvwm-patched $ cvs diff -u > patchfile > It allows fvwm to load SVG images, adding librsvg with cairo > as a new optional dependency. > > See the patched fvwm manpage for usage details. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: SVG image loader

2007-01-23 Thread Dominik Vogt
uot;cvs diff -u", > but I had trouble with the new file "libs/Fsvg.h". So I hand > edited the diff to include this file. I guess I just should > have attached it separately. Ah, I just noticed it was all my fault. I looked at the patch with mc without unpacking it first, a

  1   2   3   4   5   6   7   >