Re: [PATCH master 0/6] Clear/remove public/private OS params in gnt-instance modify/reinstall

Aside from the couple of nitpicks that I've already commented in the rest of the patchset, this looks like a reasonable patch to me. I haven't had the time to test it yet, but other than that it looks good to me. On 1 December 2016 at 10:34, Yiannis Tsiouris wrote: > This

Re: [PATCH master 3/6] Add cmdlib tests for removing instance OS params

On 1 December 2016 at 10:34, Yiannis Tsiouris wrote: > From: Nikos Skalkotos > > Add LUInstanceSetParams tests for removing individual public & private > parameters, as well as, for clearing out public & private parameters. > > Signed-off-by: Nikos Skalkotos

Re: [PATCH master 1/6] Add clear OS params options in gnt-instance modify

Thanks for the patch, this is mostly okay aside from a few small comments inline. On 1 December 2016 at 10:34, Yiannis Tsiouris wrote: > This patch adds two new options in 'gnt-instance modify' which allow the > user to clear all current public/private OS parameters of an

Re: [PATCH stable-2.15] Fix for incorrect parsing of DRBD versions

On Thu, Dec 01, 2016 at 04:09:56AM -0800, Ganeti Development List wrote: > > On Thursday, December 1, 2016 at 11:53:43 AM UTC, Iustin Pop wrote: > > > > On Thu, Dec 01, 2016 at 11:38:35AM +, Ganeti Development List wrote: > > > Following issue #1194, this patch allows Ganeti to correctly >

Re: [PATCH stable-2.15] Fix for incorrect parsing of DRBD versions

On Thursday, December 1, 2016 at 11:53:43 AM UTC, Iustin Pop wrote: > > On Thu, Dec 01, 2016 at 11:38:35AM +, Ganeti Development List wrote: > > Following issue #1194, this patch allows Ganeti to correctly > > parse drbd versions that also include a dash in their k-fix > > version

Re: [PATCH stable-2.15] Fix for incorrect parsing of DRBD versions

On Thu, Dec 01, 2016 at 11:38:35AM +, Ganeti Development List wrote: > Following issue #1194, this patch allows Ganeti to correctly > parse drbd versions that also include a dash in their k-fix > version component. This means 8.4.8-1 and 8.4.8.1 will be treated the same. Is this the correct

[PATCH stable-2.15] Fix for incorrect parsing of DRBD versions

Following issue #1194, this patch allows Ganeti to correctly parse drbd versions that also include a dash in their k-fix version component. Signed-off-by: Federico Morg Pareschi --- lib/storage/drbd_info.py| 17 +++--

[PATCH master 0/6] Clear/remove public/private OS params in gnt-instance modify/reinstall

This patchset extends 'gnt-instance modify' and 'gnt-instance reinstall' functionality by allowing partial/total removal of current OS parameters of an instance. This is specifically useful for preparing or performing an instance reinstall to a different OS provider or the same OS provider that

[PATCH master 2/6] Support OS params removal in gnt-instance modify

This patch extends 'gnt-instance modify' by allowing a user to remove a list of public/private OS parameters from an instance. This can be useful before performing a reinstall to a new OS provider. Example usage: $ gnt-instance modify --remove-os-parameters parm1,parm2 or $ gnt-instance modify

[PATCH master 1/6] Add clear OS params options in gnt-instance modify

This patch adds two new options in 'gnt-instance modify' which allow the user to clear all current public/private OS parameters of an instance. This might be useful for OS providers that consider no parameters as valid or, more commonly, for changing OS provider (and parameters) before performing

[PATCH master 6/6] Add OS params removal in gnt-instance reinstall

This patch adds '--remove-os-parameters' and '--remove-os-parameters-private' options to 'gnt-instance reinstall'. Similarly to 'gnt-instance modify', the new options can be used to perform reinstalls to OS providers that support different parameters. E.g.: $ gnt-instance reinstall

[PATCH master 3/6] Add cmdlib tests for removing instance OS params

From: Nikos Skalkotos Add LUInstanceSetParams tests for removing individual public & private parameters, as well as, for clearing out public & private parameters. Signed-off-by: Nikos Skalkotos Signed-off-by: Yiannis Tsiouris ---

[PATCH master 5/6] Support clear OS params in gnt-instance reinstall

This extends 'gnt-instance reinstall' to support '--clear-os-parameters' and '--clear-os-parameters-private' options from 'gnt-instance modify'. E.g.: $ gnt-instance reinstall --clear-os-parameters -o \ -O param1=val1,param2=val2 or $ gnt-instance reinstall --clear-os-parameters-private \

[PATCH master 4/6] Test new options of gnt-instance modify in RAPI

This patch adds tests to RAPI for gnt-instance modify options: - '--clear-os-parameters'/'--clear-os-parameters-private' - '--remove-os-parameters'/'--remove-os-parameters-private' Signed-off-by: Yiannis Tsiouris --- test/py/ganeti.rapi.rlib2_unittest.py | 73