Re: Merge branch 'stable-2.17' into master

LGTM, thanks On Thu, 4 Feb 2016 at 12:49 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > > commit ab46b54a227278600e5a31d63ff0da8d901820e6 > Merge: cefe382 141a836 > Author: Klaus Aehlig > Date: Thu Feb 4 12:44:52 2016 +0100 > > Merge branch

Re: [PATCH stable-2.17] Update design doc of node security

to the cluster config that would 'freeze' the ``master_capable`` state of nodes. This turned On Wed, 3 Feb 2016 at 14:10 Hrvoje Ribicic <r...@google.com> wrote: > Nitpicks, else LGTM. > > On Fri, Jan 29, 2016 at 1:07 PM, 'Helga Velroyen' via ganeti-devel < > ganeti-devel@go

Re: [PATCH master] Depend Arbitrary (Map k a) instance on QuickCheck version

LGTM, thanks On Wed, 3 Feb 2016 at 16:50 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > QuickCheck version 2.8.2 newly introduced an Arbitrary instance > for Maps. As this instance was not present in earlier versions > of QuickCheck, we have it in our TestCommon module

[PATCH stable-2.17] Update design doc of node security

This patch updates the design doc of Ganeti's node security. It turned out that the solution of freezing master capability is not feasible. This patch explains the reasons and the alternative considered. Signed-off-by: Helga Velroyen --- doc/design-node-security.rst | 55

Re: [PATCH stable-2.15] Do not add a new Inotify watchers on timer

On Thu, 28 Jan 2016 at 18:49 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Ganeti updates its in-memory copy of the configuration in several ways. > One of them is by using an inotify, the other is by periodically, in the > order of seconds, polling the file. On the

[PATCH stable-2.15] Mock InitDrbdHelper's output in unittests

The output of the InitDrbdHelper function was cluttering up the unit tests. Let's mock that output in tests. Signed-off-by: Helga Velroyen --- lib/client/gnt_cluster.py | 6 +++--- test/py/ganeti.client.gnt_cluster_unittest.py | 14 +- 2 files

Re: [PATCH stable-2.16 1/2] Update NEWS file for 2.16.0 beta2

LGTM, thanks On Thu, 28 Jan 2016 at 10:58 'Viktor Bachraty' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Update both major and minor changes since beta 1 including changes > inherited from older branches. > > Signed-off-by: Viktor Bachraty > --- > NEWS | 122

Re: [PATCH stable-2.16 1/2] Update NEWS file for 2.16.0 beta2

On Wed, 27 Jan 2016 at 20:50 'Viktor Bachraty' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Update both major and minor changes since beta 1 including changes > inherited from older branches. > > Signed-off-by: Viktor Bachraty > --- > NEWS | 118 >

Re: [PATCH stable-2.16 2/2] Bump version suffix to 2.16.0 beta2

LGTM, thanks On Wed, 27 Jan 2016 at 20:50 'Viktor Bachraty' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Signed-off-by: Viktor Bachraty > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac

Re: [PATCH stable-2.17] Fix window size in CPU collector

LGTM, thanks On Thu, 28 Jan 2016 at 12:00 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > When determining which observations to take for computing the node load, > only keep those that happened after the beginning of the current window, > not those that happened after

Re: [PATCH stable-2.16] Update NEWS file for 2.16.0~beta2

On Wed, 27 Jan 2016 at 17:23 'Viktor Bachraty' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Mention all more significant changes since 2.16.0~beta1. > > Signed-off-by: Viktor Bachraty > --- > NEWS | 469 >

[PATCH stable-2.17] This is a test, ignore me

Ignore me! Helga Velroyen (1): This is a test, ignore me NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.0.rc3.207.g0ac5344

[PATCH stable-2.17] This is a test, ignore me

Signed-off-by: Helga Velroyen --- NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS b/NEWS index ebef168..65f 100644 --- a/NEWS +++ b/NEWS @@ -10,7 +10,7 @@ Version 2.17.0 alpha1 Incompatible/important changes ~~

Re: [MERGE] Merge branch 'stable-2.15' into stable-2.16

LGTM On Fri, Jan 22, 2016, 1:53 PM 'Hrvoje Ribicic' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > commit 5bfbbd76a6810d035efb2ea2ad3ece74ea2f07df > Merge: dd6f11c 4b7cd46 > Author: Hrvoje Ribicic > Date: Fri Jan 22 13:52:50 2016 +0100 > > Merge branch

Re: [MERGE] Merge branch 'stable-2.14' into stable-2.15

LGTM, thanks On Fri, 22 Jan 2016 at 13:32 'Hrvoje Ribicic' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > commit 0943565956b20980fa56d40fd1e942de7588c4a0 > Merge: 56ffa79 115325f > Author: Hrvoje Ribicic > Date: Fri Jan 22 12:26:07 2016 +0100 > > Merge branch

[PATCH stable-2.17] Rearrange line-break to satisfy lint

Signed-off-by: Helga Velroyen --- test/py/testutils_ssh.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/py/testutils_ssh.py b/test/py/testutils_ssh.py index 34e9d85..fa3b35d 100644 --- a/test/py/testutils_ssh.py +++ b/test/py/testutils_ssh.py @@

Re: [PATCH master 2/3] Provide alternative to decompressWithErrors in zlib 6.0

On Wed, 20 Jan 2016 at 16:10 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > For decompression with proper error handling, Ganeti used to use > the function decompressWithErrors. This function, however, does not > exist any more in zlib 6.0 and higher. Therefore provide

Re: [PATCH master 3/3] Increase supported range for zlib

LGTM, thanks On Wed, 20 Jan 2016 at 16:10 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > ...now that we have all the infrastructure in place to support > those zlib until 0.6.1.1. > > Signed-off-by: Klaus Aehlig > --- > cabal/ganeti.template.cabal

Re: [PATCH master 1/3] Increase version range of some Haskell dependencies

On Wed, 20 Jan 2016 at 16:10 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > ...after verifying that Ganeti works properly with the > newer dependencies. > > Signed-off-by: Klaus Aehlig > --- > cabal/ganeti.template.cabal | 10 +- > 1 file

Re: [PATCH stable-2.17 3/9] RenewCrypto: do not consult public key file

On Wed, 20 Jan 2016 at 11:09 Klaus Aehlig <aeh...@google.com> wrote: > On Tue, Jan 19, 2016 at 04:15:01PM +0100, 'Helga Velroyen' via > ganeti-devel wrote: > > There is a bug in the current implementation of > > backend.RenewCrypto. Before re-generating keys, it check

Re: [PATCH stable-2.16 3/3] Document the increased timeout as an incompatible change

LGTM, thanks On Wed, 20 Jan 2016 at 12:31 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > While the timeout for communication with luxid is mainly > an internal parameter, it also changes which response time > for Ganeti tools is still to be considered normal. Hence >

Re: [PATCH stable-2.16 1/3] Do not repeat constants in comments

LGTM, thanks On Wed, 20 Jan 2016 at 12:30 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > ...as this works against the idea of having all constants in one > central place so that they can be changed in a simple way. > > Signed-off-by: Klaus Aehlig >

Re: [PATCH stable-2.16 2/3] Increase timeouts for luxi by a factor of 3

LGTM, thanks On Wed, 20 Jan 2016 at 12:31 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > While sending answers lazily as Strings has reduced memory footprint > by over an order of magnitude, it seems that answer times have gotten > slower. Accept this trade off

Re: [PATCH master] Remove gnt-cluster verify --dry-run flag

LGTM, thanks On Tue, 19 Jan 2016 at 11:20 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > It did nothing useful, was undocumented, and caused VerifyCluster to > raise a TypeError. > > Signed-off-by: Brian Foley > --- > lib/client/gnt_cluster.py | 3

Re: [PATCH master] Remove superfuous warnings about storage types

Hi! you are right, I think I mistook this with similar bug. LGTM to your code then! Cheers, Helga On Mon, 18 Jan 2016 at 13:07 Viktor Bachraty wrote: > Sorry, didn't hit reply to all. > > On Mon, Jan 18, 2016 at 11:00 AM, Viktor Bachraty > wrote:

[PATCH stable-2.17 7/9] Make backend.RenewCrypto more testable

In order to improve the testability of backend.RenewCrypto, this patch does two things: * It uses the previously introduced SSH utility functions. Those are easier to consistently mock during unit tests and they consistenly abstract the lower layer of file operations on SSH keys. * When

[PATCH stable-2.17 3/9] RenewCrypto: do not consult public key file

There is a bug in the current implementation of backend.RenewCrypto. Before re-generating keys, it checks if the current key of each node is in the Ganeti public key file. This was intended as a security feature, but actually does not work like that. The Ganeti public key file does only contain

[PATCH stable-2.17 8/9] SSH testutils: GetKeyOfNode

This adds a little utility function to ask the SSH file manager for a key of one particular node. This patch also updates some documentation of the previous function. Signed-off-by: Helga Velroyen --- test/py/testutils_ssh.py | 13 + 1 file changed, 13

[PATCH stable-2.17 1/9] Fix TestDetermineKeyBits

The test never ran, because it did not inherit from a test case class. This patch fixes that and all nits that made the tests fail. Signed-off-by: Helga Velroyen --- test/py/ganeti.ssh_unittest.py | 27 ++- 1 file changed, 14 insertions(+), 13

[PATCH stable-2.17 0/9] Unittest for renew-crypto

This patch series eventually adds a unit test for renew-crypto. The patches before that add various test utilities and refactor code in order to make it more testable. It also fixes some bugs on the way. Helga Velroyen (9): Fix TestDetermineKeyBits SSH testutils: function to return all node

[PATCH stable-2.17 4/9] SSH utility functions for key manipulation

So far, the backend code contains a lot of (repetitive) code to manipulate SSH keys on the local disk. This patch adds utility functions for those basic operations and also includes unit tests for those. In the later patches of this series, those functions will be used to simplify the code and

[PATCH stable-2.17 2/9] SSH testutils: function to return all node UUIDs

This patch adds a utility function to the SSH test utilities which returns all UUIDs of all nodes that the file manager is aware of. Signed-off-by: Helga Velroyen --- test/py/testutils_ssh.py | 8 1 file changed, 8 insertions(+) diff --git a/test/py/testutils_ssh.py

[PATCH stable-2.17 9/9] Unit test for backend.RenewCrypto

This patch adds a unit test for the successful execution of backend.RenewCrypto. It mostly reuses infrastructure from the unit tests for adding and removing SSH keys. Signed-off-by: Helga Velroyen --- test/py/ganeti.backend_unittest.py | 74

[PATCH stable-2.17 5/9] Remove _ReplaceMasterKeyOnMaster

The somewhat cumbersome function _ReplaceMasterKeyOnMaster is replaced with one of the ssh utility functions provied in the previous patches. Signed-off-by: Helga Velroyen --- lib/backend.py | 30 ++ 1 file changed, 2 insertions(+), 28 deletions(-)

Re: [PATCH master] Remove superfuous warnings about storage types

Generally, this looks, good, but I think there is the following problem: This works in the way that when the cluster is initialized and file-storage is not enabled, that then the directory is set properly. However, it is possible to init the cluster with file storage (and setting the dir), but

Re: Merge branch 'stable-2.12' into stable-2.13

LGTM, thanks On Thu, 14 Jan 2016 at 14:11 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > > > commit b5cfcef24f318092c87a16266c74b26bf69d7c08 > Merge: de78491 7b8b411 > Author: Klaus Aehlig > Date: Thu Jan 14 14:07:02 2016 +0100 > > Merge

Re: Merge branch 'stable-2.13' into stable-2.14

LGTM, thanks On Thu, 14 Jan 2016 at 18:04 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > > > commit e48ca3f734cfcadc056edb7b6ec7bdc40bed2e7f > Merge: 216e20b 2cd22ad > Author: Klaus Aehlig > Date: Thu Jan 14 18:01:17 2016 +0100 > > Merge

Re: [PATCH stable-2.13] Run ssh-key renewal in debug mode during upgrade

LGTM, thanks On Thu, 14 Jan 2016 at 15:25 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > As errors during an upgrade of Ganeti are harder to > understand, as two versions of Ganeti are involved, > provide more debug information for everything that happens > during that

Re: [PATCH stable-2.12 1/3] Unconditionally log upgrades at debug level

On Tue, 12 Jan 2016 at 14:02 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Cluster upgrades to a new minor version of Ganeti are a rare > operation (in fact, new minor versions are released only every > 3 months). Therefore, we do not have to worry, about increased >

Re: [PATCH stable-2.12 3/3] Also log the high-level upgrade steps

On Tue, 12 Jan 2016 at 14:02 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > The upgrade of a Ganeti cluster is done in several > high-level steps ("Draining queue", "Pausing the watcher", > "Stopping daemons", ...). Log those headings as well in > order to simplify

Re: [PATCH stable-2.12 2/3] Run renew-crypto in upgrades in debug mode

On Tue, 12 Jan 2016 at 14:02 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > As errors during an upgrade of Ganeti are harder to > understand, as two versions of Ganeti are involved, > provide more debug information for everything that happens > during that process. Note

[PATCH stable-2.17 2/4] Introduce HooksAbortCallBack

There is currently no way to clean up anything after (pre) hooks failed. LUs have a hook that is called after the hooks finish successfully, but any exception that aborts the hook execution is bubbled up till mcpu and then ignored. This patch introduces another callback called

[PATCH stable-2.17 3/4] Light-weight SSH key removal

This patch adds an RPC call, which is a very light-weight version of removing an SSH key from the cluster. It simply only removes it from the public key file of the master. This is used later to clean up in case the pre-hooks for adding a node fail. When adding a node with 'gnt-node add', the

[PATCH stable-2.17 1/4] Add useful hints to hooks documentation

Our documentation about hooks is lacking some useful hints for people setting up hooks for the first time. This patch adds the information that was otherwise only available from reading the code or the mailinglist's archive. Signed-off-by: Helga Velroyen --- doc/hooks.rst |

Re: [PATCH stable-2.12 3/4] Add function to provide logged user feedback

LGTM, thanks On Tue, 12 Jan 2016 at 16:11 Klaus Aehlig wrote: > On Tue, Jan 12, 2016 at 03:02:30PM +, Helga Velroyen wrote: > > LGTM, thanks > > I'd like to add the following interdiff to this patch, that also exports > the function from this module. > > diff --git

Re: [PATCH stable-2.12 4/4] Also log the high-level upgrade steps

LGTM, thanks On Tue, 12 Jan 2016 at 16:00 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > The upgrade of a Ganeti cluster is done in several > high-level steps ("Draining queue", "Pausing the watcher", > "Stopping daemons", ...). Log those headings as well in > order to

Re: [PATCH stable-2.12 3/4] Add function to provide logged user feedback

LGTM, thanks On Tue, 12 Jan 2016 at 16:00 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Add a utility function that provides feedback to the > user on stdout that is additionally logged (at INFO level) > in the log file. > > Signed-off-by: Klaus Aehlig

[PATCH stable-2.17 0/4] Clean up SSH setup after hooks failure

This fixes issue 1033. After a failed execution of hooks during a node-add operation, a stray SSH key was left on the master. This was not trivial to solve and thus this patch series does it in these steps: - Introduce a callback to LUs that is called in case the preparation hooks fail. -

[PATCH stable-2.17 4/4] Clean up after failed node-add-pre hooks

If the pre hooks of a node adding operation fail, so far a stray key of the node to be added was left on the master node. This patch makes sure it is cleaned up in case of a hook failure. Signed-off-by: Helga Velroyen --- lib/cmdlib/node.py | 18 ++ 1 file

Re: [PATCH stable-2.12 1/4] Fix outdated comment

LGTM, thanks On Fri, 8 Jan 2016 at 15:06 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Commit 5e641d0a introduced also counting the vote of > the node itself. Adapt the parameter description > accordingly. > > Signed-off-by: Klaus Aehlig > --- >

Re: [PATCH stable-2.12 3/4] Check for healthy majority on master failover with voting

On Fri, 8 Jan 2016 at 15:06 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > The normal procedure for a master failover is that, after telling > each node the new master, the daemons on the new master node are > started the standard way, i.e., with voting. This, however,

Re: [PATCH stable-2.12 4/4] Document healthy-majority restriction on master-failover

On Fri, 8 Jan 2016 at 15:06 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > The previous patch introduced a behavioral change for master-failover: > it is rejected unless a majority of nodes is healthy or the --no-voting > option is given. (While we in general do not

Re: [PATCH stable-2.12 2/4] Add a predicate testing that a majority of nodes is healthy

On Fri, 8 Jan 2016 at 15:06 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > For standard master failover (with voting), it is necessary > that the majority of nodes is still reachable and can answer > questions about which node is master. Add a predicate verifying > that

[PATCH stable-2.17 2/2] Introduce backoff to RetryByNumberOfTimes

This patch adds a backing-off mechanism to the function RetryByNumberOfTimes. This is useful for example when SSH connections fail in a flaky network. The original version of RetryByNumberOfTimes immediately retried failed SSH calls, but that might not be enough to recover from a network problem.

[PATCH stable-2.17 1/2] Unit tests for RetryByNumberOfTimes

As this patch series will alter the behavior of the function RetryByNumberOfTimes, we first add a few unit tests to ensure we don't break anything. Signed-off-by: Helga Velroyen --- test/py/ganeti.utils.retry_unittest.py | 42 ++ 1 file

[PATCH stable-2.17 0/2] Add backoff mechanism to SSH calls

This is a mini patch series which adds a backing off mechanism to SSH calls that are made in the backend. This is supposed to increase the reliability of those calls as they now give the network a bit more time to recover before retrying a call. Helga Velroyen (2): Unit tests for

[PATCH stable-2.15 2/3] Fix renew-crypto on one-node-cluster

There was a bug which made 'gnt-cluster renew-crypto' crash if it is a one-node cluster. This patch fixes it by checking if there are any non-master nodes to update at all. Signed-off-by: Helga Velroyen Reviewed-by: Klaus Aehlig --- lib/backend.py

[PATCH stable-2.15 1/3] ssh_update: log data that is received

Debugging ssh_update can be annoying, because the data used as input is not dumped anywhere. This patch logs makes sure it gets logged (at DEBUG level) when ssh_update receives the data. Signed-off-by: Helga Velroyen Reviewed-by: Klaus Aehlig ---

[PATCH stable-2.15 0/3] Picking SSH cherries

This is a mini patch series which exclusively composed from patches that are already part of the patch series 'Make SSH updates more transparent', which was submitted to 2.17. The patches I cherry-picked here are the ones that provide useful functionality (fixing bugs, increasing debug

[PATCH stable-2.15 0/3] Picking SSH cherries

This is a mini patch series which exclusively composed from patches that are already part of the patch series 'Make SSH updates more transparent', which was submitted to 2.17. The patches I cherry-picked here are the ones that provide useful functionality (fixing bugs, increasing debug

Re: [PATCH stable-2.15 0/3] Picking SSH cherries

Alright, will resend the entire series. Shall I assume LGTM for all, or do you want to have another look on each of them? On Fri, 8 Jan 2016 at 14:13 Klaus Aehlig wrote: > > This is a mini patch series which exclusively composed > > from patches that are already part of the

[PATCH stable-2.15 2/3] Fix renew-crypto on one-node-cluster

There was a bug which made 'gnt-cluster renew-crypto' crash if it is a one-node cluster. This patch fixes it by checking if there are any non-master nodes to update at all. Signed-off-by: Helga Velroyen Reviewed-by: Klaus Aehlig Cherry-picked-from:

[PATCH stable-2.15 1/3] ssh_update: log data that is received

Debugging ssh_update can be annoying, because the data used as input is not dumped anywhere. This patch logs makes sure it gets logged (at DEBUG level) when ssh_update receives the data. Signed-off-by: Helga Velroyen Reviewed-by: Klaus Aehlig

[PATCH stable-2.15 3/3] Catch IOError of SSH files when removing node

This patch catches an IOError when a node is removed from a cluster and the SSH files of the node are messed up. Previously, this caused the removal to fail, which is not exactly what you want when removing a messed up node. Signed-off-by: Helga Velroyen Reviewed-by: Klaus

[PATCH stable-2.16] Fix typo 'option' instead of 'options'

Signed-off-by: Helga Velroyen --- NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 1bf7d93..a6c9803 100644 --- a/NEWS +++ b/NEWS @@ -10,7 +10,7 @@ Version 2.16.0 beta2 Incompatible/important changes ~~

Re: Merge 'stable-2.15' into 'stable-2.16'

Thanks, will send a separate patch for the nit. On Mon, 4 Jan 2016 at 17:34 Hrvoje Ribicic <r...@google.com> wrote: > LGTM - the nit might be better removed in a separate patch though. > > On Mon, Jan 4, 2016 at 5:11 PM, 'Helga Velroyen' via ganeti-devel < > ganeti-devel@go

Merge 'stable-2.16' to 'stable-2.17'

commit 0d10936ea1741b381583dc1a03aac4816f3b6014 Merge: cd0db80 23503ae Author: Helga Velroyen Date: Tue Jan 5 11:13:22 2016 +0100 Merge branch 'stable-2.16' into stable-2.17 * stable-2.16 Fix typo 'option' instead of 'options' Fix error message in

Re: [PATCH stable-2.15] After TestNodeModify, fix the pool of master candidates

LGTM, thanks On Tue, 22 Dec 2015 at 14:10 'Klaus Aehlig' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > The test TestNodeModify temporarily modifies the cluster parameter > candidate-pool-size, which controls the minimal desirable number of > master candidates. Depending on the size

Re: [PATCH stable-2.12] Fix documentation for master-failover

LGTM, thanks On Mon, 4 Jan 2016 at 14:22 'Hrvoje Ribicic' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > The gnt-cluster manual still specified that arguments should be passed > to the master daemon - one which no longer exists. This patch specifies > the two new daemons to which

Re: Merge 'stable-2.15' into 'stable-2.16'

On Mon, 4 Jan 2016 at 17:11 Helga Velroyen wrote: > commit 1f87aa036cd887e15240415d73c5ea5fc5b2e18a > Merge: ceb09b5 625c8ea > Author: Helga Velroyen > Date: Mon Jan 4 17:07:50 2016 +0100 > > Merge branch 'stable-2.15' into stable-2.16 > > *

Merge 'stable-2.15' into 'stable-2.16'

commit 1f87aa036cd887e15240415d73c5ea5fc5b2e18a Merge: ceb09b5 625c8ea Author: Helga Velroyen Date: Mon Jan 4 17:07:50 2016 +0100 Merge branch 'stable-2.15' into stable-2.16 * stable-2.15 Add more documentation to testutils_ssh.py renew-crypto: use

Re: [PATCH stable-2.15 6/8] Bulk-removing SSH keys of diverse set of nodes

, a normal node, then again a master candidate, etc. On Wed, 2 Dec 2015 at 19:09 Lisa Velden <vel...@google.com> wrote: > On Tue, Nov 24, 2015 at 3:15 PM, 'Helga Velroyen' via ganeti-devel < > ganeti-devel@googlegroups.com> wrote: > >> This patch adds a unit test w

Re: [PATCH] Always pass node uuids but not node names to hooksmaster

LGTM, thanks On Tue, 1 Dec 2015 at 12:24 Oleg Ponomarev wrote: > Sorry, but there should be one more interdiff. The last one:) > > --- a/lib/cmdlib/node.py > +++ b/lib/cmdlib/node.py > @@ -1595,7 +1595,7 @@ class LUNodeRemove(LogicalUnit): >

[PATCH stable-2.15 9/8] Add more documentation to testutils_ssh.py

This patch adds more comments to the functions in testutils_ssh.py, in particular to clarify which function returns what types of objects. Signed-off-by: Helga Velroyen --- test/py/testutils_ssh.py | 43 ++- 1 file changed, 42

Re: [PATCH stable-2.15 9/8] Add more documentation to testutils_ssh.py

FYI, I'd like to add this to my previous patch series (bulk-removing SSH keys). On Tue, 1 Dec 2015 at 16:23 Helga Velroyen wrote: > This patch adds more comments to the functions in > testutils_ssh.py, in particular to clarify which function > returns what types of objects. >

Re: [PATCH stable-2.15 2/8] testutils: add keys to own 'authorized_keys' file

On Fri, 27 Nov 2015 at 15:54 Hrvoje Ribicic <r...@google.com> wrote: > On Tue, Nov 24, 2015 at 3:15 PM, 'Helga Velroyen' via ganeti-devel < > ganeti-devel@googlegroups.com> wrote: > >> This patch updates the SSH testutils to match reality better. >> So far, th

Re: [PATCH stable-2.15 3/8] Bulk-removal of SSH keys

On Fri, 27 Nov 2015 at 16:24 Lisa Velden <vel...@google.com> wrote: > On Tue, Nov 24, 2015 at 3:15 PM, 'Helga Velroyen' via ganeti-devel < > ganeti-devel@googlegroups.com> wrote: > >> In order to improve the runtime complexity of >> 'renew-crypto', this patch adds

Re: [PATCH stable-2.15 1/8] Make mock SSH file manager deal with lists

+list On Fri, 27 Nov 2015 at 14:46 Lisa Velden <vel...@google.com> wrote: > On Tue, Nov 24, 2015 at 3:15 PM, 'Helga Velroyen' via ganeti-devel < > ganeti-devel@googlegroups.com> wrote: > >> There was a subtle bug in the unit test of backend.py >> which was maski

Re: [PATCH] Always pass node uuids but not node names to hooksmaster

LGTM, thanks On Fri, 27 Nov 2015 at 16:29 Oleg Ponomarev wrote: > In the initial patch, local hooks were forgotten. > > Thus, please consider the following interdiff: > > diff --git a/lib/backend.py b/lib/backend.py > index bd638a3..a8d4170 100644 > --- a/lib/backend.py >

Re: [PATCH master 12/12] Add unit tests for global hooks

On Thu, 26 Nov 2015 at 23:20 'Oleg Ponomarev' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > The tests check the following: > - global hooks should be run on the master node even in case of empty > nodes list; > - global hooks should be run on the master node separately from >

Re: [PATCH stable-2.14] Fix lines with more than 80 characters

LGTM, thanks On Fri, 27 Nov 2015 at 11:31 'Lisa Velden' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Previous refactoring has introduced lines with too many characters. > This patch fixes this. > > Signed-off-by: Lisa Velden > --- >

Re: [PATCH] Always pass node uuids but not node names to hooksmaster

LGTM, thanks On Wed, 25 Nov 2015 at 14:10 'Oleg Ponomarev' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Currently hooksmaster is able to deal with both uuids and names. > While uuids are passed in most cases, the node list uses the legacy > naming *node_names* inside the

[PATCH stable-2.15 3/8] Bulk-removal of SSH keys

In order to improve the runtime complexity of 'renew-crypto', this patch adds a function to bulk-remove SSH keys of nodes (in contrast to the function that only removes one key at a time). Within this patch, it is only called in a unit test. Further patches will integrate and test it further.

[PATCH stable-2.15 1/8] Make mock SSH file manager deal with lists

There was a subtle bug in the unit test of backend.py which was masking another subtle bug in the test framework in testutils_ssh.py. As relict from some previous refactoring, the ssh.py functions assume that there can be more than one public key per node. The testutils so far assume there is

[PATCH stable-2.15 7/8] Use bulk-removal of SSH keys for single keys

As the code for bulk-removal of SSH keys subsumes the code for removing a single SSH key, let the latter call the first. Signed-off-by: Helga Velroyen --- lib/backend.py | 182 + 1 file changed, 16 insertions(+), 166

[PATCH stable-2.15 5/8] Bulk-removal of SSH keys of normal nodes

This patch adds a unit test for bulk-removing normal nodes. Besides that, it fixes a small bug that surfaced with that test. Signed-off-by: Helga Velroyen --- lib/backend.py | 2 +- test/py/ganeti.backend_unittest.py | 31 +++

[PATCH stable-2.15 2/8] testutils: add keys to own 'authorized_keys' file

This patch updates the SSH testutils to match reality better. So far, the test framework did not consider the fact that the key of each node should be added to it's own 'authorized_keys' file, even if the node is not a master candidate. This patch fixes that to represent the production behavior

[PATCH stable-2.15 4/8] Bulk-remove SSH keys of potential master candidates

This patch adds a unit test for bulk-removing potential master candidates. Signed-off-by: Helga Velroyen --- test/py/ganeti.backend_unittest.py | 31 +++ 1 file changed, 31 insertions(+) diff --git a/test/py/ganeti.backend_unittest.py

[PATCH stable-2.15 0/8] Introduce bulk-removing of SSH keys

This patch series introduces a backend function for bulk-removing SSH keys from the cluster. This is useful to reduce the run-time complexity of renew-crypto from quadratic to linear as no longer each key is removed individually. This patch series is composed similarly to the one for

[PATCH stable-2.15 8/8] renew-crypto: use bulk-removal of SSH keys

This patch makes renew-crypto use the newly introduced bulk-removal function for SSH keys. This way the complexity of renew-crypto (in terms of number of SSH connections) becomes linear (from previously quadratic). Signed-off-by: Helga Velroyen --- lib/backend.py | 37

[PATCH stable-2.15 6/8] Bulk-removing SSH keys of diverse set of nodes

This patch adds a unit test where SSH keys of a diverse set of nodes is removed. By 'diverse', we mean a set consisting of master candidates, potential master candidates, and normal nodes. It also fixes some minor bug that surfaced with that test. Signed-off-by: Helga Velroyen

Re: [PATCH stable-2.16 09/18] Use the SSH key parameters when generating keys

LGTM, thanks On Fri, 20 Nov 2015 at 10:59 'Hrvoje Ribicic' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > This patch makes sure that the parameters introduced in previous > patches propagates wherever SSH keys are generated and used, allowing > Ganeti to use different types of SSH

Merge 'stable-2.15' into 'stable-2.16'

commit 2df3a2c59dc677a4a2dbe7a9fae2e6341d1d Merge: 2ebf4e8 598897c Author: Helga Velroyen Date: Fri Nov 20 11:34:44 2015 +0100 Merge branch 'stable-2.15' into stable-2.16 * stable-2.15 Document the decission why optimisation is turned off Don't keep

Re: [PATCH stable-2.16 06/18] Add modify_ssh_setup to queryable config params

LGTM, thanks On Fri, 20 Nov 2015 at 10:59 'Hrvoje Ribicic' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > As this will be necessary for checking whether to create the > ganeti_pub_keys file. > > Signed-off-by: Hrvoje Ribicic > --- > src/Ganeti/Query/Server.hs | 4

Re: [PATCH stable-2.16 04/18] Show info about new params in gnt-cluster info

LGTM, thanks On Fri, 20 Nov 2015 at 10:59 'Hrvoje Ribicic' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > With this patch, gnt-cluster info shows both the ssh key type and the > key length. > > Signed-off-by: Hrvoje Ribicic > --- > lib/client/gnt_cluster.py | 2 ++

Merge 'stable-2.15' to 'stable-2.16' (2nd try)

commit 8337653769f617abfe39876d7cb794d68064ab13 Merge: 2ebf4e8 598897c Author: Helga Velroyen Date: Fri Nov 20 11:34:44 2015 +0100 Merge branch 'stable-2.15' into stable-2.16 * stable-2.15 Document the decission why optimisation is turned off Don't keep

Re: Merge 'stable-2.15' into 'stable-2.16'

On Fri, 20 Nov 2015 at 14:00 Oleg Ponomarev <oponoma...@google.com> wrote: > LGTM, but I still have two remarks: > > On 11/20/2015 01:42 PM, 'Helga Velroyen' via ganeti-devel wrote: > > backend.py > > > --logging.debug("Add ssh key of node '%s'.", nod

Re: [PATCH stable-2.16 08/21] Do not generate the ganeti_pub_keys file with --no-ssh-init

LGTM, thanks On Thu, 19 Nov 2015 at 16:07 Hrvoje Ribicic wrote: > Adding interdiff to fix the test failures present at this patch time: > > diff --git a/test/py/ganeti.client.gnt_cluster_unittest.py b/test/py/ > ganeti.client.gnt_cluster_unittest.py > index be28eb2..595864a

Re: [PATCH stable-2.16 14/15] QA: Add ssh-key-type and -bits tests

LGTM with that interdiff. Thanks. On Thu, 19 Nov 2015 at 13:56 Hrvoje Ribicic wrote: > Interdiff to make things work on the vcluster: > > diff --git a/qa/qa_cluster.py b/qa/qa_cluster.py > index fbb90d0..ec0d367 100644 > --- a/qa/qa_cluster.py > +++ b/qa/qa_cluster.py > @@

Re: [PATCH stable-2.16 05/21] Add helper function for querying cluster properties

LGTM, thanks. On Thu, 19 Nov 2015 at 14:05 'Hrvoje Ribicic' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > As more and more configuration values will have to be made available via > queries, this patch adds a small helper method for these. > > Signed-off-by: Hrvoje Ribicic

  1   2   3   4   5   6   7   8   9   10   >