Thanks Brian and Iustin for the review.
I've successfully pushed this to 2.15 after addressing some of Brian's
comments (as discussed offline).
Cheers,
Morg.
On Friday, December 2, 2016 at 12:21:23 PM UTC, Brian Foley wrote:
>
> On Fri, Dec 02, 2016 at 11:20:53AM +, 'Federico Morg Pareschi'
On Fri, Dec 02, 2016 at 11:20:53AM +, 'Federico Morg Pareschi' via
ganeti-devel wrote:
> Following issue #1194, this patch allows Ganeti to correctly
> parse drbd versions that also include a dash in their k-fix
> version component.
>
> This technically makes Ganeti treat x.y.z.k the same as
Following issue #1194, this patch allows Ganeti to correctly
parse drbd versions that also include a dash in their k-fix
version component.
This technically makes Ganeti treat x.y.z.k the same as x.y.z-k
with regards to compatibility. For practicality we can assume that
these versions are the same
On Thu, Dec 01, 2016 at 04:09:56AM -0800, Ganeti Development List wrote:
>
> On Thursday, December 1, 2016 at 11:53:43 AM UTC, Iustin Pop wrote:
> >
> > On Thu, Dec 01, 2016 at 11:38:35AM +, Ganeti Development List wrote:
> > > Following issue #1194, this patch allows Ganeti to correctly
> >
On Thursday, December 1, 2016 at 11:53:43 AM UTC, Iustin Pop wrote:
>
> On Thu, Dec 01, 2016 at 11:38:35AM +, Ganeti Development List wrote:
> > Following issue #1194, this patch allows Ganeti to correctly
> > parse drbd versions that also include a dash in their k-fix
> > version component
On Thu, Dec 01, 2016 at 11:38:35AM +, Ganeti Development List wrote:
> Following issue #1194, this patch allows Ganeti to correctly
> parse drbd versions that also include a dash in their k-fix
> version component.
This means 8.4.8-1 and 8.4.8.1 will be treated the same. Is this the
correct be
Following issue #1194, this patch allows Ganeti to correctly
parse drbd versions that also include a dash in their k-fix
version component.
Signed-off-by: Federico Morg Pareschi
---
lib/storage/drbd_info.py| 17 +++--
test/py/ganeti.storage.drbd_unittest.py | 10 +