Re: [Ganglia-developers] [patch] change privateclusters auth header to include clustername

2008-03-06 Thread Martin Knoblauch
Hi Ramon, looks harmless enough. Could you make a similar patch against trunk please? From my side +1 for both trunk and 3.0.X Cheers Martin -- Martin Knoblauch email: k n o b i AT knobisoft DOT de www: http://www.knobisoft.de -

Re: [Ganglia-developers] [patch] change privateclusters auth header to include clustername

2008-03-06 Thread Ramon Bastiaans
Oh and you also can't open 2 private clusters at the same time in 1 browser (different tabs) without this patch. Ramon Bastiaans wrote: Hi, I've made a little patch to the webfrontend of 3.0.7. The problem is that Ganglia always says Ganglia Private Cluster, for ALL private clusters in the

Re: [Ganglia-developers] [patch] change privateclusters auth header to include clustername

2008-03-06 Thread Ramon Bastiaans
Hi Martin, The patch should also work with trunk (justed tested), seems that code hasn't changed much.. ;) - Ramon. Martin Knoblauch wrote: Hi Ramon, looks harmless enough. Could you make a similar patch against trunk please? From my side +1 for both trunk and 3.0.X Cheers Martin

Re: [Ganglia-developers] [patch] change privateclusters auth header to include clustername

2008-03-06 Thread Martin Knoblauch
Hi Ramon, unless someone beats me, I will check it into trunk later today. For 3.0.X we need more votes :-) Cheers Martin -- Martin Knoblauch email: k n o b i AT knobisoft DOT de www: http://www.knobisoft.de - Original Message

Re: [Ganglia-developers] [patch] change privateclusters auth headerto include clustername

2008-03-06 Thread Brad Nicholes
-1 for now. The concern that I have is that by injecting the name of the cluster as it is pulled from the query string, seems a little dangerous. This would allow the realm to be altered in any way by just modifying the query string. Not sure if that is a real issue or not, but it seems

Re: [Ganglia-developers] [patch] change privateclusters auth headerto include clustername

2008-03-06 Thread Martin Knoblauch
Hi, what was the exact process? We need +2 for checkins into both trunk and 3.0.x, or just 3.0.x? For now I will abstain from checking Ramons patch into trunk. Cheers Martin -- Martin Knoblauch email: k n o b i AT knobisoft DOT de www:

Re: [Ganglia-developers] [patch] change privateclusters authheaderto include clustername

2008-03-06 Thread Brad Nicholes
So the process is outlined here: Proposing a patch for backport (http://ganglia.wiki.sourceforge.net/ganglia_works) . We need 2 +1's with no -1's in order to approved a patch for backport. We haven't started using the STATUS file yet for tracking backport proposals, but we should start

Re: [Ganglia-developers] [patch] change privateclusters auth headerto include clustername

2008-03-06 Thread Jesse Becker
On Thu, Mar 6, 2008 at 10:57 AM, Brad Nicholes [EMAIL PROTECTED] wrote: -1 for now. The concern that I have is that by injecting the name of the cluster as it is pulled from the query string, seems a little dangerous. This would allow the realm to be altered in any way by just modifying