Re: [Ganglia-developers] Stacked Graphs

2008-06-30 Thread Bernard Li
On Thu, Jun 19, 2008 at 3:07 PM, Brad Nicholes [EMAIL PROTECTED] wrote: The patch looks good. Now we just need somebody with a lot PHP web frontend experience than me to review the patch and determine if it should be committed to trunk. Jesse, Bernard... I'll leave it up to you or anybody

Re: [Ganglia-developers] Stacked Graphs

2008-06-30 Thread Jesse Becker
I took a quick look at the patch, although I've not applied yet. A few comments: 1) the HSV_TO_RGB and get_col functions should, IMO, be moved out to the functions.php file. 2) Chart size is fixed to 400x300. This should be based on the other charts (either pie chart, or other plots,

Re: [Ganglia-developers] Stacked Graphs

2008-06-30 Thread Bernard Li
Hi Jesse: On Mon, Jun 30, 2008 at 2:19 PM, Jesse Becker [EMAIL PROTECTED] wrote: 2) Chart size is fixed to 400x300. This should be based on the other charts (either pie chart, or other plots, depending on placement). I think it would also make sense to be able to click on the graph to blow

Re: [Ganglia-developers] Stacked Graphs

2008-06-19 Thread Brad Nicholes
Subject: Re: [Ganglia-developers] Stacked Graphs On 6/17/2008 at 4:24 PM, in message [EMAIL PROTECTED], Gilad Raphaelli wrote: I submitted the code for the stacked graphs item from the ganglia 3.1 wishlist in http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=187

Re: [Ganglia-developers] Stacked Graphs

2008-06-18 Thread Brad Nicholes
On 6/17/2008 at 4:24 PM, in message [EMAIL PROTECTED], Gilad Raphaelli [EMAIL PROTECTED] wrote: I submitted the code for the stacked graphs item from the ganglia 3.1 wishlist in http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=187 (in April). It was reviewed by someone on

Re: [Ganglia-developers] Stacked Graphs

2008-06-18 Thread Gilad Raphaelli
- Original Message From: Brad Nicholes [EMAIL PROTECTED] To: ganglia-developers@lists.sourceforge.net; Gilad Raphaelli [EMAIL PROTECTED] Sent: Thursday, June 19, 2008 12:20:48 AM Subject: Re: [Ganglia-developers] Stacked Graphs On 6/17/2008 at 4:24 PM, in message [EMAIL

[Ganglia-developers] Stacked Graphs

2008-06-17 Thread Gilad Raphaelli
I submitted the code for the stacked graphs item from the ganglia 3.1 wishlist in http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=187 (in April). It was reviewed by someone on #ganglia while ago but it never made it into svn. I assume it's a bit late for release with 3.1.0 - can