Re: [PATCH] Fix PR18589

2012-04-04 Thread William J. Schmidt
On Wed, 2012-04-04 at 13:35 +0200, Richard Guenther wrote: On Tue, Apr 3, 2012 at 10:25 PM, William J. Schmidt wschm...@linux.vnet.ibm.com wrote: On Wed, 2012-03-28 at 15:57 +0200, Richard Guenther wrote: On Tue, Mar 6, 2012 at 9:49 PM, William J. Schmidt wschm...@linux.vnet.ibm.com

Re: [PATCH] Fix PR18589

2012-04-04 Thread Richard Guenther
On Wed, Apr 4, 2012 at 2:35 PM, William J. Schmidt wschm...@linux.vnet.ibm.com wrote: On Wed, 2012-04-04 at 13:35 +0200, Richard Guenther wrote: On Tue, Apr 3, 2012 at 10:25 PM, William J. Schmidt wschm...@linux.vnet.ibm.com wrote: On Wed, 2012-03-28 at 15:57 +0200, Richard Guenther

Re: [PATCH] Dissociate store_expr's temp from exp so that it is not marked as addressable

2012-04-04 Thread Martin Jambor
Hi, On Tue, Apr 03, 2012 at 11:02:11AM +0200, Eric Botcazou wrote: Yeah, that sounds reasonable. There is a further subtlety in the second temp allocation when the expression doesn't use the alias set of its type. In that case, we cannot pass the type to set_mem_attributes. In fact,

Re: [C11-atomic] [patch] gimple atomic statements

2012-04-04 Thread Richard Henderson
On 04/04/2012 04:45 AM, Richard Guenther wrote: I suppose you do not want to use builtins because for primitive types you end up with multiple statements for something atomic? The primary motivation is that builtins cannot return two values. Our current builtin returns one of the two values by

Re: Ping [IA-64] Work around thinko in 'x' constraint implementation

2012-04-04 Thread Richard Henderson
Ok. r~ On 04/04/2012 03:34 AM, Tristan Gingold wrote: I'd like to ping this patch as it fixed an ICE visible on both ia64 linux and ia64 openvms. Tristan. On Mar 6, 2012, at 11:07 PM, Eric Botcazou wrote: We have a regression on one of the testcases of our internal testsuite on

Re: [C11-atomic] [patch] gimple atomic statements

2012-04-04 Thread Richard Guenther
On Wed, Apr 4, 2012 at 3:26 PM, Richard Henderson r...@redhat.com wrote: On 04/04/2012 04:45 AM, Richard Guenther wrote: I suppose you do not want to use builtins because for primitive types you end up with multiple statements for something atomic? The primary motivation is that builtins

Re: RFA: RL78: Add -fstack-usage support

2012-04-04 Thread nick clifton
Hi Eric, On 04/04/12 12:24, Eric Botcazou wrote: You probably need to adjust gcc.dg/stack-usage-1.c too. s/flag_stack_usage/flag_stack_usage_info/ Thanks for the corrections. Revised patch attached. OK for mainline/4.7 branch ? Cheers Nick gcc/ChangeLog 2012-04-04 Nick Clifton

[PATCH] Make gsi_remove return whether EH cleanup is required

2012-04-04 Thread Richard Guenther
Several passes needlessly cleanup EH after gsi_remove because they do not know whether the stmt was removed from EH regions. The following patch returns this information from gsi_remove and adjusts all users I could find appropriately. Bootstrapped and tested on x86_64-unknown-linux-gnu,

Re: [C11-atomic] [patch] gimple atomic statements

2012-04-04 Thread Andrew MacLeod
On 04/04/2012 09:28 AM, Andrew MacLeod wrote: I wasn't excited about creating a new gimple statement, but it seemed the best solution to my issues. In the end, I think this works very cleanly. Im certainly open to better solutions. If there is a plan to change gimple in some way that this

Re: [Libiberty]: Handle VMS as a LLP64 platform in splay-tree.h

2012-04-04 Thread Ian Lance Taylor
Tristan Gingold ging...@adacore.com writes: include/ 2012-04-04 Tristan Gingold ging...@adacore.com * splay-tree.h: Use LLP64 definitions of libi_shostptr_t and libi_hostptr_t for VMS with 64bit pointers. I was strongly opposed to adding a _WIN64 define here and this is just

Re: [C11-atomic] [patch] gimple atomic statements

2012-04-04 Thread Andrew MacLeod
On 04/04/2012 04:45 AM, Richard Guenther wrote: The fact that you need to touch every place that wants to look at memory accesses shows that you are doing it wrong. Instead my plan was to force _all_ memory accesses to GIMPLE_ASSIGNs (yes, including those we have now in calls). You're making

Re: [C11-atomic] [patch] gimple atomic statements

2012-04-04 Thread Richard Henderson
On 04/04/2012 09:46 AM, Richard Guenther wrote: If that is the only reason you can return two values by using a complex or vector type (that would be only an IL implementation detail as far as I can see). We use that trick to get sincos () sane in our IL as well. That would work if the two

Re: [C11-atomic] [patch] gimple atomic statements

2012-04-04 Thread Richard Guenther
On Wed, Apr 4, 2012 at 3:28 PM, Andrew MacLeod amacl...@redhat.com wrote: On 04/04/2012 04:45 AM, Richard Guenther wrote: The fact that you need to touch every place that wants to look at memory accesses shows that you are doing it wrong.  Instead my plan was to force _all_ memory accesses

Re: [C11-atomic] [patch] gimple atomic statements

2012-04-04 Thread Richard Guenther
On Wed, Apr 4, 2012 at 4:32 PM, Richard Henderson r...@redhat.com wrote: On 04/04/2012 09:46 AM, Richard Guenther wrote: If that is the only reason you can return two values by using a complex or vector type (that would be only an IL implementation detail as far as I can see). We use that

C++ PATCH for c++/52845 (bogus warning with empty lambda)

2012-04-04 Thread Jason Merrill
My patch for return type deduction forgot to update the fntype local variable in finish_function, leading to a bogus warning about a missing return statement. Tested x86_64-pc-linux-gnu, applying to trunk. commit 12a282edca78579074f5f4180cd2dce1edebd2bf Author: Jason Merrill ja...@redhat.com

Re: [RFC] Should SRA stop producing COMPONENT_REF for non-bit-fields (again)?

2012-04-04 Thread Richard Guenther
On Wed, 4 Apr 2012, Martin Jambor wrote: Hi everyone, especially Richi and Eric, I'd like to know what is your attitude to changing SRA's build_ref_for_model to what it once looked like, so that it produces COMPONENT_REFs only for bit-fields. The non-bit field handling was added in order

Re: [Libiberty]: Handle VMS as a LLP64 platform in splay-tree.h

2012-04-04 Thread Tristan Gingold
On Apr 4, 2012, at 3:58 PM, Ian Lance Taylor wrote: Tristan Gingold ging...@adacore.com writes: include/ 2012-04-04 Tristan Gingold ging...@adacore.com * splay-tree.h: Use LLP64 definitions of libi_shostptr_t and libi_hostptr_t for VMS with 64bit pointers. I was strongly

Re: [Libiberty]: Handle VMS as a LLP64 platform in splay-tree.h

2012-04-04 Thread Ian Lance Taylor
Tristan Gingold ging...@adacore.com writes: Would something like that be acceptable ? I have just checked that I can still build gcc with that patch. If you like this approach I will properly submit a patch. Thanks. You should also test that gdb continues to build with this patch. I guess

Re: [Libiberty]: Handle VMS as a LLP64 platform in splay-tree.h

2012-04-04 Thread Tristan Gingold
On Apr 4, 2012, at 5:07 PM, Ian Lance Taylor wrote: Tristan Gingold ging...@adacore.com writes: Would something like that be acceptable ? I have just checked that I can still build gcc with that patch. If you like this approach I will properly submit a patch. Thanks. You should

Re: [Libiberty]: Handle VMS as a LLP64 platform in splay-tree.h

2012-04-04 Thread Pedro Alves
On 04/04/2012 04:07 PM, Ian Lance Taylor wrote: Tristan Gingold ging...@adacore.com writes: Would something like that be acceptable ? I have just checked that I can still build gcc with that patch. If you like this approach I will properly submit a patch. Thanks. You should also

Re: [C11-atomic] [patch] gimple atomic statements

2012-04-04 Thread Andrew MacLeod
On 04/04/2012 10:33 AM, Richard Guenther wrote: On Wed, Apr 4, 2012 at 3:28 PM, Andrew MacLeodamacl...@redhat.com wrote: This is a WIP... that fntype fields is there for simplicity.. and no... you can do a 1 byte atomic operation on a full word object if you want by Oh, so you rather need a

Re: PATCH: [x32] libitm failures on x32

2012-04-04 Thread Uros Bizjak
Hello! We need to use long long instead of long in gtm_jmpbuf for x86_64 since long in x32 is 32bits. OK for trunk and 4.7 branch? 2012-04-03 H.J. Lu hongjiu...@intel.com PR libitm/52854 * config/x86/target.h (gtm_jmpbuf): Replace long with long long for x86-64. OK.

Re: [wwwdocs] Buildstat update for 4.5

2012-04-04 Thread Gerald Pfeifer
On Tue, 3 Apr 2012, Tom G. Christensen wrote: Latest results for 4.5.x -tgc Testresults for 4.5.3: i386-pc-solaris2.8 (2) Thanks, Tom, this is life. Gerald

[PATCH, libstdc++]: Fix static linking failure on alphaev68-pc-linux-gnu

2012-04-04 Thread Uros Bizjak
Hello! The fix for PR52689 caused following testsuite failure on alphaev68-pc-linux-gnu: Running target unix FAIL: libmudflap.c++/pass41-frag.cxx (-static) (test for excess errors) WARNING: libmudflap.c++/pass41-frag.cxx (-static) compilation failed to produce executable From the testsuite log:

Re: PATCH: Define TRY_EMPTY_VM_SPACE for Linux/x32

2012-04-04 Thread Uros Bizjak
Hello! This patch defines TRY_EMPTY_VM_SPACE for Linux/x32. Tested on Linux/x32. OK for trunk? 2012-04-03 H.J. Lu hongjiu...@intel.com * config/host-linux.c (TRY_EMPTY_VM_SPACE): Defined to 0x6000 for x32. I think we can simply check for __LP64__, without version check,

[PATCH 1/2] doc: Correct __builtin_arm_tinsr prototype documentation

2012-04-04 Thread Matt Turner
2012-04-04 Matt Turner matts...@gmail.com gcc/ * doc/extend.texi (__builtin_arm_tinsrb): Add missing second parameter. (__builtin_arm_tinsrh): Likewise. (__builtin_arm_tinsrw): Likewise. --- This patch and 2/2 are tie-ons to

[PATCH] doc: Fix typo: mno-lsc - mno-llsc

2012-04-04 Thread Matt Turner
2012-04-04 Matt Turner matts...@gmail.com gcc/ * doc/install.texi: Correct typo -mno-lsc - -mno-llsc. --- Still waiting on copyright assignment, but I think this doc patch is trivial enough to be committed without it. gcc/doc/install.texi |2 +- 1 files changed, 1

[PATCH 2/2] arm: add iwMMXt mmx-2.c test

2012-04-04 Thread Matt Turner
2012-04-04 Matt Turner matts...@gmail.com PR target/35294 * gcc.target/arm/mmx-2.c: New. --- This patch and 1/2 are tie-ons to http://gcc.gnu.org/ml/gcc-patches/2012-02/msg01269.html Still waiting on copyright assignment, but please review in the meantime. Is there anything

Re: PATCH: Define TRY_EMPTY_VM_SPACE for Linux/x32

2012-04-04 Thread H.J. Lu
On Wed, Apr 4, 2012 at 11:08 AM, Uros Bizjak ubiz...@gmail.com wrote: Hello! This patch defines TRY_EMPTY_VM_SPACE for Linux/x32.  Tested on Linux/x32. OK for trunk? 2012-04-03  H.J. Lu  hongjiu...@intel.com       * config/host-linux.c (TRY_EMPTY_VM_SPACE): Defined to       0x6000 for

libgo patch committed: More syscall improvements

2012-04-04 Thread Ian Lance Taylor
This patch to libgo adds more constants to the syscall package, continuing the process of making the gccgo version of syscall more like the one in the master library. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.7 branch. Ian diff -r 34124478458a

Re: PATCH: Define TRY_EMPTY_VM_SPACE for Linux/x32

2012-04-04 Thread Uros Bizjak
On Wed, Apr 4, 2012 at 8:47 PM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Apr 4, 2012 at 11:08 AM, Uros Bizjak ubiz...@gmail.com wrote: Hello! This patch defines TRY_EMPTY_VM_SPACE for Linux/x32.  Tested on Linux/x32. OK for trunk? 2012-04-03  H.J. Lu  hongjiu...@intel.com       *

Re: PATCH: Define TRY_EMPTY_VM_SPACE for Linux/x32

2012-04-04 Thread Andrew Pinski
On Wed, Apr 4, 2012 at 11:50 AM, Uros Bizjak ubiz...@gmail.com wrote: Looking at how other targets implement this check, I don't think that this is a problem at all. This issue only shows on a non-bootstrapped build. A full bootstrap will use correct address. The other place where it shows up

Re: PATCH: Define TRY_EMPTY_VM_SPACE for Linux/x32

2012-04-04 Thread H.J. Lu
On Wed, Apr 4, 2012 at 11:53 AM, Andrew Pinski pins...@gmail.com wrote: On Wed, Apr 4, 2012 at 11:50 AM, Uros Bizjak ubiz...@gmail.com wrote: Looking at how other targets implement this check, I don't think that this is a problem at all. This issue only shows on a non-bootstrapped build. A

Re: [PATCH] Fix PR18589

2012-04-04 Thread William J. Schmidt
On Wed, 2012-04-04 at 15:08 +0200, Richard Guenther wrote: On Wed, Apr 4, 2012 at 2:35 PM, William J. Schmidt wschm...@linux.vnet.ibm.com wrote: On Wed, 2012-04-04 at 13:35 +0200, Richard Guenther wrote: On Tue, Apr 3, 2012 at 10:25 PM, William J. Schmidt wschm...@linux.vnet.ibm.com wrote:

[patch, committed, backport] Backport IA64 patch to 4.6 branch

2012-04-04 Thread Steve Ellcey
I had a request to backport this patch to the 4.6 branch and since it is an obvious fix and hasn't caused any problems on the main line I have gone ahead and checked it in. I tested the patch on the 4.6 branch with IA64 HP-UX and had no regressions. FYI: Friday will be my last day at HP but I

Re: remove wrong code in immed_double_const

2012-04-04 Thread Mike Stump
On Mar 26, 2012, at 4:57 PM, Mike Stump wrote: On Mar 26, 2012, at 1:03 PM, Richard Sandiford wrote: I think: ...copies of the top bit. Note however that values are neither inherently signed nor inherently unsigned; where necessary, signedness is determined by the rtl operation instead.

Re: [PATCH] Fix PR18589

2012-04-04 Thread William J. Schmidt
On Wed, 2012-04-04 at 13:35 +0200, Richard Guenther wrote: On Tue, Apr 3, 2012 at 10:25 PM, William J. Schmidt wschm...@linux.vnet.ibm.com wrote: Hi Richard, I've revised my patch along these lines; see the new version below. While testing it I realized I could do a better job of

[PATCH, Android] MIPS support

2012-04-04 Thread Maxim Kuvyrkov
Chao, Let's take discussion of MIPS changes to gcc-patches@. Please follow up here. -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics On 5/04/2012, at 10:10 AM, Fu, Chao-Ying wrote: Maxim Kuvyrkov wrote: I encourage you to submit the MIPS Android patches to gcc-patches@. And, as long

Re: [PATCH] ARM: Use different linker path for hardfloat ABI

2012-04-04 Thread Michael Hope
On 4 April 2012 18:54, Jakub Jelinek ja...@redhat.com wrote: On Wed, Apr 04, 2012 at 01:34:30PM +1200, Michael Hope wrote:  I did two ports of Mandriva to armv7. One of my choice to use softfp, and another hardfp port to be compatible with other distros. But other than a previous armv5

Re: [PATCH] ARM: Use different linker path for hardfloat ABI

2012-04-04 Thread Michael Hope
On 4 April 2012 21:06, Joseph S. Myers jos...@codesourcery.com wrote: On Wed, 4 Apr 2012, Michael Hope wrote: The tricky one is new GCC with old GLIBC.  GCC may have to do a configure time test and fall back to /lib/ld-linux.so.3 if the hard float loader is missing. I don't think that's

[Patch, i386] Avoid LCP stalls (issue5975045)

2012-04-04 Thread Teresa Johnson
New patch to avoid LCP stalls based on feedback from earlier patch. I modified H.J.'s old patch to perform the peephole2 to split immediate moves to HImode memory. This is now enabled for Core2, Corei7 and Generic. I verified that this enables the splitting to occur in the case that originally

Re: [PATCH] ARM: Use different linker path for hardfloat ABI

2012-04-04 Thread Joseph S. Myers
On Thu, 5 Apr 2012, Michael Hope wrote: I don't think that's appropriate for ABI issues.  If a different dynamic linker name is specified, GCC should use it unconditionally (and require new enough glibc or a glibc installation that was appropriately rearranged). OK. I want GCC 4.7.1

Re: [Patch, i386] Avoid LCP stalls (issue5975045)

2012-04-04 Thread H.J. Lu
On Wed, Apr 4, 2012 at 5:07 PM, Teresa Johnson tejohn...@google.com wrote: New patch to avoid LCP stalls based on feedback from earlier patch. I modified H.J.'s old patch to perform the peephole2 to split immediate moves to HImode memory. This is now enabled for Core2, Corei7 and Generic. I

Re: [PATCH] ARM: Use different linker path for hardfloat ABI

2012-04-04 Thread Michael Hope
On 5 April 2012 12:07, Joseph S. Myers jos...@codesourcery.com wrote: On Thu, 5 Apr 2012, Michael Hope wrote: I don't think that's appropriate for ABI issues.  If a different dynamic linker name is specified, GCC should use it unconditionally (and require new enough glibc or a glibc

Re: [PATCH] ARM: Use different linker path for hardfloat ABI

2012-04-04 Thread dann frazier
On Wed, Apr 04, 2012 at 02:39:58PM +1200, Michael Hope wrote: On 4 April 2012 10:56, Joseph S. Myers jos...@codesourcery.com wrote: On Tue, 3 Apr 2012, Michael Hope wrote: +#define GLIBC_DYNAMIC_LINKER \ +   %{mhard-float: GLIBC_DYNAMIC_LINKER_HARD_FLOAT } \ +    %{mfloat-abi=hard:

[PATCH] Fix PR52614

2012-04-04 Thread William J. Schmidt
There seems to be tacit agreement that the vector tests should use -fno-common on all targets to avoid the recent spate of failures (see discussion in 52571 and 52603). This patch (proposed by Dominique D'Humieures) does just that. I agreed to shepherd the patch through. I've verified that it

Re: [PATCH] Fix PR52614

2012-04-04 Thread Mike Stump
On Apr 4, 2012, at 7:56 PM, William J. Schmidt wrote: There seems to be tacit agreement that the vector tests should use -fno-common on all targets to avoid the recent spate of failures (see discussion in 52571 and 52603). OK for trunk? Ok. Any other solution I think will be real work and

Re: [Patch, i386] Avoid LCP stalls (issue 5975045)

2012-04-04 Thread davidxl
http://codereview.appspot.com/5975045/diff/6001/config/i386/i386.md File config/i386/i386.md (right): http://codereview.appspot.com/5975045/diff/6001/config/i386/i386.md#newcode16974 config/i386/i386.md:16974: ;; gets too big. The comments may need to be updated.

Re: [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043)

2012-04-04 Thread Michael Hope
On 5 April 2012 15:56, asha...@chromium.org wrote: Reviewers: Diego Novillo, jingyu, davidxl, Message: Please take a look at this patch and tell me if it's OK for branches/google/gcc-4_6. Description: Backported the following patch from trunk: 2011-10-07  Andrew Stubbs  

Re: [Patch, i386] Avoid LCP stalls (issue5975045)

2012-04-04 Thread Teresa Johnson
On Wed, Apr 4, 2012 at 5:39 PM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Apr 4, 2012 at 5:07 PM, Teresa Johnson tejohn...@google.com wrote: New patch to avoid LCP stalls based on feedback from earlier patch. I modified H.J.'s old patch to perform the peephole2 to split immediate moves to

<    1   2   3