Re: [PATCH] i386: Update naked-1.c for PIC

2017-07-31 Thread Uros Bizjak
On Tue, Aug 1, 2017 at 12:48 AM, H.J. Lu wrote: > For ia32 targets, -fPIC may generate > > call __x86.get_pc_thunk.ax > ... > __x86.get_pc_thunk.ax: > movl(%esp), %eax > ret > > We should check "ret" only for non-PIC or non-ia32 targets.

[Bug c++/81632] spurious -Wterminate warning about throw in destructor

2017-07-31 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81632 Martin Sebor changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC|

[PING #2] [PATCH] enhance -Wrestrict to handle string built-ins (PR 78918)

2017-07-31 Thread Martin Sebor
Richard, in discussing this work Jeff mentioned that your comments on the tree-ssa-alias.c parts would be helpful. When you have a chance could you please give it a once over and let me know if you have any suggestions or concerns? There are no visible changes to existing clients of the pass,

Re: PING: [PATCH] PR driver/81523: Make -static override -pie

2017-07-31 Thread H.J. Lu
On Mon, Jul 31, 2017 at 5:37 PM, Alan Modra wrote: > On Mon, Jul 31, 2017 at 08:04:13AM -0700, H.J. Lu wrote: >> On Mon, Jul 24, 2017 at 10:24 AM, H.J. Lu wrote: >> > On Sun, Jul 23, 2017 at 8:14 AM, H.J. Lu wrote: >> >> -static and

[Bug bootstrap/81638] [7 Regression] AIX bootstrap failure due to Recover GOTO predictor

2017-07-31 Thread dje at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81638 --- Comment #4 from David Edelsohn --- The test around the setting of incl is the same as the test around the use of incl at the place of the false positive uninitialized error for (i = 0; i < vec->count; ++i) incl = ... if

Re: [PATCH 0/2] add unique_ptr class

2017-07-31 Thread David Malcolm
On Mon, 2017-07-31 at 19:46 -0400, tbsaunde+...@tbsaunde.org wrote: > From: Trevor Saunders > > Hi, > > I've been saying I'd do this for a long time, but I'm finally getting > to > importing the C++98 compatable unique_ptr class Pedro wrote for gdb a > while > back.

Re: PING: [PATCH] PR driver/81523: Make -static override -pie

2017-07-31 Thread Alan Modra
On Mon, Jul 31, 2017 at 08:04:13AM -0700, H.J. Lu wrote: > On Mon, Jul 24, 2017 at 10:24 AM, H.J. Lu wrote: > > On Sun, Jul 23, 2017 at 8:14 AM, H.J. Lu wrote: > >> -static and -pie together behave differently depending on whether GCC is > >> configured

[Bug bootstrap/81638] [7 Regression] AIX bootstrap failure due to Recover GOTO predictor

2017-07-31 Thread pinskia at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81638 --- Comment #3 from Andrew Pinski --- Just for reference we have: for (i = 0; i < vec->count; ++i) { incl = (struct xcoff_incl *) vec->vec.base + i; if (incl->begin <= lnnoptr && lnnoptr <= incl->end) break; } if

[PATCH 1/5] Rename existing insn_cost to insn_sched_cost

2017-07-31 Thread Segher Boessenkool
haifa-sched exports an insn_cost function, but it is only used in a few places and specialised to scheduling. This patch renames it to insn_sched_cost. --- gcc/haifa-sched.c | 14 +++--- gcc/sched-int.h| 2 +- gcc/sched-rgn.c| 4 ++-- gcc/sel-sched-ir.c | 2 +- 4 files

[PATCH 0/5] RFC, WIP: RTL cost improvements

2017-07-31 Thread Segher Boessenkool
This series creates pattern_cost and insn_cost functions that together replace the existing insn_rtx_cost function. pattern_cost is like the old insn_rtx_cost function; insn_cost takes an actual rtx_insn * as input, not just a pattern. Also a targetm.insn_cost is added, which targets can use to

[PATCH 5/5] rs6000: Implement insn_cost hook

2017-07-31 Thread Segher Boessenkool
This is a pretty minimalistic implementation of the insn_cost hook: it just counts how many machine instructions will be generated. Some improvements are needed: loads should get extra cost; some instructions like mul and div should be more expensive than others; and it exposes some

Re: [PATCH 00/19] cleanup of memory stats prototypes

2017-07-31 Thread Martin Sebor
On 07/31/2017 05:11 PM, Trevor Saunders wrote: On Mon, Jul 31, 2017 at 04:58:15PM -0600, Martin Sebor wrote: On 07/31/2017 03:34 PM, Trevor Saunders wrote: On Mon, Jul 31, 2017 at 02:56:40PM -0600, Martin Sebor wrote: On 07/27/2017 02:30 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor

[Bug c++/81609] incompatible extern C declarations of the same extern function at local scope accepted

2017-07-31 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81609 Martin Sebor changed: What|Removed |Added See Also||https://gcc.gnu.org/bugzill

[PATCH 4/5] Add targetm.insn_cost hook

2017-07-31 Thread Segher Boessenkool
This introduces a hook to implement insn_cost. If a target does not implement the hook, the old function (i.e. pattern_cost) is used. --- gcc/doc/tm.texi| 12 gcc/doc/tm.texi.in | 2 ++ gcc/rtlanal.c | 3 +++ gcc/target.def | 14 ++ 4 files changed, 31

[PATCH 2/5] Replace insn_rtx_cost with insn_cost and pattern_cost

2017-07-31 Thread Segher Boessenkool
This renames insn_rtx_cost to pattern cost, and adds a new function insn_cost that takes an rtx_insn * instead of an instruction pattern as input. It uses the latter function anywhere an instruction is readily available (instead of just an instruction pattern). The actual implementation of

[PATCH] rs6000: Trailing comma warning in enum

2017-07-31 Thread Segher Boessenkool
Committed. Segher 2017-07-31 Segher Boessenkool * config/rs6000/rs6000.c (enum rs6000_reg_type): Delete trailing comma. --- gcc/config/rs6000/rs6000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/rs6000/rs6000.c

[PATCH 3/5] combine: Use insn_cost instead of pattern_cost everywhere

2017-07-31 Thread Segher Boessenkool
This changes combine to always use insn_cost, not pattern_cost. I don't intend to commit it like this: it calls recog more often than necessary, and it is very ugly (no, don't look at it). But it's good enough to test things with. --- gcc/combine.c | 31 +-- 1 file

[Patch] Testsuite fixes for failures caused by patch for PR 80925 (part deux)

2017-07-31 Thread Steve Ellcey
Here is a second set of patches to fix tests that started failing with the patch for PR 80925.  It uses the same testsuite changes I did for no-section-anchors-vect-69.c and section-anchors-vect-69.c on new set of gcc.dg/vect/vect-* tests. 2017-07-31  Steve Ellcey  

[PATCH 1/2] add unique_ptr header

2017-07-31 Thread tbsaunde+gcc
From: Trevor Saunders For most of the history of this see https://sourceware.org/ml/gdb-patches/2016-10/msg00223.html The changes are mostly s/gdb/gtl/g include/ChangeLog: 2017-07-29 Trevor Saunders * unique-ptr.h: New file.

[PATCH 2/2] use unique_ptr some

2017-07-31 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2017-07-31 Trevor Saunders * cse.c (find_comparison_args): Make visited a unique_ptr. * lto-streamer-out.c (write_global_references): Make data a unique_ptr. *

[PATCH 0/2] add unique_ptr class

2017-07-31 Thread tbsaunde+gcc
From: Trevor Saunders Hi, I've been saying I'd do this for a long time, but I'm finally getting to importing the C++98 compatable unique_ptr class Pedro wrote for gdb a while back. I believe the gtl namespace also comes from Pedro, but GNU template library seems as

[Bug bootstrap/81638] [7 Regression] AIX bootstrap failure due to Recover GOTO predictor

2017-07-31 Thread dje at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81638 --- Comment #2 from David Edelsohn --- Created attachment 41877 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=41877=edit pre-processed xcoff.c compiled on AIX 7.2

[Bug bootstrap/81638] [7 Regression] AIX bootstrap failure due to Recover GOTO predictor

2017-07-31 Thread dje at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81638 David Edelsohn changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug bootstrap/81638] New: AIX bootstrap failure due to Recover GOTO predictor

2017-07-31 Thread dje at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81638 Bug ID: 81638 Summary: AIX bootstrap failure due to Recover GOTO predictor Product: gcc Version: 8.0 Status: UNCONFIRMED Severity: normal Priority: P3

Re: [PATCH 00/19] cleanup of memory stats prototypes

2017-07-31 Thread Trevor Saunders
On Mon, Jul 31, 2017 at 04:58:15PM -0600, Martin Sebor wrote: > On 07/31/2017 03:34 PM, Trevor Saunders wrote: > > On Mon, Jul 31, 2017 at 02:56:40PM -0600, Martin Sebor wrote: > > > On 07/27/2017 02:30 AM, tbsaunde+...@tbsaunde.org wrote: > > > > From: Trevor Saunders

Re: ping [PATCH] [MSP430] Fix PR78849: ICE on initialization of global struct containing __int20 array

2017-07-31 Thread Joseph Myers
On Wed, 26 Jul 2017, Jeff Law wrote: > TYPE_SIZE, according to my understanding, should be a tree for the size > of the expression in bits. > > The problem is for msp430 that size varies depending on where it's used. > ie, in a register an object might have a bitsize of 20 bits, but in > memory

Re: [PATCH 4/N] Recover GOTO predictor.

2017-07-31 Thread David Edelsohn
This patch breaks bootstrap on AIX and probably is a hidden bug on all targets. With the patch, libbacktrace/xcoff.c fails to compile with the error: /nasfarm/edelsohn/src/src/libbacktrace/xcoff.c: In function 'xcoff_add': /nasfarm/edelsohn/src/src/libbacktrace/xcoff.c:822:13: error: 'incl' may

Re: [PATCH 00/19] cleanup of memory stats prototypes

2017-07-31 Thread Martin Sebor
On 07/31/2017 03:34 PM, Trevor Saunders wrote: On Mon, Jul 31, 2017 at 02:56:40PM -0600, Martin Sebor wrote: On 07/27/2017 02:30 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders The preC++ way of passing information about the call site of a function was

[PATCH] i386: Update naked-1.c for PIC

2017-07-31 Thread H.J. Lu
For ia32 targets, -fPIC may generate call __x86.get_pc_thunk.ax ... __x86.get_pc_thunk.ax: movl(%esp), %eax ret We should check "ret" only for non-PIC or non-ia32 targets. OK for trunk? H.J. --- * gcc.target/i386/naked-1.c: Check "ret" only for

Re: C PATCH to detect clashing attributes (PR c/81544)

2017-07-31 Thread Joseph Myers
On Tue, 25 Jul 2017, Marek Polacek wrote: > PR c/81544 complaints that we aren't detecting clashing noreturn / > warn_unused_result attributes so this patch adds that checking. Martin > plans to do more systematic checking in this area but meanwhile we > might want to go with this. > >

Re: [RFC] Remaining references of Java

2017-07-31 Thread Joseph Myers
On Tue, 25 Jul 2017, Richard Biener wrote: > > 2) fold-const.c: > > > > 1882/* The following code implements the floating point to integer > > 1883 conversion rules required by the Java Language Specification, > > 1884 that IEEE NaNs are mapped to zero and values that

[Bug c/39985] Type qualifiers not actually ignored on function return type

2017-07-31 Thread joseph at codesourcery dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=39985 --- Comment #5 from joseph at codesourcery dot com --- In C, in C11 mode, type qualifiers are completely ignored on function return types, including not affecting type compatibility, after my commit: r236231 | jsm28 | 2016-05-13 21:35:39 +

[Bug tree-optimization/80925] [8 Regression] vect peeling failures

2017-07-31 Thread sje at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80925 --- Comment #19 from Steve Ellcey --- Author: sje Date: Mon Jul 31 21:44:34 2017 New Revision: 250752 URL: https://gcc.gnu.org/viewcvs?rev=250752=gcc=rev Log: 2017-07-31 Steve Ellcey PR tree-optimization/80925

[Bug c/79696] missing -Wunused-result on calls to malloc() and calloc()

2017-07-31 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79696 Martin Sebor changed: What|Removed |Added Status|WAITING |UNCONFIRMED Ever confirmed|1

Re: [PATCH 00/19] cleanup of memory stats prototypes

2017-07-31 Thread Trevor Saunders
On Mon, Jul 31, 2017 at 02:56:40PM -0600, Martin Sebor wrote: > On 07/27/2017 02:30 AM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > The preC++ way of passing information about the call site of a function was > > to > > use a macro that passed

Re: [PATCH 00/19] cleanup of memory stats prototypes

2017-07-31 Thread Martin Sebor
On 07/27/2017 02:30 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders The preC++ way of passing information about the call site of a function was to use a macro that passed __file__, __LINE__, and __FUNCTION__ to a function with the same name with _stat

Re: [PATCH, RFC] Proposed PowerPC IEEE 128-bit floating point changes

2017-07-31 Thread Joseph Myers
On Fri, 21 Jul 2017, Michael Meissner wrote: > The first change is to enable the C language to use _Float128 keyword (but not > __float128) without having to use the -mfloat128 option on power7-power9 > systems. My question is in the TR that introduced _Float128, is there any > expectation that

New French PO file for 'gcc' (version 7.1.0)

2017-07-31 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the French team of translators. The file is available at: http://translationproject.org/latest/gcc/fr.po (This file, 'gcc-7.1.0.fr.po', has just

[Bug c/80130] Wrong diagnostic: dereferencing type-punned pointer

2017-07-31 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80130 Eric Gallager changed: What|Removed |Added CC||egallager at gcc dot gnu.org ---

Re: [PATCH, rs6000] Fix PR81622

2017-07-31 Thread Bill Schmidt
> On Jul 31, 2017, at 11:27 AM, Jakub Jelinek wrote: > > On Mon, Jul 31, 2017 at 11:19:26AM -0500, Bill Schmidt wrote: >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81622 reports an ICE-on-invalid >> for the vec_ld and vec_st built-in functions. This fires when the last >>

Re: [PATCH] enhance overflow and truncation detection in strncpy and strncat (PR 81117)

2017-07-31 Thread Martin Sebor
So I think the fixes exposed by the new warning are OK to go in as-is immediately if you wish to do so. Minor questions on the actual improved warnings inline. Sure, thanks. -static inline tree +static tree compute_objsize (tree dest, int ostype) { ... + type = TYPE_MAIN_VARIANT

[Bug target/81622] [7/8 Regression] ICE on invalid altivec code with ppc64{,le}

2017-07-31 Thread wschmidt at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81622 --- Comment #12 from Bill Schmidt --- (In reply to Jakub Jelinek from comment #9) > I take back the ARRAY_TYPE thing, apparently it is different for C vs. C++, > in C one always sees there POINTER_TYPE, while in C++ always ARRAY_TYPE. > Anyway,

[Bug target/81622] [7/8 Regression] ICE on invalid altivec code with ppc64{,le}

2017-07-31 Thread wschmidt at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81622 --- Comment #11 from Bill Schmidt --- I went spelunking and found that the ARRAY_TYPE change was added here: https://gcc.gnu.org/viewcvs/gcc?view=revision=237077. Looks like a C++ implementation detail.

[Bug testsuite/81626] Need effective target omp_target

2017-07-31 Thread tschwinge at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81626 --- Comment #5 from Thomas Schwinge --- (In reply to Tom de Vries from comment #4) > (In reply to Thomas Schwinge from comment #3) > > Yeah, I suppose you just need to remove a "--disable-multilib" from your > > nvptx offloading GCC build

[PATCH, Fortran] Support for legacy %FILL fields in STRUCTUREs

2017-07-31 Thread Fritz Reese
All, Attached is a patch which extends the DEC STRUCTURE support to include special fields named '%FILL'. These fields generate anonymous inaccessible components, commonly used in DEC FORTRAN to control alignment of fields within STRUCTUREs. The patch is fairly straightforward. The match is

[Bug tree-optimization/81637] New: [8 regression] compilation of 416.games from spec2006 fails starting with r250670

2017-07-31 Thread seurer at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81637 Bug ID: 81637 Summary: [8 regression] compilation of 416.games from spec2006 fails starting with r250670 Product: gcc Version: 8.0 Status: UNCONFIRMED

[Bug testsuite/80759] gcc.target/x86_64/abi/ms-sysv FAILs

2017-07-31 Thread daniel.santos at pobox dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80759 --- Comment #61 from Daniel Santos --- (In reply to Dominique d'Humieres from comment #60) > At revision r250610 I still see > > WARNING: Could not generate > /opt/gcc/build_w/gcc/testsuite/gcc/ms-sysv/ms-sysv-generated.h Thank you for the

[PATCH] Update myself in MAINTAINERS

2017-07-31 Thread Richard Henderson
A change of jobs requires a change of email. And I'm going to finally admit that I've not been active gcc development in the last year or two. I am far enough behind that I cannot globally review changes. That said, I do not plan to abandon Alpha just yet. r~ --- MAINTAINERS | 7 ++- 1

Re: [1/2] PR 78736: New warning -Wenum-conversion

2017-07-31 Thread Prathamesh Kulkarni
On 11 July 2017 at 17:59, Prathamesh Kulkarni wrote: > On 13 June 2017 at 01:47, Joseph Myers wrote: >> This is OK with one fix: >> >>> +C ObjC Var(warn_enum_conversion) Init(0) Warning LangEnabledBy(C Objc,Wall) >> >> I believe the

Re: [PATCH 00/19] cleanup of memory stats prototypes

2017-07-31 Thread Jeff Law
On 07/27/2017 02:43 AM, Richard Biener wrote: > On Thu, Jul 27, 2017 at 10:30 AM, wrote: >> From: Trevor Saunders >> >> The preC++ way of passing information about the call site of a function was >> to >> use a macro that passed __file__,

Re: [PATCH] Make mempcpy more optimal (PR middle-end/70140).

2017-07-31 Thread Jeff Law
On 07/20/2017 12:59 AM, Martin Liška wrote: > Hello. > > Following patch does sharing of expansion for mem{p,}cpy and also strpcy > (with a known constant as source) > so that we use same type of expansion (direct insns emission, direct emission > with a loop instruction and > library call). As

Re: [PATCH 6/6] qsort comparator consistency checking

2017-07-31 Thread Alexander Monakov
On Mon, 31 Jul 2017, Jeff Law wrote: > I must have missed something. Can't you just define > > qsort (BASE, NMEMB, SIZE, COMPARE) into > > qsort_chk (BASE, NMEMB, SIZE, COMPARE) > > That shouldn't affect the qsort from vec? Right? Or am I missing something If you do #define qsort(base,

Re: [RFC] propagate malloc attribute in ipa-pure-const pass

2017-07-31 Thread Prathamesh Kulkarni
On 23 May 2017 at 19:10, Prathamesh Kulkarni wrote: > On 19 May 2017 at 19:02, Jan Hubicka wrote: >>> >>> * LTO and memory management >>> This is a general question about LTO and memory management. >>> IIUC the following sequence takes place during

Re: Overwhelmed by GCC frustration

2017-07-31 Thread Segher Boessenkool
On Mon, Jul 31, 2017 at 11:54:12AM -0600, Jeff Law wrote: > On 07/31/2017 11:23 AM, Segher Boessenkool wrote: > > On Tue, Aug 01, 2017 at 01:12:41AM +0900, Oleg Endo wrote: > >> I could probably write a similar rant. This is the life of a "minority > >> target programmer". Most development

[Bug c++/81636] New: Confusing warning message containing "#‘obj_type_ref’ not supported by expression#"

2017-07-31 Thread abbeyj+gcc at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81636 Bug ID: 81636 Summary: Confusing warning message containing "#‘obj_type_ref’ not supported by expression#" Product: gcc Version: 7.1.0 Status: UNCONFIRMED

[Bug c++/81632] spurious -Wterminate warning about throw in destructor

2017-07-31 Thread daniel.kruegler at googlemail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81632 Daniel Krügler changed: What|Removed |Added CC||daniel.kruegler@googlemail.

[Bug target/81635] New: nvptx SLP test cases regressions

2017-07-31 Thread tschwinge at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81635 Bug ID: 81635 Summary: nvptx SLP test cases regressions Product: gcc Version: 8.0 Status: UNCONFIRMED Severity: minor Priority: P3 Component: target

Re: [PATCH 6/6] qsort comparator consistency checking

2017-07-31 Thread Jeff Law
On 07/15/2017 02:47 PM, Alexander Monakov wrote: > This is the updated qsort comparator verifier. > > Since we have vec::qsort(cmp), the patch uses the macro argument counting > trick to redirect only the four-argument invocations of qsort to qsort_chk. > I realize that won't win much sympathies,

Re: [PATCH 1/2] x86,s390: add compiler memory barriers when expanding atomic_thread_fence (PR 80640)

2017-07-31 Thread Alexander Monakov
On Mon, 31 Jul 2017, Jeff Law wrote: > > Please consider that expand_mem_thread_fence is used to place fences around > > seq-cst atomic loads when the backend doesn't provide a direct > > pattern. > > With compiler barriers on both sides of the machine barrier, the generated > > sequence for a

Re: [PATCH] Add -std=c++2a

2017-07-31 Thread Joseph Myers
On Thu, 20 Jul 2017, Andrew Sutton wrote: > This adds a new C++ dialect, enabled by -std=c++2a. I don't see documentation here. I'd expect additions to invoke.texi and standards.texi discussing the new option. -- Joseph S. Myers jos...@codesourcery.com

[Bug c/79959] -Wimplicit-fallthrough doesn't recognize some more complex exit cases

2017-07-31 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79959 Eric Gallager changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

Re: Overwhelmed by GCC frustration

2017-07-31 Thread Jeff Law
On 07/31/2017 11:23 AM, Segher Boessenkool wrote: > On Tue, Aug 01, 2017 at 01:12:41AM +0900, Oleg Endo wrote: >> I could probably write a similar rant. This is the life of a "minority >> target programmer". Most development efforts are being done with >> primary targets in mind. And as a

Re: [PATCH] Fix libquadmath regression (bootstrap failure) on FreeBSD

2017-07-31 Thread Joseph Myers
On Wed, 19 Jul 2017, Jakub Jelinek wrote: > > And can you please push this > > to glibc as well (which I do not have access to)? > > glibc uses u_int32_t in all the places of *powl.c where libquadmath > uses uint32_t, and various other files, so I guess it is intentional. I'd consider it a

[Bug c/29970] mixing ({...}) with VLA leads to massive breakage

2017-07-31 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=29970 Eric Gallager changed: What|Removed |Added CC||egallager at gcc dot gnu.org

[Bug target/81622] [7/8 Regression] ICE on invalid altivec code with ppc64{,le}

2017-07-31 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81622 Jakub Jelinek changed: What|Removed |Added Attachment #41875|0 |1 is obsolete|

Re: Overwhelmed by GCC frustration

2017-07-31 Thread Jeff Law
On 07/31/2017 10:49 AM, Joel Sherrill wrote: > > > On 7/31/2017 11:12 AM, Oleg Endo wrote: >> On Mon, 2017-07-31 at 15:25 +0200, Georg-Johann Lay wrote: >>> Around 2010, someone who used a code snipped that I published in >>> a wiki, reported that the code didn't work and hang in an >>> endless

[Bug c/79696] missing -Wunused-result on calls to malloc() and calloc()

2017-07-31 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79696 Eric Gallager changed: What|Removed |Added Status|UNCONFIRMED |WAITING Last reconfirmed|

[Bug target/81622] [7/8 Regression] ICE on invalid altivec code with ppc64{,le}

2017-07-31 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81622 --- Comment #9 from Jakub Jelinek --- I take back the ARRAY_TYPE thing, apparently it is different for C vs. C++, in C one always sees there POINTER_TYPE, while in C++ always ARRAY_TYPE. Anyway, your patch seems to be wrong, POINTER_TYPE_P's

[Bug c/79667] spurious -Wunused-variable on a local array of struct declared unused

2017-07-31 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79667 Eric Gallager changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

Re: [PATCH 5/6] haifa-sched.c: give up qsort checking when autoprefetch heuristic is in use

2017-07-31 Thread Jeff Law
On 07/15/2017 02:47 PM, Alexander Monakov wrote: > The autopref_rank_for_schedule sub-comparator and its subroutine > autopref_rank_data lack transitivity. Skip checking if they are in use. > > This heuristic is disabled by default everywhere except ARM and AArch64, > so on other targets this

[Bug c/79688] ICE with a RTL test-case and -O1 provided

2017-07-31 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79688 Eric Gallager changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

Re: [PATCH], PR target/81593, Optimize PowerPC vector sets coming from a vector extracts

2017-07-31 Thread Bill Schmidt
> On Jul 31, 2017, at 12:40 PM, Michael Meissner > wrote: > > On Sun, Jul 30, 2017 at 09:00:58AM -0500, Bill Schmidt wrote: (define_insn "vsx_concat_" - [(set (match_operand:VSX_D 0 "gpc_reg_operand" "=,we") + [(set (match_operand:VSX_D 0

Re: [PATCH], PR target/81593, Optimize PowerPC vector sets coming from a vector extracts

2017-07-31 Thread Michael Meissner
On Sun, Jul 30, 2017 at 09:00:58AM -0500, Bill Schmidt wrote: > >> (define_insn "vsx_concat_" > >> - [(set (match_operand:VSX_D 0 "gpc_reg_operand" "=,we") > >> + [(set (match_operand:VSX_D 0 "vsx_register_operand" "=wa,we") > >>(vec_concat:VSX_D > >> - (match_operand: 1 "gpc_reg_operand"

Re: [PATCH 4/6] lra-assigns.c: give up on qsort checking in assign_by_spills

2017-07-31 Thread Jeff Law
On 07/15/2017 02:47 PM, Alexander Monakov wrote: > The reload_pseudo_compare_func comparator, when used from assign_by_spills, > can be non-transitive, indicating A < B < C < A if both A and C satisfy > !bitmap_bit_p (_reload_pseudos, rAC), but B does not. > > This function was originally a

[Bug target/81622] [7/8 Regression] ICE on invalid altivec code with ppc64{,le}

2017-07-31 Thread wschmidt at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81622 --- Comment #8 from Bill Schmidt --- I should clarify that Richard reviewed the VEC_LD / VEC_ST code chunks. The other pieces predate me. The stylistic issues were copied from another place at the time and I missed those, sorry about that...

Re: [PATCH], PR target/81593, Optimize PowerPC vector sets coming from a vector extracts

2017-07-31 Thread Michael Meissner
On Fri, Jul 28, 2017 at 04:08:50PM -0500, Segher Boessenkool wrote: > Hi! > > On Thu, Jul 27, 2017 at 07:21:14PM -0400, Michael Meissner wrote: > > This patches optimizes the PowerPC vector set operation for 64-bit doubles > > and > > longs where the elements in the vector set may have been

[Bug tree-optimization/81633] [7/8 Regression] Incorrect floating point result with tree vectoriser

2017-07-31 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81633 --- Comment #4 from Jakub Jelinek --- I'm afraid the tree-vect-slp.c change is completely wrong, the original change in https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01090.html if the oprnd == NULL has child_index++; looks reasonable to me. It

Re: [PATCH 1/2] x86,s390: add compiler memory barriers when expanding atomic_thread_fence (PR 80640)

2017-07-31 Thread Jeff Law
On 07/31/2017 11:02 AM, Alexander Monakov wrote: > On Mon, 31 Jul 2017, Jeff Law wrote: In the middle end patch, do we need a barrier before the fence as well? The post-fence barrier prevents reordering the fence with anything which follows the fence. But do we have to also prevent

[Bug target/81622] [7/8 Regression] ICE on invalid altivec code with ppc64{,le}

2017-07-31 Thread wschmidt at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81622 --- Comment #7 from Bill Schmidt --- This code was reviewed and approved by Richard back when it was first written. It's been some time since this was written, so I don't recall the origin of the array type, but it was definitely necessary.

Re: [PATCH] enhance overflow and truncation detection in strncpy and strncat (PR 81117)

2017-07-31 Thread Jeff Law
On 07/08/2017 02:45 PM, Martin Sebor wrote: > PR 81117 asks for improved detection of common misuses(*) of > strncpy and strncat. The attached patch is my solution. It > consists of three related sets of changes: > > 1) Adds a new option, -Wstringop-truncation, that diagnoses calls > to

Re: Overwhelmed by GCC frustration

2017-07-31 Thread Segher Boessenkool
On Tue, Aug 01, 2017 at 01:12:41AM +0900, Oleg Endo wrote: > I could probably write a similar rant.  This is the life of a "minority > target programmer".  Most development efforts are being done with > primary targets in mind.  And as a result, most changes are being > tested only on such

Re: [PATCH] libstdc++: Support std::is_aggregate on clang++ (was [cfe-dev] clang++: std::is_aggregate unusable with clang-5.0/libstdc++-7)

2017-07-31 Thread Tim Song
On Mon, Jul 31, 2017 at 11:13 AM, Tim Song wrote: > > https://clang.llvm.org/docs/LanguageExtensions.html#checks-for-type-trait-primitives > seems to suggest using __has_extension instead. Hmm, that doesn't work. Oh well.

Re: [PATCH 0/6] [i386] PR80969 Fix ICE with -mabi=ms -mavx512f

2017-07-31 Thread Daniel Santos
Well I just learned how to test 32-bit earlier and I've uncovered a problem when running 32-bit tests. Do you want me to commit the the two patches (squashed together) in the mean time? Thanks, Daniel

[PATCH, Fortran] Slight cleanup in set_dec_flags

2017-07-31 Thread Fritz Reese
All, Attached is a trivial patch which exists for posterity: currently set_dec_flags(int value) enables support for legacy standards and disables warnings for them etc... Unfortunately it does this irrespective of the int value parameter. Since set_dec_flags(0) is called on initialization, the

[PATCH, Fortran] Correctly set -fd-lines-as-comments with -fdec

2017-07-31 Thread Fritz Reese
All, This is a simple patch. The original intent was for -fdec to set -fd-lines-as-comments by default if flag_d_lines was unspecified by the user. However, currently flag_d_lines is interrogated in set_dec_flags(), usually before its final value is determined. The attached patch fixes this

Re: Overwhelmed by GCC frustration

2017-07-31 Thread Andrew Haley
On 31/07/17 17:12, Oleg Endo wrote: > On Mon, 2017-07-31 at 15:25 +0200, Georg-Johann Lay wrote: >> Around 2010, someone who used a code snipped that I published in >> a wiki, reported that the code didn't work and hang in an >> endless loop. Soon I found out that it was due to some GCC >>

Re: Overwhelmed by GCC frustration

2017-07-31 Thread Joseph Myers
On Tue, 1 Aug 2017, Oleg Endo wrote: > To improve the situation, we'd need a lot more target specific tests > which test for those regressions that you have mentioned.  Then of > course somebody has to run all those tests on all those various > targets.  I think that's the biggest problem.  But

Re: C PATCH to further improve diagnostic for -Wsign-compare (PR c/81417)

2017-07-31 Thread Martin Sebor
On 07/31/2017 10:05 AM, Marek Polacek wrote: On Mon, Jul 31, 2017 at 09:54:03AM -0600, Martin Sebor wrote: On 07/31/2017 08:14 AM, Marek Polacek wrote: This patch improves the diagnostic of -Wsign-compare for ?: by also printing the types, similarly to my recent patch. But we can do even

Re: [PATCH 1/2] x86,s390: add compiler memory barriers when expanding atomic_thread_fence (PR 80640)

2017-07-31 Thread Alexander Monakov
On Mon, 31 Jul 2017, Jeff Law wrote: > >> In the middle end patch, do we need a barrier before the fence as well? > >> The post-fence barrier prevents reordering the fence with anything which > >> follows the fence. But do we have to also prevent reordering the fence > >> with prior instructions

[Bug bootstrap/81033] [8 Regression] Revision r249019 breaks bootstrap on darwin

2017-07-31 Thread dominiq at lps dot ens.fr
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81033 --- Comment #25 from Dominique d'Humieres --- I have posted the results on darwin for r250610 at https://gcc.gnu.org/ml/gcc-testresults/2017-07/msg02582.html. I see 646 failures compared to 318 with r249104. I am planning to open new Pos for

[Bug testsuite/80759] gcc.target/x86_64/abi/ms-sysv FAILs

2017-07-31 Thread dominiq at lps dot ens.fr
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80759 Dominique d'Humieres changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

Re: Overwhelmed by GCC frustration

2017-07-31 Thread Joel Sherrill
On 7/31/2017 11:12 AM, Oleg Endo wrote: On Mon, 2017-07-31 at 15:25 +0200, Georg-Johann Lay wrote: Around 2010, someone who used a code snipped that I published in a wiki, reported that the code didn't work and hang in an endless loop. Soon I found out that it was due to some GCC problem,

[Bug tree-optimization/81633] [7/8 Regression] Incorrect floating point result with tree vectoriser

2017-07-31 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81633 --- Comment #3 from Jakub Jelinek --- In *.ifcvt dump we have _69 = identity[j_31][0]; _71 = _69 * _69; tmp[j_31][0] = _71; _77 = identity[j_31][1]; _78 = _69 * _77; tmp[j_31][1] = _78; _84 = identity[j_31][2]; _85 = _69 * _84;

Re: [PATCH, rs6000] Fix PR81622

2017-07-31 Thread Jakub Jelinek
On Mon, Jul 31, 2017 at 11:19:26AM -0500, Bill Schmidt wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81622 reports an ICE-on-invalid > for the vec_ld and vec_st built-in functions. This fires when the last > argument of the built-in is not a pointer or array type, as is required. > We

[PATCH, rs6000] Fix PR81622

2017-07-31 Thread Bill Schmidt
Hi, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81622 reports an ICE-on-invalid for the vec_ld and vec_st built-in functions. This fires when the last argument of the built-in is not a pointer or array type, as is required. We break on this during early expansion of the built-ins into tree code

[Bug fortran/81615] save-temps and gfortran produces *.f90 files instead of *.i or *i90 files

2017-07-31 Thread tkoenig at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81615 Thomas Koenig changed: What|Removed |Added Status|WAITING |NEW --- Comment #3 from Thomas Koenig

Re: Overwhelmed by GCC frustration

2017-07-31 Thread Oleg Endo
On Mon, 2017-07-31 at 15:25 +0200, Georg-Johann Lay wrote: > Around 2010, someone who used a code snipped that I published in > a wiki, reported that the code didn't work and hang in an > endless loop.  Soon I found out that it was due to some GCC > problem, and I got interested in fixing the

[PATCH] Fix reassoc var_bound range test optimization (PR tree-optimization/81588)

2017-07-31 Thread Jakub Jelinek
Hi! This patch fixes a couple of issues in optimize_range_tests_var_bound. One is that if we have ranges[i].in_p, we should be inverting the comparison rather than just swapping or not swapping operands. Then because we want to handle only LT/LE, we want to swap operands and the comparison code

Re: [WWW PATCH]: Mention that x86 now supports "naked" function attribute.

2017-07-31 Thread Gerald Pfeifer
On Mon, 31 Jul 2017, Uros Bizjak wrote: > One liner that mentions new addition to x86 port. > > OK for wwwdocs? Sure. (Even without asking. ;-) Thanks, Gerald

Re: C PATCH to further improve diagnostic for -Wsign-compare (PR c/81417)

2017-07-31 Thread Marek Polacek
On Mon, Jul 31, 2017 at 09:54:03AM -0600, Martin Sebor wrote: > On 07/31/2017 08:14 AM, Marek Polacek wrote: > > This patch improves the diagnostic of -Wsign-compare for ?: by also printing > > the types, similarly to my recent patch. But we can do even better here if > > we > > actually point

  1   2   3   >