Re: [cfe-dev] C++11: new builtin to allow constexpr to be applied to performance-critical functions

2012-10-20 Thread Jeffrey Yasskin
On Fri, Oct 19, 2012 at 10:50 PM, Chandler Carruth chandl...@google.com wrote: On Fri, Oct 19, 2012 at 10:04 PM, Richard Smith rich...@metafoo.co.uk wrote: [Crossposted to both GCC and Clang dev lists] Hi, One issue facing library authors wanting to use C++11's constexpr feature is that

Re: Dealing with C++98/11 ABI incompatibilities

2012-07-03 Thread Jeffrey Yasskin
On Tue, Jul 3, 2012 at 1:02 PM, Paolo Carlini paolo.carl...@oracle.com wrote: Hi, On 07/03/2012 09:18 PM, Jason Merrill wrote: 2) Object layout changes to std::list and std::basic_string.  For these types, there is no way to both retain backward compatibility with older C++98 code and

Re: C++98/C++11 ABI compatibility for gcc-4.7

2012-05-23 Thread Jeffrey Yasskin
I've posted this to http://gcc.gnu.org/wiki/Cxx11AbiCompatibility. I would greatly appreciate any corrections or improvements. On Tue, May 22, 2012 at 9:04 AM, Jeffrey Yasskin jyass...@googlers.com wrote: I've put together the following description of C++98/11 ABI (in)compatibility, so people

C++98/C++11 ABI compatibility for gcc-4.7

2012-05-22 Thread Jeffrey Yasskin
I've put together the following description of C++98/11 ABI (in)compatibility, so people can tell which libraries need to be recompiled. This is useful when you've bought a library that didn't come with source code, and you're trying to figure out if you need to buy a new version. I think this

Re: [google/gcc-4_7] Allow static const floats unless -pedantic is passed (issue6212051)

2012-05-15 Thread Jeffrey Yasskin
Looks good to me. Yay for kicking the can down the road. ;) On Tue, May 15, 2012 at 12:57 PM, Ollie Wild a...@google.com wrote: To be applied to google/gcc-4_7. Allow static const floats unless -pedantic is passed. This patch allows us to migrate to C++11 more incrementally, since we can

Re: [google/integration] Extend C++11 UDLs to be compatible with inttypes.h macros (issue6104051)

2012-04-22 Thread Jeffrey Yasskin
Could you try to get this into mainline instead of just the google branches? In http://gcc.gnu.org/PR52538, Jonathan sounded like he'd consider accepting it. On Sun, Apr 22, 2012 at 7:54 PM, Ollie Wild a...@google.com wrote: Add new option, -Wreserved-user-defined-literal. This option, which

Re: [google/integration] Extend C++11 UDLs to be compatible with inttypes.h macros (issue6104051)

2012-04-22 Thread Jeffrey Yasskin
be accepted into trunk. Ollie On Sun, Apr 22, 2012 at 10:10 PM, Jeffrey Yasskin jyass...@google.com wrote: Could you try to get this into mainline instead of just the google branches? In http://gcc.gnu.org/PR52538, Jonathan sounded like he'd consider accepting it. On Sun, Apr 22, 2012 at 7:54 PM

Re: [google/integration] Extend C++11 UDLs to be compatible with inttypes.h macros (issue6104051)

2012-04-22 Thread Jeffrey Yasskin
Thanks! On Sun, Apr 22, 2012 at 8:32 PM, Ollie Wild a...@google.com wrote: Okay, I'll send out a trunk patch for review now, too. Ollie On Sun, Apr 22, 2012 at 10:29 PM, Jeffrey Yasskin jyass...@google.com wrote: Let's let the discussion _start_ before assuming it'll be protracted. ;) I

Re: [patch] Fix PR52822 (stable_partition move-assigns object to itself) in trunk, 4.7, and 4.6

2012-04-06 Thread Jeffrey Yasskin
On Wed, Apr 4, 2012 at 11:09 PM, Paolo Carlini paolo.carl...@oracle.com wrote: Hi, The attached patches fix http://gcc.gnu.org/PR52822, and have been tested with `make check-c++` on linux-x86_64. The trunk patch applies and tests cleanly on gcc-4_7-branch. The gcc-4_6-branch patch is

[patch] Fix PR52822 (stable_partition move-assigns object to itself) in trunk, 4.7, and 4.6

2012-04-03 Thread Jeffrey Yasskin
that there's no way to force get_temporary_buffer to return a short buffer, I'm not sure how to improve it. It might be possible to use set_memory_limits(), but that would require a very complex test program to make sure exactly the right operator new call fails. Jeffrey Yasskin

[google] Fix PR52822 in google's gcc-4.6 branch (issue5975063)

2012-04-02 Thread Jeffrey Yasskin
be happy to fix up the google branch to match whatever gets accepted for gcc-4_6-branch once that's decided. Tested with `make check` on x86-64-linux, and I'll check this against the build I originally noticed the problem in before committing it. 2012-04-02 Jeffrey Yasskin jyass...@google.com

[google] Work around PR52796 by replacing empty packs with explicit overloads. (issue5971053)

2012-03-30 Thread Jeffrey Yasskin
in valgrind for each changed location. Some of the insert_aux locations appear inaccessible because of missing emplace() functions. I plan to only apply this to the google/gcc-4_6 branch, since gcc-4.7 already makes these cases work properly. 2012-03-30 Jeffrey Yasskin jyass...@google.com

Re: Long-term plan for C++98/C++11 incompatibility

2011-12-15 Thread Jeffrey Yasskin
On Mon, Oct 10, 2011 at 5:07 PM, Gabriel Dos Reis g...@integrable-solutions.net wrote: On Mon, Oct 10, 2011 at 5:25 PM, Joe Buck joe.b...@synopsys.com wrote: On Fri, Oct 07, 2011 at 07:35:17PM -0700, Gabriel Dos Reis wrote: C++11 is essentially binary incompatible with C++98. Only partially.  

[patch][google] Backport r176665 to google/gcc-4_6 making narrowing conversions a pedwarn.

2011-11-02 Thread Jeffrey Yasskin
it in a few hours unless I hear complaints. c-family/ChangeLog.google-4_6: 2011-11-02 Jeffrey Yasskin jyass...@google.com Backport from rev 176665 2011-07-22 Jason Merrill ja...@redhat.com * c.opt (Wnarrowing): New. cp/ChangeLog.google-4_6: 2011-11-02 Jeffrey Yasskin

Re: [patch][google] Allow static const floats unless -pedantic is passed. (issue 5306071)

2011-10-28 Thread Jeffrey Yasskin
them to use constexpr. We should NOT forward-port this to any gcc-4.7 branches. gcc/cp/ChangeLog.google-4_6 2011-10-28 Jeffrey Yasskin jyass...@google.com google ref 5514746; backport of r179121 Modified locally to only block static const literals in -pedantic mode

Re: C++11 atomic library notes

2011-10-05 Thread Jeffrey Yasskin
On Wed, Oct 5, 2011 at 5:49 AM, Andrew MacLeod amacl...@redhat.com wrote: On 10/05/2011 12:14 AM, Jeffrey Yasskin wrote: I see two ways out: 1) Say that accessing a non-volatile atomic through a volatile reference or pointer causes undefined behavior. The standard doesn't say

Re: C++11 atomic library notes

2011-10-04 Thread Jeffrey Yasskin
On Fri, Sep 30, 2011 at 1:36 PM, Andrew MacLeod amacl...@redhat.com wrote: I've been working on GCC's C++11 atomic implementation. In discussions with Lawrence, I've recently discovered a fundamental change in what libstdc++-v3 is likely to provide as far as an implementation. Previously,

Re: [PATCH] Propagate source locations from function_decls to their template_decls

2011-08-01 Thread Jeffrey Yasskin
Thanks. Committed to gcc-4_6-branch in r176851 and the google/gcc-4_6 branch in r177072. On Wed, Jul 27, 2011 at 11:46 AM, Jason Merrill ja...@redhat.com wrote: Yes. Jeffrey Yasskin jyass...@google.com wrote: Thanks. I'll commit to trunk in the morning when I can be around to watch

Re: [google][patch] Put make_heap's declaration on a single line to work around inconsistent debug locations

2011-08-01 Thread Jeffrey Yasskin
And reverted in r177083 because I fixed the underlying problem. On Fri, Jul 22, 2011 at 11:06 PM, Ollie Wild a...@google.com wrote: Ok for inclusion in google/gcc-4_6. Ollie On Fri, Jul 22, 2011 at 5:46 PM, Jeffrey Yasskin jyass...@google.com wrote: For the google/gcc-4_6 branch _only_

Re: [PATCH] Propagate source locations from function_decls to their template_decls

2011-07-27 Thread Jeffrey Yasskin
Thanks. I'll commit to trunk in the morning when I can be around to watch for breakage. Is this also ok for gcc-4_6-branch? On Tue, Jul 26, 2011 at 7:16 PM, Jason Merrill ja...@redhat.com wrote: Ok. Jeffrey Yasskin jyass...@google.com wrote: Hi Jason. Paolo suggested I ping you directly

[PATCH] Propagate source locations from function_decls to their template_decls

2011-07-26 Thread Jeffrey Yasskin
to check it in to trunk, and will propagate it to the gcc-4_6-branch if you think that's the right thing to do. No more tests fail than in http://gcc.gnu.org/ml/gcc-testresults/2011-07/msg02995.html. gcc/cp/ChangeLog: 2011-07-26 Jeffrey Yasskin jyass...@google.com * pt.c

[google][patch] Put make_heap's declaration on a single line to work around inconsistent debug locations

2011-07-22 Thread Jeffrey Yasskin
checker. Until I can find why the locations are inconsistent, we can work around the problem by putting the name and closing ')' on the same line. libstdc++-v3/ChangeLog 2011-07-22 Jeffrey Yasskin jyass...@google.com * include/bits/stl_heap.h(make_heap): Remove a newline. Index: libstdc

[google] Merge r173574 to google/gcc-4_6 to fix an incompatibility between C++98 and C++0x (issue4592057)

2011-06-14 Thread Jeffrey Yasskin
-c++` on x86_64-unknown-linux-gnu. 2011-06-14 Jeffrey Yasskin jyass...@google.com Merge r173574 to google/gcc-4_6. * include/c_global/cmath (acosh, asinh, atanh, cbrt, copysign, erf, erfc, exp2, expm1, fdim, fma, fmax, hypot, ilogb, lgamma, llrint, llround, log1p

Re: [google] Merge r173574 to google/gcc-4_6 to fix an incompatibility between C++98 and C++0x (issue4592057)

2011-06-14 Thread Jeffrey Yasskin
On Tue, Jun 14, 2011 at 12:38 PM, Diego Novillo dnovi...@google.com wrote: On Tue, Jun 14, 2011 at 14:45, Jeffrey Yasskin jyass...@google.com wrote: In C++0x mode, without this patch, calls to a user-defined trunc() function with an argument in namespace std and a parameter type that has

[patch] Import iota and is_sorted from std to __gnu_cxx in C++0x mode. (issue4384043)

2011-04-06 Thread Jeffrey Yasskin
: `make -k check-c++` on x86_64-unknown-linux-gnu. (still running) libstdc++-v3/ChangeLog: 2011-04-06 Jeffrey Yasskin jyass...@google.com * include/ext/algorithm (is_sorted): In C++0x mode import from namespace std. * include/ext/numeric (iota): In C++0x mode import from

[patch] Fix two C++ errors in libstdc++. (issue4341041)

2011-03-31 Thread Jeffrey Yasskin
this change. libstdc++-v3/ChangeLog: 2011-03-31 Jeffrey Yasskin jyass...@google.com * libsupc++/exception_ptr.h: Forward-declare std::type_info. * libsupc++/nested_exception.h (__throw_with_nested): Remove a redundant default argument from std::__throw_with_nested. diff

Re: [patch] Fix two C++ errors in libstdc++. (issue4341041)

2011-03-31 Thread Jeffrey Yasskin
On Thu, Mar 31, 2011 at 12:49 PM, Paolo Carlini paolo.carl...@oracle.com wrote: On 03/31/2011 09:41 PM, Paolo Carlini wrote: I think this is a candidate to backport to libstdc++-4.6.1. exception_ptr.h needs the forward declaration because it's included fromtypeinfo  beforetypeinfo  defines

Re: Proposal: Improving patch tracking and review using Rietveld

2011-01-27 Thread Jeffrey Yasskin
On Thu, Jan 27, 2011 at 6:53 AM, Diego Novillo dnovi...@google.com wrote: On Thu, Jan 27, 2011 at 09:49, Richard Guenther richard.guent...@gmail.com wrote: Sure, as it is non-invasive trying it is ok.  I just wanted to see if it fixes any existing problem - it does not seem to (apart from