[patch][trivial] Fix signed integer overflow in cp-demangle.c (d_number)

2019-10-28 Thread Paul Pluzhnikov via gcc-patches
Greetings, This is rather on the trivial side. Google fuzzer found signed integer overflow in d_number, given this input: _ZZccDF2147483647 Google ref: b141647507. Ok for trunk? Thanks, libiberty/ChangeLog 2019-10-28 Paul Pluzhnikov * cp-demangle (d_number): Avoid signed int

[google][gcc-4.9][committed] Add inexpensive bounds checks to std::array

2015-08-01 Thread Paul Pluzhnikov
Greetings, For google b/9650176, attached patch adds bounds checks to std::array and updates expected line numbers in tests. This is similar to the checks that we do for std::vector. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56109 Committed as r226465. Thanks, -- Paul Pluzhnikov

Re: Ok to backport r210653 (fix for PR58930) to gcc-4_9-branch?

2014-07-01 Thread Paul Pluzhnikov
On Fri, Jun 27, 2014 at 12:51 PM, Jason Merrill ja...@redhat.com wrote: On 06/27/2014 11:04 AM, Paul Pluzhnikov wrote: Ok to backport r210653 (fix for PR58930) to gcc-4_9-branch? OK, yes. Thanks. Committed attached patch as r212207. Tested on Linux/x86_64, no regressions. -- Paul

Re: Ok to backport r210653 (fix for PR58930) to gcc-4_9-branch?

2014-07-01 Thread Paul Pluzhnikov
... In the mean time, r212208 deleted the doubling. Thanks, -- Paul Pluzhnikov

Ok to backport r210653 (fix for PR58930) to gcc-4_9-branch?

2014-06-27 Thread Paul Pluzhnikov
a few issues. Thus certainly no objections from me. Just ask on the mailing list: if Jason agrees, please go ahead. Thanks. Ok to backport r210653 (fix for PR58930) to gcc-4_9-branch? (If not, I'll backport to google/gcc-4_9 instead.) Thanks, -- Paul Pluzhnikov

Re: detecting container overflow bugs in std::vector

2014-05-26 Thread Paul Pluzhnikov
no longer necessary/useful with asan? This was some unrelated change. Paul? That appears to have been a merge mistake on my part. I'll add them back. Thanks for noticing. -- Paul Pluzhnikov

Re: [google gcc-4_8][x86_64]Optimize access to globals in -fpie -pie builds with copy relocations

2014-05-22 Thread Paul Pluzhnikov
+Target Report Var(ix86_ld_pie_copyrelocs) Init(0) +Use linker copy relocs for pie They are not linker copy relocs, they are simply copy relocations. So I would call the option -mcopy-relocs and be done with that. But this is just bike-shedding :-) LGTM. -- Paul Pluzhnikov

Re: [google/gcc-4_8] Add -fskeleton-type-units flag.

2014-05-12 Thread Paul Pluzhnikov
Add -f[no-]skeleton-type-units flag to control whether GCC generates skeleton type units. This patch is for the google/gcc-4_8 branch. Ok for Google branch. Thanks, -- Paul Pluzhnikov

Re: [patch] Fix PR59295 -- move redundant friend decl warning under -Wredundant-decls

2014-04-11 Thread Paul Pluzhnikov
Ping? On Fri, Mar 21, 2014 at 9:16 AM, Paul Pluzhnikov ppluzhni...@google.com wrote: Greetings, To fix PR59295, this patch moves (generally useless) warning about repeated / redundant friend declarations under -Wredundant-decls. Tested on Linux/x86_64 with no regressions. Ok for trunk

Re: [patch] Fix PR59295 -- remove useless warning

2014-03-21 Thread Paul Pluzhnikov
On Fri, Mar 21, 2014 at 1:58 AM, Fabien Chêne fabien.ch...@gmail.com wrote: Why not making this warning suppressable, instead of removing it ? Shouldn't it fall under -W(no)-redundant-decls ? Thanks. I'll revise the patch to do that. -- Paul Pluzhnikov

[patch] Fix PR59295 -- move redundant friend decl warning under -Wredundant-decls

2014-03-21 Thread Paul Pluzhnikov
Greetings, To fix PR59295, this patch moves (generally useless) warning about repeated / redundant friend declarations under -Wredundant-decls. Tested on Linux/x86_64 with no regressions. Ok for trunk once it opens in stage 1? Thanks, -- 2014-03-21 Paul Pluzhnikov ppluzhni...@google.com

[patch] Fix PR59295 -- remove useless warning

2014-03-20 Thread Paul Pluzhnikov
, Google ref: b/11542609 -- 2014-03-20 Paul Pluzhnikov ppluzhni...@google.com PR c++/59295 * gcc/cp/friend.c (add_friend): Remove complain parameter. (do_friend): Adjust. * gcc/cp/cp-tree.h (add_friend): Adjust. * gcc/cp/pt.c (instantiate_class_template_1

Re: [patch] Fix array overflow in gcc.dg/vect/no-vfa-vect-depend-2.c

2014-02-18 Thread Paul Pluzhnikov
Jakub, On Mon, Feb 10, 2014 at 12:09 AM, Jakub Jelinek ja...@redhat.com wrote: On Tue, Feb 04, 2014 at 04:59:14PM -0800, Paul Pluzhnikov wrote: gcc/testsuite/ChangeLog: 2014-02-04 Paul Pluzhnikov ppluzhni...@google.com * gcc.dg/vect/no-vfa-vect-depend-2.c (main1): Fix buffer

Re: [patch] Fix array overflow in gcc.dg/vect/no-vfa-vect-depend-2.c

2014-02-09 Thread Paul Pluzhnikov
Ping? On Tue, Feb 4, 2014 at 5:08 PM, Paul Pluzhnikov ppluzhni...@google.com wrote: +cc jakub On Tue, Feb 4, 2014 at 4:59 PM, Paul Pluzhnikov ppluzhni...@google.com wrote: Greetings, The gcc.dg/vect/no-vfa-vect-depend-2.c failed for us, when linked with gold, but not when linked with BFD

[patch] Fix array overflow in gcc.dg/vect/no-vfa-vect-depend-2.c

2014-02-04 Thread Paul Pluzhnikov
Greetings, The gcc.dg/vect/no-vfa-vect-depend-2.c failed for us, when linked with gold, but not when linked with BFD ld. The problem appears to be off-by-one error causing array out of bounds access, fixed by attached patch. OK for trunk? Thanks, gcc/testsuite/ChangeLog: 2014-02-04 Paul

Re: [patch] Fix array overflow in gcc.dg/vect/no-vfa-vect-depend-2.c

2014-02-04 Thread Paul Pluzhnikov
+cc jakub On Tue, Feb 4, 2014 at 4:59 PM, Paul Pluzhnikov ppluzhni...@google.com wrote: Greetings, The gcc.dg/vect/no-vfa-vect-depend-2.c failed for us, when linked with gold, but not when linked with BFD ld. The problem appears to be off-by-one error causing array out of bounds access

Is testing libgomp outside of the build tree supported?

2014-02-03 Thread Paul Pluzhnikov
Greetings, We test GCC without access to the build tree (we only have convenient access to install and source trees). Building libgomp.c/affinity-1.c and libgomp.c++/affinity-1.C fails in such testing, because of '#include config.h' which is nowhere to be found. Is that a bug? Should I open a

[google][4.8] Add more inexpensive debug checks to vector, bitvector, deque

2014-01-06 Thread Paul Pluzhnikov
Greetings, For Google b/9127283, I've committed attached patch on google/gcc-4_8 branch. Related: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56109 This caught ~10 bugs for us. erase(end()) and pop_back() on empty vector appear to be most common. -- Paul Pluzhnikov Index: libstdc++-v3/include

[Google][gcc-4_8] Completed backport of r202818 from trunk to google/gcc-4_8 as r206071.

2013-12-17 Thread Paul Pluzhnikov
Greetings, I've finished backport of r202818 from trunk to google/gcc-4_8 as r206071. Thanks, -- Paul Pluzhnikov Index: libstdc++-v3/include/debug/array === --- libstdc++-v3/include/debug/array(revision 206038) +++ libstdc++-v3

[google gcc-4_8] Reverted r203873 and r203036

2013-11-15 Thread Paul Pluzhnikov
Greetings, I've reverted r203873 and r203036 in r204860 on google/gcc-4_8 branch. The r203036 changes output of std::sort when input has equivalent elements, and this breaks golden output tests, which we'll need to clean up. Thanks, -- Paul Pluzhnikov

[google gcc-4_8,integration][patch] Set abi-version to 0

2013-10-10 Thread Paul Pluzhnikov
Greetings, For Google b/10860844, I've committed the patch below on google gcc-4_8 (r203381) and integration (r203382) branches. This forces abi-version to be the latest available. 2013-10-10 Paul Pluizhnikov ppluzhni...@google.com * gcc/common.opt (flag_abi_version): Set to 0.

Re: [patch] Make cxxfilt demangle internal-linkage templates

2013-10-10 Thread Paul Pluzhnikov
Ian? Ping x4. On Wed, Sep 18, 2013 at 4:24 PM, Paolo Carlini paolo.carl...@oracle.com wrote: Original message: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00394.html I'm adding Ian in CC. -- Paul Pluzhnikov

Re: google branch breakage

2013-10-01 Thread Paul Pluzhnikov
problem likely exists on trunk, so please do tell how to configure GCC in order to reproduce it. Paolo, does attached patch look correct for trunk? Thanks, -- Paul Pluzhnikov Index: libstdc++-v3/src/c++11/snprintf_lite.cc

Re: google branch breakage

2013-10-01 Thread Paul Pluzhnikov
On Tue, Oct 1, 2013 at 8:56 AM, Jonathan Wakely jwakely@gmail.com wrote: On 1 October 2013 16:49, Paul Pluzhnikov wrote: The same problem likely exists on trunk, so please do tell how to configure GCC in order to reproduce it. The std::__7 namespace implies --enable-symvers=gnu-versioned

Re: google branch breakage

2013-10-01 Thread Paul Pluzhnikov
On Tue, Oct 1, 2013 at 9:12 AM, Oleg Smolsky oleg.smol...@riverbed.com wrote: On 2013-10-01 09:00, Paul Pluzhnikov wrote: 2013-10-01 Paul Pluzhnikov ppluzhni...@google.com * src/c++11/snprintf_lite.cc: Add missing _GLIBCXX_{BEGIN,END}_NAMESPACE_VERSION Thanks. This patch address

Re: google branch breakage

2013-10-01 Thread Paul Pluzhnikov
On Tue, Oct 1, 2013 at 9:16 AM, Paul Pluzhnikov ppluzhni...@google.com wrote: Thanks. I've also confirmed that trunk is similarly broken with --enable-symvers=gnu-versioned-namespace, and that the patch fixes that. Would you like me to build the whole compiler package as well as a test

[google gcc-4_8] Applied partial backport of r202818, r202832 and r202836.

2013-09-25 Thread Paul Pluzhnikov
Greetings, I committed partial backport of r202818, r202832 and r202836 to google/gcc-4_8 branch as r202927. 2013-09-25 Paul Pluzhnikov ppluzhni...@google.com * libstdc++-v3/config/abi/pre/gnu.ver: Add _ZSt24__throw_out_of_range_fmtPKcz * libstdc++-v3/src/c++11/Makefile.am

Re: [google integration,gcc-4_8] Additional lightweight debug checks for std::deque

2013-09-24 Thread Paul Pluzhnikov
On Mon, Sep 23, 2013 at 6:29 PM, Paul Pluzhnikov ppluzhni...@google.com wrote: I've committed the patch below to google/integration (r202856) and gcc-4_8 (r202857) branches. Google ref: b/10872448. I've committed r202880 to adjust line numbers for libstdc++ breakage on google/gcc-4_8 branch

Re: [patch] Make vector::at() assertion message more useful (try #2)

2013-09-23 Thread Paul Pluzhnikov
On 9/23/13 4:26 AM, Paolo Carlini wrote: m68k-linux/./libstdc++-v3/src/.libs/libstdc++.so: undefined reference to `int std::__int_to_charchar, unsigned int(char*, unsigned int, char const*, std::_Ios_Fmtflags, bool)' Reproduced on i686. Sorry about the trouble ... I would say, either make

Re: [patch] Make vector::at() assertion message more useful (try #2)

2013-09-23 Thread Paul Pluzhnikov
On 9/23/13 7:48 AM, Paul Pluzhnikov wrote: Testing this patch: libstdc++ tests finished with RUNTESTFLAGS='--target_board=unix\{-m32,-m64\}' Committed as r202832. Sorry about the trouble. -- 2013-09-23 Paul Pluzhnikov ppluzhni...@google.com * src/c++11/snprintf_lite.cc

Re: [patch] Make vector::at() assertion message more useful (try #2)

2013-09-23 Thread Paul Pluzhnikov
On 9/23/13 7:54 AM, Paolo Carlini wrote: Testing this patch: In fact, however, that unsigned long long instantiation isn't *unconditionally* available, see locale-inst.cc. Thanks, I think we have to use unsigned long as a fall back controlled by the same macro. And please add a comment

Re: [patch] Make vector::at() assertion message more useful (try #2)

2013-09-23 Thread Paul Pluzhnikov
On 9/23/13 9:24 AM, Paolo Carlini wrote: Does this look right? Yes. Nit, in the comment I would also explicitly mention locale-inst.cc. Done, submitted as r202836. 2013-09-23 Paul Pluzhnikov ppluzhni...@google.com * src/c++11/snprintf_lite.cc (__concat_size_t): Use

[google integration,gcc-4_8] Additional lightweight debug checks for std::deque

2013-09-23 Thread Paul Pluzhnikov
Greetings, I've committed the patch below to google/integration (r202856) and gcc-4_8 (r202857) branches. Google ref: b/10872448. This cought approximately 10 bugs in our code. See also r195357 (similar checks for std::vector) and PR 56109. Thanks, 2013-09-23 Paul Pluzhnikov ppluzhni

Re: [patch] Make vector::at() assertion message more useful (try #2)

2013-09-21 Thread Paul Pluzhnikov
. There are also tests that are failing there independently of my patch. Committed as r202818. Thanks, -- Paul Pluzhnikov

Re: [patch] Make cxxfilt demangle internal-linkage templates

2013-09-18 Thread Paul Pluzhnikov
Ping x3? 2013/9/11 Paul Pluzhnikov ppluzhni...@google.com: Ping x2? Original message: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00394.html Thanks, -- Paul Pluzhnikov

Re: [PATCH] Fix PR58417 -- r202700 appears to be causing ICEs

2013-09-18 Thread Paul Pluzhnikov
: New testcase. Thanks, -- Paul Pluzhnikov

Re: [patch] Make vector::at() assertion message more useful (try #2)

2013-09-18 Thread Paul Pluzhnikov
__builtin_sprintf. P.P.S. Sorry this patch grew ... I can split it into parts if that's easier to review. -- Paul Pluzhnikov libstdc++-v3/ChangeLog: * include/bits/functexcept.h (__throw_out_of_range_fmt): New. * src/c++11/functexcept.cc (__throw_out_of_range_fmt): New. * src

Re: [patch] Make vector::at() assertion message more useful (try #2)

2013-09-12 Thread Paul Pluzhnikov
... functions. I've added the new snprintf.cc to c++11/ rather than c++98/ as Paolo suggested, because the only current caller is in c++11/functexcept.cc Thanks, -- Paul Pluzhnikov libstdc++-v3/ChangeLog: 2013-09-12 Paul Pluzhnikov ppluzhni...@google.com * src/c++11/Makefile.am: Add

Re: [patch] Make cxxfilt demangle internal-linkage templates

2013-09-11 Thread Paul Pluzhnikov
Ping x2? Original message: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00394.html On Fri, Aug 16, 2013 at 6:10 PM, Paul Pluzhnikov ppluzhni...@google.com wrote: Ping? -- Paul Pluzhnikov

[patch] Make vector::at() assertion message more useful (try #2)

2013-09-04 Thread Paul Pluzhnikov
()); [The patch also doesn't include libstdc++-v3/libsupc++/Makefile.in, which I'll regenerate before submitting.] [Please CC me on any replies.] -- Paul Pluzhnikov 2013-09-04 Paul Pluzhnikov ppluzhni...@google.com * libstdc++-v3/config/abi/pre/gnu.ver: Add

Re: [patch] Make vector::at() assertion message more useful (try #2)

2013-09-04 Thread Paul Pluzhnikov
translation more difficult. 2. __index_out_of_range_msg() would have to return a string, which is heavier weight (in try#1 I just used snprintf, which was considered too heavy). Thanks, -- Paul Pluzhnikov

Re: [patch] Make vector::at() assertion message more useful (try #2)

2013-09-04 Thread Paul Pluzhnikov
++-v3/libsupc++/ ok? (Would probably be called snprintf_lite.cc or some such.) Is the version I've assigned to the symbol -- GLIBCXX_3.4.20 -- ok? Thanks, -- Paul Pluzhnikov

Re: [patch] Make cxxfilt demangle internal-linkage templates

2013-08-16 Thread Paul Pluzhnikov
Ping? On Wed, Aug 7, 2013 at 11:51 AM, Paul Pluzhnikov ppluzhni...@google.com wrote: The following source: templatetypename T static void f(); void g() { fint(); } results in _Z1fIiEvv under g++, but in _ZL1fIiEvv under clang. Richard Smith says: The ABI doesn't cover manglings

[patch google/gcc-4_8] Applied r201755 to google/gcc-4_8 branch

2013-08-14 Thread Paul Pluzhnikov
Greetings, I've committed r201755 on google/gcc-4_8 branch as r201761.

[patch] Make cxxfilt demangle internal-linkage templates

2013-08-07 Thread Paul Pluzhnikov
(since there is no ABI violation here), but c++filt should be able to handle this, and does with attached patch. Ok for trunk? Thanks, Google ref: b/10137049 --- Paul Pluzhnikov 2013-08-07 Paul Pluzhnikov ppluzhni...@google.com * cp-demangle.c (d_name): Handle internal-linkage templates

Re: [patch] Make cxxfilt demangle internal-linkage templates

2013-08-07 Thread Paul Pluzhnikov
On Wed, Aug 7, 2013 at 11:34 AM, Andrew Pinski pins...@gmail.com wrote: I think this should also be send to the GCC List as libiberty is officially maintained by GCC. http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00394.html Thanks, -- Paul Pluzhnikov

[google/4_8] Merged r200809 from gcc-4_8-branch to google/gcc-4_8EOM

2013-07-09 Thread Paul Pluzhnikov
-- Paul Pluzhnikov

Re: [google gcc-4_8 commited] Adjust testsuite line numbers for r199468.

2013-05-31 Thread Paul Pluzhnikov
On Thu, May 30, 2013 at 10:00 PM, Paul Pluzhnikov ppluzhni...@google.com wrote: I've committed attached patch on google/gcc-4_8 branch to fix testsuite failures broken by r199468. Also applied to google/integration branch. -- Paul Pluzhnikov

[google gcc-4_7,gcc-4_8,integration] Relax vector validity checks

2013-05-30 Thread Paul Pluzhnikov
by such version linked in with new code, and failing the check. Google ref b/9198806 Attached patch relaxes the check, while still catching dangling vector accesses. Ok for google/gcc_4-7, gcc-4_8 and integration branches? Thanks, -- Paul Pluzhnikov Index: libstdc++-v3/include/bits/stl_vector.h

Re: [google gcc-4_7,gcc-4_8,integration] Relax vector validity checks

2013-05-30 Thread Paul Pluzhnikov
On Thu, May 30, 2013 at 6:48 PM, Diego Novillo dnovi...@google.com wrote: OK. Is this applicable to trunk and/or release branches? No: the cheap vector and string checks are on google branches only. -- Paul Pluzhnikov

Re: [google gcc-4_7,gcc-4_8,integration] Add bounds checks to vectorbool

2013-05-24 Thread Paul Pluzhnikov
Jonathan, On Thu, May 23, 2013 at 10:13 AM, Paul Pluzhnikov ppluzhni...@google.com wrote: On Thu, May 23, 2013 at 9:14 AM, Jonathan Wakely jwakely@gmail.com wrote: I was wondering the other day whether we should put these checks on trunk and enable them automatically when !defined

Re: [google gcc-4_7,gcc-4_8,integration] Add bounds checks to vectorbool

2013-05-23 Thread Paul Pluzhnikov
also want these checks. -- Paul Pluzhnikov

[patch][google/gcc-4_7] Suppress failure in gcc.dg/lto/20100430-1 on powerpc and powerpc64

2013-04-18 Thread Paul Pluzhnikov
Greetings, I've commited the patch below on google/gcc-4_7 branch (r198071) to XFAILs gcc.dg/lto/20100430-1 on powerpc*. Index: contrib/testsuite-management/powerpc64-grtev3-linux-gnu.xfail === ---

Re: [google][4.7]Using CPU mocks to test code coverage of multiversioned functions

2013-03-18 Thread Paul Pluzhnikov
and sse2 are available Thanks, -- Paul Pluzhnikov

Re: [google][4.7]Using CPU mocks to test code coverage of multiversioned functions

2013-03-18 Thread Paul Pluzhnikov
. Yes, that's how I understood you. I don't believe it would be easy to implement such interposer (if possible at all), and it would be very much tied to glibc internals. Overriding CPUID at loader initialization time sounds simpler (but I haven't looked at the code yet :-). -- Paul Pluzhnikov

Re: [google gcc-4_7, integration] Build more of libstdc++ with frame pointers

2013-02-28 Thread Paul Pluzhnikov
... Thanks, -- Paul Pluzhnikov

Re: [google gcc-4_7, integration] Build more of libstdc++ with frame pointers

2013-02-28 Thread Paul Pluzhnikov
malloc ... takes loader lock ... takes malloc lock malloc _Unwind_Backtrace ... needs malloc lock dl_iterate_phdr held by T2... needs loader lock held by T1 -- Paul Pluzhnikov

Re: [google gcc-4_7, integration] Build more of libstdc++ with frame pointers

2013-02-28 Thread Paul Pluzhnikov
is nowhere close at 50x. -- Paul Pluzhnikov

Re: [google gcc-4_7, integration] Build more of libstdc++ with frame pointers

2013-02-28 Thread Paul Pluzhnikov
~15 years ago why it is that way (it had something to do with Hurd); an explanation I can't find at the moment. -- Paul Pluzhnikov

[google gcc-4_7, integration] Build more of libstdc++ with frame pointers

2013-02-27 Thread Paul Pluzhnikov
Greetings, Google ref b/8187733 Build libstdc++-v3/src/c++11/debug.cc with -fno-omit-frame-pointer, so frame-based unwinder can step through it. Tested: bootstrap build and verified debug.cc is built with -fno-omit-frame-pointer. Ok for google/gcc-4_7 and google/integration? Thanks, -- Paul

Re: [google gcc-4_7, integration] Build more of libstdc++ with frame pointers

2013-02-27 Thread Paul Pluzhnikov
matters when you collect stack traces across live production services). I hope this answers your question. -- Paul Pluzhnikov

Re: [google gcc-4_7, integration] Build more of libstdc++ with frame pointers

2013-02-27 Thread Paul Pluzhnikov
past) suitable for the unwinder requirements that people have? Thanks, -- Paul Pluzhnikov

Re: [google gcc-4_7, integration] Scribble on destructed strings to catch invalid accesses.

2013-01-25 Thread Paul Pluzhnikov
us again during Stage 1 :-) http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56109 Googlers, please include the libstdc++ list on patches to the libstdc++ code, even if it's only to a google branch. Will do. Sorry about that. Thanks, -- Paul Pluzhnikov

[google gcc-4_7, integration] Scribble on destructed strings to catch invalid accesses.

2013-01-23 Thread Paul Pluzhnikov
This patch allows us to catch use of destructed strings. Google ref: b/5430313 Ok for google/gcc-4_7 and google/integration? -- Paul Pluzhnikov Index: libstdc++-v3/include/ext/sso_string_base.h === --- libstdc++-v3/include/ext

[google gcc-4_7, integration] Add more lightweight checks for dangling vectors

2013-01-21 Thread Paul Pluzhnikov
This patch sets destructed vector into an invalid state, such that subsequent calls to begin(), end(), size(), etc. all throw logic_error. Google ref b/7248326 Ok for google/gcc-4_7 and google/integration? Thanks, -- Paul Pluzhnikov Index: libstdc++-v3/include/bits/stl_vector.h

Re: [google gcc-4_7, integration] Add lightweight checks for front()/back() on empty vector

2013-01-20 Thread Paul Pluzhnikov
On Sun, Jan 20, 2013 at 3:16 AM, Gerald Pfeifer ger...@pfeifer.com wrote: Isn't the error message wrong, then? Thanks for catching that! Updated patch attached. -- Paul Pluzhnikov Index: libstdc++-v3/include/bits/stl_vector.h

[google gcc-4_7, integration] Add lightweight checks for front()/back() on empty vector

2013-01-19 Thread Paul Pluzhnikov
This patch adds lightweight checks for front()/back() on empty vector. Google ref b/7939186 Ok for google/gcc-4_7 and google/integration branches? -- Paul Pluzhnikov Index: libstdc++-v3/include/bits/stl_vector.h === --- libstdc

[google gcc-4_7] Backport r195207 (fix for PR55982) into google/gcc-4_7

2013-01-15 Thread Paul Pluzhnikov
Ok for google/gcc-4_7 ? Ref b/8003094 Thanks, -- Paul Pluzhnikov 2013-01-15 Paul Pluzhnikov ppluzhni...@google.com PR 55982 * strncat-chk.c (__strncat_chk): Fix loop unroll. Index: libssp/strncat-chk.c

[patch] PR55982 Fix buglet in __strncat_chk

2013-01-14 Thread Paul Pluzhnikov
Greetings, In libssp/strncat-chk.c, the loop was unrolled 5 times (apparently by accident). Ok for trunk? Thanks, -- Paul Pluzhnikov 2013-01-14 Paul Pluzhnikov ppluzhni...@google.com PR 55982 * strncat-chk.c (__strncat_chk): Fix loop unroll. Index: libssp/strncat-chk.c

[google 4_7] Backport r194909 (:: is incorrectly treated as digraph ...) to google/gcc-4_7 branch (issue7028052)

2013-01-04 Thread Paul Pluzhnikov
Back-port revision 194909 to google/gcc-4_7 branch: http://gcc.gnu.org/viewcvs?root=gccview=revrev=194909 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54526 Google ref: b/7427993 Index: gcc/testsuite/g++.old-deja/g++.other/crash28.C

Re: [google 4_7] Backport r194909 (:: is incorrectly treated as digraph ...) to google/gcc-4_7 branch (issue7028052)

2013-01-04 Thread Paul Pluzhnikov
On Fri, Jan 4, 2013 at 9:41 AM, Xinliang David Li davi...@google.com wrote: ok. The patch as sent caused some breakage, I had to adjust test cases a bit. Submitting attached patch. Thanks, -- Paul Pluzhnikov Index: gcc/testsuite/g++.old-deja/g++.other/crash28.C

Re: [google 4_7] Backport r194909 (:: is incorrectly treated as digraph ...) to google/gcc-4_7 branch (issue7028052)

2013-01-04 Thread Paul Pluzhnikov
{ target c++98 } 19 } +// { dg-message 17:\\(if you use '-fpermissive' G\\+\\+ will accept your code\\) -fpermissive { target c++98 } 19 } (Minor adjustment to the expected error message). error12.C is identical on trunk and google/gcc-4_7. Thanks, -- Paul Pluzhnikov

Re: [google 4_7] backport std::unique_ptrT[], D improvements

2013-01-03 Thread Paul Pluzhnikov
.html to the google 4.7 branch. Approved for google/gcc-4_7 branch. Thanks, -- Paul Pluzhnikov

[patch][google/gcc-4_7] Extend expiration date for pr54127 (issue6817091)

2012-11-05 Thread Paul Pluzhnikov
Greetings, This patch is for google/gcc-4_7 branch. Thanks, 2012-11-05 Paul Pluzhnikov ppluzhni...@google.com * contrib/testsuite-management/powerpc-grtev3-linux-gnu.xfail: extend expiration date for pr54127. Index: contrib/testsuite-management/powerpc-grtev3-linux

Re: [google/gcc-4_7] Backport patch for comdat types problem

2012-09-05 Thread Paul Pluzhnikov
On Wed, Sep 5, 2012 at 7:46 PM, Cary Coutant ccout...@google.com wrote: This patch is for the google/gcc-4_7 branch. Approved for google/gcc-4_7 branch. Thanks, -- Paul Pluzhnikov

Re: [google/gcc-4_7] Fix ICE in should_move_die_to_comdat

2012-08-22 Thread Paul Pluzhnikov
On Wed, Aug 22, 2012 at 5:11 PM, Cary Coutant ccout...@google.com wrote: This patch is for the google/gcc-4_7 branch. Approved for google/gcc-4_7 branch. Thanks, -- Paul Pluzhnikov

Re: [google][gcc-4.7]Revert Old CPU Runtime Detection Implementation (issue6458081)

2012-08-03 Thread Paul Pluzhnikov
On Fri, Aug 3, 2012 at 2:56 PM, Sriraman Tallam tmsri...@google.com wrote: This patch reverts the original implementation of CPU runtime detection Ok for google/gcc-4_7 branch -- Paul Pluzhnikov

[patch][google/integration] Don't force tls-model to initial-exec when building libgomp (issue6107046)

2012-04-22 Thread Paul Pluzhnikov
b/6368405 Google ref b/6156799 Tested: make make check 2012-04-22 Paul Pluzhnikov ppluzhni...@google.com * libgomp/configure.tgt: Don't force initial-exec. Index: libgomp/configure.tgt === --- libgomp/configure.tgt

Re: [patch][google/integration] Don't force tls-model to initial-exec when building libgomp (issue6107046)

2012-04-22 Thread Paul Pluzhnikov
: http://old.nabble.com/-patch--libgomp%3A-removing-nodlopen-flag-for-portability-td10286039.html Generally we don't use OpenMP, but some of our third-party libraries do depend on it. Thanks for the heads-up. -- Paul Pluzhnikov

Re: RFC: DWARF Extensions for Separate Debug Info Files (Fission)

2011-09-22 Thread Paul Pluzhnikov
(and the .o files *will* need to be copied) if a distributed compilation system (a build farm) is used (as is the case here). Thanks, -- Paul Pluzhnikov

[patch][google/integration] Add lightweight checks to vector::begin et. al. (issue4973065)

2011-09-06 Thread Paul Pluzhnikov
Greetings, This patch adds a lightweight self-consistency check to many vector operations. Google issue 5246356. Ok for google/integration branch? Thanks, -- 2011-09-06 Paul Pluzhnikov ppluzhni...@google.com * include/bits/stl_vector.h (__is_valid): New function. (begin

Re: [patch][google/integration] Add lightweight checks to vector::begin et. al. (issue4973065)

2011-09-06 Thread Paul Pluzhnikov
On Tue, Sep 6, 2011 at 9:28 AM, Paul Pluzhnikov ppluzhni...@google.com wrote: This patch adds a lightweight self-consistency check to many vector operations. Google issue 5246356. Sorry, forgot to mention: tested by doing bootstrap and make check on Linux/x86_64. -- Paul Pluzhnikov

Re: [patch][google/integration] Add lightweight checks to vector::begin et. al. (issue4973065)

2011-09-06 Thread Paul Pluzhnikov
On Tue, Sep 6, 2011 at 10:46 AM, Diego Novillo dnovi...@google.com wrote: On Tue, Sep 6, 2011 at 12:54, Paul Pluzhnikov ppluzhni...@google.com wrote: On Tue, Sep 6, 2011 at 9:44 AM, Diego Novillo dnovi...@google.com wrote: OK.  Any reason not to send this (or a variant) to mainline? AFAIU

Re: [patch][google/integration] Add lightweight checks to vector::begin et. al. (issue4973065)

2011-09-06 Thread Paul Pluzhnikov
. Sure -- we have other ways to catch the these bugs. They are not very practical at the moment due to their runtime overhead. As for your other suggestion: enabling _GLIBCXX_DEBUG just for vector, that didn't occur to me and is something I'd like to explore. Thanks, -- Paul Pluzhnikov

Re: [patch][google/integration] Add lightweight checks to vector::begin et. al. (issue4973065)

2011-09-06 Thread Paul Pluzhnikov
new bugs (at least not on Linux) -- the code would have immediately crashed on zero-page dereference anyway. Thanks, -- Paul Pluzhnikov

Re: [patch][google/integration] Add lightweight checks to vector::begin et. al. (issue4973065)

2011-09-06 Thread Paul Pluzhnikov
that makes pages dirty after free. Agreed. I'll rename __is_valid to _M_is_valid to match the rest of the file, and submit to google/integration only. Thanks for your comments, -- Paul Pluzhnikov

Re: [Patch] Make libstdc++'s abi_check more robust against readelf output format

2011-05-20 Thread Paul Pluzhnikov
On Fri, May 20, 2011 at 8:10 AM, Ollie Wild a...@google.com wrote: Ok, for google/integration.  Please integrate to google/main and google/gcc-4_6 as well. Done: r173959, r173960, r173961. Thanks, -- Paul Pluzhnikov

Build more of libstdc++ exception throwing code with frame pointers (issue4539068)

2011-05-19 Thread Paul Pluzhnikov
2011-05-19 Paul Pluzhnikov ppluzhni...@google.com * libstdc++-v3/libsupc++/Makefile.am: Add -fno-omit-frame-pointer to vterminate. * libstdc++-v3/libsupc++/Makefile.in: Regenerate. Index: libstdc++-v3/libsupc++/Makefile.in

[google] Re: Build more of libstdc++ exception throwing code with frame pointers (issue4539068)

2011-05-19 Thread Paul Pluzhnikov
This patch is for google/integration branch. Sorry about not setting the markers correctly. Tested by doing a bootstrap build and verifying that __gnu_cxx::__verbose_terminate_handler is built with frame pointers. On Thu, May 19, 2011 at 10:46 AM, Paul Pluzhnikov ppluzhni...@google.com wrote

Re: [patch] make default linker --hash-style configurable option

2011-05-10 Thread Paul Pluzhnikov
', you need to examine 'gcc -v' very carefully. And, as Jakub noted, linking directly with 'ld' is discouraged. Thanks, -- Paul Pluzhnikov

Re: [patch] make default linker --hash-style configurable option

2011-05-09 Thread Paul Pluzhnikov
Ping? Ping? Ping? Ping? Ping? http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00246.html CC'ing the rest of build system maintainers. On Mon, May 2, 2011 at 8:56 AM, Paul Pluzhnikov ppluzhni...@google.com wrote: On Mon, May 2, 2011 at 7:59 AM, Joseph S. Myers jos...@codesourcery.com wrote

Re: [patch] make default linker --hash-style configurable option

2011-05-09 Thread Paul Pluzhnikov
with me, and I gather from the thread that you are fine with that as well. Given the build system changes, the gcc.c changes are OK. Ok for trunk then? I'll wait till tomorrow in case someone has additional comments on the desirability part. Thanks! -- Paul Pluzhnikov

Re: [patch] make default linker --hash-style configurable option

2011-05-02 Thread Paul Pluzhnikov
Ping? Ping? Ping? Ping? This is getting ridiculous. Would someone please accept the patch, tell me what to fix in it to make it acceptable, or explain why it is a bad idea? Thanks! On Mon, Apr 25, 2011 at 9:08 AM, Paul Pluzhnikov ppluzhni...@google.com wrote: Ping? Ping? Ping? On Mon, Apr 18

Re: [patch] make default linker --hash-style configurable option

2011-04-25 Thread Paul Pluzhnikov
Ping? Ping? Ping? On Mon, Apr 18, 2011 at 9:45 AM, Paul Pluzhnikov ppluzhni...@google.com wrote: Ping? Ping? On Mon, Apr 11, 2011 at 11:00 AM, Paul Pluzhnikov ppluzhni...@google.com wrote: Ping? -- Paul Pluzhnikov

Re: [patch] make default linker --hash-style configurable option

2011-04-18 Thread Paul Pluzhnikov
Ping? Ping? On Mon, Apr 11, 2011 at 11:00 AM, Paul Pluzhnikov ppluzhni...@google.com wrote: Ping? -- Paul Pluzhnikov

[google/integration] Enable lightweight debug checks (issue4402041)

2011-04-12 Thread Paul Pluzhnikov
This patch adds lightweight debug checks (if enabled by macros). To be applied only to google/integration branch. Tested by bootstrapping and running make check. 2011-04-12 Paul Pluzhnikov ppluzhni...@google.com * libstdc++-v3/include/ext/vstring.h: Enable debug checks when

Re: [patch] make default linker --hash-style configurable option

2011-04-11 Thread Paul Pluzhnikov
prefer common use cases to be easier than that. The first version of this patch Satoru proposed was a general do anything to specs patch. Ian voted that down as being too generic and difficult to use correctly. Thanks, -- Paul Pluzhnikov

[patch] make default linker --hash-style configurable option

2011-04-04 Thread Paul Pluzhnikov
-style is passed to the linker, and also configuring with --with-linker-hash-style=gnu and verifying that --hash-style=gnu is then passed to the linker. Ok for trunk? Thanks, P.S. Google has a blanket copyright assignment to FSF. -- Paul Pluzhnikov 2011-04-04 Satoru Takabayashi sato

[google] Build libstdc++ exception throwing code with frame pointers (issue4348050)

2011-04-04 Thread Paul Pluzhnikov
and eh_terminate. 2011-04-04 Paul Pluzhnikov ppluzhni...@google.com * libstdc++-v3/src/Makefile.am (revision 171950): Add -fno-omit-frame-pointer to functexcept. * libstdc++-v3/libsupc++/Makefile.am(revision 171950): Add -fno-omit-frame-pointer to eh_throw