[stdc++] Mark global new/delete operators as weak symbols

2013-08-20 Thread Romain Geissler
Hi, According to the C++ standard ยง17.4.3.4(2,3) the global new and delete operator implementation can be replaced by the program. For example, tcmalloc does redefine them. On ELF targets, it is currently OK if you link libstc++ dynamically. However, if you try to link both tcmalloc and stdc++

Re: [PATCH] TREE-SSA remove redundant condition checks in get_default_value

2013-08-20 Thread Jeff Law
On 08/12/2013 12:46 AM, Zhouyi Zhou wrote: In function get_default_value of tree-ssa-ccp.c, 261 else if (is_gimple_assign (stmt) 262/* Value-returning GIMPLE_CALL statements assign to 263 a variable, and are treated similarly to GIMPLE_ASSIGN. */ 264||

Re: GDB hooks for debugging GCC

2013-08-20 Thread Marek Polacek
On Mon, Aug 19, 2013 at 03:45:57PM -0600, Jeff Law wrote: In this specific instance I was referring to getting meaningful data out of gdb when I do something like p bb or p e for a block and edge respectively. Printing the pointer is useful, but printing information about the actual

Re: [PATCH] Fix PR57451 (Incorrect debug ranges emitted for -freorder-blocks-and-partition -g)

2013-08-20 Thread Jeff Law
On 08/19/2013 11:21 PM, Teresa Johnson wrote: On Mon, Aug 19, 2013 at 5:01 PM, Teresa Johnson tejohn...@google.com wrote: On Mon, Aug 19, 2013 at 11:44 AM, Jeff Law l...@redhat.com wrote: On 08/19/2013 12:34 PM, Teresa Johnson wrote: Ping. Thanks, Teresa On Sun, Aug 11, 2013 at 9:35 PM,

Re: [PATCH] Redesign pthread in LIB_SPEC for systems without libpthread

2013-08-20 Thread Kirill Yukhin
Hello, All good, thanks! Checked into MT: http://gcc.gnu.org/viewcvs?rev=201871root=gccview=rev -- Thanks, K

Re: Request to merge Undefined Behavior Sanitizer in (take 3)

2013-08-20 Thread Marek Polacek
On Thu, Aug 15, 2013 at 05:08:48PM +0200, Marek Polacek wrote: One patch is not in yet, but that isn't anything important: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00376.html I've now commited this patch: diff --git a/gcc/ChangeLog.ubsan b/gcc/ChangeLog.ubsan index 9040b68..695522e

Re: msp430 port

2013-08-20 Thread Jeff Law
On 08/19/2013 07:04 PM, Mike Stump wrote: On Aug 19, 2013, at 1:54 PM, Jeff Law l...@redhat.com wrote: On 08/19/2013 02:49 PM, DJ Delorie wrote: I'd say it's not as simple as you make it out to be. You can't blindly combine operations on volatile memory. I'm not blindly combining them, I'm

Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-20 Thread Eric Botcazou
Dollar sign is not a valid character in symbols on some platforms, such as AIX. Sure, but DECL_NAME isn't used for any symbol here, unlike DECL_ASSEMBLER_NAME. -- Eric Botcazou

Re: [PATCH/RFA] Do not set MULTILIB_DEFAULTS for arm*-*-linux-gnueabi* targets

2013-08-20 Thread Ramana Radhakrishnan
On 08/19/13 11:54, Matthew Gretton-Dann wrote: All, The attached patch removes the setting of MULTILIB_DEFAULTS for arm*-*-linux-gnueabi* targets. The current setting of MULTILIB_DEFAULTS includes mfloat-abi=hard, which for arm*-*-linux-gnueabi is not true. This makes generating a hard-float

Re: [regex] New enum type syntax_option_type

2013-08-20 Thread Tim Shen
On Mon, Aug 19, 2013 at 10:26 PM, Tim Shen timshe...@gmail.com wrote: Great, let's test it now, though I don't think that it breaks something. Committed. -- Tim Shen

[PATCH] Fix PR tree-optimization/58137

2013-08-20 Thread Bernd Edlinger
This patch fixes a bug in the vectorized pointer arithmetic in the forwprop optimization pass. Although it seems to be impossible to create a vector of pointers with the __attribute__((vector_size(x))) syntax, the vector loop optimization together with the loop unrolling can create code which

[Patch, AArch64] Optimized implementation of vget_low_* in arm_neon.h.

2013-08-20 Thread Tejas Belagod
Hi, This patch replaces all inline asm implementations of vget_low_* in arm_neon.h with optimized implementations using other neon intrinsics. Tested with aarch64-none-elf. OK? Thanks, Tejas Belagod ARM. 2013-08-20 Tejas Belagod tejas.bela...@arm.com gcc/ *

Clean up pretty printers [9/n]

2013-08-20 Thread Gabriel Dos Reis
This patch formalizes the observation that certain pretty printing functions return formatted texts that have lifetime logically outlasting the local instances of pretty printers. This has not been a problem so far because we were using static storage, but once we switch local pretty printers,

[C++ Patch, committed as obvious] PR 58190

2013-08-20 Thread Paolo Carlini
Hi, simply matter of using __SIZE_TYPE__. Committed to mainline. Thanks, Paolo. /// 2013-08-20 Paolo Carlini paolo.carl...@oracle.com PR c++/58190 * g++.dg/pr57878.C: Use __SIZE_TYPE__. Index: g++.dg/pr57878.C

Re: [C++ Patch, committed as obvious] PR 58190

2013-08-20 Thread Jakub Jelinek
On Tue, Aug 20, 2013 at 01:40:59PM +0200, Paolo Carlini wrote: simply matter of using __SIZE_TYPE__. Committed to mainline. Please apply it to branches/gcc-4_8-branch too. Also note that the ChangeLog entry for it was wrong originally (both on trunk and the branch): 2013-07-18 Wei Mi

Re: [C++ Patch, committed as obvious] PR 58190

2013-08-20 Thread Paolo Carlini
Hi, On 08/20/2013 01:48 PM, Jakub Jelinek wrote: On Tue, Aug 20, 2013 at 01:40:59PM +0200, Paolo Carlini wrote: simply matter of using __SIZE_TYPE__. Committed to mainline. Please apply it to branches/gcc-4_8-branch too. More information bug reporter didn't provide ;) Ok. Also note that the

Re: RFA: Fix declaration of default value of TARGET_NARROW_VOLATILE_BITFIELD

2013-08-20 Thread nick clifton
Hi Gerald, it looks this patch did not get applied. Is this because you failed to get approval? Yes. :-( With a patch Joseph did recently, this would now be in gcc/target.def, and from what I can see both parts of the patch are fine. Unless anyone objects, can you please ago ahead and

[PATCH v2 00/18] resurrect automatic dependencies

2013-08-20 Thread Tom Tromey
This is version 3 of my series to resurrect automatic dependencies for GCC. Version 2 is here: http://gcc.gnu.org/ml/gcc-patches/2013-07/msg01386.html Ordinarily I would simply ping the existing patches, but Alexandre asked me to resend the series and CC him. I've rebased the series and

[PATCH v3 02/18] update generated_files

2013-08-20 Thread Tom Tromey
A few generated files were not mentioned in the generated_files variable. This fixes the problem. * Makefile.in (generated_files): Add options.h, target-hooks-def.h, insn-opinit.h, common/common-target-hooks-def.h, pass-instances.def. --- gcc/Makefile.in | 4 +++- 1 file

[PATCH v3 01/18] clean up SHLIB so subshells are not needed

2013-08-20 Thread Tom Tromey
This changes the handling of SHLIB so that it is inlined into DRIVER_DEFINES. This is ok because SHLIB is defined in a Makefile fragment that is included by the generated Makefile. The rationale for this is that it simplifies some .o targets, so that we can share more code. *

[PATCH v3 03/18] move generated_files order-only dependency later

2013-08-20 Thread Tom Tromey
There is an order-only dependency in gcc/Makefile.in that tries to build the generated files before compiling regular objects. However, this appears too early, and so at the time it is seen by make, GCOV_OBJS and GCOV_DUMP_OBJS have not yet been set. This patch fixes the problem and prevents any

[PATCH v3 05/18] convert the C front end to automatic dependencies

2013-08-20 Thread Tom Tromey
This converts the C front end. Note that this fixes a latent bug in gcc/Makefile.in's definition of C_TREE_H. This is needed to avoid breaking this build with this patch. * Makefile.in (C_TREE_H): Reference c/c-tree.h. * Make-lang.in (c/gccspec.o): Remove.

[PATCH v3 04/18] add configury

2013-08-20 Thread Tom Tromey
This adds the configury needed for automatic dependency tracking. It also adds some bits to the Makefile so we can begin converting (removing) explicit dependencies. * Makefile.in (CCDEPMODE, DEPDIR, depcomp, COMPILE.base) (COMPILE, POSTCOMPILE): New variables. (.cc.o

[PATCH v3 06/18] convert the C++ front end to automatic dependencies

2013-08-20 Thread Tom Tromey
This converts the C++ front end. This renames g++spec.o to cp/g++spec.o for uniformity. This lets us remove an explicit rule. This patch does not remove various *_H macros from cp/Make-lang.in. These are still needed by ObjC++. They're removed by a later patch. * Make-lang.in

[PATCH v3 09/18] convert the Java front end to automatic dependencies

2013-08-20 Thread Tom Tromey
This converts the Java front end. We also rename jvspec.o to java/jvspec.o, for uniformity; this lets us remove an explicit rule. * Make-lang.in (jvspec.o): Remove. (CFLAGS-java/jvspec.o): New variable. ($(XGCJ)$(exeext), java_OBJS): Use java/jvspec.o

[PATCH v3 07/18] convert the ObjC front end to automatic dependencies

2013-08-20 Thread Tom Tromey
This converts the ObjC front end. Note that there is a latent possible bug in this code -- both ObjC and ObjC++ define START_HDRS. Whichever is included last, wins; if they are out of sync, then something could break. This possibility is eliminated by this series. * Make-lang.in

[PATCH v3 08/18] convert the ObjC++ front end to automatic dependencies

2013-08-20 Thread Tom Tromey
This converts the ObjC++ front end. Now we can finally remove the *_H macros from cp/Make-lang.in. * Make-lang.in (CXX_TREE_H, CXX_PARSER_H, CXX_PRETTY_PRINT_H): Remove. * Make-lang.in (START_HDRS, cc1objplus-checksum.o) (objcp/objcp-lang.o, objcp/objcp-decl.o

[PATCH v3 10/18] Fix up c-family targets

2013-08-20 Thread Tom Tromey
This removes manual dependencies for the c-family .o files. * Makefile.in (c-family/cppspec.o, c-family/c-common.o) (c-family/c-cppbuiltin.o, c-family/c-dump.o, c-family/c-format.o) (c-family/c-gimplify.o, c-family/c-lex.o, c-family/c-omp.o) (c-family/c-opts.o,

[PATCH v3 12/18] convert the Go front end to automatic dependencies

2013-08-20 Thread Tom Tromey
This converts Go. It renames gospec.o to go/gospec.o, for uniformity and so we can remove an explicit rule. It defines go_OBJS, to conform to the documented Make-lang.in conventions, and to ensure that Go objects are given the correct order-only dependencies on generated files. *

[PATCH v3 13/18] convert LTO to automatic dependencies

2013-08-20 Thread Tom Tromey
This converts LTO. This also fixes a latent buglet in lto/Make-lang.in. lto_OBJS should hold all the objects for a language, but LTO never defined this. * Make-lang.in (LTO_H, LINKER_PLUGIN_API_H, LTO_TREE_H) (lto/lto-lang.o, lto/lto.o, lto/lto-partition.o)

[PATCH v3 11/18] convert the Fortran front end to automatic dependencies

2013-08-20 Thread Tom Tromey
This convert fortran. It renames gfortranspec.o to fortran/gfortranspec.o, for uniformity and to allow removing an explicit rule. * Make-lang.in (fortran_OBJS): Use fortran/gfortranspec.o. (gfortranspec.o): Remove. (CFLAGS-fortran/gfortranspec.o): New variable.

[PATCH v3 16/18] remove last reference to TREE_GIMPLE_H

2013-08-20 Thread Tom Tromey
There is a single reference to TREE_GIMPLE_H in the source tree. Since it is not defined anywhere, we might as well remove the use. * config/i386/t-i386 (i386.o): Don't use TREE_GIMPLE_H. --- gcc/config/i386/t-i386 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 17/18] remove last definition of CROSS_FLOAT_H

2013-08-20 Thread Tom Tromey
There is a single definition of CROSS_FLOAT_H in the source. As far as I can tell, this is never used anywhere. So, this patch removes it. * config/mcore/t-mcore (CROSS_FLOAT_H): Remove. --- gcc/config/mcore/t-mcore | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH v3 15/18] make out_object_file rule use automatic dependencies

2013-08-20 Thread Tom Tromey
This is a small change to make out_object_file use automatic dependencies. * Makefile.in ($(out_object_file)): Use COMPILE and POSTCOMPILE. --- gcc/Makefile.in | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/gcc/Makefile.in b/gcc/Makefile.in index

[PATCH v3 18/18] remove unused macros

2013-08-20 Thread Tom Tromey
I used this perl script to find unused _H macros in the Makefile. I deleted the definitions it reported and re-ran the script, until there was no more output. The script also makes note of _H variables which are used but never defined. That is how I found the TREE_GIMPLE_H use, fixed earlier in

Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-20 Thread David Edelsohn
On Tue, Aug 20, 2013 at 4:44 AM, Eric Botcazou ebotca...@adacore.com wrote: Dollar sign is not a valid character in symbols on some platforms, such as AIX. Sure, but DECL_NAME isn't used for any symbol here, unlike DECL_ASSEMBLER_NAME. Okay, just wanted to make sure. Thanks, David

Re: [PATCH i386 3/8] [AVX512] Add AVX-512 patterns.

2013-08-20 Thread Kirill Yukhin
On 19 Aug 15:01, Richard Henderson wrote: ;; All vector modes including V?TImode, used in move patterns. (define_mode_iterator V16 - [(V32QI TARGET_AVX) V16QI - (V16HI TARGET_AVX) V8HI - (V8SI TARGET_AVX) V4SI - (V4DI TARGET_AVX) V2DI + [(V64QI TARGET_AVX512F) (V32QI

[Patch, Fortran, committed] PR 53655: [F03] default initializer warnings

2013-08-20 Thread Janus Weil
Hi all, I have just committed as obvious a one-line patch fixing a bogus warning: http://gcc.gnu.org/viewcvs/gcc?view=revisionrevision=201884 Cheers, Janus

fixed rot on the wide-int branch.

2013-08-20 Thread Kenneth Zadeck
Index: gcc/optabs.c === --- gcc/optabs.c(revision 201884) +++ gcc/optabs.c(working copy) @@ -867,7 +867,8 @@ expand_subword_shift (enum machine_mode outof_input, const1_rtx, 0, unsignedp, methods);

[Patch, fortran] PR57798 uninitialized loop bound with sum and array-returning function.

2013-08-20 Thread Mikael Morin
Hello, this is the fix for pr57798 where a variable used as scalarization loop bound was used outside the outer scalarization loop, before it was defined (inside it). To make it more clear the code generated was like this: ... toto = bad do ... bad = titi do ... ... The patch

[Patch,AArch64] Support SISD Shifts (SHL/USHR/SSHL/USHL/SSHR)

2013-08-20 Thread Vidya Praveen
Hello, This patch supports SISD shift instructions SHL/USHR/SSHR/SSHL/USHL for SImode and DImode. This patch also refactors the integer shifts pattern optabmode3_insn. Pattern for rotate is moved out as rormode3_insn. Shift patterns (aarch64_{lshr|ashl|ashr}_sisd_or_int_{si|di}3) support both

Re: [Patch,AArch64] Support SISD Shifts (SHL/USHR/SSHL/USHL/SSHR)

2013-08-20 Thread Vidya Praveen
With the attachment this time :-) Regards VP On Tue, Aug 20, 2013 at 04:01:59PM +0100, Vidya Praveen wrote: Hello, This patch supports SISD shift instructions SHL/USHR/SSHR/SSHL/USHL for SImode and DImode. This patch also refactors the integer shifts pattern optabmode3_insn. Pattern for

Re: [PATCH] Rerun df_analyze after delete_unmarked_insns during DCE

2013-08-20 Thread Jeff Law
On 07/20/2013 03:02 AM, Alexey Makhalov wrote: 2013-07-20 Alexey Makhalov makhal...@gmail.com mailto:makhal...@gmail.com * dce.c (fini_dce): Call df_analyze again just in case delete_unmarked_insns removed anything. Thanks. Installed. jeff

Re: [PATCH i386 3/8] [AVX512] Add AVX-512 patterns.

2013-08-20 Thread Richard Henderson
On 08/20/2013 07:04 AM, Kirill Yukhin wrote: 2013-08-20 Kirill Yukhin kirill.yuk...@intel.com * config/i386/sse.md (V16): Rename to... (VMOVE): this. (movmode): Update iterator name. (*movmode_internal): Ditto. (pushmode1): Ditto.

Re: [PATCH v3 06/18] convert the C++ front end to automatic dependencies

2013-08-20 Thread Gabriel Dos Reis
On Tue, Aug 20, 2013 at 8:59 AM, Tom Tromey tro...@redhat.com wrote: This converts the C++ front end. This renames g++spec.o to cp/g++spec.o for uniformity. This lets us remove an explicit rule. This patch does not remove various *_H macros from cp/Make-lang.in. These are still needed by

Re: [PATCH v3 08/18] convert the ObjC++ front end to automatic dependencies

2013-08-20 Thread Mike Stump
On Aug 20, 2013, at 6:59 AM, Tom Tromey tro...@redhat.com wrote: This converts the ObjC++ front end. Ok.

Re: [PATCH v3 07/18] convert the ObjC front end to automatic dependencies

2013-08-20 Thread Mike Stump
On Aug 20, 2013, at 6:59 AM, Tom Tromey tro...@redhat.com wrote: This converts the ObjC front end. Ok.

[patch, libtool] Top-level libtool.m4 patch for autoconf 2.68

2013-08-20 Thread Steve Ellcey
Some of the binutils directories (libgloss and newlib) have moved from autoconf 2.64 to 2.68. While running autoconf 2.68 on these directories I get some warnings coming from libtool.m4 which is at the top level of the GCC and binutils trees. Fixes for these warnings are already in the upstream

Re: [PATCH i386 1/8] [AVX512] Adjust register classes.

2013-08-20 Thread Richard Henderson
On 08/20/2013 10:48 AM, Kirill Yukhin wrote: @@ -34589,8 +34649,20 @@ ix86_hard_regno_mode_ok (int regno, enum machine_mode mode) { /* We implement the move patterns for all vector modes into and out of SSE registers, even when no operation instructions - are

Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv

2013-08-20 Thread Florian Weimer
On 08/20/2013 12:24 AM, Caroline Tice wrote: Hi All, I could really use some help here from someone who has a better understanding of how the config/Makefile system works than I do. In my libvtv/configure.ac file, I have: AC_GNU_SOURCE AC_CHECK_FUNCS([__secure_getenv]) AC_GNU_SOURCE

Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv

2013-08-20 Thread Caroline Tice
That fixed it, thanks! Attached is the latest patch (Florian, I will send you the regenerated Makefile.in and configure separately). Please review and let me know if this is OK to commit! -- Caroline cmt...@google.com 2013-08-20 Caroline Tice cmt...@google.com * Makefile.am (DEFS):

[Google] Refine hot caller heuristic

2013-08-20 Thread Easwaran Raman
The current hot caller heuristic simply promotes edges whose caller is hot. This patch does the following: * Turn it off for applications with large footprint since the size increase hurts them * Be more selective by considering arguments to callee when the heuristic is enabled. This performs

Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv

2013-08-20 Thread Florian Weimer
On 08/20/2013 09:15 PM, Caroline Tice wrote: That fixed it, thanks! Attached is the latest patch (Florian, I will send you the regenerated Makefile.in and configure separately). Please review and let me know if this is OK to commit! As the libvtv reviewer, you don't need permission to commit

Re: [patch] [python libstdc++ printers] Fix gdb/15195

2013-08-20 Thread Phil Muldoon
On 19/08/13 09:00, Jonathan Wakely wrote: On 16 August 2013 16:28, Tom Tromey wrote: Phil == Phil Muldoon pmuld...@redhat.com writes: Phil Anyway, I have regenerated the patch with the fixes requested. Thanks. Phil 2013-08-16 Phil Muldoon pmuld...@redhat.com Phil PR gcc/53477 I

Re: [PATCH] lower-subreg and IBM long double

2013-08-20 Thread Steven Bosscher
On Mon, Aug 19, 2013 at 8:47 AM, Alan Modra wrote: gcc/ ... * doc/tm.texi.in (TARGET_INIT_LOWER_SUBREG): Document. ChangeLog update needed here, the new hook is documented in target.def. +static void +rs6000_init_lower_subreg (void *data) +{ Functions should start with a leading

Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv

2013-08-20 Thread Caroline Tice
Ok, committed (with the space fix). -- Caroline Tice cmt...@google.com On Tue, Aug 20, 2013 at 12:43 PM, Florian Weimer fwei...@redhat.com wrote: On 08/20/2013 09:15 PM, Caroline Tice wrote: That fixed it, thanks! Attached is the latest patch (Florian, I will send you the regenerated

Re: [PATCH 0/2] Port symtab/cgraph/varpool nodes to use C++ inheritance

2013-08-20 Thread Jan Hubicka
Hi, sorry for late reply, I noticed the patch only yesterday. Honza: following up from our IRC chat, I've ported the symtab, cgraph and varpool nodes from the current hand-coded inheritance-in-C scheme to being a C+ class hierarchy. I know you're in the middle of making lots of other

Re: [PATCH 1/2] Convert symtab, cgraph and varpool nodes into a real class hierarchy

2013-08-20 Thread Jan Hubicka
+/* GTY((user)) hooks for symtab_node_base (and its subclasses). + We could use virtual functions for this, but given the presence of the + type field and the trivial size of the class hierarchy, switches are + perhaps simpler and faster. */ Generally I am not really happy about the

Re: [patch] Adjust DECL_NAME of virtual clones

2013-08-20 Thread Eric Botcazou
Okay, just wanted to make sure. Understood. FWIW the patchlet has been in AdaCore's tree for some months and works fine on Linux, Windows, Solaris, AIX, HP-UX, VMS, etc. -- Eric Botcazou

Re: [PATCH 1/2] Convert symtab, cgraph and varpool nodes into a real class hierarchy

2013-08-20 Thread Steven Bosscher
On Tue, Aug 20, 2013 at 11:06 PM, Jan Hubicka hubi...@ucw.cz wrote: +/* GTY((user)) hooks for symtab_node_base (and its subclasses). + We could use virtual functions for this, but given the presence of the + type field and the trivial size of the class hierarchy, switches are + perhaps

Re: [PATCH 1/2] Convert symtab, cgraph and varpool nodes into a real class hierarchy

2013-08-20 Thread Jan Hubicka
On Tue, Aug 20, 2013 at 11:06 PM, Jan Hubicka hubi...@ucw.cz wrote: +/* GTY((user)) hooks for symtab_node_base (and its subclasses). + We could use virtual functions for this, but given the presence of the + type field and the trivial size of the class hierarchy, switches are +

Re: [PATCH 1/2] Convert symtab, cgraph and varpool nodes into a real class hierarchy

2013-08-20 Thread Jan Hubicka
On Tue, Aug 20, 2013 at 11:06 PM, Jan Hubicka hubi...@ucw.cz wrote: +/* GTY((user)) hooks for symtab_node_base (and its subclasses). + We could use virtual functions for this, but given the presence of the + type field and the trivial size of the class hierarchy, switches

Fix corruption of call site hash with speculative edges

2013-08-20 Thread Jan Hubicka
Hi, this patch should fix cgrpah verifier ICE that occurs for speculative calls with call site hash in caller. Here we manage to wrong non-speculative edge into the hash from time to time, when the edges are copied by inliner. This patch fixes the problema and also fixes problem in

Re: [GOOGLE] Assign discriminators for different callsites at a same line within one BB

2013-08-20 Thread Cary Coutant
This patch assigns discriminators for different callsites within the same BB. This is needed for accurate profile attribution in AutoFDO. Testing on going. OK for google branches if test pass? + for (gsi = gsi_start_bb (bb); !gsi_end_p (gsi); gsi_next (gsi)) + { + gimple stmt =

Re: [ping] 3 pending patches

2013-08-20 Thread Jeff Law
On 08/07/2013 02:47 PM, Eric Botcazou wrote: Improve debug info for small structures passed by reference: http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00895.html OK. Please check in the regression tests that you created as well. jeff

Re: [ping] 3 pending patches

2013-08-20 Thread Jeff Law
On 08/07/2013 02:47 PM, Eric Botcazou wrote: Fix error recovery issue with alias: http://gcc.gnu.org/ml/gcc-patches/2013-06/msg01417.html This is fine too. Please install. Thanks, Jeff

Re: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C

2013-08-20 Thread Aldy Hernandez
[rth, law, jakub: Your input required throughout...please.] More review stuff... Overall, I must say, I'm not a big fan of the super early expansion you're doing right after parsing. I mean, you leave CILK_SPAWN and CILK_SYNC keywords as is (in tree form until gimplification) but there's

Re: [PATCH, PR 57748] Set mode of structures with zero sized arrays to be BLK

2013-08-20 Thread David Abdurachmanov
ping^2 david On Aug 12, 2013, at 2:31 PM, David Abdurachmanov wrote: Hi, Ping. Any news of the following patch being included into the trunk? Thanks, david On Aug 2, 2013, at 1:45 PM, Martin Jambor wrote: Hi, while compute_record_mode in stor-layout.c makes sure it assigns BLK

[PATCH] Fixing improper conversion from sin() to sinf() in optimization mode.

2013-08-20 Thread Cong Hou
When a sin() (cos(), log(), etc.) function is called on a value of float type and the returned double value is converted to another value of float type, GCC converts this function call into a float version (sinf()) in the optimization mode. This avoids two type conversions and the float version

Re: [GOOGLE] Assign discriminators for different callsites at a same line within one BB

2013-08-20 Thread Dehao Chen
You are right, we need discriminator for non-CALL stmts too. Patch updated: Index: gcc/tree-cfg.c === --- gcc/tree-cfg.c (revision 201858) +++ gcc/tree-cfg.c (working copy) @@ -781,9 +781,37 @@ assign_discriminators (void) {

RE: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C

2013-08-20 Thread Iyer, Balaji V
HI Aldy et al., I would like to address the early expansion question. The reason why I did it is this way is because it was straight-forward for me to implement. I did some preliminary analysis, and it wasn't blocking any major optimization. Also, after parsing all I am really doing is

Re: [Google] Refine hot caller heuristic

2013-08-20 Thread Xinliang David Li
Do you need to guard the jump function access with check if (ipa_node_params_vector.exists ())? Ideally, useful_cold_callee should be folded into the inline hints estimation. Question about the heuristic: why filtering out PASS_THROUGH parameter cases completely? Passing 'this' parameter in many