Re: [RFC][IPA-VRP] Early VRP Implementation

2016-07-14 Thread Andrew Pinski
On Thu, Jul 14, 2016 at 9:45 PM, kugan wrote: > > Hi, > > > > This patch adds a very simple early vrp implementation. This visits the > basic blocks in the dominance order and set the Value Ranges (VR) for > > SSA_NAMEs in the scope. Use this VR to discover more

[RFC][IPA-VRP] Teach tree-vrp to use the VR set in params

2016-07-14 Thread kugan
Hi, This patch teaches tree-vrp to use the VR set in params. Thanks, Kugan gcc/ChangeLog: 2016-07-14 Kugan Vivekanandarajah * tree-vrp.c (get_value_range): Teach PARM_DECL to use ipa-vrp results. >From

[RFC][IPA-VRP] Add support for IPA VRP in ipa-cp/ipa-prop

2016-07-14 Thread kugan
Hi, This patch extends ipa-cp/ipa-prop infrastructure to handle propagation of VR. Thanks, Kugan gcc/testsuite/ChangeLog: 2016-07-14 Kugan Vivekanandarajah * gcc.dg/ipa/vrp1.c: New test. * gcc.dg/ipa/vrp2.c: New test. *

Re: [RFC][IPA-VRP] Check for POINTER_TYPE_P before accessing SSA_NAME_PTR_INFO in tree-inline

2016-07-14 Thread Andrew Pinski
On Thu, Jul 14, 2016 at 9:43 PM, kugan wrote: > > Hi, > > > > This patch adds check for POINTER_TYPE_P before accessing SSA_NAME_PTR_INFO > in remap_ssa_name in gcc/tree-inline.c. This is not related to IPA_VRP but > was exposed by that. SSA_NAME_PTR_INFO

[RFC][IPA-VRP] Early VRP Implementation

2016-07-14 Thread kugan
Hi, This patch adds a very simple early vrp implementation. This visits the basic blocks in the dominance order and set the Value Ranges (VR) for SSA_NAMEs in the scope. Use this VR to discover more VRs. Restore the old VR once the scope is exit. Thanks, Kugan gcc/ChangeLog:

[RFC][IPA-VRP] Re-factor tree-vrp to factor out common code

2016-07-14 Thread kugan
Hi, This patch re-factors common code in tree-vrp to be used in early vrp. I am not entirely sure where I should place struct value_range. For now I have placed in tree.h. Thanks, Kugan 2016-07-14 Kugan Vivekanandarajah * tree-ssanames.h (enum

[RFC][IPA-VRP] Check for POINTER_TYPE_P before accessing SSA_NAME_PTR_INFO in tree-inline

2016-07-14 Thread kugan
Hi, This patch adds check for POINTER_TYPE_P before accessing SSA_NAME_PTR_INFO in remap_ssa_name in gcc/tree-inline.c. This is not related to IPA_VRP but was exposed by that. Thanks, Kugan gcc/ChangeLog: 2016-07-14 Kugan Vivekanandarajah *

[RFC][IPA-VRP] Disable setting param of __builtin_constant_p to null

2016-07-14 Thread kugan
Hi, VRP assumes that it is run after inlining. Therefore, if there is a call to __builtin_constant_p with function parameter, it resolve it to false to avoid bogus warnings. Since we use this as an early vrp before inling, it leads to wrong code. As a workaround I have disabled it for the

[RFC][IPA-VRP] IPA VRP Implementation

2016-07-14 Thread kugan
Hi, This patch series implements IPA-VRP based on the previous discussions in https://gcc.gnu.org/ml/gcc/2016-01/msg00063.html. 0001-Hack-Prevent-setting-__builtin_constant_p-of-param-t.patch -This is to prevent EVRP setting result of __builtin_constant_p to null that will inlined

Re: [PATCH/AARCH64] Add rtx_costs routine for vulcan.

2016-07-14 Thread Virendra Pathak
Hi James/Julian, Kindly merge this patch to the trunk. Thanks. >> Julian has commit rights and is on the ChangeLog, so I'll let him >> commit the patch on your behalf. > Julian, Kindly commit the patch to the trunk. > with regards, Virendra Pathak On Mon, Jul 11, 2016 at 2:50 PM, Virendra

[PATCH] Fix OpenACC vector_length parsing in fortran

2016-07-14 Thread Cesar Philippidis
The fortran FE is currently scanning for the vector clause before vector_length. That's a problem match_oacc_clause_gwv matches 'vector' without looking for whatever follows it. The correction I made here was to scan for vector_length before vector. Is this OK for trunk and gcc6? Cesar

Re: [PATCH] zero-length arrays in OpenACC

2016-07-14 Thread Cesar Philippidis
Ping, x2. Cesar On 06/01/2016 02:35 PM, Cesar Philippidis wrote: > This patch teaches c and c++ front ends and omp-low how to deal with > subarray involving GOMP_MAP_FORCE_{PRESENT,TO,FROM,TOFROM} data > mappings. As the libgomp test case shows, it might be possible for a > subarray to have zero

Re: [patch, fortran] PR62125 Nested select type not accepted (rejects valid)

2016-07-14 Thread Jerry DeLisle
Hit send too soon and forgot to fill out the subject line. Correctly given here. On 07/14/2016 10:47 AM, Jerry DeLisle wrote: This simple patch kindly provided by Marco solves the problem. Regression tested on x86_64-Linux, Test case provided also. OK to commit to trunk? Jerry 2016-07-14

[libstdc++] Add C++17clamp

2016-07-14 Thread Ed Smith-Rowland
Here is an implementation of P0025 An algorithm to "clamp" a value between a pair of boundary values. Testing is almost finished - looks good so far. OK if testing passes? I didn't see a feature test in any of the SD-6 papers or P0025. 2016-07-15 Edward Smith-Rowland <3dw...@verizon.net>

Re: [PATCH 2/3] Run profile feedback tests with autofdo

2016-07-14 Thread Andi Kleen
> >> I haven't seen that. Unstable in what way? > > For GCC doesn't support FDO, it run below tests as you said: > > > > PASS: gcc.dg/tree-prof/20041218-1.c compilation, -g > > UNSUPPORTED: gcc.dg/tree-prof/20041218-1.c: Cannot run create_gcov > > --binary

Re: [PATCH] Add missing OBJCOPY variable to Makefile.in

2016-07-14 Thread JonY
On 7/14/2016 06:22, Jeff Law wrote: > On 07/03/2016 05:56 AM, JonY wrote: >> This patch allows OBJCOPY to be set by configure. It was missing in >> Makefile.in. >> >> Patch OK? > With a ChangeLog and verification that some host/target combination > still builds this is OK. > > jeff > >

Re: [PATCH, vec-tails 07/10] Support loop epilogue combining

2016-07-14 Thread Jeff Law
On 06/28/2016 06:24 AM, Ilya Enkovich wrote: Here is an updated patch version. Thanks, Ilya -- gcc/ 2016-05-28 Ilya Enkovich * dbgcnt.def (vect_tail_combine): New. * params.def (PARAM_VECT_COST_INCREASE_COMBINE_THRESHOLD): New. *

Re: [PATCH, vec-tails 08/10] Support loop epilogue masking and low trip count loop vectorization

2016-07-14 Thread Jeff Law
On 06/24/2016 05:46 AM, Ilya Enkovich wrote: Here is an updated version. It allows vectorization with a smaller vector size in case we fail to vectorize with masking. Thanks, Ilya -- gcc/ 2016-05-24 Ilya Enkovich * dbgcnt.def (vect_tail_mask): New.

PR fortran/29819 -- fix committed.

2016-07-14 Thread Steve Kargl
Committed as obvious. 2016-07-14 Steven G. Kargl PR fortran/29819 * parse.c (parse_contained): Use proper locus. 2016-07-14 Steven G. Kargl PR fortran/29819 * gfortran.dg/bind_c_usage_9.f03: Move dg-error. *

Re: [PATCH, vec-tails 03/10] Support epilogues vectorization with no masking

2016-07-14 Thread Jeff Law
On 06/24/2016 01:40 AM, Ilya Enkovich wrote: Here is an updated version with disabled alias checks for loop epilogues. Instead of calling vect_analyze_data_ref_dependence I just use VF of the original loop as MAX_VF for epilogue. Thanks, Ilya -- gcc/ 2016-05-24 Ilya Enkovich

Re: [PATCH] Handle undefined extern vars in output_in_order

2016-07-14 Thread Jeff Law
On 06/23/2016 08:45 AM, Alexander Monakov wrote: Hi, I've discovered that this assert in my patch was too restrictive: + if (DECL_HAS_VALUE_EXPR_P (pv->decl)) + { + gcc_checking_assert (lookup_attribute ("omp declare target link", +

Re: [PATCH] Handle undefined extern vars in output_in_order

2016-07-14 Thread Jeff Law
On 07/14/2016 12:33 PM, Alexander Monakov wrote: On Thu, 14 Jul 2016, Jeff Law wrote: Is the point here to be able to deduce what symbols are external & undefined and emit some kind of directive to the assembler in that case? Yes, PTX assembly requires that properly typed declarations are

Re: [PATCH, contrib] download_prerequisites: check for existing symlinks before making new ones

2016-07-14 Thread Eric Gallager
On 7/14/16, Jeff Law wrote: > On 07/14/2016 04:57 AM, Eric Gallager wrote: >> On 7/13/16, Jeff Law wrote: >>> On 06/27/2016 08:10 PM, Eric Gallager wrote: The last time I ran ./contrib/download_prerequisites, I already had previous symlinks set up from

Re: [PATCH] Tweak diagnostic-token.ranges.c testcase (PR testsuite/71865)

2016-07-14 Thread Jakub Jelinek
On Thu, Jul 14, 2016 at 02:29:10PM -0400, David Malcolm wrote: > > Tested on x86_64-linux and i686-linux, ok for trunk? > > Thanks. I think I can approve this with my "libcpp/diagnostic messages > " maintainer hat on. > > Did you test the case with a build for one of the affected targets to >

Re: [C PATCH] Ignore invisible bindings for misspelling hints (PR c/71858)

2016-07-14 Thread Jakub Jelinek
On Thu, Jul 14, 2016 at 02:22:36PM -0400, David Malcolm wrote: > I agree with the points you raise; in that light I'm fine with your > patch. Ok, Marek has approved it earlier, so I went ahead and committed. > > shouldn't be lowered (say for at > > most 4 chars identifiers only consider

Re: [PATCH] Handle undefined extern vars in output_in_order

2016-07-14 Thread Alexander Monakov
On Thu, 14 Jul 2016, Jeff Law wrote: > Is the point here to be able to deduce what symbols are external & undefined > and emit some kind of directive to the assembler in that case? Yes, PTX assembly requires that properly typed declarations are emitted for external references. Today, the NVPTX

Re: [PATCH 2/2] C++ FE: handle misspelled identifiers and typenames

2016-07-14 Thread David Malcolm
On Wed, 2016-07-13 at 16:12 -0600, Jeff Law wrote: > On 06/30/2016 12:53 PM, David Malcolm wrote: > > This is a port of the C frontend's r237714 [1] to the C++ frontend: > > https://gcc.gnu.org/ml/gcc-patches/2016-06/msg01052.html > > offering spelling suggestions for misspelled identifiers,

Re: [PATCH] Tweak diagnostic-token.ranges.c testcase (PR testsuite/71865)

2016-07-14 Thread David Malcolm
On Thu, 2016-07-14 at 16:55 +0200, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, this testcase behaves differently on > powerpc*/spu/s390* targets, because in non-iso modes they predefine > conditional macros like bool and that affects the behavior of the > suggestions. > > We should

Re: [C PATCH] Ignore invisible bindings for misspelling hints (PR c/71858)

2016-07-14 Thread David Malcolm
On Thu, 2016-07-14 at 19:47 +0200, Jakub Jelinek wrote: > On Thu, Jul 14, 2016 at 01:22:27PM -0400, David Malcolm wrote: > > I wrote a patch for this, similar to yours, but with a slightly > > different approach for handling builtins. > > > > I think it's reasonable to offer suggestions for

Re: [PATCH] Handle undefined extern vars in output_in_order

2016-07-14 Thread Jeff Law
On 06/23/2016 08:45 AM, Alexander Monakov wrote: Hi, I've discovered that this assert in my patch was too restrictive: + if (DECL_HAS_VALUE_EXPR_P (pv->decl)) + { + gcc_checking_assert (lookup_attribute ("omp declare target link", +

Re: [PATCH v2] extend shift count warnings to vector types

2016-07-14 Thread Jeff Law
On 07/01/2016 08:29 AM, Jan Beulich wrote: gcc/c/ 2016-07-01 Jan Beulich * c-fold.c (c_fully_fold_internal): Also emit shift count warnings for vector types. * c-typeck.c (build_binary_op): Likewise. gcc/testsuite/ 2016-07-01 Jan Beulich

Re: [Fortran, Patch, PR71807, v1] [5/6/7 Regression] Internal compiler error with NULL() reference in structure constructor

2016-07-14 Thread Jerry DeLisle
On 07/14/2016 09:17 AM, Andre Vehreschild wrote: > Hi all, > > attached patch fixes the ICE when assigning null() to an allocatable > component in an initializer. > > Bootstrapped and regtested on x86_64-linux/F23 ok for trunk, > gcc-6-branch and gcc-5-branch. > > Ok for trunk and one week

Re: [PATCH PR71503/PR71683]Fix ICE in tree-if-conv.c

2016-07-14 Thread Jeff Law
On 07/14/2016 10:12 AM, Bin Cheng wrote: Hi, This is a simple patch fixing ICE in tree-if-conv.c. Existing code does not setup a variable (cond) when predicate of basic block is true and it asserts on the variable. Interesting thing is dead code is not cleaned up before ifcvt, but that's

[patch, fortran]

2016-07-14 Thread Jerry DeLisle
This simple patch kindly provided by Marco solves the problem. Regression tested on x86_64-Linux, Test case provided also. OK to commit to trunk? Jerry 2016-07-14 Jerry DeLisle Marco Restelli PR fortran/62125 *

Re: [C PATCH] Ignore invisible bindings for misspelling hints (PR c/71858)

2016-07-14 Thread Jakub Jelinek
On Thu, Jul 14, 2016 at 01:22:27PM -0400, David Malcolm wrote: > I wrote a patch for this, similar to yours, but with a slightly > different approach for handling builtins. > > I think it's reasonable to offer suggestions for misspellings of e.g. > "snprintf" even if the pertinent header hasn't

Re: [PATCH, vec-tails 10/10] Tests

2016-07-14 Thread Jeff Law
On 07/05/2016 09:44 AM, Ilya Enkovich wrote: Hi, This patch adds several tests to check tails vectorization functionality. Thanks, Ilya -- gcc/testsuite/ 2016-07-05 Ilya Enkovich * lib/target-supports.exp (check_avx2_hw_available): New.

[v3 PATCH] Fix the constraints for any's assignment operator template to properly reject assignment from a non-copyable lvalue.

2016-07-14 Thread Ville Voutilainen
Tested on Linux-x64. 2016-07-14 Ville Voutilainen Fix the constraints for any's assignment operator template to properly reject assignment from a non-copyable lvalue. * include/std/any (operator=(_ValueType&&)): Constrain the decayed type for

Re: [PATCH, contrib] download_prerequisites: check for existing symlinks before making new ones

2016-07-14 Thread Jeff Law
On 07/14/2016 04:57 AM, Eric Gallager wrote: On 7/13/16, Jeff Law wrote: On 06/27/2016 08:10 PM, Eric Gallager wrote: The last time I ran ./contrib/download_prerequisites, I already had previous symlinks set up from a previous run of the script, so `ln` followed the existing

Re: [C PATCH] Ignore invisible bindings for misspelling hints (PR c/71858)

2016-07-14 Thread David Malcolm
On Thu, 2016-07-14 at 16:50 +0200, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, anticipated decls should be ignored from > fuzzy > lookups, unless the corresponding decl is declared first. I wrote a patch for this, similar to yours, but with a slightly different approach for handling

Re: [PATCH] doc fix for c/71560 - union compound literal initializes wrong union field

2016-07-14 Thread Jeff Law
On 07/14/2016 09:03 AM, Martin Sebor wrote: Ping. The updated patch at the link below corrects the issues with the tags pointed out by Sandra in her review. https://gcc.gnu.org/ml/gcc-patches/2016-07/msg00350.html OK. jeff

Re: [PATCH testsuite]XFAIL gcc.dg/tree-ssa/pr71347 on some targets

2016-07-14 Thread Jeff Law
On 07/14/2016 10:11 AM, Bin Cheng wrote: Hi, Test gcc.dg/tree-ssa/pr71347 failed on some targets if the two memory references are re-written into different forms by IVOPT. This could be because of various reasons, for example, auto-increment addressing mode. Since the address expressions are

Re: [JAVA PATCH] Enable more array bounds check elimination

2016-07-14 Thread Andrew Hughes
snip... > > At a very high level, you should be aware of a general belief that GCJ's > life is limited. There's been various calls to deprecate it. So > spending a lot of time optimizing GCJ's output may not be the best use > of your skills :-) > Unless things have changed since it was last

Re: [PATCH, ARM 7/7] Enable atomics for ARMv8-M Mainline

2016-07-14 Thread Thomas Preudhomme
On Thursday 14 July 2016 17:23:46 Kyrill Tkachov wrote: > Hi Thomas, > > On 14/07/16 14:37, Thomas Preudhomme wrote: > > Hi Kyrill, > > > > On Thursday 19 May 2016 17:18:29 Kyrill Tkachov wrote: > >> Hi Thomas, > >> > >> On 17/05/16 11:15, Thomas Preudhomme wrote: > >>> Ping? > >>> > >>> ***

Re: [PATCH, GCC/LRA] Teach LRA to not use same register value for multiple output operands of an insn

2016-07-14 Thread Vladimir Makarov
On 07/08/2016 11:07 AM, Thomas Preudhomme wrote: Hi, While investigating the root cause a testsuite regression for the ARM/embedded-5-branch GCC in gcc.dg/vect/slp-perm-5.c, we found that the bug seems to also affect trunk. The bug manifests itself as an ICE in cselib due to a parallel insn

Re: [PATCH, ARM 7/7] Enable atomics for ARMv8-M Mainline

2016-07-14 Thread Kyrill Tkachov
Hi Thomas, On 14/07/16 14:37, Thomas Preudhomme wrote: Hi Kyrill, On Thursday 19 May 2016 17:18:29 Kyrill Tkachov wrote: Hi Thomas, On 17/05/16 11:15, Thomas Preudhomme wrote: Ping? *** gcc/ChangeLog *** 2015-12-17 Thomas Preud'homme *

[Fortran, Patch, PR71807, v1] [5/6/7 Regression] Internal compiler error with NULL() reference in structure constructor

2016-07-14 Thread Andre Vehreschild
Hi all, attached patch fixes the ICE when assigning null() to an allocatable component in an initializer. Bootstrapped and regtested on x86_64-linux/F23 ok for trunk, gcc-6-branch and gcc-5-branch. Ok for trunk and one week later for the other branches? Regards, Andre -- Andre

Re: [PATCH] Fix tree-data-ref.c ICE (PR tree-optimization/71872)

2016-07-14 Thread Richard Biener
On July 14, 2016 5:28:03 PM GMT+02:00, Jakub Jelinek wrote: >Hi! > >As mentioned in the PR, we ICE on the following testcase, because >tree-data-ref.c for VIEW_CONVERT_EXPR(0) attempts to create >ADDR_EXPR of INTEGER_CST, which is not really valid. > >I've successfully

[PATCH PR71503/PR71683]Fix ICE in tree-if-conv.c

2016-07-14 Thread Bin Cheng
Hi, This is a simple patch fixing ICE in tree-if-conv.c. Existing code does not setup a variable (cond) when predicate of basic block is true and it asserts on the variable. Interesting thing is dead code is not cleaned up before ifcvt, but that's another story. Bootstrap and test on x86_64.

[PATCH testsuite]XFAIL gcc.dg/tree-ssa/pr71347 on some targets

2016-07-14 Thread Bin Cheng
Hi, Test gcc.dg/tree-ssa/pr71347 failed on some targets if the two memory references are re-written into different forms by IVOPT. This could be because of various reasons, for example, auto-increment addressing mode. Since the address expressions are of different form, DOM fails to eliminate

[PATCH test]Refine test string for scev-8.c

2016-07-14 Thread Bin Cheng
Hi, Dump information of IVOPT has been improved, but scanning string in gcc.dg/tree-ssa/scev-8.c was left over because it appears as PASS. This patch changes test string to what should be tested. Test result checked. This is an obvious change. Thanks, bin gcc/testsuite/ChangeLog 2016-07-14

Re: [PATCH] Amend dump expectation in slsr-8.c (PR, tree-optimization/71490)

2016-07-14 Thread Martin Liška
On 07/14/2016 01:21 PM, Richard Biener wrote: > On Thu, Jul 14, 2016 at 1:06 PM, Martin Liška wrote: >> On 07/13/2016 07:21 PM, Jeff Law wrote: >>> Isn't that a code quality regression? So instead shouldn't we be keeping >>> the same expectation, but xfailing the test? >>> >>>

Re: [patch] Fix type merging deficiency during WPA

2016-07-14 Thread Eric Botcazou
> Yeah, as said such optimistic merging would need to happen during canoncial > type merging for example by completely ignoring TYPE_DOMAIN or > DECL_FIELD_OFFSET ... (a non-constant in one unit may be the same as a > constant in another...). OK, that's really optimistic, and we can probably get

Re: [PATCH] Add header for std::search to testcase

2016-07-14 Thread Jonathan Wakely
On 14/07/16 16:29 +0100, Jonathan Wakely wrote: * testsuite/experimental/functional/searchers.cc: Include for std::search. This test was failing in Parallel Mode, because it wasn't including the header for std::search. Actually that fix isn't quite enough. Even if the

Re: [Ada] Another small tweak in LTO mode

2016-07-14 Thread Eric Botcazou
> I am not quite sure I understand your explanation. Can you, please, show me > how the types differ? So you have one type which contains ptr_type_node and > other which is array? For one compilation unit, the type is an array of pointer to something, for example a record type and, for another

[PATCH] Add header for std::search to testcase

2016-07-14 Thread Jonathan Wakely
* testsuite/experimental/functional/searchers.cc: Include for std::search. This test was failing in Parallel Mode, because it wasn't including the header for std::search. Tested x86_64-linux, committed to trunk. commit ca8663b7b1451f4ca0097af7eb902367970f7b33 Author: redi

[PATCH] Fix tree-data-ref.c ICE (PR tree-optimization/71872)

2016-07-14 Thread Jakub Jelinek
Hi! As mentioned in the PR, we ICE on the following testcase, because tree-data-ref.c for VIEW_CONVERT_EXPR(0) attempts to create ADDR_EXPR of INTEGER_CST, which is not really valid. I've successfully bootstrapped/regtested earlier version of this patch with is_gimple_constant instead of

[C++ PATCH] Fix up vector cond expr handling in templates (PR c++/71871)

2016-07-14 Thread Jakub Jelinek
Hi! This patch reverts part of https://gcc.gnu.org/ml/gcc-patches/2012-10/msg01665.html which looks wrong to me. The problem is that in templates, if the build_x_conditional_expr arguments aren't type dependent, we might get NON_DEPENDENT_EXPR wrappers around the argument, so after issuing

[patch] Add new hook to diagnose address space usage

2016-07-14 Thread Georg-Johann Lay
This adds a new hook that allows to emit better diagnostics if an address space is used that's not available. One solution would be no not register the address space with c_register_addr_space but that gives ugly report like error: expected '=', ',', ';', 'asm' or '__attribute__' before

Re: [PATCH] c++/60760 - arithmetic on null pointers should not be allowed in constant expressions

2016-07-14 Thread Martin Sebor
Ping. Jason, do you have any further comments or concerns with the updated patch? https://gcc.gnu.org/ml/gcc-patches/2016-07/msg00280.html Thanks Martin On 07/06/2016 04:20 PM, Martin Sebor wrote: On 06/23/2016 03:36 PM, Jason Merrill wrote: On 06/20/2016 10:17 PM, Martin Sebor wrote: +

Re: [PATCH] doc fix for c/71560 - union compound literal initializes wrong union field

2016-07-14 Thread Martin Sebor
Ping. The updated patch at the link below corrects the issues with the tags pointed out by Sandra in her review. https://gcc.gnu.org/ml/gcc-patches/2016-07/msg00350.html Thanks Martin On 07/07/2016 01:47 PM, Martin Sebor wrote: On 07/03/2016 05:22 PM, Sandra Loosemore wrote: On 07/01/2016

[Fortran, Patch, PR70842, v1] [4.9/5/6/7 Regression] internal compiler error with character members within a polymorphic pointer

2016-07-14 Thread Andre Vehreschild
Hi all, attached patch fixes the ICE and the wrong char array length mentioned in comment #3 of the PR. The issue was that getting the _len component is valid online for unlimited polymorphic pointers. But here this was tried for polymorphic entity, which had to fail. Bootstrapped and regtests

Re: [C PATCH] Ignore invisible bindings for misspelling hints (PR c/71858)

2016-07-14 Thread Marek Polacek
On Thu, Jul 14, 2016 at 04:50:16PM +0200, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, anticipated decls should be ignored from fuzzy > lookups, unless the corresponding decl is declared first. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > 2016-07-13

[PATCH] Tweak diagnostic-token.ranges.c testcase (PR testsuite/71865)

2016-07-14 Thread Jakub Jelinek
Hi! As mentioned in the PR, this testcase behaves differently on powerpc*/spu/s390* targets, because in non-iso modes they predefine conditional macros like bool and that affects the behavior of the suggestions. We should certainly discuss what to do with the conditional macros, but in the mean

[C PATCH] For implicit function declaration suggestions only consider fns and fn pointers (PR c/71858)

2016-07-14 Thread Jakub Jelinek
Hi! When implicit_decl_warning is called, we know we are interested in a function or function pointer (or macro), C doesn't support int () like C++, or var () when var doesn't have function pointer type. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-07-14 Jakub

[C PATCH] Ignore invisible bindings for misspelling hints (PR c/71858)

2016-07-14 Thread Jakub Jelinek
Hi! As mentioned in the PR, anticipated decls should be ignored from fuzzy lookups, unless the corresponding decl is declared first. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-07-13 Jakub Jelinek PR c/71858 * c-decl.c

Re: [PATCH, rs6000] Fix PR target/71733, ICE with -mcpu=power9 -mno-vsx

2016-07-14 Thread Segher Boessenkool
On Thu, Jul 14, 2016 at 12:14:10PM +0930, Alan Modra wrote: > The following has now been bootstrapped and regression tested on > powerpc64le-linux. OK for mainline? > > * gcc/config/rs6000/altivec.md (altivec_mov): Disparage > gpr alternatives. Correct '*' placement on Y,r

Re: [PATCH, contrib] download_prerequisites: check for existing symlinks before making new ones

2016-07-14 Thread NightStrike
On Thu, Jul 14, 2016 at 6:57 AM, Eric Gallager wrote: > On 7/13/16, Jeff Law wrote: >> On 06/27/2016 08:10 PM, Eric Gallager wrote: >>> The last time I ran ./contrib/download_prerequisites, I already had >>> previous symlinks set up from a previous run of

Re: [PATCH, contrib] download_prerequisites: check for existing symlinks before making new ones

2016-07-14 Thread NightStrike
On Wed, Jul 13, 2016 at 5:36 PM, Jeff Law wrote: > On 06/27/2016 08:10 PM, Eric Gallager wrote: >> >> The last time I ran ./contrib/download_prerequisites, I already had >> previous symlinks set up from a previous run of the script, so `ln` >> followed the existing symlinks and

Re: [PATCH, ARM 7/7] Enable atomics for ARMv8-M Mainline

2016-07-14 Thread Thomas Preudhomme
Hi Kyrill, On Thursday 19 May 2016 17:18:29 Kyrill Tkachov wrote: > Hi Thomas, > > On 17/05/16 11:15, Thomas Preudhomme wrote: > > Ping? > > > > *** gcc/ChangeLog *** > > > > 2015-12-17 Thomas Preud'homme > > > > * config/arm/arm.h (TARGET_HAVE_LDACQ):

Re: [PATCH][vectorizer][2/2] Hook up mult synthesis logic into vectorisation of mult-by-constant

2016-07-14 Thread Rainer Orth
Hi Richard, > On Thu, 14 Jul 2016, Kyrill Tkachov wrote: > >> Hi all, >> >> On 07/07/16 17:16, Kyrill Tkachov wrote: >> > >> > On 06/07/16 13:40, Kyrill Tkachov wrote: >> > > >> > > On 06/07/16 13:31, Rainer Orth wrote: >> > > > Hi Kyrill, >> > > > >> > > > > On 05/07/16 12:24, Rainer Orth

Re: [PATCH] disable IPA-cp cloning for functions with target_clones attribute

2016-07-14 Thread Martin Jambor
Hi Jeff, On Wed, Jul 13, 2016 at 08:46:35AM -0600, Jeff Law wrote: > On 07/12/2016 03:31 AM, Martin Jambor wrote: > > Hi, > > > > On Fri, Jun 24, 2016 at 01:41:05PM -0700, Evgeny Stupachenko wrote: > > > Hi, > > > > > > Fix ICE when IPA-cp and target_clones are applied to the same function. > >

Re: [PATCH, GCC/LRA] Teach LRA to not use same register value for multiple output operands of an insn

2016-07-14 Thread Thomas Preudhomme
On Thursday 14 July 2016 10:32:48 Thomas Preudhomme wrote: > On Friday 08 July 2016 09:05:55 Mike Stump wrote: > > On Jul 8, 2016, at 8:07 AM, Thomas Preudhomme > > wrote: > > > While investigating the root cause a testsuite regression for the > > >

[PATCH] Fix PR71866

2016-07-14 Thread Richard Biener
The following fixes PR71866 and also includes some cleanup starting to address the issue at a different level (we want to insert a & -1 as we didn't manage to simplify that during phi-translation - but during insertion we _do_ simplify it and end up inserting nothing but still report "progress",

Re: [patch,avr] minor tweaks for 8-bit operations

2016-07-14 Thread Georg-Johann Lay
On 14.07.2016 05:55, Senthil Kumar Selvaraj wrote: Georg-Johann Lay writes: This patch contains some unrelated tweaks [...] - Some patterns that match situations with zero_extend that can be performed with less instructions / register pressure. From my (admittedly limited) attempts at

Re: [Ada] Another small tweak in LTO mode

2016-07-14 Thread Jan Hubicka
> This change makes it so that gigi uses a generic pointer type (ptr_type_node) > for pointers to Taft Amendment types, which are kind of opaque pointer types. > > Tested on x86_64-suse-linux, applied on the mainline. > > However, this isn't sufficient for LTO's type canonical merging code,

Re: [patch] Fix type merging deficiency during WPA

2016-07-14 Thread Richard Biener
On Wed, Jul 13, 2016 at 3:16 PM, Eric Botcazou wrote: >> As tree merging really replaces trees it has to error on the side of not >> merging while canonical type merging has to error on the side of "merging" >> to make types alias. > > OK, then the former won't be

Re: [PATCH] Lift alignment restrictions from inlining register size memcpy

2016-07-14 Thread Richard Biener
On Thu, 14 Jul 2016, Georg-Johann Lay wrote: > On 12.07.2016 11:38, Richard Biener wrote: > > > > The following patch does $subject which is requested in a comment in > > PR50417 as this restriction defeats the purpose of having memcpy > > as a portable and efficient way to circumvent

Re: [PATCH] Lift alignment restrictions from inlining register size memcpy

2016-07-14 Thread Georg-Johann Lay
On 12.07.2016 11:38, Richard Biener wrote: The following patch does $subject which is requested in a comment in PR50417 as this restriction defeats the purpose of having memcpy as a portable and efficient way to circumvent strict-aliasing violations (or even as a portable and efficient way to

Re: [PATCH GCC]Improve loop-niter to handle possible infinite loop.

2016-07-14 Thread Richard Biener
On Wed, Jul 13, 2016 at 6:09 PM, Bin.Cheng wrote: > On Fri, Jul 1, 2016 at 11:33 AM, Richard Biener > wrote: >> On Tue, Jun 28, 2016 at 8:18 AM, Bin Cheng wrote: >>> Hi, >>> At the moment, loop niter analyzer depends on

Re: [PATCH] Amend dump expectation in slsr-8.c (PR, tree-optimization/71490)

2016-07-14 Thread Richard Biener
On Thu, Jul 14, 2016 at 1:06 PM, Martin Liška wrote: > On 07/13/2016 07:21 PM, Jeff Law wrote: >> Isn't that a code quality regression? So instead shouldn't we be keeping >> the same expectation, but xfailing the test? >> >> jeff > > Hello. > > Disabling a pass before slsr makes

[Ada] Another small tweak in LTO mode

2016-07-14 Thread Eric Botcazou
This change makes it so that gigi uses a generic pointer type (ptr_type_node) for pointers to Taft Amendment types, which are kind of opaque pointer types. Tested on x86_64-suse-linux, applied on the mainline. However, this isn't sufficient for LTO's type canonical merging code, because the

Re: [PATCH] Lift alignment restrictions from inlining register size memcpy

2016-07-14 Thread Richard Biener
On Thu, 14 Jul 2016, Eric Botcazou wrote: > > Boostrap / regtest on strict-alignment platforms welcome. > > Bootstrap/regtest on SPARC/Solaris is OK, modulo: > > XPASS: gcc.dg/memmove-4.c scan-tree-dump-not optimized "memmove" > FAIL: gcc.dg/strlenopt-8.c scan-tree-dump-times strlen "strlen

Re: [PATCH 2/3] Run profile feedback tests with autofdo

2016-07-14 Thread Bin.Cheng
On Thu, Jul 14, 2016 at 12:06 PM, Bin.Cheng wrote: > On Thu, Jul 14, 2016 at 11:55 AM, Andi Kleen wrote: >>> After this patch, I got below test results with command line: make >>> check-gcc RUNTESTFLAGS="tree-prof.exp" -k >> >> That is expected if you

Re: [PATCH] Amend dump expectation in slsr-8.c (PR, tree-optimization/71490)

2016-07-14 Thread Martin Liška
On 07/13/2016 07:21 PM, Jeff Law wrote: > Isn't that a code quality regression? So instead shouldn't we be keeping the > same expectation, but xfailing the test? > > jeff Hello. Disabling a pass before slsr makes the test to catch both opportunities. Is the patch fine? Thanks, Martin >From

Re: [PATCH 2/3] Run profile feedback tests with autofdo

2016-07-14 Thread Bin.Cheng
On Thu, Jul 14, 2016 at 11:55 AM, Andi Kleen wrote: >> After this patch, I got below test results with command line: make >> check-gcc RUNTESTFLAGS="tree-prof.exp" -k > > That is expected if you don't have autofdo. You would prefer to hide it? > >> Also I got unstable test

Re: [PATCH, contrib] download_prerequisites: check for existing symlinks before making new ones

2016-07-14 Thread Eric Gallager
On 7/13/16, Jeff Law wrote: > On 06/27/2016 08:10 PM, Eric Gallager wrote: >> The last time I ran ./contrib/download_prerequisites, I already had >> previous symlinks set up from a previous run of the script, so `ln` >> followed the existing symlinks and created the new ones in

Re: [PATCH 2/3] Run profile feedback tests with autofdo

2016-07-14 Thread Andi Kleen
> After this patch, I got below test results with command line: make > check-gcc RUNTESTFLAGS="tree-prof.exp" -k That is expected if you don't have autofdo. You would prefer to hide it? > Also I got unstable test result in tree-prof.exp if I run > aforementioned command line with -jnum

Re: [PATCH] Lift alignment restrictions from inlining register size memcpy

2016-07-14 Thread Eric Botcazou
> Boostrap / regtest on strict-alignment platforms welcome. Bootstrap/regtest on SPARC/Solaris is OK, modulo: XPASS: gcc.dg/memmove-4.c scan-tree-dump-not optimized "memmove" FAIL: gcc.dg/strlenopt-8.c scan-tree-dump-times strlen "strlen (" 0 FAIL: gcc.dg/strlenopt-8.c scan-tree-dump-times

Re: [PATCH][vectorizer][2/2] Hook up mult synthesis logic into vectorisation of mult-by-constant

2016-07-14 Thread Richard Biener
On Thu, 14 Jul 2016, Kyrill Tkachov wrote: > Hi all, > > On 07/07/16 17:16, Kyrill Tkachov wrote: > > > > On 06/07/16 13:40, Kyrill Tkachov wrote: > > > > > > On 06/07/16 13:31, Rainer Orth wrote: > > > > Hi Kyrill, > > > > > > > > > On 05/07/16 12:24, Rainer Orth wrote: > > > > > > Marc

[PATCH] Improve doxygen comments for allocators in containers

2016-07-14 Thread Jonathan Wakely
PR libstdc++/70716 * include/bits/forward_list.h (forward_list): Update doxygen comments to reflect allocator propagation semantics. Remove ambiguous statements about data being lost. * include/bits/stl_deque.h (deque): Likewise. *

Re: [PATCH GCC]Resolve compilation time known alias checks in vectorizer

2016-07-14 Thread Bin.Cheng
On Thu, Jul 14, 2016 at 10:49 AM, Thomas Schwinge wrote: > Hi! > > On Wed, 13 Jul 2016 16:09:21 +0100, "Bin.Cheng" wrote: >> Patch re-tested/applied on trunk as r238301. As I mentioned >> previously, gcc.dg/vect/vect-mask-store-move-1.c fails now

Re: [PATCH GCC]Resolve compilation time known alias checks in vectorizer

2016-07-14 Thread Thomas Schwinge
Hi! On Wed, 13 Jul 2016 16:09:21 +0100, "Bin.Cheng" wrote: > Patch re-tested/applied on trunk as r238301. As I mentioned > previously, gcc.dg/vect/vect-mask-store-move-1.c fails now because of > PR65206. Unless you intend to work on PR65206 (Richard's last comment was

Re: [PATCH, GCC/LRA] Teach LRA to not use same register value for multiple output operands of an insn

2016-07-14 Thread Thomas Preudhomme
On Friday 08 July 2016 09:05:55 Mike Stump wrote: > On Jul 8, 2016, at 8:07 AM, Thomas Preudhomme wrote: > > While investigating the root cause a testsuite regression for the > > ARM/embedded-5-branch GCC in gcc.dg/vect/slp-perm-5.c, we found that the > > bug

Re: Fix PR44281 (bad RA with global regs)

2016-07-14 Thread Dominik Vogt
On Wed, Jul 13, 2016 at 07:43:13PM +0200, Bernd Schmidt wrote: > On 07/13/2016 05:29 PM, Dominik Vogt wrote: > > >Unfortunately this patch (or whatever got actually committed) has > >broken the gcc.target/s390/pr679443.c test case, which is a bit > >fishy (see code snippet below). I assign most

Re: [PATCH, GCC/ARM testsuite] Fix pr42574.c selector syntax error

2016-07-14 Thread Thomas Preudhomme
On Thursday 14 July 2016 10:14:52 Kyrill Tkachov wrote: > Hi Thomas, > > On 14/07/16 10:12, Thomas Preudhomme wrote: > > This patch fixes a syntax error in the dg-do selector of pr42574.c: it is > > missing the target keyword, with the following boolean expression enclosed > > in curly braces.

Re: [PATCH, GCC/ARM testsuite] Fix pr42574.c selector syntax error

2016-07-14 Thread Kyrill Tkachov
Hi Thomas, On 14/07/16 10:12, Thomas Preudhomme wrote: This patch fixes a syntax error in the dg-do selector of pr42574.c: it is missing the target keyword, with the following boolean expression enclosed in curly braces. Test fails to be run without this patch and successfully pass with it.

[PATCH, GCC/ARM testsuite] Fix pr42574.c selector syntax error

2016-07-14 Thread Thomas Preudhomme
This patch fixes a syntax error in the dg-do selector of pr42574.c: it is missing the target keyword, with the following boolean expression enclosed in curly braces. Test fails to be run without this patch and successfully pass with it. Patch is in attachment. ChangeLog entry is as follows:

Re: [PATCH v5] Allocate constant size dynamic stack space in the prologue

2016-07-14 Thread Dominik Vogt
On Wed, Jul 13, 2016 at 04:12:36PM -0600, Jeff Law wrote: > On 07/11/2016 05:44 AM, Dominik Vogt wrote: > >On Thu, Jul 07, 2016 at 12:57:16PM +0100, Dominik Vogt wrote: > >>On Wed, Jul 06, 2016 at 02:01:06PM +0200, Bernd Schmidt wrote: > >>>There's one thing I don't quite understand and which

Re: Implement -Wswitch-fallthrough: aarch64 + arm

2016-07-14 Thread Richard Earnshaw (lists)
Where the comments just say "Fall through", or equivalent, and there's no other explanation I think those comments are now redundant and should be removed. So remove: /* Fall through. */ but keep things like: /* Fall through - if the lane index isn't a constant then

Re: [v3 PATCH] Implement P0032R3, Homogeneous interface for variant, any and optional, for the parts concerning any and optional.

2016-07-14 Thread Jonathan Wakely
This change replaced a Tab with 8 spaces, but the lines after it still use Tabs: @@ -641,12 +634,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } template - void +enable_if_t::value> emplace(_Args&&... __args) { Might as well

  1   2   >