Re: [RS6000] PR72802 part 2, reload ICE

2016-08-08 Thread Alan Modra
Also committed to gcc-6 branch. PR target/72802 * config/rs6000/rs6000.md (mov_hardfloat): Sort alternatives. Put loads first, then stores, and reg/reg moves within same class later. Delete attr length. testsuite/ * gcc.c-torture/compile/pr72802.c: New.

Re: [RS6000] PR72802 part 1, fix constraints for lxssp/stxssp

2016-08-08 Thread Alan Modra
Now backported to gcc-6-branch too, after bootstrap and regression testing. PR target/72802 * config/rs6000/rs6000.c (mem_operand_gpr): Remove vsx dform test. (mem_operand_ds_form): New predicate. * config/rs6000/rs6000-protos.h (mem_operand_ds_form): Declare.

Re: [Patch, libfortran] Multi-threaded random_number

2016-08-08 Thread Jerry DeLisle
On 08/08/2016 04:01 AM, Janne Blomqvist wrote: PING**2 OK, thanks for patch. Jerry On Sun, Jul 24, 2016 at 4:45 PM, Janne Blomqvist wrote: Hi, the attached patch replaces the current random_number / random_seed implementations with an implementation that better

Ping^2: [PATCH build/doc] Replacing libiberty with gnulib

2016-08-08 Thread ayush goel
This patch https://gcc.gnu.org/ml/gcc-patches/2016-07/msg01302.html is still pending review. -Ayush

Re: [RFC][PR61839]Convert CST BINOP COND_EXPR to COND_EXPR ? (CST BINOP 1) : (CST BINOP 0)

2016-08-08 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On 29 April 2016 at 20:47, Richard Biener wrote: > On Sun, Apr 17, 2016 at 1:14 AM, kugan > wrote: >> As explained in PR61839, >> >> Following difference results in extra instructions: >> - c = b

Re: [PATCH] Fix warning breaking profiled bootstrap

2016-08-08 Thread Andi Kleen
> Ideally we'd have a test that we could more deeply analyze for paths > through the CFG that can't be executed. Finding those paths usually > both fixes the warning *and* results in better code. Even if we > can't fix it now, we can file it away for future work It's multiple variables who are

[v3 PATCH] Implement the latest proposed resolution of LWG 2756

2016-08-08 Thread Ville Voutilainen
Tested on Linux-x64. The proposed resolution of the aforementioned issue hasn't been adopted by LWG yet, but it certainly makes much more sense than the previous resolution (disclaimer: I wrote both the previous and the latest p/r). Paolo, can you please review this patch? Jonathan is on holiday.

Re: Set nonnull attribute to ptr_info_def based on VRP

2016-08-08 Thread kugan
Hi Jakub, Thanks for the review. On 08/08/16 16:40, Jakub Jelinek wrote: On Mon, Aug 08, 2016 at 01:36:51PM +1000, kugan wrote: diff --git a/gcc/tree-ssanames.h b/gcc/tree-ssanames.h index c81b1a1..6e34433 100644 --- a/gcc/tree-ssanames.h +++ b/gcc/tree-ssanames.h @@ -43,6 +43,9 @@ struct

Re: [PATCH], Improve vector int/long initialization on PowerPC

2016-08-08 Thread Michael Meissner
On Fri, Aug 05, 2016 at 05:00:39PM -0500, Pat Haugen wrote: > On 08/03/2016 11:33 PM, Michael Meissner wrote: > > { > > - if (BYTES_BIG_ENDIAN) > > -return "xxpermdi %x0,%x1,%x2,0"; > > + if (which_alternative == 0) > > +return (BYTES_BIG_ENDIAN > > + ? "xxpermdi %x0,%x1,%x2,0" >

Re: [PATCH], Improve vector int/long initialization on PowerPC

2016-08-08 Thread Michael Meissner
On Thu, Aug 04, 2016 at 10:03:36AM -0500, Segher Boessenkool wrote: > Hi Mike, > > On Thu, Aug 04, 2016 at 12:33:44AM -0400, Michael Meissner wrote: > > I built spec 2006 with these patches on a little endian power8 system, and > > at > > least 18 of the benchmarks had vector initializations

Re: libgo patch committed: Update to 1.7rc3

2016-08-08 Thread Ian Lance Taylor
On Fri, Aug 5, 2016 at 1:24 AM, Uros Bizjak wrote: > On Thu, Aug 4, 2016 at 6:48 PM, Ian Lance Taylor wrote: >> On Thu, Aug 4, 2016 at 1:11 AM, Uros Bizjak wrote: >>> On Thu, Aug 4, 2016 at 12:53 AM, Ian Lance Taylor

Re: [PR63240] generate debug info for defaulted member functions

2016-08-08 Thread Jason Merrill
OK. On Fri, Aug 5, 2016 at 5:47 PM, Alexandre Oliva wrote: > On Aug 4, 2016, Jason Merrill wrote: > >> On Mon, Aug 1, 2016 at 10:57 PM, Alexandre Oliva wrote: >>> * langhooks.h (struct lang_hooks_for_decls): Add >>>

libgo patch committed: adjust dependencies

2016-08-08 Thread Ian Lance Taylor
The current libgo dependencies are too aggressive, in that if the Makefile changes the .dep files, which are included, get rebuilt, and that caused the entire library to be rebuilt. This patch changes the Makefile so that the .lo files do not depend on the .lo.dep files. Instead, when rebuilding

Re: [C++ PATCH] Fix ICE when throwing va_list (PR c++/72809)

2016-08-08 Thread Jason Merrill
OK. On Mon, Aug 8, 2016 at 3:09 PM, Jakub Jelinek wrote: > Hi! > > If va_list is one-entry array of structs, those RECORD_TYPEs don't > have TYPE_BINFO. > > Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for > trunk? > > I've made the testcase compile

[committed] Fix selftest::test_lexer_string_locations_ebcdic for systems without iconv (PR bootstrap/72844)

2016-08-08 Thread David Malcolm
selftest::test_lexer_string_locations_ebcdic has this clause: /* EBCDIC support requires iconv. */ if (!HAVE_ICONV) return; leading to a build failure on systems without iconv. This conditional works in libcpp due to this in libcpp/internal.h: #if HAVE_ICONV #include #else

Re: libgo patch committed: Change build procedure to use build tags

2016-08-08 Thread Ian Lance Taylor
On Mon, Aug 8, 2016 at 11:14 AM, Lynn A. Boger wrote: > The libgo tests on ppc64le and ppc64 have all been failing in > gcc-testresults since this change went in and continues to fail after the > recent fixes for failures on other platforms. > > Built myself and got

Re: [PATCH 3/4] Use class substring_loc in c-format.c (PR c/52952)

2016-08-08 Thread David Malcolm
On Thu, 2016-08-04 at 12:08 -0600, Jeff Law wrote: > On 08/03/2016 09:45 AM, David Malcolm wrote: > > This patch updates c-format.c to use the new class substring_loc, > > added > > in the previous patch, replacing location_column_from_byte_offset. > > Hence with this patch, Wformat can underline

[committed] Fix ICE with lambda in OpenMP for loop iterator dependent init (PR c++/58706)

2016-08-08 Thread Jakub Jelinek
Hi! When parsing lambdas, the C++ FE emits DECL_EXPRs with TYPE_DECLs for the lambda structs, which confuse the OpenMP iterator init handling. Fixed by moving those over into the for block. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2016-08-08 Jakub Jelinek

[committed] Fix ICE with omp declare simd in BLOCK DATA (PR fortran/72716)

2016-08-08 Thread Jakub Jelinek
Hi! We reject the statement later on, because it is not allowed in block data, but if we stick it into the block data ns anyway, we ICE later on during diagnostics. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk, queued for 6.2. 2016-08-08 Jakub Jelinek

[PATCH] Fix unaligned access when predictive commoning (PR 71083)

2016-08-08 Thread Bernd Edlinger
Hi! As described in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71083 we generate unaligned accesses because tree-predcom rewrites bitfield and packed accesses in a way that looses the proper alignment information. The attached patch fixes this by re-using the gimple memory expression from the

[committed] Avoid some -Wuninitialized OpenMP false positives (PR middle-end/72781)

2016-08-08 Thread Jakub Jelinek
Hi! The control structure is too hard to understand in certain cases for the uninit pass - the test for the last iteration compares against a specific value, while in the loop it tests for the particular assigned chunks. So, this patch marks the private vars for lastprivate or for simd linear

libgo patch committed: treat functions that return zero bytes as returning void

2016-08-08 Thread Ian Lance Taylor
PR 72814 is a bug that is due to a mismatch between libffi and the code being called when the code returns a zero-sized struct. libffi can not represent a zero-sized struct, so the Go runtime creates a libffi type that uses a one-byte struct. This technique fails on 32-bit SPARC, where the

[committed] Fix simd clone creation for C++ inlines etc. (PR middle-end/68762)

2016-08-08 Thread Jakub Jelinek
Hi! When a cgraph clone is created for simd clones, it is forced make_decl_local, but for the simd clones we actually want to preserve their visibility, weak, comdat etc. (except that we want to use a separate comdat group). Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux,

Re: Init df for split pass since some target use REG_NOTE in split pattern

2016-08-08 Thread Jeff Law
On 07/25/2016 08:31 PM, Kito Cheng wrote: Hi Jeff: Oop, patch in attachment, and I hit this bug in gcc.dg/torture/vshuf-v2di.c with our nds32 internal branch. Hi Richard: I think we really need reg dead note for some optimization, and btw, here is our split pattern: So I see a real need to be

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

2016-08-08 Thread Jeff Law
On 08/04/2016 03:13 PM, Martin Sebor wrote: On 07/21/2016 03:48 PM, Jeff Law wrote: Sorry about the delay in responding... I saw a few places in GCC itself where you increased buffer sizes. Were any of those level 1 failures? Yes. With optimization, even level 1 uses range information

Re: [PATCH GCC]Simplify interface for simplify_using_initial_conditions

2016-08-08 Thread Jeff Law
On 08/05/2016 08:53 AM, Bin.Cheng wrote: On Thu, Aug 4, 2016 at 1:48 PM, Richard Biener wrote: On Thu, Aug 4, 2016 at 10:40 AM, Bin.Cheng wrote: On Wed, Aug 3, 2016 at 11:17 PM, Jeff Law wrote: On 08/03/2016 10:35 AM, Bin

Re: [testsuite] add require-effective-target c99_runtime for pr71078-*.c tests

2016-08-08 Thread Jeff Law
On 08/06/2016 02:55 AM, Prathamesh Kulkarni wrote: Hi Richard, The patch for PR71078 broke the test-cases for arm and aarch64 bare metal targets :/ In the attached patch, restricting the tests to c99_runtime. Sorry for the breakage. Ok for trunk ? Thanks, Prathamesh patch.txt 2016-08-06

Re: [PATCH] Remove unnecessary jump threading restriction

2016-08-08 Thread Jeff Law
On 08/06/2016 05:34 AM, Richard Biener wrote: On Fri, Aug 5, 2016 at 10:43 PM, Jeff Law wrote On 08/05/2016 01:45 AM, Richard Biener wrote: There is no need to avoid threading to a loop header, the threading code can cope with this just fine. Noticed when working on

[C++ PATCH] Fix ICE when throwing va_list (PR c++/72809)

2016-08-08 Thread Jakub Jelinek
Hi! If va_list is one-entry array of structs, those RECORD_TYPEs don't have TYPE_BINFO. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? I've made the testcase compile instead of run, because while it with the patch works both on x86_64-linux and i686-linux,

Re: libgo patch committed: Change build procedure to use build tags

2016-08-08 Thread Lynn A. Boger
Sorry if I was unclear. Failures started happening with r239189, and it continues to fail in the most recent commit, so none of the later changes fixed the problem. Only happens on trunk, ppc64le & ppc64 (m32 also). I did my build on a different machine from the gcc-testresults build just

Re: protected alloca class for malloc fallback

2016-08-08 Thread Richard Biener
On August 8, 2016 7:39:39 PM GMT+02:00, Trevor Saunders wrote: >On Mon, Aug 08, 2016 at 11:00:28AM -0600, Jeff Law wrote: >> On 08/06/2016 09:08 AM, Richard Biener wrote: >> > On August 6, 2016 12:15:26 PM GMT+02:00, Aldy Hernandez > wrote: >> > > On

[PATCH] Add cgraph edge for early fixup_cfg inserted __builtin_unreachable (PR target/71910)

2016-08-08 Thread Jakub Jelinek
Hi! In cross to mingw we ICE on the following testcase, because fixup_cfg pass adds __builtin_unreachable call without adding corresponding cgraph_edge (the body of the parallel region doesn't return, so while GOMP_parallel isn't a noreturn function, it will actually never return).

[PATCH] Fix ldist memset discovery with -0.0 (PR tree-optimization/72824)

2016-08-08 Thread Jakub Jelinek
Hi! Only +0.0 stores can be optimized into memset, -0.0 can't, so if we are honoring signed zeros, we should make sure the constant is positive. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-08-08 Jakub Jelinek PR tree-optimization/72824

Re: libgo patch committed: Change build procedure to use build tags

2016-08-08 Thread Ian Lance Taylor
On Mon, Aug 8, 2016 at 11:14 AM, Lynn A. Boger wrote: > > The libgo tests on ppc64le and ppc64 have all been failing in > gcc-testresults since this change went in and continues to fail after the > recent fixes for failures on other platforms. > > Built myself and got

Re: one more patch for PR69847

2016-08-08 Thread H.J. Lu
On Fri, Aug 5, 2016 at 2:35 PM, Vladimir N Makarov wrote: > This is a patch to fix some testsuite failures reported for arm: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69847 > > The patch was bootstrapped and tested on x86-64 and ppc64. > > Committed as rev. 239180.

Re: libgo patch committed: Change build procedure to use build tags

2016-08-08 Thread Lynn A. Boger
The libgo tests on ppc64le and ppc64 have all been failing in gcc-testresults since this change went in and continues to fail after the recent fixes for failures on other platforms. Built myself and got the same failures. I set keep=true in gotest to save the test dirs. Just running a

Re: [PATCH/AARCH64] Improve ThunderX code generation slightly with load/store pair

2016-08-08 Thread Andrew Pinski
On Fri, Aug 5, 2016 at 12:18 AM, Andrew Pinski wrote: > Hi, > On ThunderX, load (and store) pair that does a pair of two word > (32bits) load/stores is slower in some cases than doing two > load/stores. For some internal benchmarks, it provides a 2-5% > improvement. > > This

Re: [patch, avr] Fix mmcu to specs issues

2016-08-08 Thread Denis Chertykov
Sorry for delay. Committed. 2016-08-08 9:17 GMT+03:00 Pitchumani Sivanupandi : > Ping! > > > On Friday 29 July 2016 05:14 PM, Pitchumani Sivanupandi wrote: >> >> On Friday 29 July 2016 02:06 PM, Georg-Johann Lay wrote: >>> >>> On 28.07.2016 13:50, Pitchumani

Re: protected alloca class for malloc fallback

2016-08-08 Thread Trevor Saunders
On Mon, Aug 08, 2016 at 11:00:28AM -0600, Jeff Law wrote: > On 08/06/2016 09:08 AM, Richard Biener wrote: > > On August 6, 2016 12:15:26 PM GMT+02:00, Aldy Hernandez > > wrote: > > > On 08/05/2016 04:07 PM, Richard Biener wrote: > > > > On August 5, 2016 8:15:54 PM GMT+02:00,

Re: [PATCH] c-format.c: cleanup of check_format_info_main

2016-08-08 Thread Jeff Law
On 08/05/2016 07:24 PM, David Malcolm wrote: On Thu, 2016-08-04 at 14:22 -0600, Jeff Law wrote: On 08/04/2016 01:24 PM, David Malcolm wrote: Do you realize that this isn't used for ~700 lines after this point? Is there any sensible way to factor some code here to avoid the coding disconnect.

Re: [Fortran, Patch] First patch for coarray FAILED IMAGES (TS 18508)

2016-08-08 Thread Dan Nagle
Hi, The failed images features of gfortran are exciting, and folks here would like to start testing with their scientific codes. I’d like to build a new gfortran to support them, but I must build from a trusted source, which means from trunk, without custom patches. Can Alessandro’s patch get a

Re: [Revert][AArch64] PR 63521 Define REG_ALLOC_ORDER/HONOR_REG_ALLOC_ORDER

2016-08-08 Thread Jiong Wang
Jiong Wang writes: > Andrew Pinski writes: > >> On Mon, Jul 27, 2015 at 3:36 AM, James Greenhalgh >> wrote: >>> On Mon, Jul 27, 2015 at 10:52:58AM +0100, pins...@gmail.com wrote: > On Jul 27, 2015, at 2:26 AM, Jiong Wang wrote: > >

Re: [PATCH] PR middle-end/21137: Folding if (((int)x >> 31) & 64) into if ((int)x < 0)

2016-08-08 Thread Jeff Law
On 08/08/2016 05:58 AM, Marek Polacek wrote: On Mon, Aug 08, 2016 at 12:56:20PM +0100, Roger Sayle wrote: The following patch is an attempt to finally fully close PR middle-end/21137. As explained in the PR, my original patch from 2006 didn't handle the case where there's a sign preserving NOP

Re: [PATCH 5/N] Add new *_atomic counter update function, (-fprofile-update=atomic)

2016-08-08 Thread Martin Liška
On 08/08/2016 06:50 PM, Martin Liška wrote: > On 08/08/2016 05:24 PM, Nathan Sidwell wrote: >> On 08/08/16 09:59, Martin Liška wrote: >>> Hello. >>> >>> This patch is follow-up of the series where I introduce a set of counter >>> update >>> function that are thread-safe. I originally thought that

Re: protected alloca class for malloc fallback

2016-08-08 Thread Jeff Law
On 08/06/2016 09:08 AM, Richard Biener wrote: On August 6, 2016 12:15:26 PM GMT+02:00, Aldy Hernandez wrote: On 08/05/2016 04:07 PM, Richard Biener wrote: On August 5, 2016 8:15:54 PM GMT+02:00, Oleg Endo wrote: On Fri, 2016-08-05 at 19:55 +0200,

Re: [PATCH 5/N] Add new *_atomic counter update function, (-fprofile-update=atomic)

2016-08-08 Thread Martin Liška
On 08/08/2016 05:24 PM, Nathan Sidwell wrote: > On 08/08/16 09:59, Martin Liška wrote: >> Hello. >> >> This patch is follow-up of the series where I introduce a set of counter >> update >> function that are thread-safe. I originally thought that majority of profile >> corruptions are >> caused

[PATCH] Fix POW2 histogram

2016-08-08 Thread Martin Liška
Hello. Currently, we utilize pow2 profile histogram to track gimple STMTs like this: ssa_name_x % value. void __gcov_pow2_profiler (gcov_type *counters, gcov_type value) { if (value & (value - 1)) counters[0]++; else counters[1]++; } Although __gcov_pow2_profiler function wrongly

Re: [PATCH] Fix warning breaking profiled bootstrap

2016-08-08 Thread Jeff Law
On 08/06/2016 09:41 PM, Andi Kleen wrote: From: Andi Kleen This patch fixes an bootstrap error with autoprofiledbootstrap due to uninitiliazed variables, because the compiler cannot figure out they don't need to be initialized in an error path. Just always initialize

Re: [PATCH] Make autofdo tests safer for parallel builds

2016-08-08 Thread Jeff Law
On 08/06/2016 09:43 PM, Andi Kleen wrote: From: Andi Kleen There were some reports that the autofdo tests are non deterministic with parallel builds. I wasn't able to reproduce this, but here are two changes that may help: - Always use unique file names for temporary

Re: [PATCH] Fix assembler arguments for -m16

2016-08-08 Thread Roger Pau Monne
On Wed, Jul 20, 2016 at 06:31:57PM +0200, Roger Pau Monne wrote: > On Wed, Jul 06, 2016 at 04:18:49PM +0200, Roger Pau Monne wrote: > > At the moment the -m16 option only passes the "--32" parameter to the > > assembler on glibc OSes, while on other OSes the assembler is called without > > any

Re: [Patch, tentative, reload] Make push_reload work with more types of subregs?

2016-08-08 Thread Senthil Kumar Selvaraj
Bernd Schmidt writes: > On 07/28/2016 09:33 AM, Senthil Kumar Selvaraj wrote: >> >> Is there a reason why only REG and SYMBOL_REFs get valid >> subreg_in_class? I tried extending it handle constants and PLUS >> expressions, and it fixes PR 71873. It also fixes a another >> bug that was a

Re: [PATCH 5/N] Add new *_atomic counter update function, (-fprofile-update=atomic)

2016-08-08 Thread Nathan Sidwell
On 08/08/16 09:59, Martin Liška wrote: Hello. This patch is follow-up of the series where I introduce a set of counter update function that are thread-safe. I originally thought that majority of profile corruptions are caused by non-atomic updated of CFG (-fprofile-arc). But there are multiple

Re: [RFC] ipa bitwise constant propagation

2016-08-08 Thread David Malcolm
On Mon, 2016-08-08 at 16:03 +0200, Martin Jambor wrote: > Hi, > > thanks for following through. You'll need an approval from Honza, > but > I think the code looks good (I have looked at the places that I > believe have changed since the last week). However, I have > discovered > one new thing I

[PATCH] gcov-tool: Do not segfault in merge operation (PR, gcov-profile/67097).

2016-08-08 Thread Martin Liška
Hi. Following simple patch is a fix for $subject. Ready for trunk? Martin >From 936e45b384f30f560cacafb7bb6ed9968e4faa96 Mon Sep 17 00:00:00 2001 From: marxin Date: Mon, 8 Aug 2016 16:09:06 +0200 Subject: [PATCH] gcov-tool: Do not segfault in merge operation (PR

Re: [RFC] ipa bitwise constant propagation

2016-08-08 Thread Martin Jambor
Hi, thanks for following through. You'll need an approval from Honza, but I think the code looks good (I have looked at the places that I believe have changed since the last week). However, I have discovered one new thing I don't like and still believe you need to handle different precisions in

[PATCH 5/N] Add new *_atomic counter update function, (-fprofile-update=atomic)

2016-08-08 Thread Martin Liška
Hello. This patch is follow-up of the series where I introduce a set of counter update function that are thread-safe. I originally thought that majority of profile corruptions are caused by non-atomic updated of CFG (-fprofile-arc). But there are multiple counters that compare it's count to a

Re: [PATCH,rs6000] Add built-in function support Power9 binary floating point operations

2016-08-08 Thread Pat Haugen
On 08/05/2016 08:04 PM, Segher Boessenkool wrote: > On Fri, Aug 05, 2016 at 04:27:36PM -0500, Pat Haugen wrote: >> On 08/02/2016 03:15 PM, Segher Boessenkool wrote: >>> On Tue, Aug 02, 2016 at 03:03:42PM -0500, Pat Haugen wrote: On 07/29/2016 10:47 AM, Kelvin Nilsen wrote: > + "xsxexpdp

Re: [PATCH] Fix regno_in_use_p for RTL checking bootstrap (PR rtl-optimization/72821)

2016-08-08 Thread Vladimir N Makarov
On 08/06/2016 03:11 PM, Jakub Jelinek wrote: On Wed, Aug 03, 2016 at 02:59:30PM -0400, Vladimir N Makarov wrote: --- lra-spills.c(revision 239000) +++ lra-spills.c(working copy) @@ -686,16 +686,40 @@ return_regno_p (unsigned int regno) return false; } -/* Return true

Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)

2016-08-08 Thread Nathan Sidwell
On 08/06/16 06:31, Jakub Jelinek wrote: Fixed thusly, committed as obvious to trunk: 2016-08-06 Jakub Jelinek * gcov.c (handle_cycle): Use INTTYPE_MAXIMUM (int64_t) instead of INT64_MAX. thanks Jakub! nathan

Re: [PATCH] PR middle-end/21137: Folding if (((int)x >> 31) & 64) into if ((int)x < 0)

2016-08-08 Thread Marek Polacek
On Mon, Aug 08, 2016 at 12:56:20PM +0100, Roger Sayle wrote: > > The following patch is an attempt to finally fully close PR middle-end/21137. > As explained in the PR, my original patch from 2006 didn't handle the case > where there's a sign preserving NOP in the tree. Easily fixed by calling >

[PATCH] PR middle-end/21137: Folding if (((int)x >> 31) & 64) into if ((int)x < 0)

2016-08-08 Thread Roger Sayle
The following patch is an attempt to finally fully close PR middle-end/21137. As explained in the PR, my original patch from 2006 didn't handle the case where there's a sign preserving NOP in the tree. Easily fixed by calling tree_strip_nop_conversions at the appropriate point in fold-const.c.

Re: [PATCH] Allow relayout_decl on FIELD_DECLs (PR c/72816)

2016-08-08 Thread Marek Polacek
On Mon, Aug 08, 2016 at 11:04:32AM +, Joseph Myers wrote: > On Sat, 6 Aug 2016, Jakub Jelinek wrote: > > > --- gcc/testsuite/gcc.dg/pr72816.c.jj 2016-08-06 13:06:45.046003282 > > +0200 > > +++ gcc/testsuite/gcc.dg/pr72816.c 2016-08-06 13:07:57.217093845 +0200 > > @@ -0,0 +1,9 @@ > >

[backported,v5,v6] Fix PR71976 in combine.c:get_last_value()

2016-08-08 Thread Georg-Johann Lay
Applied to v5: https://gcc.gnu.org/r239239 v6: https://gcc.gnu.org/r239238 Johann Backport from 2016-07-29 trunk r238863. PR rtl-optimization/71976 * combine.c (get_last_value): Return 0 if the argument for which the function is called has a wider mode than the

Re: [PATCH AArch64/V3]Add new patterns for vcond_mask and vec_cmp

2016-08-08 Thread Bin.Cheng
On Mon, Aug 8, 2016 at 11:40 AM, James Greenhalgh wrote: > On Mon, Aug 01, 2016 at 01:18:53PM +, Bin Cheng wrote: >> Hi, >> This is the 3rd version patch implementing vcond_mask and vec_cmp patterns on >> AArch64. Bootstrap and test along with next patch on AArch64,

Re: [PATCH] Allow relayout_decl on FIELD_DECLs (PR c/72816)

2016-08-08 Thread Joseph Myers
On Sat, 6 Aug 2016, Jakub Jelinek wrote: > --- gcc/testsuite/gcc.dg/pr72816.c.jj 2016-08-06 13:06:45.046003282 +0200 > +++ gcc/testsuite/gcc.dg/pr72816.c2016-08-06 13:07:57.217093845 +0200 > @@ -0,0 +1,9 @@ > +/* PR c/72816 */ > +/* { dg-do compile } */ > +/* { dg-options "-std=gnu11" } */ >

Re: [avr,RFC,patch] Add var attribute "absdata" to support LDS / STS on AVR_TINY.

2016-08-08 Thread Georg-Johann Lay
On 08.08.2016 07:10, Sandra Loosemore wrote: On 08/03/2016 10:17 AM, Georg-Johann Lay wrote: Index: doc/extend.texi === --- doc/extend.texi(revision 238983) +++ doc/extend.texi(working copy) @@ -5957,6 +5957,25 @@

Re: [Patch, libfortran] Multi-threaded random_number

2016-08-08 Thread Janne Blomqvist
PING**2 On Sun, Jul 24, 2016 at 4:45 PM, Janne Blomqvist wrote: > Hi, > > the attached patch replaces the current random_number / random_seed > implementations with an implementation that better supports threads. > It's an improved version of the RFC patch I posted

Re: [PATCH] aarch64: Add split-stack initial support

2016-08-08 Thread Jiong Wang
Adhemerval Zanella writes: >> diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c >> index e56398a..2cf239f 100644 >> --- a/gcc/config/aarch64/aarch64.c >> +++ b/gcc/config/aarch64/aarch64.c >> @@ -3227,6 +3227,34 @@ aarch64_expand_prologue (void) >>

Re: [PATCH AArch64][V3]Rewrite vcond patterns using vcond_mask/vec_cmp, also support missing vect_cond_mixed patterns

2016-08-08 Thread James Greenhalgh
On Mon, Aug 01, 2016 at 01:19:54PM +, Bin Cheng wrote: > Hi, > This is the 3rd version patch implementing vcond patterns on AArch64. It > rewrites vcond patterns using newly introduced vcond_mask and vec_cmp > patterns in previous patch. It also adds missing vect_cond_mixed patterns > for

Re: [PATCH, RELOAD] Don't assume subreg mem address is ok

2016-08-08 Thread Segher Boessenkool
On Mon, Aug 08, 2016 at 07:15:01PM +0930, Alan Modra wrote: > > > Segher, is this rs6000 patch OK? Bootstrapped as above. > > > > > > PR target/72771 > > > * config/rs6000/rs6000.c (toc_relative_expr_p): Allow lo_sum/high > > > toc refs created during reload. > > > > > /* Return true if

Re: [PATCH AArch64/V3]Add new patterns for vcond_mask and vec_cmp

2016-08-08 Thread James Greenhalgh
On Mon, Aug 01, 2016 at 01:18:53PM +, Bin Cheng wrote: > Hi, > This is the 3rd version patch implementing vcond_mask and vec_cmp patterns on > AArch64. Bootstrap and test along with next patch on AArch64, is it OK? OK, with a couple of comments below, one on an extension and once style nit.

Re: [Patch, wwwdocs] Add caveat for AVR port

2016-08-08 Thread Senthil Kumar Selvaraj
Georg-Johann Lay writes: > On 08.08.2016 10:24, Senthil Kumar Selvaraj wrote: >> Hi, >> >> This doc patch informs the user that a specific (or higher) version of >> binutils is a prerequisite for the fix for a rather vexing bug (PR >> 71151) that was fixed for 6.2. >> >> I've added it to

Re: [Patch, wwwdocs] Add caveat for AVR port

2016-08-08 Thread Georg-Johann Lay
On 08.08.2016 10:24, Senthil Kumar Selvaraj wrote: Hi, This doc patch informs the user that a specific (or higher) version of binutils is a prerequisite for the fix for a rather vexing bug (PR 71151) that was fixed for 6.2. I've added it to the Caveats section; is there a better place?

Re: [Patch] Implement std::experimental::variant

2016-08-08 Thread Ville Voutilainen
On 7 August 2016 at 04:04, Ville Voutilainen wrote: >> Good news! This compiles now! I learned the technique from Anthony >> Williams's implementation, whose code also compiles, but it requires a >> close-to-trunk gcc, which implements >> "...for unions, at least one

Re: [Fortran, patch, pr71936, v1] [6/7 Regression] ICE in wide_int_to_tree, at tree.c:1487

2016-08-08 Thread Andre Vehreschild
Hi Paul, thanks for the review. Committed to trunk as r239237. I will commit to gcc-6 in one week. Regards, Andre On Mon, 8 Aug 2016 11:33:06 +0200 Paul Richard Thomas wrote: > Hi Andre, > > That looks fine to me. OK for 6-branch and trunk. > > Thanks

Re: [Fortran, Patch, PR72698, v1] [5/6/7 Regression] ICE in lhd_incomplete_type_error, at langhooks.c:205

2016-08-08 Thread Andre Vehreschild
Hi Thomas, thanks for the review. I have changed the test to run and result check as requested. Committed to trunk as r239236. Will commit to gcc-6 and -5-branch in one week. Regards, Andre On Mon, 8 Aug 2016 08:42:08 +0200 Thomas Koenig wrote: > Am 07.08.2016

Re: [PATCH, RELOAD] Don't assume subreg mem address is ok

2016-08-08 Thread Alan Modra
On Mon, Aug 08, 2016 at 03:52:31AM -0500, Segher Boessenkool wrote: > On Mon, Aug 08, 2016 at 05:03:46PM +0930, Alan Modra wrote: > > Segher, is this rs6000 patch OK? Bootstrapped as above. > > > > PR target/72771 > > * config/rs6000/rs6000.c (toc_relative_expr_p): Allow lo_sum/high > >

Re: [Fortran, patch, pr71936, v1] [6/7 Regression] ICE in wide_int_to_tree, at tree.c:1487

2016-08-08 Thread Paul Richard Thomas
Hi Andre, That looks fine to me. OK for 6-branch and trunk. Thanks for the patch. Paul On 7 August 2016 at 15:32, Andre Vehreschild wrote: > Hi all, > > attached patch fixes the ICE by ensuring that when the SOURCE=/MOLD= > expression is an array-valued function call with no

Re: [Patch, wwwdocs] Add caveat for AVR port

2016-08-08 Thread Gerald Pfeifer
On Mon, 8 Aug 2016, Senthil Kumar Selvaraj wrote: > This doc patch informs the user that a specific (or higher) version of > binutils is a prerequisite for the fix for a rather vexing bug (PR > 71151) that was fixed for 6.2. > > I've added it to the Caveats section; is there a better

Re: [PATCH, RELOAD] Don't assume subreg mem address is ok

2016-08-08 Thread Segher Boessenkool
On Mon, Aug 08, 2016 at 05:03:46PM +0930, Alan Modra wrote: > Segher, is this rs6000 patch OK? Bootstrapped as above. > > PR target/72771 > * config/rs6000/rs6000.c (toc_relative_expr_p): Allow lo_sum/high > toc refs created during reload. > /* Return true if OP is a toc

Re: [RS6000] PR72802 part 2, reload ICE

2016-08-08 Thread Segher Boessenkool
On Mon, Aug 08, 2016 at 04:27:22PM +0930, Alan Modra wrote: > PR target/72802 > * config/rs6000/rs6000.md (mov_hardflow): Sort "hardfloat". > alternatives. Put loads first, then stores, and reg/reg moves > within same class later. Delete attr length. > testsuite/ >

Ping patch GCC-6

2016-08-08 Thread Jakub Sejdak
Hi! I would like to ping a couple of unreviewed patches for GCC-6 branch (they are already in trunk): - Backport new Phoenix-RTOS OS name to config.sub https://gcc.gnu.org/ml/gcc-patches/2016-07/msg01441.html - Backport support for Phoenix-RTOS targets in GCC's config for ARM platform.

Re: backward threading heuristics tweek

2016-08-08 Thread James Greenhalgh
On Sun, Aug 07, 2016 at 10:30:48AM -0700, Andrew Pinski wrote: > On Mon, Jun 6, 2016 at 3:19 AM, Jan Hubicka wrote: > > Hi, > > while looking into profile mismatches introduced by the backward threading > > pass > > I noticed that the heuristics seems quite simplistics. First it

[Patch, wwwdocs] Add caveat for AVR port

2016-08-08 Thread Senthil Kumar Selvaraj
Hi, This doc patch informs the user that a specific (or higher) version of binutils is a prerequisite for the fix for a rather vexing bug (PR 71151) that was fixed for 6.2. I've added it to the Caveats section; is there a better place? If not, ok to commit? Regards Senthil Index:

Re: Ping [Fortran, Patch, pr70524, v1] [5/6/7 Regression] ICE when using -frepack-arrays -Warray-temporaries

2016-08-08 Thread Andre Vehreschild
Hi Thomas, thanks for the review. Committed as r239230in trunk, r239231in gcc-6-branch, r239232in gcc-5-branch. Thanks again, Andre On Mon, 8 Aug 2016 08:37:16 +0200 Thomas Koenig wrote: > Hi Andre, > > the patch is OK. > > > > Ping. > > Regards >

Re: [PATCH, RELOAD] Don't assume subreg mem address is ok

2016-08-08 Thread Alan Modra
On Mon, Aug 08, 2016 at 12:55:59PM +0930, Alan Modra wrote: > On Mon, Aug 08, 2016 at 12:13:18PM +0930, Alan Modra wrote: > > This patch fixes a case where reload blindly assumes a subreg mem > > is OK if its address has been partially reloaded by > > legitimize_reload_address. The change ought

Re: [RS6000] PR72802 part 2, reload ICE

2016-08-08 Thread Alan Modra
On Fri, Aug 05, 2016 at 08:31:45PM -0500, Segher Boessenkool wrote: > On Sat, Aug 06, 2016 at 10:53:33AM +0930, Alan Modra wrote: > > On Fri, Aug 05, 2016 at 06:01:47PM -0500, Segher Boessenkool wrote: > > > I agree reg-reg moves should come after reg-mem moves, but is it such > > > a good idea to

Re: [Fortran, Patch, PR72698, v1] [5/6/7 Regression] ICE in lhd_incomplete_type_error, at langhooks.c:205

2016-08-08 Thread Thomas Koenig
Am 07.08.2016 um 13:52 schrieb Andre Vehreschild: Hi Andre, attached patch fixes the ICE caused by a zero-sized string. Assigning that string to a temporary variable obviously did not work out. The patch fixes this by checking for zero-sized strings in SOURCE= and not producing the code to

Re: Set nonnull attribute to ptr_info_def based on VRP

2016-08-08 Thread Jakub Jelinek
On Mon, Aug 08, 2016 at 01:36:51PM +1000, kugan wrote: > diff --git a/gcc/tree-ssanames.h b/gcc/tree-ssanames.h > index c81b1a1..6e34433 100644 > --- a/gcc/tree-ssanames.h > +++ b/gcc/tree-ssanames.h > @@ -43,6 +43,9 @@ struct GTY(()) ptr_info_def > above alignment. Access only through the

Re: Ping [Fortran, Patch, pr70524, v1] [5/6/7 Regression] ICE when using -frepack-arrays -Warray-temporaries

2016-08-08 Thread Thomas Koenig
Hi Andre, the patch is OK. Ping. Regards Thomas

Re: [patch, avr] Fix mmcu to specs issues

2016-08-08 Thread Pitchumani Sivanupandi
Ping! On Friday 29 July 2016 05:14 PM, Pitchumani Sivanupandi wrote: On Friday 29 July 2016 02:06 PM, Georg-Johann Lay wrote: On 28.07.2016 13:50, Pitchumani Sivanupandi wrote: On Tuesday 26 July 2016 06:00 PM, Georg-Johann Lay wrote: On 26.07.2016 12:20, Pitchumani Sivanupandi wrote: