Re: [GCC][PATCH][TESTSUITE][ARM][COMMITTED] Invert check to misalign in vect_hw_misalign (PR 78421)

2017-09-25 Thread Christophe Lyon
On 25 September 2017 at 20:19, Mike Stump wrote: > On Sep 23, 2017, at 10:52 AM, Christophe Lyon > wrote: >> The attached patch would apply after reverting yours. >> I've applied it against r253072 (just before your patch) and the >> results

[PING 4] [PATCH 3/4] enhance overflow and truncation detection in strncpy and strncat (PR 81117)

2017-09-25 Thread Martin Sebor
Ping #4: https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00912.html On 09/19/2017 09:44 AM, Martin Sebor wrote: Ping #3: https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00912.html Thanks Martin On 08/28/2017 08:34 PM, Martin Sebor wrote: Ping #2:

Re: [RFC] propagate malloc attribute in ipa-pure-const pass

2017-09-25 Thread Jan Hubicka
> Hi Honza, > Could you please have a look at this patch ? > https://gcc.gnu.org/ml/gcc-patches/2017-07/msg02063.html I can and I should have done long time ago. I really apologize for slow response and I will try to be more timely from now on. The reason was that I had some patches that I was

[PATCH PR79868 ][aarch64] Fix error calls in aarch64 code so they can be translated (version 2)

2017-09-25 Thread Steve Ellcey
This is a new version of my patch to fix PR target/79868, where some error messages are impossible to translate correctly due to how the strings are dynamically constructed.  It also includes some format changes in the error messags to make the messages more consistent with each other and with

[committed][PATCH] Stack clash protection 06/08 - V5

2017-09-25 Thread Jeff Law
Final committed patch that addresses the minor comments from Segher for the archives. Bootstrapped and regression tested on ppc64le. As with the other patches for stack-clash protection, I'll be here to deal with any fallout, particularly on other ppc platforms such as AIX. Addressing

[PATCH v2,rs6000] Replace swap of a loaded vector constant with load of a swapped vector constant

2017-09-25 Thread Kelvin Nilsen
On Power8 little endian, two instructions are needed to load from the natural in-memory representation of a vector into a vector register: a load followed by a swap. When the vector value to be loaded is a constant, more efficient code can be achieved by swapping the representation of the

RE: 0002-Part-2.-Document-finstrument-control-flow-and-notrack attribute

2017-09-25 Thread Tsimbalist, Igor V
> -Original Message- > From: Sandra Loosemore [mailto:san...@codesourcery.com] > Sent: Monday, September 25, 2017 5:07 AM > To: Tsimbalist, Igor V ; 'gcc- > patc...@gcc.gnu.org' > Cc: Jeff Law > Subject: Re:

Re: [Patch, Fortran] PR 82143: add a -fdefault-real-16 flag

2017-09-25 Thread Steve Kargl
On Mon, Sep 25, 2017 at 11:14:42PM +0200, Janus Weil wrote: > 2017-09-25 17:07 GMT+02:00 David Edelsohn : > > promotion_3.f90 and promotion_4.f90 are failing on at least PowerPC > > and AArch64. Are these new tests limited to x86 or some long double > > assumptions? > > These

Re: [Patch, Fortran] PR 82143: add a -fdefault-real-16 flag

2017-09-25 Thread Janus Weil
2017-09-25 17:07 GMT+02:00 David Edelsohn : > promotion_3.f90 and promotion_4.f90 are failing on at least PowerPC > and AArch64. Are these new tests limited to x86 or some long double > assumptions? These tests require the availability of a 10- or 16-byte-wide REAL type,

Re: [GCC][PATCH][TESTSUITE][ARM][COMMITTED] Invert check to misalign in vect_hw_misalign (PR 78421)

2017-09-25 Thread Mike Stump
On Sep 23, 2017, at 10:52 AM, Christophe Lyon wrote: > The attached patch would apply after reverting yours. > I've applied it against r253072 (just before your patch) and the > results are visible at: >

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Jeff Law
On 09/25/2017 11:25 AM, Segher Boessenkool wrote: > On Mon, Sep 25, 2017 at 10:00:55AM -0600, Jeff Law wrote: >> On 09/25/2017 04:52 AM, Segher Boessenkool wrote: >>> Did you also test Ada? It needs testing. I wanted to try it myself, >>> but your patch doesn't apply (you included the changelog

Re: [RFC] propagate malloc attribute in ipa-pure-const pass

2017-09-25 Thread Prathamesh Kulkarni
On 15 September 2017 at 17:49, Prathamesh Kulkarni wrote: > On 1 September 2017 at 08:09, Prathamesh Kulkarni > wrote: >> On 17 August 2017 at 18:02, Prathamesh Kulkarni >> wrote: >>> On 8 August

Re: [PING][patch] PR81794: have "would be stringified in traditional C" warning in libcpp/macro.c be controlled by -Wtraditional

2017-09-25 Thread Eric Gallager
Ping: https://gcc.gnu.org/ml/gcc-patches/2017-09/msg01107.html cc-ing additional libcpp (i.e. preprocessor) maintainers and diagnostic messages maintainers On Sun, Sep 17, 2017 at 8:00 PM, Eric Gallager wrote: > Attached is a version of >

Re: [PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-09-25 Thread Steve Ellcey
Ping. Steve Ellcey sell...@cavium.com On Fri, 2017-09-15 at 11:22 -0700, Steve Ellcey wrote: > PR 81356 points out that doing a __builtin_strcpy of an empty string on > aarch64 does a copy from memory instead of just writing out a zero byte. > In looking at this I found that it was because of >

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Segher Boessenkool
On Mon, Sep 25, 2017 at 10:00:55AM -0600, Jeff Law wrote: > On 09/25/2017 04:52 AM, Segher Boessenkool wrote: > > Did you also test Ada? It needs testing. I wanted to try it myself, > > but your patch doesn't apply (you included the changelog bits in the > > patch), and I cannot easily manually

Re: Transform (x / y) != 0 to x >=y and (x / y) == 0 to x < y if x, y are unsigned

2017-09-25 Thread Prathamesh Kulkarni
On 18 September 2017 at 15:40, Prathamesh Kulkarni wrote: > On 15 September 2017 at 22:09, Marc Glisse wrote: >> On Fri, 15 Sep 2017, Wilco Dijkstra wrote: >> >>> Marc Glisse wrote: >>> The question is whether, having computed c=a/b, it

Re: [libgfortran] Replace implicit conversions between enums in io/transfer.c by explicit casts.

2017-09-25 Thread Prathamesh Kulkarni
On 12 September 2017 at 17:08, Prathamesh Kulkarni wrote: > Hi, > I am working on patch for PR78736 > (https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00011.html), > which adds a new warning -Wenum-conversion to C front-end to warn for > implicit conversion between

Re: [PATCH PR82163/V2]New interface checking LCSSA for single loop

2017-09-25 Thread Bin.Cheng
On Sat, Sep 23, 2017 at 6:31 PM, Bernhard Reutner-Fischer wrote: > On Fri, Sep 22, 2017 at 11:37:53AM +, Bin Cheng wrote: > >> diff --git a/gcc/tree-ssa-loop-manip.c b/gcc/tree-ssa-loop-manip.c >> index d6ba305..6ad0b75 100644 >> --- a/gcc/tree-ssa-loop-manip.c >> +++

Re: [patch, fortran] Warn about out-of-bounds access with DO subscripts

2017-09-25 Thread Thomas Koenig
Hi Jerry, Yes OK, Thanks for the review, committed as r253156. Now, on to some other bugs... Regards Thomas

Re: [PATCH] Fix PR80295[aarch64] [7/8 Regression] ICE in __builtin_update_setjmp_buf expander

2017-09-25 Thread Qing Zhao
Hi, Andreas, thanks for the comment. > GNU style is line break before the operator, not after. updated per your comment. Qing. --- gcc/config/aarch64/aarch64.c | 12 +--- gcc/config/aarch64/aarch64.h | 2 +- gcc/config/aarch64/aarch64.md |

[PING][PATCH] Fix bug in simplify_ternary_operation

2017-09-25 Thread Tom de Vries
On 09/01/2017 10:51 AM, Tom de Vries wrote: On 08/31/2017 11:44 PM, Jeff Law wrote: On 08/28/2017 12:26 PM, Tom de Vries wrote: Hi, I think I found a bug in r17465: ...     * cse.c (simplify_ternary_operation): Handle more IF_THEN_ELSE     simplifications. diff --git a/gcc/cse.c

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Jeff Law
On 09/25/2017 08:14 AM, Segher Boessenkool wrote: > On Mon, Sep 25, 2017 at 07:41:18AM -0500, Segher Boessenkool wrote: >> On Mon, Sep 25, 2017 at 05:52:27AM -0500, Segher Boessenkool wrote: >>> Bootstrap+testsuite finished on BE, but I forgot to enable stack-clash >>> protection by default,

Re: [PATCH] Fix PR80295[aarch64] [7/8 Regression] ICE in __builtin_update_setjmp_buf expander

2017-09-25 Thread Andreas Schwab
On Sep 25 2017, Qing Zhao wrote: > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index 6c3ef76..876e9e3 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c > @@ -3693,7 +3693,9 @@ aarch64_expand_prologue (void) >

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Jeff Law
On 09/25/2017 04:52 AM, Segher Boessenkool wrote: > >> I also flipped things so that clash protection is enabled by default and >> re-ran the tests. The idea being to see if I could exercise the path >> that uses SP_ADJUST a bit more. But that gave me the same results. >> While I think the

[PATCH] Fix PR80295[aarch64] [7/8 Regression] ICE in __builtin_update_setjmp_buf expander

2017-09-25 Thread Qing Zhao
Hi, This patch fixes the aarch64 bug 80295 https://gcc.gnu.org/PR80295 The aarch64 backend has multiple places that miss the handling of TARGET_ILP32. in the patch, we added correct handling of TARGET_ILP32 into aarch64 backend. a new small testing case is added. bootstrapped and tested on

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Jeff Law
On 09/25/2017 06:41 AM, Segher Boessenkool wrote: > On Mon, Sep 25, 2017 at 05:52:27AM -0500, Segher Boessenkool wrote: >> Bootstrap+testsuite finished on BE, but I forgot to enable stack-clash >> protection by default, whoops. Will have results later today (also LE). > > Some new failures show

Re: [PATCH] haifa-sched: fix autopref_rank_for_schedule qsort comparator

2017-09-25 Thread Maxim Kuvyrkov
> On Sep 22, 2017, at 4:18 AM, Alexander Monakov wrote: > > On Tue, 19 Sep 2017, Alexander Monakov wrote: >> * haifa-sched.c (autopref_rank_for_schedule): Order 'irrelevant' insns >> first, always call autopref_rank_data otherwise. > > May I apply this patch now to

Re: [Patch, Fortran] PR 82143: add a -fdefault-real-16 flag

2017-09-25 Thread David Edelsohn
promotion_3.f90 and promotion_4.f90 are failing on at least PowerPC and AArch64. Are these new tests limited to x86 or some long double assumptions? f951: Fatal Error: REAL(KIND=16) is not available for '-fdefault-real-16' option compilation terminated. f951: Fatal Error: REAL(KIND=10) is not

[PATCH] Pretty-print GOACC_REDUCTION arguments

2017-09-25 Thread Tom de Vries
Hi, currently for a GOACC_REDUCTION internal fn call we print: ... sum_5 = GOACC_REDUCTION (SETUP, _3, 0, 0, 67, 0); ... This patch adds a comment for some arguments explaining the meaning of the argument: ... sum_5 = GOACC_REDUCTION (SETUP, _3, 0, 0 /*gang*/, 67 /*+*/, 0); ... OK

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Segher Boessenkool
On Mon, Sep 25, 2017 at 07:41:18AM -0500, Segher Boessenkool wrote: > On Mon, Sep 25, 2017 at 05:52:27AM -0500, Segher Boessenkool wrote: > > Bootstrap+testsuite finished on BE, but I forgot to enable stack-clash > > protection by default, whoops. Will have results later today (also LE). > >

Re: [PATCH] libstdc++: istreambuf_iterator keep attached streambuf

2017-09-25 Thread Jonathan Wakely
On 23/09/17 09:54 +0300, Petr Ovtchenkov wrote: istreambuf_iterator should not forget about attached streambuf when it reach EOF. Checks in debug mode has no infuence more on character extraction in istreambuf_iterator increment operators. In this aspect behaviour in debug and non-debug mode is

Re: [PATCH, libstdc++]: Fix another instance of -Werror=attributes bootststrap failure

2017-09-25 Thread Jonathan Wakely
On 25/09/17 11:11 +0200, Uros Bizjak wrote: Hello! Attached patch fixes -Werror=attributes bootstrap failure on alphaev68-linux-gnu. The patch declares the alias without a prototype, as suggested in [1]. 2017-09-25 Uros Bizjak PR c/81854 * src/c++98/complex_io.cc

Re: [PATCH] tree-sra: fix compare_access_positions qsort comparator

2017-09-25 Thread Alexander Monakov
On Mon, 25 Sep 2017, Martin Jambor wrote: > --- a/gcc/tree-sra.c > +++ b/gcc/tree-sra.c > @@ -1542,19 +1542,20 @@ compare_access_positions (const void *a, const void > *b) > && TREE_CODE (f2->type) != COMPLEX_TYPE > && TREE_CODE (f2->type) != VECTOR_TYPE) > return

[PATCH] Add helper to sort sibling loops, do so in GRAPHITE

2017-09-25 Thread Richard Biener
The following adds a helper to sort the sibling loop list in RPO order as it can get messed up (we only ever add loops at the start of the list). GRAPHITE SCOP detection assumes this list is sorted naturally in RPO order (as a flow_loops_find would generate). Turns out it helps a few more loops

Re: [PATCH][GRAPHITE] More TLC

2017-09-25 Thread Richard Biener
On Fri, 22 Sep 2017, Sebastian Pop wrote: > On Fri, Sep 22, 2017 at 8:03 AM, Richard Biener wrote: > > > > > This simplifies canonicalize_loop_closed_ssa and does other minimal > > TLC. It also adds a testcase I reduced from a stupid mistake I made > > when reworking

Re: [PATCH][GRAPHITE] More TLC

2017-09-25 Thread Richard Biener
On Mon, 25 Sep 2017, Bin.Cheng wrote: > On Mon, Sep 25, 2017 at 1:46 PM, Richard Biener wrote: > > On Mon, 25 Sep 2017, Richard Biener wrote: > > > >> On Fri, 22 Sep 2017, Richard Biener wrote: > >> > >> > > >> > This simplifies canonicalize_loop_closed_ssa and does other

RE: Enable no-exec stacks for more targets using the Linux kernel

2017-09-25 Thread Nagaraju Mekala
> -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Nagaraju Mekala > Sent: Thursday, September 21, 2017 2:56 PM > To: Joseph Myers > Cc: sch...@suse.de; gcc-patches@gcc.gnu.org; l...@redhat.com; >

Re: [PATCH][GRAPHITE] More TLC

2017-09-25 Thread Bin.Cheng
On Mon, Sep 25, 2017 at 1:46 PM, Richard Biener wrote: > On Mon, 25 Sep 2017, Richard Biener wrote: > >> On Fri, 22 Sep 2017, Richard Biener wrote: >> >> > >> > This simplifies canonicalize_loop_closed_ssa and does other minimal >> > TLC. It also adds a testcase I reduced from

Re: Don't query the frontend for unsupported types

2017-09-25 Thread Richard Biener
On Fri, Sep 22, 2017 at 6:42 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Thu, Sep 21, 2017 at 2:56 PM, Richard Sandiford >> wrote: >>> Richard Biener writes:

Re: [GCC][PATCH][TESTSUITE][ARM][COMMITTED] Invert check to misalign in vect_hw_misalign (PR 78421)

2017-09-25 Thread Christophe Lyon
On 25 September 2017 at 11:36, Tamar Christina wrote: > > >> -Original Message- >> From: Christophe Lyon [mailto:christophe.l...@linaro.org] >> Sent: 23 September 2017 18:52 >> To: Tamar Christina >> Cc: gcc-patches@gcc.gnu.org; nd; Ramana Radhakrishnan; Richard

Re: [Ada] Improve performance of 'Image with enumeration types.

2017-09-25 Thread Duncan Sands
Hi, On 09/25/2017 10:54 AM, Pierre-Marie de Rodat wrote: This patch improves the performance of the code generated by the compiler for attribute Image when applied to user-defined enumeration types and the sources are compiled with optimizations enabled. it looks like this is in essence

Re: [PATCH][GRAPHITE] More TLC

2017-09-25 Thread Richard Biener
On Mon, 25 Sep 2017, Richard Biener wrote: > On Fri, 22 Sep 2017, Richard Biener wrote: > > > > > This simplifies canonicalize_loop_closed_ssa and does other minimal > > TLC. It also adds a testcase I reduced from a stupid mistake I made > > when reworking canonicalize_loop_closed_ssa. > > >

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Segher Boessenkool
On Mon, Sep 25, 2017 at 05:52:27AM -0500, Segher Boessenkool wrote: > Bootstrap+testsuite finished on BE, but I forgot to enable stack-clash > protection by default, whoops. Will have results later today (also LE). Some new failures show up: +FAIL: c-c++-common/ubsan/vla-1.c -O0 execution

Re: [Ada] Use the Monotonic Clock on Linux

2017-09-25 Thread Duncan Sands
Hi, On 09/25/2017 10:47 AM, Pierre-Marie de Rodat wrote: The monotonic clock epoch is set to some undetermined time in the past (typically system boot time). In order to use the monotonic clock for absolute time, the offset from a known epoch is calculated and incorporated into timed delay and

Re: [PATCH] tree-sra: fix compare_access_positions qsort comparator

2017-09-25 Thread Martin Jambor
On Thu, Sep 21, 2017 at 08:27:31PM +0300, Alexander Monakov wrote: > Hi, > > The compare_access_positions qsort comparator lacks transitivity, although > somewhat surprisingly this issue didn't manifest on 64-bit x86 bootstraps. > The first invalid comparison step is here (tree-sra.c:1545): > >

Re: [PATCH] [PR82155] Fix crash in dwarf2out_abstract_function

2017-09-25 Thread Pierre-Marie de Rodat
On 09/25/2017 01:54 PM, Richard Biener wrote: Ok for trunk and gcc-7 branch after a while. Thank you, Richard! Committed on trunk as 253147; I’ll wait at least one week to revisit the gcc-7 branch commit. -- Pierre-Marie de Rodat

Re: Add VEC_DUPLICATE_{CST,EXPR} and associated optab

2017-09-25 Thread Richard Sandiford
Richard Biener writes: > On Mon, Sep 25, 2017 at 1:08 PM, Richard Sandiford > wrote: >> SVE needs a way of broadcasting a scalar to a variable-length vector. >> This patch adds VEC_DUPLICATE_CST for when VECTOR_CST would be used for >>

Re: [PATCH] [PR82155] Fix crash in dwarf2out_abstract_function

2017-09-25 Thread Richard Biener
On Tue, Sep 12, 2017 at 8:00 AM, Pierre-Marie de Rodat wrote: > Hello, > > This patch is an attempt to fix the crash reported in PR82155. > > When generating a C++ class method for a class that is itself nested in > a class method, dwarf2out_early_global_decl currently leaves

Re: Update interface to TARGET_VECTORIZE_VEC_PERM_CONST_OK

2017-09-25 Thread Richard Biener
On Fri, Sep 22, 2017 at 6:34 PM, Richard Sandiford wrote: > This patch makes TARGET_VECTORIZE_VEC_PERM_CONST_OK take the permute > vector in the form of a vec_perm_indices instead of an unsigned char *. > It follows on from the recent patch that did the same in

Re: Change permute index type to unsigned short

2017-09-25 Thread Richard Biener
On Fri, Sep 22, 2017 at 6:36 PM, Richard Sandiford wrote: > This patch changes the element type of (auto_)vec_perm_indices from > unsigned char to unsigned short. This is needed for fixed-length > 2048-bit SVE. (SVE is variable-length by default, but it's possible

Re: Add VEC_DUPLICATE_{CST,EXPR} and associated optab

2017-09-25 Thread Richard Biener
On Mon, Sep 25, 2017 at 1:08 PM, Richard Sandiford wrote: > SVE needs a way of broadcasting a scalar to a variable-length vector. > This patch adds VEC_DUPLICATE_CST for when VECTOR_CST would be used for > fixed-length vectors and VEC_DUPLICATE_EXPR for when

[PATCH] Fix PR82285

2017-09-25 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2017-09-25 Richard Biener PR tree-optimization/82285 * tree-vect-patterns.c (vect_recog_bool_pattern): Also handle enumeral types. * gcc.dg/torture/pr82285.c:

Add VEC_DUPLICATE_{CST,EXPR} and associated optab

2017-09-25 Thread Richard Sandiford
SVE needs a way of broadcasting a scalar to a variable-length vector. This patch adds VEC_DUPLICATE_CST for when VECTOR_CST would be used for fixed-length vectors and VEC_DUPLICATE_EXPR for when CONSTRUCTOR would be used for fixed-length vectors. VEC_DUPLICATE_EXPR is the tree equivalent of the

[nvptx, committed] Add exit after call to noreturn function

2017-09-25 Thread Tom de Vries
Hi, atm for the nvptx target we're emitting a trap after a noreturn function to indicate the control flow barrier to ptxas: ... call exit, (%out_arg1); trap; // (noreturn) ... However, after reporting a bug to nvidia (

Re: [RFA][PATCH] Stack clash protection 06/08 - V4

2017-09-25 Thread Segher Boessenkool
Hi Jeff, On Fri, Sep 22, 2017 at 11:49:04AM -0600, Jeff Law wrote: > The go test suite has been run with and without this patch. I've found > os/signal seems to flip between pass and fail without rhyme or reason. > It may be related to system load. TestCgoCallbackGC now passes for > reasons

Re: [PATCH][AArch64] Add BIC-imm and ORR-imm SIMD pattern

2017-09-25 Thread Sudi Das
Hi James I put aarch64_output_simd_general_immediate looking at the similarities of the immediates for mov/mvni and orr/bic. The CHECK macro in aarch64_simd_valid_immediate both checks and converts the immediates in a manner that are needed for the instructions. Having said that, I agree that

[Ada] Crash on an aspect specification with parameter associations

2017-09-25 Thread Pierre-Marie de Rodat
This patch fixes a compiler abort in ASIS mode on an aspect specification whose expression is a function call with parameter associations. The following must compile quietly: gcc -c -gnatct p.adb --- with System; procedure P is type T is new Integer; package Obj is Buf : T := 1234;

Re: [patch] Fix wrong code with small structure return on PowerPC

2017-09-25 Thread Richard Biener
On Mon, Sep 25, 2017 at 11:35 AM, Eric Botcazou wrote: >> ISTR SUBREG_PROMOTED_* gets set by RTL expansion, the problematic >> one should be the one in expr.c setting it on all SSA_NAMEs, maybe it is >> enough to avoid setting it for SSA_NAME_IS_DEFAULT_DEF ones? > > No,

[Ada] Handle errors and limit simultaneous wait objects number in win32_wait

2017-09-25 Thread Pierre-Marie de Rodat
Everything is in the subject. Tested on x86_64-pc-linux-gnu, committed on trunk 2017-09-25 Vasiliy Fofanov * adaint.c (win32_wait): Properly handle error and take into account the WIN32 limitation on the number of simultaneous wait objects. Index:

[Ada] Do not insert calls to invariant procedure in GNATprove mode

2017-09-25 Thread Pierre-Marie de Rodat
GNATprove handles specially invariant checks, and so does not expect to see calls to invariant procedures in the AST. This patch fixes the two places where such calls were inserted during semantic analysis, so that calls are only inserted when not in GNATprove mode. Possibly the same could be done

[Ada] Insert explicit dereference in GNATprove mode for pointer analysis

2017-09-25 Thread Pierre-Marie de Rodat
Safe pointer analysis in GNATprove mode depends on explicit dereferences being present in the tree. Insert them where needed on access to components in the special expansion performed in GNATprove mode. The following code is now analysed without errors in GNATprove mode (with -gnatd.F) with the

[PATCH][GRAPHITE] More -fopt-info, do not abort from ISL

2017-09-25 Thread Richard Biener
The following also dumps if the optimized schedule is equal to the original one. It also makes all ISL operations (well, nearly) not abort on errors but instead propagate errors upward. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2017-09-25 Richard Biener

RE: [GCC][PATCH][TESTSUITE][ARM][COMMITTED] Invert check to misalign in vect_hw_misalign (PR 78421)

2017-09-25 Thread Tamar Christina
> -Original Message- > From: Christophe Lyon [mailto:christophe.l...@linaro.org] > Sent: 23 September 2017 18:52 > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd; Ramana Radhakrishnan; Richard Earnshaw; > ni...@redhat.com; Kyrylo Tkachov > Subject: Re:

Re: [patch] Fix wrong code with small structure return on PowerPC

2017-09-25 Thread Eric Botcazou
> ISTR SUBREG_PROMOTED_* gets set by RTL expansion, the problematic > one should be the one in expr.c setting it on all SSA_NAMEs, maybe it is > enough to avoid setting it for SSA_NAME_IS_DEFAULT_DEF ones? No, it's not enough in this case, you need to work a little harder and look at the

[Ada] Crash on classwide precondition for interface operation

2017-09-25 Thread Pierre-Marie de Rodat
This patch fixes a crash on a classwide precondition on an interface primitive with an controlling access parameter, when the precondition is a call that contains a reference to that formal. The following must execute quietly: gnatmake -q main main --- with Conditional_Interfaces; with

[Ada] Default to no source locations in non-GCC backend bug boxes

2017-09-25 Thread Pierre-Marie de Rodat
Default to "No source file position information available" message for bug boxes emitted from the non-GCC backends. No test provided, because this only affects bug boxes. Tested on x86_64-pc-linux-gnu, committed on trunk 2017-09-25 Piotr Trojanek * adabkend.adb

[Ada] Crash on instantiation with renamed formal package.

2017-09-25 Thread Pierre-Marie de Rodat
This patch fixes a compiler abort on a package instantiation when the corresponding generic has a formal package, and the instantiation has an actual that renames the desired package instance. The following must compile quietly: gcc -c mc.adb --- package MC is procedure Dump_States; end

[Ada] Use of renamings in pragmas

2017-09-25 Thread Pierre-Marie de Rodat
This patch suppresses the transformation of references to renamings into references to renamed names when the reference appears within a pragma of no significance to SPARK. -- Source -- -- uname.adb procedure Uname is type Bounded_String is record Length :

[Ada] Minor clean up of contract freezing

2017-09-25 Thread Pierre-Marie de Rodat
This patch updates the analysis of Refined_State triggered by contract freezing to raise a more suitable exception when compilation has to be halted. -- Source -- -- pack.ads package Pack with Abstract_State => State is function F return Boolean with Global =>

[Ada] Proper qualification of concurrent discriminants

2017-09-25 Thread Pierre-Marie de Rodat
This patch modifies resolution to perform minor expansion for SPARK in order to properly qualify concurrent discriminants used as defaulted actuals in calls. -- Source -- -- p.ads package P is protected type PT (D : Integer) is procedure Dummy (Arg : Integer

Re: [PATCH] tree-sra: fix compare_access_positions qsort comparator

2017-09-25 Thread Alexander Monakov
On Thu, 21 Sep 2017, Richard Sandiford wrote: > LGTM FWIW, but isn't there also the problem that the TYPE_PRECISION > test fails to stabilise the sort if you have two integral types with > the same precision? Yes, but that's a pre-existing issue, so I didn't change it in the patch. I think GCC

[PATCH, libstdc++]: Fix another instance of -Werror=attributes bootststrap failure

2017-09-25 Thread Uros Bizjak
Hello! Attached patch fixes -Werror=attributes bootstrap failure on alphaev68-linux-gnu. The patch declares the alias without a prototype, as suggested in [1]. 2017-09-25 Uros Bizjak PR c/81854 * src/c++98/complex_io.cc (_GLIBCXX_LDBL_COMPAT): Declare alias

[Ada] Entry family selector not recognised as entity usage

2017-09-25 Thread Pierre-Marie de Rodat
This patch corrects an issue whereby index actuals in calls to entry families were not being properly flagged as referenced leading to spurious warnings when compiling with -gnatwu. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ 2017-09-25 Justin Squirek

[Ada] Spurious visibility error in ASIS mode

2017-09-25 Thread Pierre-Marie de Rodat
In ASIS mode we resolve the expressions in aspect specifications to provide sufficient semantic information, including entities and types of identifiers. The tree traversal that performs this resolution must omit identifiers that are selector names of parameter associations in calls, because these

[Ada] Remove duplicated Has_Null_Abstract_State routines

2017-09-25 Thread Pierre-Marie de Rodat
Cleanup only; semantics unaffected. Tested on x86_64-pc-linux-gnu, committed on trunk 2017-09-25 Piotr Trojanek * sem_util.adb (Has_Null_Abstract_State): Remove, as an exactly same routine is already provided by Einfo. * einfo.adb

[Ada] Improve performance of 'Image with enumeration types.

2017-09-25 Thread Pierre-Marie de Rodat
This patch improves the performance of the code generated by the compiler for attribute Image when applied to user-defined enumeration types and the sources are compiled with optimizations enabled. No test required. Tested on x86_64-pc-linux-gnu, committed on trunk 2017-09-25 Javier Miranda

[Ada] Use the Monotonic Clock on Linux

2017-09-25 Thread Pierre-Marie de Rodat
The monotonic clock epoch is set to some undetermined time in the past (typically system boot time). In order to use the monotonic clock for absolute time, the offset from a known epoch is calculated and incorporated into timed delay and sleep. Tested on x86_64-pc-linux-gnu, committed on trunk

Re: [PATCH][GRAPHITE] More TLC

2017-09-25 Thread Richard Biener
On Fri, 22 Sep 2017, Richard Biener wrote: > > This simplifies canonicalize_loop_closed_ssa and does other minimal > TLC. It also adds a testcase I reduced from a stupid mistake I made > when reworking canonicalize_loop_closed_ssa. > > Bootstrapped and tested on x86_64-unknown-linux-gnu,

[PING#2, Makefile] improve libsubdir variable transmission to sub-makes on Windows

2017-09-25 Thread Olivier Hainque
Hello, Ping #2 for https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00017.html > Makefile.in: > ... > export libsubdir > > This is not working well on cygwin environments where environment > variable names are translated to uppercase (so sub-makes evaluating > the variable with the lowercase

[PING#2, Makefile] improve default cpu selection for e500v2

2017-09-25 Thread Olivier Hainque
Hello, Ping #2 for https://gcc.gnu.org/ml/gcc-patches/2017-08/msg01783.html > config.gcc already has a provision for a good default > cpu selection for SPE with double precision floats > when the latter is explicitly requested with an explicit > --enable command line option. ... > The attached

Re: [PATCH] Fix PR82144

2017-09-25 Thread Richard Biener
On Fri, 22 Sep 2017, Alexandre Oliva wrote: > On Sep 21, 2017, Richard Biener wrote: > > > On Tue, 12 Sep 2017, Richard Biener wrote: > >> > >> The following avoids adding DW_AT_alignment twice by not doing it > >> for incomplete types. > >> > >> Bootstrapped on

[PATCH, fortran, committed] Remove unnecessary fold_convert in gfc_(un)likely

2017-09-25 Thread Janne Blomqvist
This patch removes an unnecessary fold_convert to boolean_type_node at the end of gfc_likely and gfc_unlikely. It makes no difference to the generated code, but makes tree dumps a little bit cleaner. 2017-09-25 Janne Blomqvist * trans.c (gfc_unlikely): Remove