Re: [PATCH] detect nonstring arguments to string functions (PR 82945)

2017-11-16 Thread Jakub Jelinek
On Thu, Nov 16, 2017 at 05:15:20PM -0700, Jeff Law wrote: > > + tree_code code = gimple_assign_rhs_code (def); > > + if (code == ADDR_EXPR > > + || code == COMPONENT_REF > > + || code == VAR_DECL) > > + dcl = gimple_assign_rhs1 (def); > Note that

[RFA][PATCH] patch 7/n Introduce evrp_range_analyzer class

2017-11-16 Thread Jeff Law
This patch introduces the evrp_range_analyzer class. This is the class we're going to be able to embed into existing dominator walkers to provide them with context sensitive range analysis. The bulk of the class is extracted from the evrp_dom_walker class. A few minor notes. Setup of the

Re: Add -std=c18 etc. option aliases

2017-11-16 Thread Jakub Jelinek
On Thu, Nov 16, 2017 at 11:34:07PM +, Joseph Myers wrote: > On Thu, 16 Nov 2017, Mike Stump wrote: > > > date on it. If there was no major release with c17, I would ditch the > > c17 spelling and just change it to c18 now. :-) I know, kinda sucks, > > There is no evidence yet of anyone

Re: [RFA][PATCH] patch 4/n Refactor bits of vrp_visit_assignment_or_call

2017-11-16 Thread Jeff Law
On 11/15/2017 03:45 AM, Kyrill Tkachov wrote: > Hi Jeff, > > I think you attached the wrong patch to this mail... Yup. Totally botched it. Correct version already resent. Oh how I wish for the days where my mail client would show me my own attachments inline :( Though I'd had enough cold

[RFA][PATCH] patch 6/n Refactoring evrp

2017-11-16 Thread Jeff Law
As I've stated several times one of the goals here is to provide a little range analysis module that we can embed & reuse. To accomplish that I need to break down the evrp class. This patch does the bulk of the real work. evrp_dom_walker::before_dom_children is the key function we need to

Re: [PATCH 1/3][middle-end]PR78809 (Inline strcmp with small constant strings)

2017-11-16 Thread Jeff Law
On 11/16/2017 06:53 PM, Qing Zhao wrote: > >> On Nov 16, 2017, at 6:57 PM, Jeff Law > > wrote: >> >> On 11/15/2017 08:00 AM, Qing Zhao wrote: >>> Hi, >>> >>> this is the first patch for PR78809 (totally 3 patches) >>> >>>

[PATCH] Add _Float/_FloatX rounding built-ins & improve gimple optimization of _Float/_FloatX built-in functions

2017-11-16 Thread Michael Meissner
This patch is an enhancement of a previous page that never got approved. https://gcc.gnu.org/ml/gcc-patches/2017-10/threads.html#02124 In the original patch, I added support to the machine independent infrastructure to support the rounding built-in functions for _Float and _FloatX types (i.e.

Re: [PATCH, i386] Enable option -mprefer-avx256 as default for Intel Skylake configuration

2017-11-16 Thread Kirill Yukhin
Hello Sergey, On 02 Nov 10:15, Shalnov, Sergey wrote: > Hi, > This patch makes "prefer-avx256" option as default tuning for > "skylake-avx512". > This is due to better performance of 256-bit code for some of the cases. In > case of > Skylake Server the Optimization Manual has following "Since

[RFA][PATCH] patch 5/n Cleaning up evrp

2017-11-16 Thread Jeff Law
So with the major reorganization bits in place it's time to start cleaning up. This patch is primarily concerned with cleanups to the evrp_dom_walker class. We pull a blob of code from execute_early_vrp into a new member function. That subsequently allows various data members to become private.

[RFA][PATCH] patch 4/n Refactor bits of vrp_visit_assignment_or_call -- correct patch attached this time

2017-11-16 Thread Jeff Law
No nyquil tonight, so the proper patch is attached this time... -- So the next group of changes is focused on breaking down evrp into an analysis engine and the actual optimization pass. The analysis engine can be embedded into other dom walker passes quite easily. I've done it for the

Re: [006/nnn] poly_int: tree constants

2017-11-16 Thread Jeff Law
On 10/23/2017 11:00 AM, Richard Sandiford wrote: > This patch adds a tree representation for poly_ints. Unlike the > rtx version, the coefficients are INTEGER_CSTs rather than plain > integers, so that we can easily access them as poly_widest_ints > and poly_offset_ints. > > The patch also

Re: [005/nnn] poly_int: rtx constants

2017-11-16 Thread Jeff Law
On 10/23/2017 11:00 AM, Richard Sandiford wrote: > This patch adds an rtl representation of poly_int values. > There were three possible ways of doing this: > > (1) Add a new rtl code for the poly_ints themselves and store the > coefficients as trailing wide_ints. This would give constants

Re: [013/nnn] poly_int: same_addr_size_stores_p

2017-11-16 Thread Jeff Law
On 10/23/2017 11:05 AM, Richard Sandiford wrote: > This patch makes tree-ssa-alias.c:same_addr_size_stores_p handle > poly_int sizes and offsets. > > > 2017-10-23 Richard Sandiford > Alan Hayward > David Sherwood

Re: [012/nnn] poly_int: fold_ctor_reference

2017-11-16 Thread Jeff Law
On 10/23/2017 11:04 AM, Richard Sandiford wrote: > This patch changes the offset and size arguments to > fold_ctor_reference from unsigned HOST_WIDE_INT to poly_uint64. > > > 2017-10-23 Richard Sandiford > Alan Hayward >

Re: [010/nnn] poly_int: REG_OFFSET

2017-11-16 Thread Jeff Law
On 10/23/2017 11:04 AM, Richard Sandiford wrote: > This patch changes the type of the reg_attrs offset field > from HOST_WIDE_INT to poly_int64 and updates uses accordingly. > This includes changing reg_attr_hasher::hash to use inchash. > (Doing this has no effect on code generation since the only

Re: [009/nnn] poly_int: TRULY_NOOP_TRUNCATION

2017-11-16 Thread Jeff Law
On 10/23/2017 11:03 AM, Richard Sandiford wrote: > This patch makes TRULY_NOOP_TRUNCATION take the mode sizes as > poly_uint64s instead of unsigned ints. The function bodies > don't need to change. > > > 2017-10-23 Richard Sandiford > Alan Hayward

Re: [008/nnn] poly_int: create_integer_operand

2017-11-16 Thread Jeff Law
On 10/23/2017 11:02 AM, Richard Sandiford wrote: > This patch generalises create_integer_operand so that it accepts > poly_int64s rather than HOST_WIDE_INTs. > > > 2017-10-23 Richard Sandiford > Alan Hayward > David

Re: [007/nnn] poly_int: dump routines

2017-11-16 Thread Jeff Law
On 10/23/2017 11:02 AM, Richard Sandiford wrote: > Add poly_int routines for the dumpfile.h and pretty-print.h frameworks. > > > 2017-10-23 Richard Sandiford > Alan Hayward > David Sherwood >

Re: [004/nnn] poly_int: mode query functions

2017-11-16 Thread Jeff Law
On 10/23/2017 10:59 AM, Richard Sandiford wrote: > This patch changes the bit size and vector count arguments to the > machmode.h functions from unsigned int to poly_uint64. > > > 2017-10-23 Richard Sandiford > Alan Hayward >

Re: [003/nnn] poly_int: MACRO_MODE

2017-11-16 Thread Jeff Law
On 10/23/2017 10:59 AM, Richard Sandiford wrote: > This patch uses a MACRO_MODE wrapper for the target macro invocations > in targhooks.c and address.h, so that macros for non-AArch64 targets > can continue to treat modes as fixed-size. > > It didn't seem worth converting the address macros to

Re: [002/nnn] poly_int: IN_TARGET_CODE

2017-11-16 Thread Jeff Law
On 10/23/2017 10:58 AM, Richard Sandiford wrote: > This patch makes each target-specific TU define an IN_TARGET_CODE macro, > which is used to decide whether poly_int<1, C> should convert to C. > > > 2017-10-23 Richard Sandiford > Alan Hayward

Re: [PATCH 1/3][middle-end]PR78809 (Inline strcmp with small constant strings)

2017-11-16 Thread Qing Zhao
> On Nov 16, 2017, at 6:57 PM, Jeff Law wrote: > > On 11/15/2017 08:00 AM, Qing Zhao wrote: >> Hi, >> >> this is the first patch for PR78809 (totally 3 patches) >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78809 >> inline strcmp with small constant strings >> >> The

Re: [001/nnn] poly_int: add poly-int.h

2017-11-16 Thread Jeff Law
On 11/13/2017 04:36 PM, Richard Sandiford wrote: > Jeff Law writes: >> On 11/09/2017 04:06 AM, Richard Sandiford wrote: >> Let me say at the outset that I struggle to comprehend that a few instructions is even a consideration when not optimizing, especially in

Re: [PATCH] gdbinit.in: add "break-on-diagnostic" command

2017-11-16 Thread Jeff Law
On 11/16/2017 12:08 PM, David Malcolm wrote: > It's useful to be able to put a breakpoint on the *emission* of > a diagnostic (without having to step past all of the warnings > that are suppressed because of command-line options). > > The invocation: > > (gdb) break diagnostic_show_locus > >

Re: [PATCH 1/3][middle-end]PR78809 (Inline strcmp with small constant strings)

2017-11-16 Thread Jeff Law
On 11/15/2017 08:00 AM, Qing Zhao wrote: > Hi, > > this is the first patch for PR78809 (totally 3 patches) > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78809 > inline strcmp with small constant strings > > The design doc is at: > https://www.mail-archive.com/gcc@gcc.gnu.org/msg83822.html >

Re: [PATCH] C/C++: more stdlib header hints (PR c/81404) (v5)

2017-11-16 Thread Joseph Myers
On Fri, 3 Nov 2017, David Malcolm wrote: > This currently just works by scanning a hardcoded array of known > name/header associations, but perhaps in the future could be turned > into some kind of symbol database so that the compiler could record API > uses and use that to offer suggestions e.g.

Re: [PATCH] Fix UBSAN errors in dse.c (PR rtl-optimization/82044).

2017-11-16 Thread Jeff Law
On 11/15/2017 12:31 AM, Martin Liška wrote: > On 11/08/2017 05:31 PM, Jeff Law wrote: >> I don't see an updated patch in this thread? THe last message I see is >> this one where you indicate you're going to tweak the patch and re-test. >> >> Jeff > Yes, I tweaked and tested following patch. > >

Re: [PATCH] Fix __VA_OPT__ testsuite fallout

2017-11-16 Thread Jeff Law
On 11/14/2017 01:30 AM, Jakub Jelinek wrote: > Hi! > > On Sun, Nov 12, 2017 at 12:33:03AM -0700, Tom Tromey wrote: >>if (argc < macro->paramc) >> { >> - /* As an extension, variadic arguments are allowed to not appear in >> + /* In C++2a (here the va_opt flag is used), and also

Re: [PATCH] detect nonstring arguments to string functions (PR 82945)

2017-11-16 Thread Jeff Law
On 11/13/2017 06:21 PM, Martin Sebor wrote: > Attached is an improved version that rather than hardcoding > the built-in functions to check uses the constness of each > built-in's char* argument as a trigger to do the checking. > > This avoids the problem of the list being incomplete either > by 

Re: [PATCH 21/22] Add extra field to gtm_jmpbuf on x86 only

2017-11-16 Thread Jeff Law
On 11/13/2017 06:53 AM, Tsimbalist, Igor V wrote: >> -Original Message- >> From: H.J. Lu [mailto:hjl.to...@gmail.com] >> Sent: Thursday, November 9, 2017 2:37 PM >> To: Tsimbalist, Igor V >> Cc: Jeff Law ; gcc-patches@gcc.gnu.org; >>

Re: Add -std=c18 etc. option aliases

2017-11-16 Thread Joseph Myers
On Thu, 16 Nov 2017, Mike Stump wrote: > date on it. If there was no major release with c17, I would ditch the > c17 spelling and just change it to c18 now. :-) I know, kinda sucks, There is no evidence yet of anyone using the C18 name. So far, it's consistently being referred to as C17

RE: [patch] remove cilk-plus

2017-11-16 Thread Joseph Myers
There are places in the c-parser.c changes where there is a comment referring to array notation and you remove the subsequent Cilk-specific code, but not the comment. In at least one such place, the contents of the "else" block that's made unconditional also need to be reindented. -- Joseph

Re: Add -std=c18 etc. option aliases

2017-11-16 Thread Mike Stump
On Nov 16, 2017, at 2:24 PM, Joseph Myers wrote: > > ISO C17 won't go to ballot until December, meaning publication of the > standard won't be until 2018, leaving ambiguity as to whether people > will end up referring to the standard as C17, as it's currently known > and

Re: [PATCH] Disable -ftrapping-math by default

2017-11-16 Thread Marc Glisse
On Thu, 16 Nov 2017, Richard Biener wrote: On Thu, Nov 16, 2017 at 3:33 PM, Wilco Dijkstra wrote: GCC currently defaults to -ftrapping-math. This is supposed to generate code for correct user-visible traps and FP status flags. However it doesn't work as expected

Re: [PATCH] Disable -ftrapping-math by default

2017-11-16 Thread Joseph Myers
I'd expect (considering the whole GNU toolchain, not just GCC in isolation) this to require a corresponding glibc change to build with -ftrapping-math (added alongside the use of -frounding-math - adding the option is of course save independently of the GCC change). Also, GCC tests involving

Add -std=c18 etc. option aliases

2017-11-16 Thread Joseph Myers
ISO C17 won't go to ballot until December, meaning publication of the standard won't be until 2018, leaving ambiguity as to whether people will end up referring to the standard as C17, as it's currently known and which corresponds to the __STDC_VERSION__ value, or C18 based on the publication

Re: Make istreambuf_iterator::_M_sbuf immutable and add debug checks

2017-11-16 Thread François Dumont
On 16/11/2017 19:12, Petr Ovtchenkov wrote: On Thu, 16 Nov 2017 18:40:08 +0100 François Dumont wrote: On 16/11/2017 12:46, Jonathan Wakely wrote: Let me be more clear: I'm not going to review further patches in this area while you two are proposing different

C++ PATCH for c++/79092, auto template args of different type and same value

2017-11-16 Thread Jason Merrill
For an auto template parameter, the type of the argument matters, so we can't treat 0 and 0u as equivalent. But if we adjust cp_tree_equal to consider the type of a constant, we need to be more careful about actually converting template arguments to the type of the (non-auto) parameter, so that

Re: std::advance istreambuf_iterator overload

2017-11-16 Thread Tim Song
On Mon, Nov 13, 2017 at 3:32 PM, Daniel Krügler wrote: > but as Jonathan already said, for std::istreambuf_iterator this can > never be true (because of the involved IO operations). > Except, of course, if you advance by zero. It's not a very useful case, for sure...

Re: [PATCH, AArch64] Adjust tuning parameters for Falkor

2017-11-16 Thread Luis Machado
On 15 November 2017 at 01:00, Luis Machado wrote: > > I think the best thing is to leave this tuning structure in place and > > just change default_opt_level to -1 to disable it at -O3. > > > > Thanks, > > Andrew > > > > Indeed that seems to be more appropriate if

Re: Hurd port for gcc-7 go PATCH 1-3(15)

2017-11-16 Thread Svante Signell
On Thu, 2017-11-16 at 14:12 +0100, Svante Signell wrote: > On Wed, 2017-11-15 at 21:54 +0100, Svante Signell wrote: > > > > Attached is an updated patch for gcc-7. An updated patch for gcc-8 will follow > shortly when I have build tested gcc-8 go on both Linux and Hurd. > > The patch for

Re: [PATCH 7/7]: Enable clobber high for tls descs on Aarch64

2017-11-16 Thread Andrew Pinski
On Thu, Nov 16, 2017 at 4:35 AM, Alan Hayward wrote: > This final patch adds the clobber high expressions to tls_desc for aarch64. > It also adds three tests. > > In addition I also tested by taking the gcc torture test suite and making > all global variables __thread. Then

Re: Adjust empty class parameter passing ABI (PR c++/60336)

2017-11-16 Thread Jason Merrill
On Thu, Nov 16, 2017 at 12:41 PM, Marek Polacek wrote: > On Tue, Nov 14, 2017 at 07:34:54AM +0100, Richard Biener wrote: >> On November 14, 2017 6:21:41 AM GMT+01:00, Jason Merrill >> wrote: >> >On Mon, Nov 13, 2017 at 1:02 PM, Marek Polacek

Re: [PATCH 08/22] Add Intel CET support for EH in libgcc.

2017-11-16 Thread Jeff Law
On 11/13/2017 02:44 PM, Tsimbalist, Igor V wrote: > New patch is attached. The difference is that all newly introduced macro > are removed except of _Unwind_Frames_Extra macro. They are replaced > with new parameters and local variables. > > Igor > > >

[PATCH] gdbinit.in: add "break-on-diagnostic" command

2017-11-16 Thread David Malcolm
It's useful to be able to put a breakpoint on the *emission* of a diagnostic (without having to step past all of the warnings that are suppressed because of command-line options). The invocation: (gdb) break diagnostic_show_locus has been my approach for this for a while (it even works in the

Re: [PATCH 14/22] Enable building libsanitizer with Intel CET

2017-11-16 Thread Jeff Law
On 11/08/2017 04:22 PM, Tsimbalist, Igor V wrote: > The revised patch is attached. The differences are in what options are > defined and propagated to Makefiles for CET enabling. > > Ok for trunk? OK once the set as a whole is ack'd. JEff

Re: [patch, doc] Document that new Perl version breaks required automake

2017-11-16 Thread Jeff Law
On 11/09/2017 12:28 AM, Thomas Koenig wrote: > Hello world, > > while PR 82856 remains unsolved so far, this documentation patch at > least points people into the right direction if --enable-maintainer-mode > fails due to the incompatibility of the latest Perl version with > the required

Re: Improve spilling for variable-size slots

2017-11-16 Thread Jeff Law
On 11/03/2017 10:35 AM, Richard Sandiford wrote: > Once SVE is enabled, a general AArch64 spill slot offset will be > > A + B * VL > > where A is a constant and B is a multiple of the SVE vector length. > The offsets in SVE load and store instructions are a multiple of VL > (and so can encode

Re: [PATCH 1/7]: SVE: Add CLOBBER_HIGH expression

2017-11-16 Thread Alan Hayward
> On 16 Nov 2017, at 18:24, Richard Biener wrote: > > On November 16, 2017 7:05:30 PM GMT+01:00, Jeff Law wrote: >> On 11/16/2017 05:34 AM, Alan Hayward wrote: >>> This is a set of patches aimed at supporting aarch64 SVE register >>> preservation

Re: [PATCH #2], make Float128 built-in functions work with -mabi=ieeelongdouble

2017-11-16 Thread Segher Boessenkool
On Thu, Nov 16, 2017 at 12:54:54PM -0500, David Edelsohn wrote: > On Thu, Nov 16, 2017 at 12:48 PM, Michael Meissner > wrote: > > On Thu, Nov 16, 2017 at 04:48:18AM -0600, Segher Boessenkool wrote: > >> On Wed, Nov 15, 2017 at 04:56:10PM -0500, Michael Meissner wrote:

Re: [PATCH] c-family: add name_hint/deferred_diagnostic (v3)

2017-11-16 Thread Jeff Law
On 11/02/2017 06:21 PM, David Malcolm wrote: > Jeff: You previously had concerns about the refcounting used in v1 > of this patch; this avoids that in favor of using gnu::unique_ptr. > Joseph already approved the C frontend parts of v2 of this > patch. I had to go back and find my original

Re: [PATCH 1/7]: SVE: Add CLOBBER_HIGH expression

2017-11-16 Thread Richard Biener
On November 16, 2017 7:05:30 PM GMT+01:00, Jeff Law wrote: >On 11/16/2017 05:34 AM, Alan Hayward wrote: >> This is a set of patches aimed at supporting aarch64 SVE register >> preservation around TLS calls. >> >> Across a TLS call, Aarch64 SVE does not explicitly preserve the >>

Re: [PATCH v2] [libcc1] Rename C{,P}_COMPILER_NAME and remove triplet from them

2017-11-16 Thread Jeff Law
On 11/15/2017 09:12 PM, Sergio Durigan Junior wrote: > On Wednesday, November 15 2017, Jim Wilson wrote: > >> On 11/13/2017 01:10 PM, Sergio Durigan Junior wrote: >>> On Tuesday, September 26 2017, I wrote: >>> Ping^2. >>> >>> Ping^3. >>> >>> I'm sending the updated ChangeLog/patch. I'm

Re: Make istreambuf_iterator::_M_sbuf immutable and add debug checks

2017-11-16 Thread Petr Ovtchenkov
On Thu, 16 Nov 2017 18:40:08 +0100 François Dumont wrote: > On 16/11/2017 12:46, Jonathan Wakely wrote: > > On 16/11/17 10:57 +, Jonathan Wakely wrote: > >> On 16/11/17 08:51 +0300, Petr Ovtchenkov wrote: > >>> On Mon, 6 Nov 2017 22:19:22 +0100 > >>> François Dumont

Re: [PATCH 1/7]: SVE: Add CLOBBER_HIGH expression

2017-11-16 Thread Jeff Law
On 11/16/2017 05:34 AM, Alan Hayward wrote: > This is a set of patches aimed at supporting aarch64 SVE register > preservation around TLS calls. > > Across a TLS call, Aarch64 SVE does not explicitly preserve the > SVE vector registers. However, the Neon vector registers are preserved. > Due to

Re: [PATCH] Improve -Wmaybe-uninitialized documentation

2017-11-16 Thread Jeff Law
On 11/16/2017 03:49 AM, Jonathan Wakely wrote: > On 15/11/17 20:28 -0700, Martin Sebor wrote: >> On 11/15/2017 07:31 AM, Jonathan Wakely wrote: >>> The docs for -Wmaybe-uninitialized have some issues: >>> >>> - That first sentence is looong. >>> - Apparently some C++ programmers think 

Re: [PING] [PATCH] Remove CANADIAN, that break compilation for foreign target

2017-11-16 Thread Petr Ovtchenkov
On Wed, 20 Sep 2017 13:44:59 +0300 Petr Ovtchenkov wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71212 > > On Fri, 20 May 2016 16:10:50 +0300 > Petr Ovtchenkov wrote: > > > Some old ad-hoc (adding -I/usr/include to compiler > > flags) break

Re: [patch] remove cilk-plus

2017-11-16 Thread Jeff Law
On 11/16/2017 09:22 AM, Eric Gallager wrote: > On 11/16/17, Koval, Julia wrote: >> // I failed to send patch itself, it is too big even in gzipped form. What >> is the right way to send such big patches? >> >> Hi, this patch removes cilkplus. Ok for trunk? > > I'm not a

Re: [PATCH #2], make Float128 built-in functions work with -mabi=ieeelongdouble

2017-11-16 Thread David Edelsohn
On Thu, Nov 16, 2017 at 12:48 PM, Michael Meissner wrote: > On Thu, Nov 16, 2017 at 04:48:18AM -0600, Segher Boessenkool wrote: >> On Wed, Nov 15, 2017 at 04:56:10PM -0500, Michael Meissner wrote: >> > David tells me that the patch to enable float128 built-in

Re: [committed][PATCH] Change order of processing blocks/threads in tree-ssa-threadupdate.c

2017-11-16 Thread Jeff Law
On 11/15/2017 12:57 AM, Aldy Hernandez wrote: > > > On 11/14/2017 10:46 PM, Jeff Law wrote: >> With my local patches to remove jump threading from VRP I was seeing a >> fairly obvious jump threading path left in the CFG after DOM.  This >> missed jump thread ultimately caused a false positive

Re: [PATCH #2], make Float128 built-in functions work with -mabi=ieeelongdouble

2017-11-16 Thread Michael Meissner
On Thu, Nov 16, 2017 at 04:48:18AM -0600, Segher Boessenkool wrote: > On Wed, Nov 15, 2017 at 04:56:10PM -0500, Michael Meissner wrote: > > David tells me that the patch to enable float128 built-in functions to work > > with the -mabi=ieeelongdouble option broke AIX because on AIX, the float128 >

Re: Adjust empty class parameter passing ABI (PR c++/60336)

2017-11-16 Thread Marek Polacek
On Tue, Nov 14, 2017 at 07:34:54AM +0100, Richard Biener wrote: > On November 14, 2017 6:21:41 AM GMT+01:00, Jason Merrill > wrote: > >On Mon, Nov 13, 2017 at 1:02 PM, Marek Polacek > >> In the end I did two bootstraps with the patch, but modifed one of >

Re: Make istreambuf_iterator::_M_sbuf immutable and add debug checks

2017-11-16 Thread François Dumont
On 16/11/2017 12:46, Jonathan Wakely wrote: On 16/11/17 10:57 +, Jonathan Wakely wrote: On 16/11/17 08:51 +0300, Petr Ovtchenkov wrote: On Mon, 6 Nov 2017 22:19:22 +0100 François Dumont wrote: Hi     Any final decision regarding this patch ? François

[PATCH] [BRIGFE] Reduce the number of type conversions due to the untyped HSAIL regs

2017-11-16 Thread Pekka Jääskeläinen
Instead of always representing the HSAIL's untyped registers as unsigned int, the gccbrig now pre-analyzes the BRIG code and builds the register variables as a type used the most when storing or reading data to/from each register. This reduces the total conversions which cannot be always optimized

[PATCH] Use bswap framework in store-merging (PR tree-optimization/78821)

2017-11-16 Thread Jakub Jelinek
Hi! This patch uses the bswap pass framework inside of the store merging pass to handle adjacent stores which produce together a 16/32/64 bit store of bswapped value (loaded or from SSA_NAME) or identity (usually only from SSA_NAME, the code prefers to use the existing store merging code if

Re: [PATCH][ARM] Fix test armv8_2-fp16-move-1.c

2017-11-16 Thread Kyrill Tkachov
Hi Sudi, On 16/11/17 16:37, Sudi Das wrote: Hi This patch fixes the test case armv8_2-fp16-move-1.c for arm-none-linux-gnueabihf where 2 of the scan-assembler directives were failing. We now generate less vmov between core and VFP registers. Thus changing those directives to reflect that.

RE: [patch] remove cilk-plus

2017-11-16 Thread Koval, Julia
Thanks for your comments, fixed it. 2017-11-16 Julia Koval Sebastian Peryt * Makefile.def (target_modules): Remove libcilkrts. * Makefile.in: Ditto. * configure: Ditto. * configure.ac: Ditto.

Remove write only bb_freq in tree-emutls.c

2017-11-16 Thread Jan Hubicka
Hi, this var is actually write only, so I have removed it. Honza * tree-emutls.c (lower_emutls_data): Remove unused bb_freq. (lower_emutls_function_body): Do not compute it. Index: tree-emutls.c === --- tree-emutls.c

Accumulate time in sreals in ipa-fnsplit

2017-11-16 Thread Jan Hubicka
Hi, this patch does same change to ipa-split as previous patch did to fnsummary. Bootstrapped/regtested x86_64-linux. Honza * ipa-split.c (split_bb_info): Turn time to sreal. (split_point): Likewise. (dump_split_point): Likewise. (fine_split_points): Likewise.

Accumulate time in sreals consistently in ipa-fnsummary

2017-11-16 Thread Jan Hubicka
Hi, this patch drops use of integer bb frequencies in ipa-fnsummary. This avoids capping to 100 for frequency and makes it consistent with edge accounting. ipcp-2.c needs updating becuase the cumulated time is now more realistic. There is loop iterating 32*32 times and we accounted it as loop

Set edges to region known to be executed 0 times to have probability 0

2017-11-16 Thread Jan Hubicka
Hi, this patch fixes one profilemismatch issue in testsuite where we end up with non-zero probability with edge to BB calling abort. When detecting regions known to be executed 0 times, we should also set edges leading to them to be executed 0 times. The other change makes

[PATCH][ARM] Fix test armv8_2-fp16-move-1.c

2017-11-16 Thread Sudi Das
Hi This patch fixes the test case armv8_2-fp16-move-1.c for arm-none-linux-gnueabihf where 2 of the scan-assembler directives were failing. We now generate less vmov between core and VFP registers. Thus changing those directives to reflect that. Is this ok for trunk? If yes could someone

Remove scale_bbs_frequencies_int, scale_bbs_frequencies_int

2017-11-16 Thread Jan Hubicka
Hi, since all uses of those functions are now updated to profile counts and probabilities, we can rmeove these. Bootstrapped/retested x86_64-linux, comitted. Honza * cfg.c (scale_bbs_frequencies_int, cale_bbs_frequencies_gcov_type): Remove. * cfg.h

Avoid integer profile scaling in tree_transform_and_unroll_loop

2017-11-16 Thread Jan Hubicka
Hi, this is the last remaining case of integer scaling. The issue is again the same. We scale up which is not best idea and unrolling done via cfgloopmanip gets around wtihout doing it. Again I decided to keep the logic for now, just update it to profile counts. Bootstrapped/regtested

Use profile count scaling in vect_do_peeling

2017-11-16 Thread Jan Hubicka
Hi, this is one of two remiaing places we scale by integer ratios rather than counts which lose quality info. This is because we scale up here which is technically bad idea we lose precision and all code duplication should perform scale at once as last step to avoid cumulating mistakes. Bot

Re: [patch] remove cilk-plus

2017-11-16 Thread Eric Gallager
On 11/16/17, Koval, Julia wrote: > // I failed to send patch itself, it is too big even in gzipped form. What > is the right way to send such big patches? > > Hi, this patch removes cilkplus. Ok for trunk? I'm not a reviewer, but just as an onlooker, I'd want to see notes

[PATCH][PR c++/82888] smarter code for default initialization of scalar arrays

2017-11-16 Thread Nathan Froyd
Default-initialization of scalar arrays in C++ member initialization lists produced rather slow code, laboriously setting each element of the array to zero. It would be much faster to block-initialize the array, and that's what this patch does. The patch works for me, but I'm not sure if it's

Re: [PATCH] Improve -Wmaybe-uninitialized documentation

2017-11-16 Thread Martin Sebor
On 11/16/2017 03:49 AM, Jonathan Wakely wrote: On 15/11/17 20:28 -0700, Martin Sebor wrote: On 11/15/2017 07:31 AM, Jonathan Wakely wrote: The docs for -Wmaybe-uninitialized have some issues: - That first sentence is looong. - Apparently some C++ programmers think "automatic variable"

Re: [patch] remove cilk-plus

2017-11-16 Thread Jakub Jelinek
On Thu, Nov 16, 2017 at 03:33:40PM +, Koval, Julia wrote: > // I failed to send patch itself, it is too big even in gzipped form. What > is the right way to send such big patches? Don't include the libcilkrts subtree in the patch nor /cilk-plus/ testcases that are going to be removed? >

Re: [PATCH] Disable -ftrapping-math by default

2017-11-16 Thread Wilco Dijkstra
Richard Biener wrote: > We are generally not preserving traps but we guard any transform that > might introduce traps with -ftrapping-math.  That's similar to how we treat > -ftrapv and pointer dereferences. Right. It appears it's mostly concerned about division - if it is about division by zero

Re: [patch] remove cilk-plus

2017-11-16 Thread Marek Polacek
On Thu, Nov 16, 2017 at 03:33:40PM +, Koval, Julia wrote: > // I failed to send patch itself, it is too big even in gzipped form. What > is the right way to send such big patches? You can split the patch and then post each part in a separate e-mail. Easier to review, too. > Hi, this patch

[patch] remove cilk-plus

2017-11-16 Thread Koval, Julia
// I failed to send patch itself, it is too big even in gzipped form. What is the right way to send such big patches? Hi, this patch removes cilkplus. Ok for trunk? 2017-11-16 Julia Koval Sebastian Peryt gcc/ *

RE: [PATCH, committed] Add myself to MAINTAINERS

2017-11-16 Thread Peryt, Sebastian
Message didn't get thru for some reason. Resending. Sebastian From: Peryt, Sebastian Sent: Wednesday, November 15, 2017 1:44 PM To: gcc-patches@gcc.gnu.org Cc: Peryt, Sebastian Subject: [PATCH, committed] Add myself to MAINTAINERS ChangeLog: 2017-11-15  Sebastian

Re: [PATCH][GCC][mid-end] Allow larger copies when target supports unaligned access [Patch (1/2)]

2017-11-16 Thread Tamar Christina
Hi Richard, > > I'd have made it > > if { ([is-effective-target non_strict_align] > && ! ( [istarget ...] || )) > > thus default it to 1 for non-strict-align targets. > Fair, I've switched it to a black list and have excluded the only one I know should not work. Most of the

Re: [PATCH GCC]A simple implementation of loop interchange

2017-11-16 Thread Bin.Cheng
On Tue, Oct 24, 2017 at 3:30 PM, Michael Matz wrote: > Hello, > > On Fri, 22 Sep 2017, Bin.Cheng wrote: > >> This is updated patch for loop interchange with review suggestions >> resolved. Changes are: >> 1) It does more light weight checks like rectangle loop nest check >>

Re: [PATCH, GCC/ARM] Fix ICE in Armv8-M Security Extensions code

2017-11-16 Thread Kyrill Tkachov
Hi Thomas, On 15/11/17 16:57, Thomas Preudhomme wrote: Hi, Commit r253825 which introduced some sanity checks for sbitmap revealed a bug in the conversion of cmse_nonsecure_entry_clear_before_return () to using bitmap structure. bitmap_and expects that the two bitmaps have the same length, yet

Re: [PATCH] New lang hook

2017-11-16 Thread Nathan Sidwell
On 11/16/2017 07:03 AM, Richard Biener wrote: Looks reasonable apart from + /* Overwrite the DECL_ASSEMBLER_NAME for a node. The name is being + changed (including to or from NULL_TREE). */ which suggests the default implementation of set_decl_assembler_name would call this hook (which

Re: [PATCH] Disable -ftrapping-math by default

2017-11-16 Thread Richard Biener
On Thu, Nov 16, 2017 at 3:33 PM, Wilco Dijkstra wrote: > GCC currently defaults to -ftrapping-math. This is supposed to generate > code for correct user-visible traps and FP status flags. > > However it doesn't work as expected since it doesn't block any floating > point

[PATCH] Add noexcept to std::shared_future copy operations (LWG DR 2799)

2017-11-16 Thread Jonathan Wakely
These functions just increment a refcount (and the base class functions that do that are already noexcept anyway). * include/std/future (shared_future): Add noexcept to copy constructor and copy-assignment operator (LWG 2799). Tested pwoerpc64le-linux, committed to trunk.

[PATCH] Disable -ftrapping-math by default

2017-11-16 Thread Wilco Dijkstra
GCC currently defaults to -ftrapping-math. This is supposed to generate code for correct user-visible traps and FP status flags. However it doesn't work as expected since it doesn't block any floating point optimizations. For example it continues to perform CSE, moves FP operations across

Re: [PATCH] BRIG frontend: request for a global review

2017-11-16 Thread Pekka Jääskeläinen
Hi, I added some content to gccbrig.texi in r254820 as below. If you have something that I could describe further there, please just let me know. Index: gcc/brig/gccbrig.texi === --- gcc/brig/gccbrig.texi (revision 254819) +++

Re: [PATCH] Factor out division by squares and remove division around comparisons (2/2)

2017-11-16 Thread Wilco Dijkstra
ping From: Jackson Woodruff Sent: 06 September 2017 10:55 To: Richard Biener Cc: Wilco Dijkstra; kyrylo.tkac...@foss.arm.com; Joseph S. Myers; GCC Patches Subject: Re: [PATCH] Factor out division by squares and remove division around comparisons (2/2)   Hi

[Ada] Handling of elaboration warnings

2017-11-16 Thread Pierre-Marie de Rodat
This patch modifies the elaboration warnings produced by the ABE mechanism to depend on the status of flag Elab_Warnings. The flag is enabled by compilation switch -gnatwl. This change allows for selective suppression of warnings, as well as total suppression. In order to preserve the behaviour

Re: Hurd port for gcc-7 go PATCH 1-3(15)

2017-11-16 Thread Svante Signell
On Wed, 2017-11-15 at 21:54 +0100, Svante Signell wrote: > On Wed, 2017-11-15 at 21:40 +0100, Matthias Klose wrote: > > On 06.11.2017 16:36, Svante Signell wrote: > > > Hi, > > > > > > Attached are patches to enable gccgo to build properly on Debian > > > GNU/Hurd on gcc-7 (7-7.2.0-12). > > > >

[Ada] Spurious error on System'To_Address in -gnatc mode

2017-11-16 Thread Pierre-Marie de Rodat
This patch fixes a bug where if an address clause specifies a call to System'To_Address as the address, and the code is compiled with the -gnatc switch, the compiler gives a spurious error message. The following test should compile quietly with -gnatc: gcc -c -gnatc counter.ads with System;

[PATCH 7/7]: Enable clobber high for tls descs on Aarch64

2017-11-16 Thread Alan Hayward
This final patch adds the clobber high expressions to tls_desc for aarch64. It also adds three tests. In addition I also tested by taking the gcc torture test suite and making all global variables __thread. Then emended the suite to compile with -fpic, save the .s file and only for one given O

[PATCH 5/7]: cse support for clobber_high

2017-11-16 Thread Alan Hayward
This patch simply adds the cse specific changes for clobber_high. Alan. 2017-11-16 Alan Hayward * cse.c (invalidate_reg): New function extracted from... (invalidate): ...here. (canonicalize_insn): Check for clobber high.

[PATCH 6/7]: Remaining support for clobber high

2017-11-16 Thread Alan Hayward
This patch simply adds the remainder of clobber high checks. Happy to split this into smaller patches if required (there didn't seem anything obvious to split into). Alan. 2017-11-16 Alan Hayward * alias.c (record_set): Check for clobber high. *

[PATCH 4/7]: lra support for clobber_high

2017-11-16 Thread Alan Hayward
This patch simply adds the lra specific changes for clobber_high. Alan. 2017-11-16 Alan Hayward * lra-eliminations.c (lra_eliminate_regs_1): Check for clobber high. (mark_not_eliminable): Likewise. * lra-int.h (struct lra_insn_reg): Add clobber

[PATCH 2/7] Support >26 operands in generation code.

2017-11-16 Thread Alan Hayward
This patch adds support for CLOBBER_HIGH in the generation code. An aarch64 will require 31 clobber high expressions, plus two clobbers. The exisiting gen code restricts to 26 vector operands by virtue of using the operators [a-z]. This patch extends this to 52 by supporting [a-zA-Z]. Alan.

  1   2   >