Hi Richard,
This is the revised patch based on the review and the discussion in
https://gcc.gnu.org/ml/gcc/2018-05/msg00179.html.
In summary:
- I skipped (element_precision (type) < element_precision (TREE_TYPE
(@0))) in the match.pd pattern as this would prevent transformation
for the case in
On Sat, 26 May 2018, Will Hawkins wrote:
> > + if (asmspec_tree != NULL_TREE)
> > +{
> > + warning (OPT_Wignored_asm_name, "asm-specifier is ignored in "
> > + "typedef declaration");
> > +}
We avoid braces around a single statement like this.
I don't think
I've committed this patch to update the GCC 8 branch to the Go 1.10.2
release, and also brought along a couple of other recent fixes.
Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed
to mainline.
cmd/go: support more Solaris assembler syntaxes
Patch by Rainer Orth.
On May 30, 2018, at 3:41 AM, Tom de Vries wrote:
>
> this patch tests the error behaviour of dg-final directives when called with
> an
> incorrect number of arguments.
Seems reasonable. Unless someone wanted to argue against it for some reason
(not portable, takes too much time, hard to
This patch to libgo updates it to the 1.10.2 release. Bootstrapped
and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline.
Ian
Index: gcc/go/gofrontend/MERGE
===
--- gcc/go/gofrontend/MERGE (revision 260913)
+++
With that in place, please go ahead and start filling this.
For GCC 8 many items came late, and I'm sure that we are still
missing many that would have been worth documenting here.
Gerald
Applied as follows...
Index: changes.html
Hi,
I have committed the patch as revision 261039.
thanks.
Qing
> On May 29, 2018, at 7:08 PM, Qing Zhao wrote:
>
> Hi, Jeff,
>
> Thanks a lot for your review and comments.
>
> I have updated my patch based on your suggestion, and retested this whole
> patch on both X86 and aarch64.
>
>
Hi,
Enable some variations of the _builtin_vec_xst() instrinsic.
For most data types (char,short,int,...) the _builtin_vec_xst() intrinsic
accepts either a pointer to , or a pointer to a vector of elements of
. We currently do not accept pointer-to-type for the long long or
double data types.
Hi,
Add support for gimple folding for unaligned vector loads and stores.
testcases posted separately in this thread.
Regtest completed across variety of systems, P6,P7,P8,P9.
OK for trunk?
Thanks,
-Will
[gcc]
2018-05-31 Will Schmidt
* config/rs6000/rs6000.c:
Hi,
Testcase coverage for variations of the vec_xst() intrinsic.
Regtest clean across assorted Linux systems (p6-p9).
OK for trunk?
Thanks,
-Will
[testsuite]
2018-05-31 Will Schmidt
* gcc.target/powerpc/fold-vec-store-vec_xst-char.c : New.
*
Hi,
Assorted updates to existing tests to compensate for codegen changes
introduced with the gimple-folding of unaligned vector loads and stores.
Regtest clean across assorted Linux systems (p6-p9).
OK for trunk?
Thanks,
-Will
[testsuite]
2018-05-31 Will Schmidt
*
Hi,
New testcases to cover variations of the vec_vsx_st() intrinsic.
Regtest clean across assorted Linux systems (p6-p9).
OK for trunk?
Thanks,
-Will
[testsuite]
2018-05-31 Will Schmidt
* gcc.target/powerpc/fold-vec-store-vec_vsx_st-char.c: New.
*
Hi,
Add testcase coverage for variations of the builtin_vec_xst() intrinsic.
Regtest clean across assorted Linux systems (p6-p9).
OK for trunk?
Thanks,
-Will
[testsuite]
2018-05-31 Will Schmidt
* gcc.target/powerpc/fold-vec-store-builtin_vec_xst-char.c: New.
*
Hi,
Add testcase coverage for variations of the vec_vsx_ld() intrinsic.
Regtest clean across assorted Linux systems (p6-p9).
OK for trunk?
Thanks,
-Will
[testsuite]
2018-05-31 Will Schmidt
* gcc.target/powerpc/fold-vec-load-vec_vsx_ld-char.c : New.
*
Hi,
Add testcase coverage for variations of the builtin_vec_xl() intrinsic.
Regtest clean across assorted Linux systems (p6-p9).
OK for trunk?
Thanks,
-Will
[testsuite]
2018-05-31 Will Schmidt
* gcc.target/powerpc/fold-vec-load-builtin_vec_xl-char.c: New.
*
Hi,
Add testcase coverage for variations of the vec_xl() intrinsic.
Regtest clean across assorted Linux systems (p6-p9).
OK for trunk?
Thanks,
-Will
[testsuite]
2018-05-31 Will Schmidt
* gcc.target/powerpc/fold-vec-load-vec_xl-char.c
*
Hello!
As reported in the PR, AMDFAM15H model 0x2 should return
AMDFAM15H_BDVER2 subtype.
2018-05-31 Uros Bizjak
PR target/85591
* config/i386/cpuinfo.c (get_amd_cpu): Return
AMDFAM15H_BDVER2 for AMDFAM15H model 0x2.
Bootstrapped and regression tested on x86_64-linux-gnu
Hi,
I've broken this set of patches up into bite-sized chunks for easier
review and management. They'll be showing up as replies to this
message.
#1-6 are straightforward tests to cover the variations of the vector
load and store intrinsics. These look much alike, but there really are
On Wed, May 30, 2018 at 06:43:23PM +0200, Jakub Jelinek wrote:
> On Wed, May 30, 2018 at 08:45:22AM -0500, Segher Boessenkool wrote:
> > > If you need to keep g for compatibility (you do), then why not just have
> > > e (long double is double)
> > > g (long double when matching __ibm128, or
This adds incomplete but functional support for std::filesystem and
std::experimental::filesystem on MinGW. In theory there should be no
changes to the existing behaviour for POSIX targets from this patch,
as all the various bugs I found while working on this have already
been fixed in separate
On Thu, 24 May 2018, Jeff Law wrote:
> > I can try to fix openbsd soon, but freebsd dropped alpha in 2009.
> > How does gcc feel about me picking up patches from openbsd ports, their
> > package manager, that weren't written by myself?
> So ISTM we should deprecate freebsd alpha.
Ab-so-lutely.
No functional changes.
2018-05-31 Uros Bizjak
* config/i386/sse.md (avx_vec_concat):
Substitute concat_tg_mode mode attribute with xtg_mode.
(avx512dq_broadcast_1): Ditto.
(concat_tg_mode): Remove mode attribute.
Bootstrapped and regression tested on x86_64-linux-gnu.
On Thu, May 31, 2018 at 3:51 AM, Kugan Vivekanandarajah
wrote:
> Hi Bin,
>
> Thanks for the review. Please find the revised patch based on the
> review comments.
>
> Thanks,
> Kugan
>
> On 17 May 2018 at 19:56, Bin.Cheng wrote:
>> On Thu, May 17, 2018 at 2:39 AM, Kugan Vivekanandarajah
>>
On Thu, May 31, 2018 at 01:34:19PM -0400, Jason Merrill wrote:
> >> Where is the error_mark_node coming from in the first place?
> >
> > remap_type invoked during omp-low.c (scan_omp).
> > omp_copy_decl returns error_mark_node for decls that tree-inline.c wants
> > to remap, but they aren't
On Thu, May 31, 2018 at 11:31 AM, Jakub Jelinek wrote:
> On Thu, May 31, 2018 at 11:19:08AM -0400, Jason Merrill wrote:
>> > In my mind the issue boils down to two questions:
>> >
>> > 1) should the pretty printer handle error-mark-node gracefully
>> >or is it appropriate for it to abort?
>>
Hi!
I've committed following patch to gomp-5_0-branch, which:
1) adds support for memory-order clauses other than seq_cst to atomic
construct
2) adds support for hint clause on atomic construct, fixes some hint related
glitches on critical construct; hints are ignored aftere checking their
On 05/30/2018 05:18 PM, Jeff Law wrote:
On 05/18/2018 05:58 PM, Martin Sebor wrote:
The -Walloc-size-larger-than= option is supposed make it possible
to disable the warning by specifying a limit that's larger than
the default of PTRDIFF_MAX (the handler for the option argument
gets around the
On Thu, May 31, 2018 at 8:08 AM, Jan Hubicka wrote:
>>
>> This is the patch I am going to check into GCC 8.
>>
>> --
>> H.J.
>
>> From 9ecbfa1fd04dc4370a9ec4f3d56189cc07aee668 Mon Sep 17 00:00:00 2001
>> From: "H.J. Lu"
>> Date: Thu, 17 May 2018 09:52:09 -0700
>> Subject: [PATCH] x86: Re-enable
On Thu, May 31, 2018 at 11:19:08AM -0400, Jason Merrill wrote:
> > In my mind the issue boils down to two questions:
> >
> > 1) should the pretty printer handle error-mark-node gracefully
> >or is it appropriate for it to abort?
> > 2) is it appropriate to be embedding/using error_mark_node in
On Thu, May 31, 2018 at 11:00 AM, Martin Sebor wrote:
> On 05/31/2018 07:30 AM, Jakub Jelinek wrote:
>>
>> On Thu, May 31, 2018 at 09:14:33AM -0400, Jason Merrill wrote:
I came up with the following hack instead (or in addition to),
replace those error_mark_node bounds with NULL
>
> This is the patch I am going to check into GCC 8.
>
> --
> H.J.
> From 9ecbfa1fd04dc4370a9ec4f3d56189cc07aee668 Mon Sep 17 00:00:00 2001
> From: "H.J. Lu"
> Date: Thu, 17 May 2018 09:52:09 -0700
> Subject: [PATCH] x86: Re-enable partial_reg_dependency and movx for Haswell
>
> r254152
On 05/31/2018 07:30 AM, Jakub Jelinek wrote:
On Thu, May 31, 2018 at 09:14:33AM -0400, Jason Merrill wrote:
I came up with the following hack instead (or in addition to),
replace those error_mark_node bounds with NULL (i.e. pretend flexible array
members) if during OpenMP/OpenACC outlining
On Wed, May 30, 2018 at 5:43 AM, H.J. Lu wrote:
> On Sun, May 20, 2018 at 11:51 AM, Jan Hubicka wrote:
>>> r254152 disabled partial_reg_dependency and movx for Haswell and newer
>>> Intel processors. r258972 restored them for skylake-avx512. For Haswell,
>>> movx improves performance. But
On Wed, May 30, 2018 at 5:23 PM, Marek Polacek wrote:
> We are failing to deduce the template parameter N here
>
> template
> void foo(const long int (&)[N]) {}
>
> void bar() {
> foo ({1,2,3});
> }
>
> because of the type mismatch; parm is long int (element type of the array),
>
On 31/05/18 13:17 +0100, Jonathan Wakely wrote:
Because the wide character types are neither signed integer types nor
unsigned integer types they need to be transformed to an integral type
of the correct size and the lowest rank (which is not necessarily the
underlying type). Reuse the helpers
On Thu, May 31, 2018 at 06:54:11AM -0700, Cesar Philippidis wrote:
> 2018-05-31 Chung-Lin Tang
> Cesar Philippidis
>
> PR middle-end/85879
>
> gcc/
> * gimplify.c (gimplify_adjust_omp_clauses): Add 'remove = true'
> when emitting error on
OpenACC has slightly different data semantics for reference types and
pointers. Without this patch, omp-low was treating all references types
like pointers which resulted in some gimple type checking errors when
checking is enabled. It turned out that Chung-Lin had resolved the issue
way back in
On May 31, 2018 12:02:49 PM GMT+02:00, Jakub Jelinek wrote:
>On Thu, May 31, 2018 at 11:46:33AM +0200, Richard Biener wrote:
>> Is naked an attribute that is specified for all targets? If so, OK.
>
>It is not specified for all targets, but all targets for which it is
>specified have the same
On Thu, May 31, 2018 at 09:14:33AM -0400, Jason Merrill wrote:
> > I came up with the following hack instead (or in addition to),
> > replace those error_mark_node bounds with NULL (i.e. pretend flexible array
> > members) if during OpenMP/OpenACC outlining we've decided not to pass around
> > the
Hi,
this enhances the GIMPLE store-merging pass by teaching it to deal with
generic stores to bit-fields, i.e. not just stores of immediates. The
motivating example is:
struct S {
unsigned int flag : 1;
unsigned int size : 31;
};
void foo (struct S *s, unsigned int size)
{
s->flag = 1;
On Thu, May 31, 2018 at 2:58 AM, Jakub Jelinek wrote:
> On Wed, May 30, 2018 at 02:39:15PM -0600, Martin Sebor wrote:
>> gcc/c-family/ChangeLog:
>>
>> PR middle-end/85956
>> * c-pretty-print.c (c_pretty_printer::direct_abstract_declarator):
>> Handle error-mark-node in array
On Wed, May 30, 2018 at 3:56 PM, Jeff Law wrote:
> On 04/22/2018 01:17 PM, dave.pa...@oracle.com wrote:
>> This patch fixes handling of -Werror=return-type as well as
>> -Wno-return-type. Currently, -Werror=return-type does not turn the
>> warnings into errors and -Wno-return-type does not turn
Wilco Dijkstra writes:
> Richard Sandiford wrote:
>
>>> This has probably been reported elsewhere already but I can't find
>>> such a report, so sorry for possible duplicate,
>>> but this patch is causing ICEs on aarch64
>>> FAIL: gcc.target/aarch64/sve/reduc_1.c -march=armv8.2-a+sve
>>>
On 05/30/2018 07:40 PM, Jakub Jelinek wrote:
> On Tue, May 01, 2018 at 11:28:13AM -0600, Jeff Law wrote:
>> On 04/27/2018 05:00 AM, Martin Liška wrote:
>>> I'm sending patch that removes MPX. It preserves all options
>>> -fcheck-pointer-bounds, -fchkp-* and -mmpx
>>> target option. These options
Because the wide character types are neither signed integer types nor
unsigned integer types they need to be transformed to an integral type
of the correct size and the lowest rank (which is not necessarily the
underlying type). Reuse the helpers for enumeration types to select the
correct
On 31/05/18 00:28, Jeff Law wrote:
It's not clear why having that subreg is causing incorrect code to be
generated, but the subreg is clearly wrong since it's a qisi pattern not
a hisi pattern. Based on that I've approved and installed the change.
There's some further info in PR85941, but I
This replaces the scanning of the -fstack-usage output with -Wstack-usage.
Tested on x86-64/Linux, applied on the mainline and 8 branch.
2018-05-31 Eric Botcazou
* gnat.dg/stack_usage1.adb: Replace -fstack-usage with -Wstack-usage.
* gnat.dg/stack_usage1b.adb: Likewise.
On Thu, May 31, 2018 at 01:22:00PM +0200, Eric Botcazou wrote:
> There is a handful of gcc.dg/store_merging_*.c tests in the testsuite with
> both a main procedure doing sanity checks and a dg-do compile directive.
>
> Tested on x86-64/Linux, applied on the mainline and 8 branch as obvious.
There is a handful of gcc.dg/store_merging_*.c tests in the testsuite with
both a main procedure doing sanity checks and a dg-do compile directive.
Tested on x86-64/Linux, applied on the mainline and 8 branch as obvious.
2018-05-31 Eric Botcazou
* gcc.dg/store_merging_10.c: Turn
Richard Sandiford wrote:
>> This has probably been reported elsewhere already but I can't find
>> such a report, so sorry for possible duplicate,
>> but this patch is causing ICEs on aarch64
>> FAIL: gcc.target/aarch64/sve/reduc_1.c -march=armv8.2-a+sve
>> (internal compiler error)
>> FAIL:
This patch implements the rule given in RM 4.2 (11): if the component type of
a string literal is a character type with a static predicate, that predicate
must be applied to each character in the string.
Compiling the example below must yield:
gcc -c -gnata main.adb
main.adb:4:23: warning:
A STORAGE ERROR is raised in __gnat_backtrace:
adainit: 0x00400DBC
Execution of ce.vxe terminated by unhandled exception
raised STORAGE_ERROR : SIGSEGV: possible stack overflow
Call stack traceback locations:
0x4082f1 0x408323 0x4080c9
It was passing with vxsim because the WRS_RTP_BASE is set
GNAT was emitting a warning about procedures with No_Return aspect on the
spec and a returning body, but failed to handle similar procedures with
no explicit spec. Now fixed.
This was also affecting GNATprove, where an undetected mismatch between
No_Return aspect and the body was a soundness bug,
This patch fixes a spurious copy of a limited object, when that object
is a discriminated record component of a limited type LT, and the enclosing
record is initialized by means of an aggregate, one of whose components is a
call to a build-in-place function that returns an unconstrained object of
Remove mention of unavailability, long obsolete, and reword suggestion of use
to indicate that we might want to switch to an internal interface using them.
The current wording suggests just that we should bind the current
Sync_Compare_And_Swap Ada subprograms to __atomic_compare builtins instead
This patch modifies the transient scope mechanism to create a scope when the
condition of an iteration scheme returns a controlled result or involves the
secondary stack. As a result, a while loop which iterates over a container
properly manages the tampering bit at each iteration of the loop.
Calling Unique_Defining_Entity on protectected entry declarations is
equivalent to calling a simpler Defining_Entity; use the simpler routine.
Simplification only; semantics unaffected, so no test provided.
Tested on x86_64-pc-linux-gnu, committed on trunk
2018-05-31 Piotr Trojanek
gcc/ada/
Loop (in)variants should appear next to each other, which is checked by GNAT
frontend. As statements inserted during expansion may break this contiguity,
GNAT recognizes specially such statements which originate in loop pragmas. In
some cases, this special treatment was not properly put in place,
This ensures that a warning for an object size clause present on a subtype
is posted on the clause and not on a size clause present on the type.
Tested on x86_64-pc-linux-gnu, committed on trunk
2018-05-31 Eric Botcazou
gcc/ada/
* einfo.ads (Object_Size_Clause): Declare.
*
gettimeofday is deprecated in Posix 2008, clock_gettime is the recommended
replacement.
Tested on x86_64-pc-linux-gnu, committed on trunk
2018-05-31 Doug Rupp
gcc/ada/
* libgnat/s-osprim__posix2008.adb (Clock): Implement using
clock_gettime.---
Rewriting of Max_Queue_Length expression into N_Integer_Literal should probably
be done in expansion and not in analysis, but anyway it should not strip the
expression from its Etype because backends (e.g. GNATprove) expect that Etype
to be present.
No frontend test is provided, because GNAT
On Thu, May 31, 2018 at 11:46:33AM +0200, Richard Biener wrote:
> Is naked an attribute that is specified for all targets? If so, OK.
It is not specified for all targets, but all targets for which it is
specified have the same behavior.
We handle "naked" a couple of times in the generic code
Hi Christophe,
On 31/05/18 09:38, Christophe Lyon wrote:
Hi,
On 29 May 2018 at 18:02, James Greenhalgh wrote:
> On Tue, May 29, 2018 at 10:28:27AM -0500, Kyrill Tkachov wrote:
>> [sending on behalf of Jackson Woodruff]
>>
>> Hi all,
>>
>> This patch generalizes the formation of LDP/STP that
On May 31, 2018 8:51:59 AM GMT+02:00, Jakub Jelinek wrote:
>Hi!
>
>We say in the documentation only supported body of naked functions
>is basic asm, anything else may but might not work. On the following
>testcase we end up with ICE, because the missing epilogue means the
>first
>partition is
On Thu, May 31, 2018 at 11:32:50AM +0200, Matthias Klose wrote:
> The fix for PR85835 causes the build to fail on sparc64-linux-gnu in the 32bit
> multilib. Testing the attached patch in a multilib enabled sparc64 cross
> build.
> Ok for the trunk and branches if the build succeeds?
>
>
The fix for PR85835 causes the build to fail on sparc64-linux-gnu in the 32bit
multilib. Testing the attached patch in a multilib enabled sparc64 cross build.
Ok for the trunk and branches if the build succeeds?
Matthias
2018-05-31 Matthias Klose
PR sanitizer/86012
*
Christophe Lyon writes:
> On 29 May 2018 at 19:34, Wilco Dijkstra wrote:
>> James Greenhalgh wrote:
>>
>>> > Add a missing ? to aarch64_get_lane to fix a failure in the testsuite.
>>>
>>> > I'd prefer more detail than this for a workaround; which test, why did it
>>> > start to fail, why is this
Hi,
On 29 May 2018 at 18:02, James Greenhalgh wrote:
> On Tue, May 29, 2018 at 10:28:27AM -0500, Kyrill Tkachov wrote:
>> [sending on behalf of Jackson Woodruff]
>>
>> Hi all,
>>
>> This patch generalizes the formation of LDP/STP that require a base register.
>>
>> In AArch64, LDP/STP
On 29 May 2018 at 19:34, Wilco Dijkstra wrote:
> James Greenhalgh wrote:
>
>> > Add a missing ? to aarch64_get_lane to fix a failure in the testsuite.
>>
>> > I'd prefer more detail than this for a workaround; which test, why did it
>> > start to fail, why is this the right solution, etc.
>
> It
On May 31, 2018 12:42:39 AM GMT+02:00, Jeff Law wrote:
>On 05/30/2018 03:37 AM, Richard Biener wrote:
>> On Tue, May 29, 2018 at 4:58 PM Martin Sebor
>wrote:
>>
>>> On 05/28/2018 03:11 AM, Richard Biener wrote:
On Fri, May 25, 2018 at 10:15 PM Martin Sebor
>wrote:
> Attached is
On Wed, May 30, 2018 at 02:39:15PM -0600, Martin Sebor wrote:
> gcc/c-family/ChangeLog:
>
> PR middle-end/85956
> * c-pretty-print.c (c_pretty_printer::direct_abstract_declarator):
> Handle error-mark-node in array bounds gracefully.
This isn't sufficient, as it still ICEs with
Hi!
We say in the documentation only supported body of naked functions
is basic asm, anything else may but might not work. On the following
testcase we end up with ICE, because the missing epilogue means the first
partition is not separated from the second partition with a barrier and
something
72 matches
Mail list logo
