Re: please approval my patch - add new logical traits to type_traits for logical completeness

2019-02-08 Thread Marc Glisse
(removing gcc-testresults@ which is for (automated) results of running the testsuite, not for patch submission) On Sat, 9 Feb 2019, 李苏旺 wrote: I have a patch about libstdc++ include/std/type_traits , testsuite/20_util/logical_traits/requirements/explicit_instantiation.cc

please approval my patch - add new logical traits to type_traits for logical completeness

2019-02-08 Thread 李苏旺
hi all, I have a patch about libstdc++ include/std/type_traits , testsuite/20_util/logical_traits/requirements/explicit_instantiation.cc testsuite/20_util/logical_traits/requirements/typedefs.cc testsuite/20_util/logical_traits/value.cc, the patch want to add new logical traits , such as

[PATCH] PR libstdc++/88066 use <> for includes not ""

2019-02-08 Thread Jonathan Wakely
Using #include "..." to include a header in the same directory fails if the user compiles with -I-, so always use something like for internal headers. I haven't added tests for this, because dg-options adds options to the end, and the position of -I- matters (if it's at the end then the tests

[PATCH] i386: Use EXT_REX_SSE_REG_P in *movoi_internal_avx/movti_internal

2019-02-08 Thread H.J. Lu
On Fri, Feb 8, 2019 at 3:28 AM H.J. Lu wrote: > > On Fri, Feb 8, 2019 at 1:51 AM Uros Bizjak wrote: > > > > On Thu, Feb 7, 2019 at 10:11 PM H.J. Lu wrote: > > > > > > OImode and TImode moves must be done in XImode to access upper 16 > > > vector registers without AVX512VL. With AVX512VL, we

[PATCH] Add noexcept to filesystem::path query functions

2019-02-08 Thread Jonathan Wakely
In the standard these member functions are specified in terms of the potentially-throwing path decompositions functions, but we implement them without constructing any new paths or doing anything else that can throw. PR libstdc++/71044 * include/bits/fs_path.h

[C++ PATCH] Fix std::is_constant_evaluated() in non-type template parameters (PR c++/88977)

2019-02-08 Thread Jakub Jelinek
Hi! Non-type template arguments are constant-expression in the grammar and thus manifestly constant-evaluated. For e.g. class templates, convert_nontype_argument is called with tf_warning_or_error and so while we called in the below spots maybe_constant_value without manifestly_const_eval=true,

Re: [PATCH] driver: Also prune joined switches with negation

2019-02-08 Thread H.J. Lu
On Fri, Feb 8, 2019 at 3:02 PM H.J. Lu wrote: > > When -march=native is passed to host_detect_local_cpu to the backend, > it overrides all command lines after it. That means > > $ gcc -march=native -march=skylake-avx512 > > is the treated as > > $ gcc -march=skylake-avx512 -march=native > >

Re: [PATCH] Updated patches for the port of gccgo to GNU/Hurd

2019-02-08 Thread Matthias Klose
On 07.02.19 06:04, Ian Lance Taylor wrote: > On Thu, Jan 31, 2019 at 7:40 AM Svante Signell > wrote: >> >> As advised by the Debian gcc maintainer Matthias Klose and golang >> developer Ian Lance Taylor I'm re-submitting the patches for >> the port of gccgo to GNU/Hurd again. Now GOOS value is

[PATCH] driver: Also prune joined switches with negation

2019-02-08 Thread H.J. Lu
When -march=native is passed to host_detect_local_cpu to the backend, it overrides all command lines after it. That means $ gcc -march=native -march=skylake-avx512 is the treated as $ gcc -march=skylake-avx512 -march=native Prune joined switches with negation to allow -march=skylake-avx512 to

Re: [RS6000] Don't support inline PLT for ABI_V4 bss-plt

2019-02-08 Thread Segher Boessenkool
Hi Alan, On Fri, Feb 08, 2019 at 11:05:57AM +1030, Alan Modra wrote: > Inline PLT calls need PLT to be an array of addresses. bss-plt works > differently. > > Bootstrap and regression test on powerpc64-linux biarch in progress. > OK assuming no regressions? > > * config/rs6000/rs6000.c

Re: C++ PATCH for c++/89212 - ICE converting nullptr to pointer-to-member-function

2019-02-08 Thread Jason Merrill
On 2/8/19 12:21 PM, Marek Polacek wrote: r256999 removed early bailout for pointer-to-member-function types, so we now try to tsubst each element of a pointer-to-member-function CONSTRUCTOR. That's fine but the problem here is that we end up converting a null pointer to

Re: [C++PATCH] [PR87322] move cp_evaluated up to tsubst all lambda parms

2019-02-08 Thread Jason Merrill
On 2/8/19 1:58 AM, Alexandre Oliva wrote: On Feb 7, 2019, Jason Merrill wrote: + PR c++/86322. */ Wrong PR number. Thanks + if (local_specializations) +if (tree r = retrieve_local_specialization (t)) + return r; Hmm, I would expect this to do the wrong thing for pack

Re: [C++PATCH] [PR86379] do not use TREE_TYPE for USING_DECL_SCOPE

2019-02-08 Thread Jason Merrill
On 2/8/19 4:07 AM, Alexandre Oliva wrote: On Feb 7, 2019, Jason Merrill wrote: In protected_accessible_p and shared_member_p, if we're left with a USING_DECL after strip_using_decl, we can't give a meaningful answer, and should probably abort; we shouldn't get here with a dependent

Re: arm access to stack slot out of allocated area

2019-02-08 Thread Wilco Dijkstra
Hi Olivier, > Sorry, I had -mapcs-frame in mind. That's identical to -mapcs, and equally deprecated. It was superceded 2 decades ago. -mpcs-frame bugs have been reported multiple times, including on VxWorks. For example https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64379 suggests VxWorks doesn't

Re: [PATCH] Add testcase for PR tree-optimization/88739

2019-02-08 Thread Christophe Lyon
On Fri, 8 Feb 2019 at 20:00, Richard Biener wrote: > > On February 8, 2019 7:22:48 PM GMT+01:00, Jakub Jelinek > wrote: > >Hi! > > > >The following testcase distilled from > >https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88739#c0 > >aborts on s390x-linux when compiled with trunk -O2 with r268332

[PR fortran/89077, patch, part 2] - ICE using * as len specifier for character parameter

2019-02-08 Thread Harald Anlauf
The attached patch attempts a substring length simplification so that more complex expressions are handled in initialization expressions. Thanks to Thomas König for the suggestion. Regtested on x86_64-pc-linux-gnu. (The PR still has other wrong-code issue to be addressed separately.) OK for

Re: [Patch]Bug 84762 - GCC for PowerPC32 violates the SysV ABI spec for small struct returns

2019-02-08 Thread Segher Boessenkool
Hi Lokesh, Sorry for not getting back to you earlier. On Thu, Jan 10, 2019 at 05:57:52PM +0530, Lokesh Janghel wrote: > Find the attached patch for the subjected issue. > Please let me know your thoughts and comments on the same. > > >Do you have a copyright assignment with the FSF? > We don't

[poweprc] RFA: patch changing expected code generation for test vsx-simode2.c

2019-02-08 Thread Vladimir Makarov
Recently I committed a patch solving https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88560 The patch resulted in test vsx-simode2.c failure.  Here is the difference in generated code: @@ -13,9 +13,8 @@ foo:  .LFB0:     .cfi_startproc     std 3,-16(1) -   ori 2,2,0 -   lwz

patch to fix PR88560

2019-02-08 Thread Vladimir Makarov
  The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88560   The patch was bootstrapped and tested on x86-64 and ppc64.  It was also tested on ARM by Tamar Christina.  The patch changes expected generated code for one test on ppc64 but in a better way.  I'll send a patch

Re: [PATCH] Add testcase for PR tree-optimization/88739

2019-02-08 Thread Richard Biener
On February 8, 2019 7:22:48 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >The following testcase distilled from >https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88739#c0 >aborts on s390x-linux when compiled with trunk -O2 with r268332 >reverted (or >e.g. with -O2 and gcc 7.x) and succeeds with trunk

Re: [EXT] Re: [PATCH, fortran ieee]: PR 88678, Many gfortran.dg/ieee/ieee_X.f90 test cases fail starting with r267465

2019-02-08 Thread Steve Ellcey
On Fri, 2019-02-08 at 10:42 +0100, Uros Bizjak wrote: > so, the reverted patch neglected this assumption. Ignoring this, we > can use > > --cut here-- > Index: libgfortran/config/fpu-glibc.h > === > ---

[PATCH] Add testcase for PR tree-optimization/88739

2019-02-08 Thread Jakub Jelinek
Hi! The following testcase distilled from https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88739#c0 aborts on s390x-linux when compiled with trunk -O2 with r268332 reverted (or e.g. with -O2 and gcc 7.x) and succeeds with trunk -O2, or -O0 with any of those compilers. Tested also on x86_64-linux

Re: [PATCH][libbacktrace] Declare external backtrace fns noinline

2019-02-08 Thread Thomas Schwinge
Hi Tom! On Fri, 8 Feb 2019 10:41:47 +0100, Tom de Vries wrote: > The backtrace functions backtrace_full, backtrace_print and backtrace_simple > walk the call stack, but make sure to skip the first entry, in order to skip > over the functions themselves, and start the backtrace at the caller of

C++ PATCH for c++/89212 - ICE converting nullptr to pointer-to-member-function

2019-02-08 Thread Marek Polacek
r256999 removed early bailout for pointer-to-member-function types, so we now try to tsubst each element of a pointer-to-member-function CONSTRUCTOR. That's fine but the problem here is that we end up converting a null pointer to pointer-to-member-function type and that crashes in fold_convert:

PING Re: [PATCH v2] C++ concepts: fix ICE with requires on dtors (PR c++/89036)

2019-02-08 Thread David Malcolm
Ping On Fri, 2019-01-25 at 15:02 -0500, David Malcolm wrote: > On Fri, 2019-01-25 at 08:59 -0800, Nathan Sidwell wrote: > > On 1/25/19 8:48 AM, David Malcolm wrote: > > > PR c++/89036 reports an ICE due to this assertion failing > > > > > > 1136/* A class should never have more than one

Re: arm access to stack slot out of allocated area

2019-02-08 Thread Ramana Radhakrishnan
On 08/02/2019 16:19, Olivier Hainque wrote: > Hi Wilco, > >> On 8 Feb 2019, at 15:49, Wilco Dijkstra wrote: >> >> Hi Olivier, >> >>> Below is a description of a very annoying bug we are witnessing >>> on ARM. >> ... >>> compiled with -Og -mapcs >> >> Do you know -mapcs has been deprecated for

[committed][PATCH] Fix PR testsuite/89258

2019-02-08 Thread Jozef Lawrynowicz
pr80887.c expects int size to be at least 32-bits, added the corresponding require-effective-target directive. Committed. >From b8a747181ed83adfb0ff5f42ba74f1bc239620d8 Mon Sep 17 00:00:00 2001 From: jozefl Date: Fri, 8 Feb 2019 16:47:28 + Subject: [PATCH] 2019-02-08 Jozef Lawrynowicz

Re: [RS6000] Correct save_reg_p

2019-02-08 Thread Segher Boessenkool
On Fri, Feb 08, 2019 at 04:18:52PM +, Iain Sandoe wrote: > > > On 8 Feb 2019, at 16:16, Segher Boessenkool > > wrote: > > > > On Fri, Feb 08, 2019 at 10:19:40PM +1030, Alan Modra wrote: > >> That one regressed gcc.dg/20020312-2.c, due to my "cleverness" in > >> simplifying the ABI_V4 case.

Re: arm access to stack slot out of allocated area

2019-02-08 Thread Olivier Hainque
Hi Wilco, > On 8 Feb 2019, at 15:49, Wilco Dijkstra wrote: > > Hi Olivier, > >> Below is a description of a very annoying bug we are witnessing >> on ARM. > ... >> compiled with -Og -mapcs > > Do you know -mapcs has been deprecated for more than 4 years now? > Is there a reason you are still

Re: [RS6000] Correct save_reg_p

2019-02-08 Thread Iain Sandoe
> On 8 Feb 2019, at 16:16, Segher Boessenkool > wrote: > > On Fri, Feb 08, 2019 at 10:19:40PM +1030, Alan Modra wrote: >> That one regressed gcc.dg/20020312-2.c, due to my "cleverness" in >> simplifying the ABI_V4 case. This one passes regression testing. >> OK to apply? > > I think this is

Re: [RS6000] Correct save_reg_p

2019-02-08 Thread Segher Boessenkool
On Fri, Feb 08, 2019 at 10:19:40PM +1030, Alan Modra wrote: > That one regressed gcc.dg/20020312-2.c, due to my "cleverness" in > simplifying the ABI_V4 case. This one passes regression testing. > OK to apply? I think this is correct. Thanks! Okay for trunk. Does it need backports? Segher

Re: [rs6000] 64-bit integer loads/stores and FP instructions

2019-02-08 Thread Segher Boessenkool
On Fri, Feb 08, 2019 at 11:46:37AM +0100, Eric Botcazou wrote: > > Backporting this is okay. (It was not done because it does not affect > > correctness). What is the "almost", btw? > > The predicate of operand #0 of movdi_internal32 is > rs6000_nonimmediate_operand > on the 7 branch and

Re: [PATCH, rs6000] PR target/89112 put branch probabilities on branches generated by inline expansion

2019-02-08 Thread Aaron Sawdey
Missed two more conditional branches created by inline expansion that should have had branch probability notes. 2019-02-08 Aaron Sawdey * config/rs6000/rs6000-string.c (expand_compare_loop, expand_block_compare): Insert REG_BR_PROB notes in inline expansion of

Re: [PATCH] Fix PR89150, GC of tree-form bitmaps

2019-02-08 Thread Jakub Jelinek
On Fri, Feb 08, 2019 at 10:02:27AM -0500, Michael Ploujnikov wrote: > On 2019-02-07 3:09 p.m., Jakub Jelinek wrote: > > On Thu, Feb 07, 2019 at 03:04:21PM -0500, Michael Ploujnikov wrote: > >> 2019-02-07 Michael Ploujnikov > >> > >>PR middle-end/89150 > >>* bitmap.c

Re: [PATCH] Fix PR89150, GC of tree-form bitmaps

2019-02-08 Thread Michael Ploujnikov
On 2019-02-07 3:09 p.m., Jakub Jelinek wrote: > On Thu, Feb 07, 2019 at 03:04:21PM -0500, Michael Ploujnikov wrote: >> 2019-02-07 Michael Ploujnikov >> >> PR middle-end/89150 >> * bitmap.c (test_bitmap_tree_marking): New test. >> (NOT_NULL_OR_GARBAGE): For shortening >>

Re: arm access to stack slot out of allocated area

2019-02-08 Thread Wilco Dijkstra
Hi Olivier, > Below is a description of a very annoying bug we are witnessing > on ARM. ... > compiled with -Og -mapcs Do you know -mapcs has been deprecated for more than 4 years now? Is there a reason you are still using it? It was deprecated since -mapcs is both extremely inefficient and

Re: [REVISED PATCH 5/9]: C++ P0482R5 char8_t: Standard library support

2019-02-08 Thread Jonathan Wakely
On 07/02/19 23:35 -0500, Tom Honermann wrote: On 2/7/19 4:44 AM, Jonathan Wakely wrote: On 23/12/18 21:27 -0500, Tom Honermann wrote: Attached is a revised patch that addresses changes in P0482R6.  Changes from the prior patch include: - Updated the value of the __cpp_char8_t feature test

[PATCH] expr.c: Correct indentations in expand_constructor

2019-02-08 Thread H.J. Lu
expand_constructor has if ((TREE_STATIC (exp) && ((mode == BLKmode && ! (target != 0 && safe_from_p (target, exp, 1))) || TREE_ADDRESSABLE (exp) || (tree_fits_uhwi_p (TYPE_SIZE_UNIT (type)) && (! can_move_by_pieces

[PATCH] Fix PR89247

2019-02-08 Thread Richard Biener
The following fixes LOOP_VECTORIZED IFNs made useless by CFG cleanup after if-conversion by re-verifying the mentioned loops still exist. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2019-02-08 Richard Biener PR tree-optimization/89247 *

[PATCH, i386]: Fix PR89221, --enable-frame-pointer does not work as intended

2019-02-08 Thread Uros Bizjak
Hello! Attached patch fixes --enable-frame-pointer handling, and this way makes a couple of defines in config/i386/sol2.h obsolete. 2019-02-08 Uroš Bizjak PR target/89221 * config.gcc (i[34567]86-*-*, x86_64-*-*): Move tests for enable_cld and enable_frame_pointer ... *

Re: [PATCH] S/390: Introduce jdd constraint

2019-02-08 Thread Andreas Krebbel
On 07.02.19 11:09, Ilya Leoshkevich wrote: > Bootstrapped and regtested on s390x-redhat-linux. > > Implementation of section anchors in S/390 back-end added in r266741 > broke jump labels in S/390 Linux kernel [1]. Currently jump labels > pass global variable addresses to .quad directive in

Re: [PATCH] S/390: Implement vectory copysign

2019-02-08 Thread Andreas Krebbel
On 07.02.19 10:28, Robin Dapp wrote: > Hi, > > this patch implements vector copysign using vector select on S/390. > > Regtested and bootstrapped on s390x. > > Regards > Robin > > -- > > gcc/ChangeLog: > > 2019-02-07 Robin Dapp > > * config/s390/vector.md: Implement vector

arm access to stack slot out of allocated area

2019-02-08 Thread Olivier Hainque
Hello, Below is a description of a very annoying bug we are witnessing on ARM. I have ideas of possible ways to address it, but don't yet have a patch. The problem touches the synchronization of register elimination, dataflow analysis and arm_expand_prologue. The overall logic is pretty

Re: [PATCH] Narrow ARRAY*_REF indexes to sizetype for gimple (PR tree-optimization/89223)

2019-02-08 Thread Jakub Jelinek
On Fri, Feb 08, 2019 at 12:47:08PM +0100, Richard Biener wrote: > My worry is that while we know the IV i doesn't wrap we > don't know the same for (sizetype)i in > > for (__int128 i = 0; i < n; ++i) > a[i] = 0.; First of all, for normal targets I think it is very rare that people use

[PATCH] Un-XFAIL gcc.dg/vect/vect-24.c on vect_condition targets

2019-02-08 Thread Richard Biener
Tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-02-08 Richard Biener PR testsuite/89250 * gcc.dg/vect/vect-24.c: Remove XFAIL on vect_condition targets. Index: gcc/testsuite/gcc.dg/vect/vect-24.c

Re: [RS6000] Correct save_reg_p

2019-02-08 Thread Alan Modra
On Fri, Feb 08, 2019 at 11:13:50AM +1030, Alan Modra wrote: > PR target/88343 > * config/rs6000/rs6000.c (save_reg_p): Correct calls_eh_return > case. Match logic in rs6000_emit_prologue emitting pic_offset_table > setup, simplifying ABI_V4 case to df_regs_ever_live_p.

Re: [PATCH] Narrow ARRAY*_REF indexes to sizetype for gimple (PR tree-optimization/89223)

2019-02-08 Thread Richard Biener
On Fri, 8 Feb 2019, Jakub Jelinek wrote: > On Fri, Feb 08, 2019 at 10:48:30AM +0100, Richard Biener wrote: > > > --- gcc/gimplify.c.jj 2019-01-28 23:30:53.199762928 +0100 > > > +++ gcc/gimplify.c2019-02-06 17:15:35.368976785 +0100 > > > @@ -2977,6 +2977,12 @@ gimplify_compound_lval

Re: [Patch] [arm] Fix 88714, Arm LDRD/STRD peepholes

2019-02-08 Thread Jakub Jelinek
On Fri, Feb 08, 2019 at 11:29:10AM +, Matthew Malcomson wrote: > I'm pretty sure there's no difference between the iwmmxt target and > others so believe your simpler fix of just using 'q' is a good idea. > (there's no difference in gas and no documentation I have found mentions > a

[Ada] Fix out-of-bounds read with wild unchecked conversion

2019-02-08 Thread Eric Botcazou
This is not really a regression (or maybe a very old one) but the behavior of the compiler is a bit annoying so IMO worth fixing: when you put a size clause to silence the warning about an unchecked conversion from a small type to a (very) large one, the compiler effectively disregards the

Re: [PATCH] i386: Use OI/TImode in *mov[ot]i_internal_avx with AVX512VL

2019-02-08 Thread H.J. Lu
On Fri, Feb 8, 2019 at 1:51 AM Uros Bizjak wrote: > > On Thu, Feb 7, 2019 at 10:11 PM H.J. Lu wrote: > > > > OImode and TImode moves must be done in XImode to access upper 16 > > vector registers without AVX512VL. With AVX512VL, we can access > > upper 16 vector registers in OImode and TImode.

Re: [Patch] [arm] Fix 88714, Arm LDRD/STRD peepholes

2019-02-08 Thread Matthew Malcomson
On 08/02/19 10:23, Jakub Jelinek wrote: > On Fri, Feb 08, 2019 at 11:06:02AM +0100, Christophe Lyon wrote: >> On Fri, 8 Feb 2019 at 10:51, Jakub Jelinek wrote: >>> >>> On Fri, Feb 08, 2019 at 10:18:03AM +0100, Christophe Lyon wrote: I'm afaid this patch causes several regressions. Maybe they

[Ada] Fix crash on very dynamic record types

2019-02-08 Thread Eric Botcazou
This is a regression present on the mainline and 8 branch: in some specific circumstances, you can get a crash when max_size is called from the gimplifier on very dynamic record types. This makes the function a bit more robust. Tested on x86_64-suse-linux, applied on mainline and 8 branch.

[Ada] Fix profile mismatch with -fprofile-{generate,use} at -O2

2019-02-08 Thread Eric Botcazou
This is a regression present on all active branches: in some cases, you get bogus profile mismatches with -fprofile-{generate,use} at -O2 because some -O3 optimizations are automatically enabled by -fprofile-use. Tested on x86_64-suse-linux, applied on all active branches. 2019-02-08 Eric

Re: [rs6000] 64-bit integer loads/stores and FP instructions

2019-02-08 Thread Eric Botcazou
> Backporting this is okay. (It was not done because it does not affect > correctness). What is the "almost", btw? The predicate of operand #0 of movdi_internal32 is rs6000_nonimmediate_operand on the 7 branch and nonimmediate_operand on the 8 branch and later. > (In

Re: [Patch] [arm] Fix 88714, Arm LDRD/STRD peepholes

2019-02-08 Thread Jakub Jelinek
On Fri, Feb 08, 2019 at 11:06:02AM +0100, Christophe Lyon wrote: > On Fri, 8 Feb 2019 at 10:51, Jakub Jelinek wrote: > > > > On Fri, Feb 08, 2019 at 10:18:03AM +0100, Christophe Lyon wrote: > > > I'm afaid this patch causes several regressions. Maybe they have > > > already been fixed post-commit

Re: [PATCH] Narrow ARRAY*_REF indexes to sizetype for gimple (PR tree-optimization/89223)

2019-02-08 Thread Jakub Jelinek
On Fri, Feb 08, 2019 at 10:48:30AM +0100, Richard Biener wrote: > > --- gcc/gimplify.c.jj 2019-01-28 23:30:53.199762928 +0100 > > +++ gcc/gimplify.c 2019-02-06 17:15:35.368976785 +0100 > > @@ -2977,6 +2977,12 @@ gimplify_compound_lval (tree *expr_p, gi > > > >if (TREE_CODE (t) ==

Re: [testsuite, ada] Don't XPASS gnat.dg/lto19.adb

2019-02-08 Thread Eric Botcazou
> Between 20181106 (r265849) and 20181107 (r265879), gnat.dg/lto19.adb > started to XPASS everywhere: > > XPASS: gnat.dg/lto19.adb (test for excess errors) The idea was to wait until Jan fixes the lto8 failure introduced roughly at the same time... -- Eric Botcazou

Re: [Patch] [arm] Fix 88714, Arm LDRD/STRD peepholes

2019-02-08 Thread Christophe Lyon
On Fri, 8 Feb 2019 at 10:51, Jakub Jelinek wrote: > > On Fri, Feb 08, 2019 at 10:18:03AM +0100, Christophe Lyon wrote: > > I'm afaid this patch causes several regressions. Maybe they have > > already been fixed post-commit (I have several validations for later > > commits still running)? > > The

Re: [PATCH] Fix ICE due to copy_reg_eh_region_note_forward (PR rtl-optimization/89234)

2019-02-08 Thread Eric Botcazou
> The following testcase ICEs on ppc64le. The problem is that > copy_reg_eh_region_note_* functions accept either some instruction, or > REG_EH_REGION note directly. To differentiate between those it uses INSN_P > test (and returns early if the insn doesn't contain any REG_EH_REGION > notes).

Re: [PATCH] i386: Use OI/TImode in *mov[ot]i_internal_avx with AVX512VL

2019-02-08 Thread Uros Bizjak
On Thu, Feb 7, 2019 at 10:11 PM H.J. Lu wrote: > > OImode and TImode moves must be done in XImode to access upper 16 > vector registers without AVX512VL. With AVX512VL, we can access > upper 16 vector registers in OImode and TImode. > > PR target/89229 > * config/i386/i386.md

Re: [Patch] [arm] Fix 88714, Arm LDRD/STRD peepholes

2019-02-08 Thread Jakub Jelinek
On Fri, Feb 08, 2019 at 10:18:03AM +0100, Christophe Lyon wrote: > I'm afaid this patch causes several regressions. Maybe they have > already been fixed post-commit (I have several validations for later > commits still running)? The following patch fixes the single ICE I've tried to reproduce.

Re: [PATCH] Narrow ARRAY*_REF indexes to sizetype for gimple (PR tree-optimization/89223)

2019-02-08 Thread Richard Biener
On Thu, 7 Feb 2019, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, given that during expansion we expand ARRAY_REFs > using get_inner_reference that casts ARRAY_*REF indexes to sizetype, all the > bits above sizetype are ignored (whether one uses long long indexes on > 32-bit targets or

[testsuite, ada] Don't XPASS gnat.dg/lto19.adb

2019-02-08 Thread Rainer Orth
Between 20181106 (r265849) and 20181107 (r265879), gnat.dg/lto19.adb started to XPASS everywhere: XPASS: gnat.dg/lto19.adb (test for excess errors) Fixed as follows, tested on i386-pc-solaris2.11 and sparc-sun-solaris2.11. Ok for mainline? Rainer --

Re: [PATCH][libbacktrace] Declare external backtrace fns noinline

2019-02-08 Thread Richard Biener
On Fri, Feb 8, 2019 at 10:41 AM Tom de Vries wrote: > > Hi, > > The backtrace functions backtrace_full, backtrace_print and backtrace_simple > walk the call stack, but make sure to skip the first entry, in order to skip > over the functions themselves, and start the backtrace at the caller of the

Vectorizer Data Structure re-org

2019-02-08 Thread Richard Biener
I am working on an internal data structure overhaul in the vectorizer to support future changes. The first task is to remove the non-SLP representation which will simplify code and improve maintainability. This first task is actually the most difficult and time-consuming one. I have pushed the

Re: [PATCH, fortran ieee]: PR 88678, Many gfortran.dg/ieee/ieee_X.f90 test cases fail starting with r267465

2019-02-08 Thread Uros Bizjak
On Fri, Feb 8, 2019 at 12:53 AM Steve Ellcey wrote: > > On Thu, 2019-01-31 at 08:46 +0100, Uros Bizjak wrote: > > On Wed, Jan 30, 2019 at 9:51 PM Janne Blomqvist > > > > > This seems to change the only user of support_fpu_trap() that is > > > different from support_fpu_flag(), so with this change

[PATCH][libbacktrace] Add btest_lto

2019-02-08 Thread Tom de Vries
Hi, Add libbacktrace test-case using -flto. OK for trunk? Thanks, - Tom [libbacktrace] Add btest_lto 2019-02-08 Tom de Vries * Makefile.am (BUILDTESTS): Add btest_lto. * Makefile.in: Regenerate. * btest.c (test1, f2, f3, test3, f22, f23): Declare with

[PATCH][libbacktrace] Declare external backtrace fns noinline

2019-02-08 Thread Tom de Vries
Hi, The backtrace functions backtrace_full, backtrace_print and backtrace_simple walk the call stack, but make sure to skip the first entry, in order to skip over the functions themselves, and start the backtrace at the caller of the functions. When compiling with -flto, the functions may be

[committed][libbacktrace] Handle DW_FORM_ref_addr

2019-02-08 Thread Tom de Vries
Hi, Add handling of the DW_FORM_ref_addr encoding to libbacktrace. Committed to trunk. Thanks, - Tom [libbacktrace] Handle DW_FORM_ref_addr 2019-02-08 Tom de Vries PR libbacktrace/78063 * dwarf.c (build_address_map): Keep all parsed units.

Re: [Patch] [arm] Fix 88714, Arm LDRD/STRD peepholes

2019-02-08 Thread Christophe Lyon
On Tue, 5 Feb 2019 at 15:44, Matthew Malcomson wrote: > > These peepholes match a pair of SImode loads or stores that can be > implemented with a single LDRD or STRD instruction. > When compiling for TARGET_ARM, these peepholes originally created a set > pattern in DI mode to be caught by movdi

Re: [PATCH] improve out-of-bounds pointer warning (PR 88771)

2019-02-08 Thread Richard Biener
On Thu, Feb 7, 2019 at 2:14 AM Martin Sebor wrote: > > The attached patch doesn't avoid the false positive but only improves > the warning to make it more readable (as suggested in the PR by Richard > for GCC 9). With the patch, for a call like: > >memcpy (d, s, -1); > > where d and s are

Re: [C++PATCH] [PR86379] do not use TREE_TYPE for USING_DECL_SCOPE

2019-02-08 Thread Alexandre Oliva
On Feb 7, 2019, Jason Merrill wrote: > In protected_accessible_p and shared_member_p, if we're left with a > USING_DECL after strip_using_decl, we can't give a meaningful answer, > and should probably abort; we shouldn't get here with a dependent > expression. In g++.dg/lookup/using39.C,

[PATCH] Fix PR89223

2019-02-08 Thread Richard Biener
The followng fixes the data-ref code not properly checking whether it can handle some constants. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2019-02-08 Richard Biener PR middle-end/89223 * tree-data-ref.c (initialize_matrix_A): Fail if